From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 588CAD31778 for ; Tue, 5 Nov 2024 18:04:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 96E376B007B; Tue, 5 Nov 2024 13:04:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F5876B0085; Tue, 5 Nov 2024 13:04:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 76E876B0088; Tue, 5 Nov 2024 13:04:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 56BB86B007B for ; Tue, 5 Nov 2024 13:04:34 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id EC9B41614DA for ; Tue, 5 Nov 2024 18:04:32 +0000 (UTC) X-FDA: 82752814704.07.B8AE897 Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) by imf22.hostedemail.com (Postfix) with ESMTP id B8CC5C000E for ; Tue, 5 Nov 2024 18:03:49 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=m4YUyK+6; spf=pass (imf22.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.179 as permitted sender) smtp.mailfrom=ryncsn@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730829735; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SLuuiNTuc6ouly10Wq3P0k2X8v68VAO1pnxnfITDOd0=; b=YdUgxOKURFdm5htSla0CjpHddWlCSglYBhU/M+RDXwMJI9WfNrhPMF8xGqFPRQ8aw3Ypsq 3WamCf4H960YXTiwgE70zPfzWwB5bheM7cTZ2caPgyrDTu6g6GUr4DZmOYI1kpOYe4x8C+ FsJErBg2c/aerPzx56ewPFUP2jfGg2g= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730829735; a=rsa-sha256; cv=none; b=2zyj2JY2WpPpxLoP+vjiGisgmOcH2i+0mtXICP85gP6bfP6S2EXCutXNQ3PPEnsf6oEZqC hMFskU5diIJMYR9DTrVvro2cPXZA/kS4Zm37Ol+di5Zbh52lzdPlNxVp2aOrKpMfLrIYCh PhXLv6ENb3sVMKD1b7gq7MUQgPelJPE= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=m4YUyK+6; spf=pass (imf22.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.179 as permitted sender) smtp.mailfrom=ryncsn@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-2fb561f273eso46217891fa.2 for ; Tue, 05 Nov 2024 10:04:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730829869; x=1731434669; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=SLuuiNTuc6ouly10Wq3P0k2X8v68VAO1pnxnfITDOd0=; b=m4YUyK+6+QFU8MI0LV+CEGLQas8ZGPc79GPZUAWdo77QfzI8Dr3pQw9z3NG26Pp30b +PQobCnQbaHfsBj4EowvRv4WEJW3ABAZKHRsHziKx1obh2NVr3CKP9sWiETFFNcGrXwI O5lRUpoxFfJyNwZX/zP4q3Lh8VjGgLMuptLBY/NHLLNbxdjt84RNpOsGC7bevEz9wXm8 jCVpvw82opGVn0/ZCjsLSk9BggRP1oRxjsFU/PF4dxX3ACK/FF3ZwGDb9vQPVMQGR6W+ vzDvWs9NInZAMLPa86Pz7RtzvrNIErfeDssYzxm4y4t5gzxZsvU/xR4ay5m/Lbm5VUHn Ml3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730829869; x=1731434669; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SLuuiNTuc6ouly10Wq3P0k2X8v68VAO1pnxnfITDOd0=; b=HokcPqhG30OeVV/hoDmfnGSDN7dV3bN9vTuas79MXB0IZcYpluhsPFHH4ujtyrQ26d USHlHMv8H2mkcKs2z2rY9LeKuDdsfKR1d8aSYSKmYFTxcn72VEOYK2EJSrDne9eK8vGm yew7FJOfF9pGHsh53il2TnAWmYIYqYe5A3vU5CZ1LT5bMH4W0zOcMZYsxN3XTLVA7cAq 1VCX0/xQBh2FQxfvW+mBrRIj1MrrFBKZTNErcn7ZtSs8icKzXD2eFxbfYeIqNqQe2bs3 He6sEGVL3KvuPKOAEIyPXEiFTUZWKyr8mj2DnRnOAXfQMGtjom4d/7PCSga+QE79Vf/p CNUg== X-Gm-Message-State: AOJu0YxS8Egc7drPgR8AF2xLQhOKSGGf1BkUjMOcJqQnUsrCMPdvP5OK VYtROewefrFksiKgOtSFiWTQ3aqRdb1tAd7fayohpvfz7QZ6fwkrj0IY3fkTCmo0PRtu58LkAyR r2FQoukRYPLhrvYfUyxjWpZsVER4= X-Google-Smtp-Source: AGHT+IEL53ipoy1SLGM7A8cyAw8EDS89mmeHDSBlCtypDDrCd6J+2iRMsUhZZOxMcTsDmsuFfqBnDvPDpTm13ckVPl4= X-Received: by 2002:a2e:be23:0:b0:2fa:c0fc:e3d6 with SMTP id 38308e7fff4ca-2fd058fb75emr122730831fa.7.1730829868984; Tue, 05 Nov 2024 10:04:28 -0800 (PST) MIME-Version: 1.0 References: <871q0641xd.fsf@yhuang6-desk2.ccr.corp.intel.com> <87a5es3f1f.fsf@yhuang6-desk2.ccr.corp.intel.com> <87ed3r8zvy.fsf@yhuang6-desk2.ccr.corp.intel.com> In-Reply-To: <87ed3r8zvy.fsf@yhuang6-desk2.ccr.corp.intel.com> From: Kairui Song Date: Wed, 6 Nov 2024 02:04:12 +0800 Message-ID: Subject: Re: cluster_alloc_swap_entry() may change per-cpu cluster of another CPU randomly To: "Huang, Ying" Cc: linux-mm , Chris Li Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: B8CC5C000E X-Stat-Signature: dbcs7k3a5xe9zx7ue13mh9ix8wxfhsck X-HE-Tag: 1730829829-846411 X-HE-Meta: U2FsdGVkX1+6oy9lAk5lFSR6gBUuIW85CF3+HaUmXbe1IFojaX8qNYrAvztPxX2QSw9qwFoNPDtWkSlakzHxChBDUJ+uDDPKOQ6C1sCGDPLEh0OjIc2ry7GDVDI/dMHMJXd02YpXVwBXJbL+Ryw6+BKn6MMnUYI636mJTeyppKdiV3F9G6Nnmzxh8idBmShGdKfa9qkff2bqH8Db9w7JIePZyISvD1gQGZGIghvJAPqm5rDMRdXAwnbvMNkSc1pw4v02jB1Beq53kGGnI41xStJCOcif/IgXI5febp8gJIY3j3NAOMHRq/gdCMIBiNVcrFrHiMBVDOeLQQzXZHdxTJ4msU/90dw0glK3gMdqp7rXTObwL//1wzpgmYZScuROcZ+/hXGFxCvLE79xAt47pAWts0mYbia/S45cQBz1p7TdzbeeeEEe0rAlggIhrQ7aDrG3xdGuVt+5A3pplus+A2+4HAjjFo7Jfe5BwsWk2ykSK+/UFp60nOcWfLAgKCjirLC2wAyhpxk8zdPbdwRCV4xWxF2Otnd5pFB0YPFyYVU8O74vBd9iUtXPk84exADinGqp+4U96hGJSKx6IoGylUd1+qCjygyO8RPrXT0xBFgg+YgTPqH9kxrjnX9fBLLKlPjurpxUFfAKUSOld7IGXBK0CwZ1sRY2/IDuxcunHqEpS2W1/QZEpeUIYRSweqS7rA6EByTK83JnLtPvz2tFHW+w4Zpa7WylF6w9j+FHUC76qKYsCNySA6CdogRlXQfExoC0aYmb/42zNXIivhUgIfbvILCk8YwJy1o8ELDs/PRGTysNfjjv3uJIgEyiFjddQAnLSbBRYkoGQHDK+HrslU/TodTxzPibBU0o/+BHCTXgwNqt202MCJPf+1jUW5F1EO3bOTBPsUaVIkceU18TTNkjiPxrGvAPlWs173lio6bqyAMtQ+S12WorUdoa1tVpfGeMXSEpjX3+MEAkCxd 6KkpRKf9 Ncj8hLS28ECtAprFTDXE5eDavWzGXBFYIrOmDMemOgnMuxjt8umXt1AQiru7V7v6h6UsA7VRwEnUX2PayqXY0jrChna7YpcHVH7+czc6Um73v5s3v/sJgJnwQNhl7wybeYM82bdHp1UN+CPTJmZelA/CGSgqxIwdKKnED7co7lYGACp2LIW0jEjS7d+fxEZUzTLBpk61YkUk/fzMavjZid76MoJsHHk7L0MWe5GrjDWkwF4K1InX8kxx6+r8CRhyn4SM1M4LKHnYxopGctkIP/wLBGr02FBmwiHThpa8hu8eBAeOPaUhaFwaq+jGTYTYcb+Te3/mvxST6SxZp8fyzEJHeXo6NgVWGNid1O9Tjle9jcjuIlyZSg6l0rRHVuXkaxiNtxMsTaRAurcLoGOwLQoej/M3GonsitjMl X-Bogosity: Ham, tests=bogofilter, spamicity=0.000018, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 4, 2024 at 11:06=E2=80=AFAM Huang, Ying = wrote: > > Kairui Song writes: > > I think that the logic of SWP_SCANNING is correct. > > As for SWP_WRITEOK, we should avoid to allocate swap entries when other > task clears it ASAP. So, the above checking may be too late, because we > have already allocated the swap entry. I think that we can check it in > cluster_reclaim_range() and refuse to allocate swap entry there. Thanks for the feedback. Not sure if this is a big issue. With the above patch SWP_WRITEOK will prevents any new allocations from using the device, already ongoing allocations may still use this device indeed, but in the end swapoff will still succeed, maybe very slightly slower as swapoff may have to unuse a few more entries. I can add another SWP_WRITEOK check to make it better, will post a patch. > Combined with the per cpu cluster (cluster->next[]) changing issue we > discussed in another email of the thread. I think the long term > solution could be separate the swap entry allocation and reclaiming a > bit more. For example, we could try to allocate some swap entries with > si->lock held firstly, record possible reclaim offset if any, change > cluster->next[], then unlock, reclaim, lock. > > -- > Best Regards, > Huang, Ying