From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B88DDC48260 for ; Fri, 16 Feb 2024 10:02:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0967A6B0088; Fri, 16 Feb 2024 05:02:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 045E96B00AC; Fri, 16 Feb 2024 05:02:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E01366B00AD; Fri, 16 Feb 2024 05:02:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id CC1F96B0088 for ; Fri, 16 Feb 2024 05:02:15 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8D12716045D for ; Fri, 16 Feb 2024 10:02:15 +0000 (UTC) X-FDA: 81797226630.21.DA21A62 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by imf10.hostedemail.com (Postfix) with ESMTP id C9A2EC0025 for ; Fri, 16 Feb 2024 10:02:13 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=AHHHOq2F; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf10.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.178 as permitted sender) smtp.mailfrom=ryncsn@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708077733; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9+r76o2JwpW191mB0cdSBI4QA1SjwNLwOUYY+I3l0fo=; b=uf/wzvZjnIDqa7jPZPCG10mGtyfM1PqAtGtdjBBr8hWvOb8V2UTm0r5Hk6DlpxBDB24dMz sIxzGafS3JnKjiuMRAYgUZ/InRruo2Iw3XjKykVn6T8Uu1xdVDObXZYx2CiucCw+RKlSf8 jszslEsZ9/L06xlKYAQNr/XJiH6xk2U= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=AHHHOq2F; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf10.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.178 as permitted sender) smtp.mailfrom=ryncsn@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708077733; a=rsa-sha256; cv=none; b=c2EDSpqAHWEkry6bgAOQEVJsA88KmpLLFcxJsBnWSMs73eQMIBDyKNLv/U+JwP0misZXEh kkWEZNLVBdXZ9+llhnOSdHgmxdQh198VYpgkZoAF8yPjSdTmLjl5reVNyD9lULPALz905J oAKw2CDY9wQwdNYpZr+qAyXPax6odgY= Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-2d0c7e6b240so24855961fa.0 for ; Fri, 16 Feb 2024 02:02:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708077732; x=1708682532; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9+r76o2JwpW191mB0cdSBI4QA1SjwNLwOUYY+I3l0fo=; b=AHHHOq2FgUaeMqA8+3d9jVT9r0m83N/7Fpg80LxeXDr1QmVYNjq4BpXObvL6vB1u9q NT57oTiyCqQroh/TExb8ZsLbNaG3qYM8zGKh0hVjcp7O+DZPj1SWrzXjm2uayh7BAOYa LpsjvR/rsyppZZ1XebL51z/dV6W/HM+fQ+h7hooLh4LAGFkdLQcHNyhKMrU0zsunFazh oUd/qP/P+YkuGaeFYDxTGt5RyV0MXjacS2jKIHNkmFq/4OMspVYxjAMd+Lwj0i5ZAZ9g xpmxAtquD9wwb2jWRy56a8e7SvGYt7i00cwShzw4To436jEdbEzm4BUKfv1VCPb1Kgji OI4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708077732; x=1708682532; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9+r76o2JwpW191mB0cdSBI4QA1SjwNLwOUYY+I3l0fo=; b=tSyPjLQi2J/HX2uwCedmJDexV4BmbXo1Iq3BiEPYgSn/YpDje2poLh4DXeRvL/GWvR jYMdJ9GmtvoZwyZP5xWQwt06xzpgdD48zsANnSpXfFrmNx1J4RiCOnJh4iYcnxvDFL7Z ZH81lq8Qjw/s4JVqGlmGQK4/FWXXyqexIbP4VyMoNE+WHQFiwfnnmTMyFNAFJM7A1fwf A8G6rVW9THiDTorQZHBTmv+wMX7jfCNFyn14zOjzrU9QegEakqBo4OEp1smgFn8yUKqp our08B+GwL8cQnRo+eLTZGCVeeZDvUuRT2Zuz1oLimv07/UFYjZ/7NeUqejsEx3Exrzb dJvw== X-Forwarded-Encrypted: i=1; AJvYcCUCO0CFClKBrbjXsonaQHijCrvaJa/OXMfQ3KlwgGf8VgusNvBVe1+Msje7fwz+mz4TEtgmtWKe/UOcfP0SBIxVdEY= X-Gm-Message-State: AOJu0Yzl9/XPV4aznl6OhXhie5MnIOMuITCYd8QZko/QOPEb5PZNv7Th H2rvsvH0AoTnZSBpvY5U7+vnUE7cd7uhAWHvhRB3/E40BAYbe87W18OQSHzYjzIjlVAMyeGGFl+ gMbp0HfTdnqo+vZ5cRec4hue2RtM= X-Google-Smtp-Source: AGHT+IHbTtXkIU6FJpAiPx0y7F1gaeijHLB/wVYaW/EFpk1Pev9GaYTryS4GHL+6L4Bo1aidj5Jo/x2kQwQI6uW0YvE= X-Received: by 2002:a2e:9214:0:b0:2d2:a27:200f with SMTP id k20-20020a2e9214000000b002d20a27200fmr2584021ljg.46.1708077731548; Fri, 16 Feb 2024 02:02:11 -0800 (PST) MIME-Version: 1.0 References: <20240206182559.32264-1-ryncsn@gmail.com> <1d259a51-46e6-4d3b-9455-38dbcc17b168@redhat.com> <4c651673-132f-4cd8-997e-175f586fd2e6@redhat.com> <20240215145836.6db8f62824e1547f0608591c@linux-foundation.org> In-Reply-To: <20240215145836.6db8f62824e1547f0608591c@linux-foundation.org> From: Kairui Song Date: Fri, 16 Feb 2024 18:01:53 +0800 Message-ID: Subject: Re: [PATCH v2] mm/swap: fix race when skipping swapcache To: Andrew Morton Cc: Minchan Kim , David Hildenbrand , linux-mm@kvack.org, "Huang, Ying" , Chris Li , Yu Zhao , Barry Song , SeongJae Park , Hugh Dickins , Johannes Weiner , Matthew Wilcox , Michal Hocko , Yosry Ahmed , stable@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: C9A2EC0025 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: qpb6rdoywztjgy714cfng4kytpheexxg X-HE-Tag: 1708077733-843375 X-HE-Meta: U2FsdGVkX19846EY1Msj1y9F3W+d3fAM1HlN3bhx0UEF6a1SbzytCsWZm9CxIDGRw0qrdxCfDQ3CJR1g8WCkkoTiDYWrb40odDwJL1pwEzD/s5k42/2iKiJEeWMiYhVQTTGZbq+iV+hF0ByA9WKfhnZk/pNlcqrk+rocTrQbJxJpYPde7+nV1bOGgUt3m43Pymz/NteGjf5stYTZak+p+JV9eC4huhBNAMu6JTPPLe2rSr0dKZEwbF14KiKzTIDCJ1HztGJtMaVLYsf3Ftv9Zm51lnuEUxMCfYuuvs9quEPWYF9NMTwMnZfTkBEQgUzqb06im5bbVgNM/TcXiYbRljHabPtNjKiFljOUYnMq0X+CgkIivjlJR5BBImwTf5jkfsdO6A9F5w3Vn46fSCIPzLRHXOY9dEhI+MFpQj78Jg+qbNlxwLELTcF8sDxzIY0lTSaa82etWOen4FJGYTRVfRHc8AhyljV/RCNNT6khJE0qOgy9RtqRsZV0EIAmWntHbdDIs9UtAxZnRp+nQOpF1CsHvWUKl2YYwFPyqemj7Vy/z1s9MHWygn6ltwFZH9Uh9rdXPo+xGK1awm9OyTj105D1KgzbuyXm63ZGiJYfXuN3e/mYxg/9YAO0uCFF9o5N69yEhqc9MZE/1YwOz4kSrDAznmZbfzG1Hc9AMAZDJl3+ARk5xqaN+Gzkr0yr0t8290BYEDCfAqMgtGBhLhUyJdfbJ5AWoSBfAg7t3Oywd6C5u39jvDEHCnLeUQ57B78X/8LXwH2SMr9cMooimH5cxIYj9Byd1zzTi/L+24BcxFhmrjZhyea4u/o1vOKmCmBCth/euTg9pypFO8BU/L/Gzdej8OPgcVTPpSC2wNB4vU/DrZCwmXlRhVCUVsWDS96V6/81fPY5FFd88xzUrSEn7itiWcsv6r1IZTEg9kf83khJrNKu50PAPauciIzNCFfNrtOO9PUrEbRCTLpVzUK RlUaslsi 4HpWrm/N2V9U6rNupImIRjP2dHtk/IYTo3gwh X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 16, 2024 at 6:58=E2=80=AFAM Andrew Morton wrote: > On Thu, 15 Feb 2024 12:55:11 -0800 Minchan Kim wrote= : > > Only concern of the approach is that it would be harder to have the fix > > in the stable tree. If there isn't strong objection, I prefer the > > Kairui's orginal solution(with some tweak of scheduler if it's > > necessary) first and then pursue your idea on latest tree. > > Do we agree that this fix is needed in -stable? For some reason I > don't have a cc:stable in the changelog. > > I'd like to move this patch into mm-hotfixes-stable in order to get it > upstream very soon. Are we all agreeable with that? I don't have an > Acked-by: David? > > I have a note (which dates back to an earlier version) that Barry would > be performing runtime testing. Has that occurred? > > Thanks. > Hi Andrew, I think this fix is needed for stable, I've sent V3, if we agree on that, please consider V3 which includes changes we have discussed so far, thanks!