From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1689BC3DA49 for ; Thu, 18 Jul 2024 11:34:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 639E96B0089; Thu, 18 Jul 2024 07:34:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E9356B0098; Thu, 18 Jul 2024 07:34:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 489B16B0099; Thu, 18 Jul 2024 07:34:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2A1866B0089 for ; Thu, 18 Jul 2024 07:34:04 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 943E9A0DC1 for ; Thu, 18 Jul 2024 11:34:03 +0000 (UTC) X-FDA: 82352664366.10.249BA24 Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by imf11.hostedemail.com (Postfix) with ESMTP id C043F4000A for ; Thu, 18 Jul 2024 11:34:01 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=RWyte3mv; spf=pass (imf11.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.174 as permitted sender) smtp.mailfrom=ryncsn@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721302421; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kz0CHYXm6hSKvPGl7KY0ucVwn4BdIuee4UTwptEYLWE=; b=cmcAsjVzGXtJtvojtAjt4KCNpAvfYnjUpAY1sGzrYjsk2FUsVf1N+uRpK9naPsTslJjFDe cRWHfuBr3oWDWToprx8vZDmYcFJ4gCjBkd2oBxAKU2PAL34PMXpmh8C+82gQJcFSoISDKk +MYF6WkYsIX5GviNbIStjPw0Bik0RPE= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=RWyte3mv; spf=pass (imf11.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.174 as permitted sender) smtp.mailfrom=ryncsn@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721302421; a=rsa-sha256; cv=none; b=hGWkywuQMKiOOeikCPfL0/1UFjBGf2EQRTIx6e6tttZeuTclV+iROJ8NNr48I2aDMX4LGG N0mXmMKBnkcOkOoUEHDfxwR+EiNp7jfBVHKh+KEpdVmPLdx8BIhbkdIz+PU92Skal1bPsj duLLtvF8mSVLDLeHKBJfof86WDWaMnI= Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-2eedea0fd88so9236941fa.2 for ; Thu, 18 Jul 2024 04:34:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721302440; x=1721907240; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=kz0CHYXm6hSKvPGl7KY0ucVwn4BdIuee4UTwptEYLWE=; b=RWyte3mv1ejFpBK9ia7SSZTEeEQ5qEgExkrdU9F1eYzjo71Ete/isE5mj5i1Je2PLS j87bfoOQNWTgzd3HG58A23LBZFpRT1dFvhnLsRU3b8sY0UuOaafvMze6+WijU/TjxCk5 Hxd8nki7Xw9Cnf2JWEy3ss8PWHlBt4kCJqs1QvU9kQnhn1ermmqzQduQjIyya1SzR2uf gFNFLx5Fsc0VT/4aOiVIO2fs7Y15Vovbxn9Xb3hnB8b5NXvj1ByJEhou4lAM3GCQ2uxB s2sUnti+aiUujtATLC5XkYNd9yszArwBAdV75mIkkhdULnHMV2LycS+g5u6L/jwnjvjE I6Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721302440; x=1721907240; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kz0CHYXm6hSKvPGl7KY0ucVwn4BdIuee4UTwptEYLWE=; b=CU5W8El+fyCJ3nQpnqfX5ZtRUe9zra9JnWt1PJR1j8xT97Ij6FQ66VQHT2xurevYH/ 2baieHrfUt2NweDIo5f/g5pw+FuaI98Wffg0SEDOpgHr0Hj8O+WTqI2dsND5TMPJXmni mXi0o6yor4/F1hW/ma9ZelvMv0HmOkaQx5SE7h/9EIMmcK5vCP/CKn8IAILqbyaAUInp +SXoBwYedNId1XqPQI3HgiaCMBDLgew/cIDfuPc/SECb0cIaB9N+0/Cqj3AUZz+waqgY wTAHYka8vKYvEUTTUiIE3aBfAOfvLquwxGQcmJceFN5sefWrypcW/vesOl4LLsZEqrB0 1qCg== X-Gm-Message-State: AOJu0Ywtp1qdLVOHVWwjW1QpLL+BBN52b1QM9mFFDDwKaMjEwENKGXcx d2gzhkdhKjmUqIXQJmqtEOReSDrxxAJzwzY32UxlWIwXHz5DZNB8m8tP65oud7IbUnTP5ci4+v8 /F8qXuXX9v1em6IA1lHND6DtHelk= X-Google-Smtp-Source: AGHT+IGtLgu8x1oLgYWRd+JYAnAhu8CopHA+eLeuYy36Hf+1B18guXka18r76W2mMUGgKDSr8IPFE6spM/m4BquKSSA= X-Received: by 2002:a2e:9999:0:b0:2ee:84af:dfc4 with SMTP id 38308e7fff4ca-2ef05d5b3f0mr14690431fa.43.1721302439654; Thu, 18 Jul 2024 04:33:59 -0700 (PDT) MIME-Version: 1.0 References: <20240624175313.47329-1-ryncsn@gmail.com> <20240624175313.47329-2-ryncsn@gmail.com> <1ED4A154-FD17-4689-BAA3-380AFEEAF58E@linux.dev> In-Reply-To: <1ED4A154-FD17-4689-BAA3-380AFEEAF58E@linux.dev> From: Kairui Song Date: Thu, 18 Jul 2024 19:33:43 +0800 Message-ID: Subject: Re: [PATCH 1/7] mm/swap, workingset: make anon workingset nodes memcg aware To: Muchun Song Cc: Linux Memory Management List , Andrew Morton , Matthew Wilcox , Johannes Weiner , Roman Gushchin , Waiman Long , Shakeel Butt , Nhat Pham , Michal Hocko , Chengming Zhou , Qi Zheng , Chris Li , Yosry Ahmed , "Huang, Ying" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: C043F4000A X-Stat-Signature: rakefga35dwf7frzsxu7e7pqacfishfz X-Rspam-User: X-HE-Tag: 1721302441-872874 X-HE-Meta: U2FsdGVkX1+MaQzwtioJ7QzWhTF6foF5QPxhtcGEgfuZT922l9e/03TBC7VcmPWhQKJcJ2R9VbOq9toDVGZiEST0uD67kOUkBrlI9P24oRno8PgXz5Qv7niex/s9ScVk905zYORLk5ueLEq06xbuWpEU7FZL4KBF5vcnM/m8cmAur8zUJ7YEoTHu/WLoOCLV1fhZcW5Gr8n5V1Dd9ZS5wG9hICEj1L3xM0N7rEKKxjL1DiTQnfkXd18KLqioFAZsD44gE0CACvjBEb6ohbT7srnVWrBH2AeXf2Y2IkcezFN/OepXSlm6r0g59PkeOdzbDJEyxIPBuFnwWEIaRNJMeaPIcNDFBBXvMZ8vqt+a61jfkc9/H6Ed9/Thq77KKZqec2/HBWzPXt0FCItEml6TIrZm7Bqljgx/XyefQ2W0EjPJicTUZ534fEPTjuSTFoLJiP1uKj+F5DhG1xN8x+DdC8daCgWeoc92BjhK2AfZr2CWRTTBOEnyy/Vmf2BGK25qkgsOm4P5IieUSoIkmefJGK3St1mwp1+mh3/vM2c5G2z9gHn/ljTGTRkZEhe1BxPyBDeJPkqOcIEEorVO5yoS4c68u1PTPwJoKwi7LH/PgijbDAQQwWv7B0f+mrkn60Hx2h6tuMAyP/Zao2Dl3ni1Xse4VoVNZ3czRYmjsHVnn9wHm+UAA6f//pf83nDl86y0989AL1r+HISWMOI3A9FwB0TtGMBL7hGxL7a7AkZ1ldWvX8b/NjrhCzm0+XnHORvxQD3sVg/5NzMSROAet8vgV0U2qQG7ES5wDLIqjirb9JQW6oaHlVW0pxIqw6jBQZnsKSvfTJ3MB0AonD50rAtXwIXSxvBZiAXmPV1dkRXBkoFmpYo8KxO+SMb9J8SZnxD2hYdtZqKHk1/Chhd9ePPuyO/8Gsu13xIizLrd1CCrSi1TrHb1L4686BcSXSSOCu8984HiYeCu2AZsPvgfi4D nLw/nD7a 8WSiJGj1oCU7XJx5TQoX58XPao4ZS9YzvuURax1qddLL7x0AIWzGiwVn19d1QA54iTHA3bG8yy1tKDqeXMZhLpJT8Tfp6ossChM9aaZhqKQKMS+YajMInXmRu1u3O69r+7BwEv1vTIKQ2xAg282pbI85kaYJHXnJEJgM66XkoEuXg6H1Ut4qpy6PedfnsEPJOEseDGbQBco1m0TvPiysnwjr3xs6dLba8y0o0dznHN4kf5qR1YVIZ4zLixTVvrYC2WgRzC+fTQnZa6MEuWhpV8z66jR7YKzAhWoUYXVrylkBG9DBcxuSYIc2mA0rJ9wGfZw1sEFoTmSsnElASMqIAnrtmYcxMqYIPDsqx0Yl/S3nmoq8pHIJBkwY5T3E1dzqeLGq7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 17, 2024 at 11:25=E2=80=AFAM Muchun Song wrote: > > On Jun 25, 2024, at 01:53, Kairui Song wrote: > > > > From: Kairui Song > > > > Currently, the (shadow) nodes of the swap cache are not accounted to > > their corresponding memory cgroup, instead, they are all accounted > > to the root cgroup. This leads to inaccurate accounting and > > ineffective reclaiming. > > > > This issue is similar to commit 7b785645e8f1 ("mm: fix page cache > > convergence regression"), where page cache shadow nodes were incorrectl= y > > accounted. That was due to the accidental dropping of the accounting > > flag during the XArray conversion in commit a28334862993 > > ("page cache: Finish XArray conversion"). > > > > However, this fix has a different cause. Swap cache shadow nodes were > > never accounted even before the XArray conversion, since they did not > > exist until commit 3852f6768ede ("mm/swapcache: support to handle the > > shadow entries"), which was years after the XArray conversion. Without > > shadow nodes, swap cache nodes can only use a very small amount of memo= ry > > and so reclaiming is not very important. > > > > But now with shadow nodes, if a cgroup swaps out a large amount of > > memory, it could take up a lot of memory. > > > > This can be easily fixed by adding proper flags and LRU setters. > > > > Signed-off-by: Kairui Song > > I haven't looked at the details of this patch yet, but I think it is not > related to this series, it could be as an individual patch (If it is a re= al > problem, I think it will be quickly and easily merged). > > Thanks. > The gain of this patch is not as big as being part of the series, but yes, it can be sent independently.