From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25646C021A6 for ; Sun, 16 Feb 2025 16:13:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 51827280022; Sun, 16 Feb 2025 11:13:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C7DC28001A; Sun, 16 Feb 2025 11:13:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 38FC3280022; Sun, 16 Feb 2025 11:13:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1ABF528001A for ; Sun, 16 Feb 2025 11:13:50 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D83084AE2A for ; Sun, 16 Feb 2025 16:13:49 +0000 (UTC) X-FDA: 83126303778.16.0735F7E Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by imf20.hostedemail.com (Postfix) with ESMTP id E1E741C0010 for ; Sun, 16 Feb 2025 16:13:47 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IFRgLPq9; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.175 as permitted sender) smtp.mailfrom=ryncsn@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739722428; a=rsa-sha256; cv=none; b=ZSWztdB1gUZ5mbfAe/OyPH/TcjJCLpZ4+dCJFgUycp1YdbrVoPxPXSYqg9fZuAdDNHZunQ F+kUhBB+NzrYwCc4w89afWKmIjgYZlJQObTM2Svfh6PA0giDZJTXUo4e/tevBEbD+p9bf0 Yat2ud1tO5cvlx8a721WJoy9EQTd4LM= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IFRgLPq9; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.175 as permitted sender) smtp.mailfrom=ryncsn@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739722428; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JGff666KGP905Vy6KNFf0v62t2tqMA1/DHBMRQ+PAkw=; b=eCKQmFw0IzaLeuajIgnsmo30Ot4QA54h5+3KtZsZJCjGz1e+UGvsJ+ZCu0OpH5HAlGS+Mu gpGKcReF7Uu6h4K1Q8UgYWUqAYJv4t//l6jhMbwQBmlT3GeljPuSWBK1JQYDNU4H/FvUeP S0bLexbN1+cFE7jnARTsIm3UMiG2afg= Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-30738a717ffso32032081fa.0 for ; Sun, 16 Feb 2025 08:13:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739722426; x=1740327226; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=JGff666KGP905Vy6KNFf0v62t2tqMA1/DHBMRQ+PAkw=; b=IFRgLPq9TkyLoekp5+ATS7Gk0ckFUdbYEuUwNhF6LAJD069/wGNauP3VAULAx58c4K YjfCsjZqDzraObDb1QODMqGAQZ1an0drbXZBsVH40KtxIbclL4c8MLD4SL2fBea9ZXdm R+oqnaHqNHGgPecLyIn1lB0wF0cm6K4wlC8VdBRUt/vK+NIzVxFIO33fJpKnZUSRIa/W BESEf7b7/85UrhxRiXfk6gsVP8Rwj4CeY4rxeSHoi1zdwPH5UJohBr1qX+Ck67iq99aU zu6aebJSgkMg0Hn98wdqUgb58/XYBNgxkEAs2Ry4oDgrJiWsB8IF6uDinPHWOVQeNGKl a1aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739722426; x=1740327226; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JGff666KGP905Vy6KNFf0v62t2tqMA1/DHBMRQ+PAkw=; b=Dks8+CaEsN1D4ioqmQ4v+aRA8ju+SCU4M5eMTxBZvKj/L4OiODdMjYSTqWtr1KlhbL h84cGQQfe5NlCzixErG4R66u3aBKRa1UvhU8Bhf7K5o9v779RgYrBDq+OU8rbXK4uLCT 1nhm/x5VSdaX5FFehxluTrQf9krhXbklYmzAgWni9imTMh6oZ+Jjdw7bIn8uwHPZ4jtk 2r08bbyb+9g1iWWUL7siuusVMDMyAXXK9A1R7Mi1YnC8GpqqtuKsFwMtBf3Eg709g/2I iaqd2TtkCi47vMjqGPZ+22YJMd3W160UhB7yRx5BruLL7xwMy0TrATKMwFwmymbuepMd FyTw== X-Forwarded-Encrypted: i=1; AJvYcCXf3meFiyDmeeOFH2zC2RLUI0Z9StL68TU6TN+ZsyBbxQ1i8eCx+0A3zbR/KkqS+hSEa7Yv3RTfYg==@kvack.org X-Gm-Message-State: AOJu0YxAKoavgTMHaL7nOgLHE9LB9e/X7/jvGOiUD9AsxhUI24n9rZJS 51FBLfOGZiHaT0qLMETl+DN+Mvu7xFEdBcZJjEDLf3SZq4g42RVO5JLuLU6Ycx6f8uASEjtg71H i/yg4lEjPjNfQbX1tkM4AXCuWTPE= X-Gm-Gg: ASbGnctfzfgBhZtWaME5Z2V2YteB6NGFws6pw1OHyCyWMlg8QLjpodYKpQh08PlY4Su +Lbtlf1FmYYOGxR1MLWPRCNjsW+vPMgFo79N5zp1Dg+D2qQTTe7PSaA0C0WRKgHwCTFiAD8+n X-Google-Smtp-Source: AGHT+IEPRagxZ65ybd4tMnjdDv98DMPP8zUFkYZRNxajhEeqtRsLRpLYM/sQhEuXJg+hx1mREhu1jEUYnLUSROxRQ0U= X-Received: by 2002:a2e:97d1:0:b0:308:f75f:459 with SMTP id 38308e7fff4ca-30927ad674bmr18832661fa.26.1739722425706; Sun, 16 Feb 2025 08:13:45 -0800 (PST) MIME-Version: 1.0 References: <675d01e9.050a0220.37aaf.00be.GAE@google.com> <67af8747.050a0220.21dd3.004c.GAE@google.com> <20250214152358.7ba29d10229e2155c0899774@linux-foundation.org> In-Reply-To: <20250214152358.7ba29d10229e2155c0899774@linux-foundation.org> From: Kairui Song Date: Mon, 17 Feb 2025 00:13:29 +0800 X-Gm-Features: AWEUYZlmJ2cXycQc1qMxY9bHA8o93Vs9KEMzZuE7UBLlIeeIlca5E5nvbyGjY2E Message-ID: Subject: Re: [syzbot] [mm?] [bcachefs?] WARNING in lock_list_lru_of_memcg To: Andrew Morton Cc: syzbot , chengming.zhou@linux.dev, hannes@cmpxchg.org, kent.overstreet@linux.dev, linux-bcachefs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@suse.com, muchun.song@linux.dev, roman.gushchin@linux.dev, sashal@kernel.org, shakeel.butt@linux.dev, syzkaller-bugs@googlegroups.com, willy@infradead.org, yuzhao@google.com, zhengqi.arch@bytedance.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: E1E741C0010 X-Rspamd-Server: rspam12 X-Stat-Signature: ihhyc9x7kt5gjmupkypzeuo77fxwtbzb X-HE-Tag: 1739722427-707122 X-HE-Meta: U2FsdGVkX19tyiy/g8ltFXrtdNF6o5dX+T7T/yF9PPkHbIJ312HmF3Thu3Qe1IKzrQKxyN61rX1g8wS6I72hHcPo+WYeeHrSb2AWJCaT2NXPcRIr+jIS5RoiZwf81870HwvAUQEWyf7HO6nieXKc3F0ePQshbt5u09QyDyGHX0vxA76jzAwe8fbkoK4rBkkqmt4Q0VFpdM8UmxQmDr5hTwSabS+OmxgNALwi0G4vbF0RCT1FZ8CtUtWGAXZmvf22pauYYaFxfQUFo9HFKG6qjHO8/CV1viNLya0wtHEi30Ad8AysfFuj2fEbukx2HEozDsNzlGLk7xLzXFfeXxShOYfFKcGWTyenvHcSKUxfLeiJ0fbOi+XQEfIoqejnq8crD4X1kxhgGelxK1ItNFOTgP+BovL0EbfJVw1BaaZE+aRxbHBLyMgRjlVrW8aJd7y1KZwGHpJcusCz8OF68Zn18SHGl7i60v/zdTp7inEamdl5kcflVrGE5+BYYpQk5UjM5ao1YMKqubEUUAdgUOu0skB4z9RAIosRW/4D4bCYZi1NXBXT7YiZVUq0HBKI0KgOZsWw0B38V6X0LKJsxxDHKDsxYNt3Q2PogvqQ158qsa4ij+KkRkXjflbItAv16zE4H5J1wDbCdxl+xyDvw7JzayPScLJR5y1NuAKwM9hx0ihcPC69Y2VMsBYemIM8nUbB6N1AZH1oqFjRvPFencb7Bs94uGk1pZ3R32tnbBu0DD4a2LJi5RjTJXQXazQ8xJm5OWuiNra7CUcipA1e5V0IwmSBohDoi9Dvpg+qHBiVr6mEAdq2SpnOVG1qe7VzYjsfzgoNv0YkrlTXTz/dnZtm9qoa2nYQVwLyfo7K/6HcUR6LNaADJ27cjJEktFkyAF1vKBYz51GeOoSoa9qebidCAWJkWvPMGzsUgBE4u5aiSGow0mwP9nFIPV2d8xdSbSHQR5cFaxhPTHeYc3exAzo zQKBD5MZ ClLzOeqsciGfH0ZaolC+CkUMmhYRxLdx7WhgoeYkWrmX0vBvb1/eqYAg1It5VnDzCp5CabB59TTPALQX7Z466ynWRdbuKdVscp2NwApcOzMqJsmo23DDWL4xBjW773BzvnOaFIzZl6xu0GqYD039DUUr8PIKDTdP8CiRsrcMhVgPVihPQ83B86PHYXcsAJVfcGHxqRoj/8PWiKfW3rGBvj/s387F29kD1zwxymeYZMFejUxZFYl9OO/m229g/pJuoR09vlEJR4MSn5wch8Fu7n6lACSC76TUcK2VPT66UGfRteiDSq+hUcQFYJ3q2z+0X5RXRGV0nveI2GPJlTFHJbPTGww7la+8WL2wJl9kRkPT1G+WK6ea+4RdyEeDw5cWzCseHkkPY2LOnT6nhIGzlYBvdfuSq0X/IQe2mUdiJGN/B8HEoU6niUryG375Nec3paO/uO161Bo30eNlLn4ROFGw/Y4Tl5j8KHl63lIx6n4f3ixQhjRVEfzoBZQLwzq5VEYsI0OapBbns562QJ+ykTqJk3Wk9EUVzDdGSsQHTYZKz26bhP83gm1tDaIoDDL3DqP53B5TLdXg1mYPeySGrhgmX97HlVPfRKVVfXJqhCr9CI5eInLQOYSnmEWwvV3kxrdnt2sxK8iyiXYjD0QFULjbncmtSCr52t5HW+SOAhVqDuEI9dn7AzhhaKApFTBuKcoX89LEAGCvA/C9ifSQujkATckrAE8mAQ/f0mCB0VkqyvxiP1jLo4ER/nwOR76fvG+OBx+0exkK3a3/pMFL+k8jn1IyRl0jA8sAQ8GNDP9i1kKQm7mLwtuQ9KoP0RhaElQAXjFTc6IDkNH6axwxiWOTS6zzjqCPZzYqexA/sMdVTj/bnY9ZsMtSS4RseMR+YJiSo0gjJyUw5SD/pVCfBeoJB29Nihd4M1Ezd7iHUjFApi97us8vBduSH8LnxBT/Fu4XH/7Edo31x6C1RA0uPy4ECy9fD L/nNlAGb 2/jT1MhHLAnxNS1nWol0LO8YcJnrJFrDjqjn7MAUqUeoTG91uDIALOYvTtH+kdf9Ye5aYpx+UBkVh5kP1/P+Z/oQzuViwLznBw5BLDbkS2s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Feb 15, 2025 at 7:24=E2=80=AFAM Andrew Morton wrote: > > On Fri, 14 Feb 2025 10:11:19 -0800 syzbot wrote: > > > syzbot has found a reproducer for the following issue on: > > Thanks. I doubt if bcachefs is implicated in this? > > > HEAD commit: 128c8f96eb86 Merge tag 'drm-fixes-2025-02-14' of https:= //g.. > > git tree: upstream > > console output: https://syzkaller.appspot.com/x/log.txt?x=3D148019a4580= 000 > > kernel config: https://syzkaller.appspot.com/x/.config?x=3Dc776e555cfb= db82d > > dashboard link: https://syzkaller.appspot.com/bug?extid=3D38a0cbd267eff= 2d286ff > > compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for D= ebian) 2.40 > > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=3D12328bf85= 80000 > > > > Downloadable assets: > > disk image (non-bootable): https://storage.googleapis.com/syzbot-assets= /7feb34a89c2a/non_bootable_disk-128c8f96.raw.xz > > vmlinux: https://storage.googleapis.com/syzbot-assets/a97f78ac821e/vmli= nux-128c8f96.xz > > kernel image: https://storage.googleapis.com/syzbot-assets/f451cf16fc9f= /bzImage-128c8f96.xz > > mounted in repro: https://storage.googleapis.com/syzbot-assets/a7da783f= 97cf/mount_3.gz > > > > IMPORTANT: if you fix the issue, please add the following tag to the co= mmit: > > Reported-by: syzbot+38a0cbd267eff2d286ff@syzkaller.appspotmail.com > > > > ------------[ cut here ]------------ > > WARNING: CPU: 0 PID: 5459 at mm/list_lru.c:96 lock_list_lru_of_memcg+0x= 39e/0x4d0 mm/list_lru.c:96 > > VM_WARN_ON(!css_is_dying(&memcg->css)); I'm checking this, when last time this was triggered, it was caused by a list_lru user did not initialize the memcg list_lru properly before list_lru reclaim started, and fixed by: https://lore.kernel.org/all/20241222122936.67501-1-ryncsn@gmail.com/T/ This shouldn't be a big issue, maybe there are leaks that will be fixed upon reparenting, and this new added sanity check might be too lenient, I'm not 100% sure though. Unfortunately I couldn't reproduce the issue locally with the reproducer yet. will keep the test running and see if it can hit this WARN_ON.