From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7EACCF3185 for ; Tue, 1 Oct 2024 21:10:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D8A042800E1; Tue, 1 Oct 2024 17:10:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D3992280068; Tue, 1 Oct 2024 17:10:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB1562800E1; Tue, 1 Oct 2024 17:10:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 97AB1280068 for ; Tue, 1 Oct 2024 17:10:42 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id F00CC804F4 for ; Tue, 1 Oct 2024 21:10:41 +0000 (UTC) X-FDA: 82626277482.18.33484EB Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) by imf06.hostedemail.com (Postfix) with ESMTP id 163F718000D for ; Tue, 1 Oct 2024 21:10:38 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IiwDKaex; spf=pass (imf06.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.172 as permitted sender) smtp.mailfrom=ryncsn@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727816912; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j5FPHhbte4Tmc4ZuPG7hVMprQvRDLf4/a9y4DExRTII=; b=YlL2+vwiXPlgv+CpnEfcaZU//pYz4vyRI8bjlXVu9QRmN0UDEYQkZXr6VoBH9mN6vrsowS 6xUcoKRSBJMGdv9XKs5MaDsHMGJXUIWvefxr+mV7jgGFKjAbpXFqkzmQMYzR/cEEVD7LrO 2wykhYxwe6JTOMns+KQUhgK1mYVjqsk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727816912; a=rsa-sha256; cv=none; b=iv+wMUi+r6frPhaHqNe5/rbeC/pYJXcbRat7PCXtYfOsVQo5r8CUSlmvj248hp3V+grgNA Ji/VAs9S2du/tUFFKHbTD2WP15LhCea63eXqwg2Rf6ZT2gTp6LN6k9+Au8n1+vVnXW9pK6 46KbEhq5ICCw4kHG2yRukdzE0hzZt5s= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IiwDKaex; spf=pass (imf06.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.172 as permitted sender) smtp.mailfrom=ryncsn@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-2fac49b17ebso25041721fa.0 for ; Tue, 01 Oct 2024 14:10:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727817037; x=1728421837; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=j5FPHhbte4Tmc4ZuPG7hVMprQvRDLf4/a9y4DExRTII=; b=IiwDKaexIVjovIDgyRV+r988iYl+g/rFSxaqoxxu4z7xjxReh+O9k4aJp8vBuj29h/ nV7h9JNiNpPlFd15L/ULckVZjaP5SHHIiVDpwVooC1ViwA1C7mzWF23Lpmg4TK+VBhX0 cyDJ5R4cXdUx/LL8+fGX9Dkaz8U4vWIHelO9QeaWl1OUAochgkhUCy6x7n+FkD3E2kuu c/XQpsgsoLKhBzOtwPwcBsfjXMSI6Dt6XNKb+duJfrHHdmOgwJX0DzPew5P5JSgx4vpE yy7whiYMaT3rj5tFSct4acZhDwAxtLazq6W0jti5tluhOBcxScg/4fcd1TgwKqKuBdec nZtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727817037; x=1728421837; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j5FPHhbte4Tmc4ZuPG7hVMprQvRDLf4/a9y4DExRTII=; b=CwXkYU7IeSHHBrYudky3u5quf4+DQsaqzaD1OHGpJ7uL6AT0mXgLmURYYV8IRyRG/z cTxdcLAMhyzr3y3a6DESZsmDgZesbXlvdA/qqXUUkvmKS6gm2p9LIV4KDZLa1lAqmVxr ad0Nmb/nnixFJ1O+3d5e+Fcgtgej+6xdNVHlxPkr7Sw90gPGdeuzdwOO699Sh71uS/6S V+OOXB2v94QZRZLXx14+tAcuMsKPCwnR9HbP02Qwlm79tcgWyJ/zQ8c1WWXtYov9kmxu DT/iqBGlEQtrlR5Jqk5B8PZin8JTwV87gGZXGuR9Rst3Gb0qcEJhQwNuTnwn9n2zIlB/ /3LQ== X-Forwarded-Encrypted: i=1; AJvYcCUZzAo3bY2foTC3cAUQY3kB1FuFteyXxLEVVB/xJbvX3a63kst5o+fEzIbXFM+nnnhYGIt8GUcpeQ==@kvack.org X-Gm-Message-State: AOJu0YyzhTrTErkbnrEgf+0XlyTjh6UTvZ8uDNJgF/hn9ZZY14Tli69/ BR2qfxfBSjtEKVoeX0pa7QdWepIXIf2P/iWMZzzGRkgEo0d4SgtHBYP6ncaSVXsMlB0wye9y6at Eg+yqMXT65J5GQdoE0cq4iQ+dHmbQMrZsl2o= X-Google-Smtp-Source: AGHT+IHyH38WiVX8HHUwc+OFQWovZwKbJEqW/O3u3XocYkPNvtQCAvFmTdZx0nP6F2Y0oSa7jC6KgiPT019755iLMPg= X-Received: by 2002:a2e:be9e:0:b0:2f7:6e3a:7c1d with SMTP id 38308e7fff4ca-2fae1044cf5mr8284241fa.15.1727817036745; Tue, 01 Oct 2024 14:10:36 -0700 (PDT) MIME-Version: 1.0 References: <0a3b09db-23e8-4a06-85f8-a0d7bbc3228b@meta.com> <87plotvuo1.fsf@gentoo.org> <87y13dtaih.fsf@gentoo.org> <0bdce668-5711-4315-ab05-1a3492cb8bf6@kernel.dk> In-Reply-To: <0bdce668-5711-4315-ab05-1a3492cb8bf6@kernel.dk> From: Kairui Song Date: Wed, 2 Oct 2024 05:10:20 +0800 Message-ID: Subject: Re: Known and unfixed active data loss bug in MM + XFS with large folios since Dec 2021 (any kernel from 6.1 upwards) To: Jens Axboe Cc: Sam James , Greg KH , stable@kernel.org, clm@meta.com, Matthew Wilcox , ct@flyingcircus.io, david@fromorbit.com, dqminh@cloudflare.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, regressions@leemhuis.info, regressions@lists.linux.dev, torvalds@linux-foundation.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 163F718000D X-Stat-Signature: xphzfefss8k67bod44hsiqficsux4kbj X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1727817038-254101 X-HE-Meta: U2FsdGVkX19xNCDwZuUptlRtULIlyX641p2+N7YaDHD8luX2+Q1e2nNmy/wIISQL8VVPpv2+QVE2bhghPx9elmiYP5yt0KCei9Am75WNpaleHiAQycBNCDT78iAdFwHQ9OcwCT/ya7ahrRqkh8+aG1u6mLWmKSI/iGvhRFZ0ESi4BqnqFJW8Hn/3WIyAaHmPrQVzyy84NwEOZuTPVcWWy9IGvTokWpjQnoIh7MqFCEarlgwjCFQV1mPsbhAPGA8Uun0sV+IaGsHDj+gzSmvDzCb+MkQ1AdacXnyzpGAIeP4RanYIBdD42LXUiJ5iS7/sD7/hB0SJ6Es6SY+PRb+UWQA+lVohNytDLoGyhBCdVfOVH60kulXTjwDeC8XWU2L4kAlt4KpkZkiu6KCVX9CiSTfnWtkAShqn/KykgxLQQ1xuQAnGas+OQogjYpFHEHPPjdl9RY8knBrZ6OUZLMsbqN5Hv0hJKyarIbBhGOuPdWbS4OHmz4eQJ9TeooGpGB/kRNZmruSG+VtSkq2BIWQ7kUOdBoLQhIG/1aNIObXNAaV1kW4+u7VbjAt1vqJt7UyonbF/TBb17QKB1sCrBM0grTFPQcgfkXX1s6lOd5y8rruig3guJrd8oynxTHdFNtTKn+FkAdJhh1oO5cvshmryCf3otOhKogbFlJ02NLzi3nSlA3ymK6GXZoAnRekRRWgQpeKgqi9Egx5sZsoUxkqpNXmpZmbcsf+S7bCxtXjWpPGKNH44a5Z53rJZ13X5ZboKlML1DJxGKjafLwTyaXUDGivQHUriRYzqGgJnhdSudpR77ghqKb0Y2GDaizfpHi4uLCba34G+F1tGbO5xMlyz6xvqG/iJBIJ2oMnQ0Eb7FTR9txLKHeoHB0VrySPuUgSsqZAks6+t/JbXs11F3XzLu0drmDrBmO0HnZdcUwnatDVQRDuykIyTDIqPL8JU2yxAm+19N2Qct0bQjzouigp 1BjzpuuB DyhpTfARM8dcXCGyJRWIP44JDnryOYCZfHzudDWvh/F3P5iCyo+iHUKu92Mr3OC0hx605Db0kL8GwqC4HNO60Kwy2KmRHCe8jqX8x04T9AaZVizOF23bVJsCi9WZG6mllnGzav1YOnPhu3KJKuHtqcKRVXocmEDUlwJRJGXAwjlyHbePQGS79TULtTXIPO8jcFoH2JVV6ax6Mz7njt3GZSucqJIw+I/zaPNJKvZKikZKSZ3Lc8zJaAJPRTjBoptD9Zd1JqNSJDuJtbKsPvYimSqPJURMLBTrR05GgLiaB+EFCmmfmgrfPe+vXgxECVkey0qEsAn0tB6d8W9ATUjQewtjNOnKAkQNSI+ciXl1BHmF3qGp4kLfLyz0oLnmNeJaU2zbi7vhilm6hWamv7EERnl7Ddp3f5kOc/3+s+BQ5gRZGY3X4nRg28psUnOomPEE7LZ4lbUql0RNd1uotwPln6vUgry3VW4l/ZyIg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000022, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Sep 27, 2024 at 10:58=E2=80=AFPM Jens Axboe wrote= : > > On 9/27/24 8:51 AM, Sam James wrote: > > Kairui Song writes: > > > >> On Wed, Sep 25, 2024 at 1:16?AM Sam James wrote: > >>> > >>> Kairui, could you send them to the stable ML to be queued if Willy is > >>> fine with it? > >>> > >> > >> Hi Sam, > > > > Hi Kairui, > > > >> > >> Thanks for adding me to the discussion. > >> > >> Yes I'd like to, just not sure if people are still testing and > >> checking the commits. > >> > >> And I haven't sent seperate fix just for stable fix before, so can > >> anyone teach me, should I send only two patches for a minimal change, > >> or send a whole series (with some minor clean up patch as dependency) > >> for minimal conflicts? Or the stable team can just pick these up? > > > > Please see https://www.kernel.org/doc/html/v6.11/process/stable-kernel-= rules.html. > > > > If Option 2 can't work (because of conflicts), please follow Option 3 > > (https://www.kernel.org/doc/html/v6.11/process/stable-kernel-rules.html= #option-3). > > > > Just explain the background and link to this thread in a cover letter > > and mention it's your first time. Greg didn't bite me when I fumbled my > > way around it :)y > > > > (greg, please correct me if I'm talking rubbish) > > It needs two cherry picks, one of them won't pick cleanly. So I suggest > whoever submits this to stable does: > > 1) Cherry pick the two commits, fixup the simple issue with one of them. > I forget what it was since it's been a week and a half since I did > it, but it's trivial to fixup. > > Don't forget to add the "commit XXX upstream" to the commit message. > > 2) Test that it compiles and boots and send an email to > stable@vger.kernel.org with the patches attached and CC the folks in > this thread, to help spot if there are mistakes. > > and that should be it. Worst case, we'll need a few different patches > since this affects anything back to 5.19, and each currently maintained > stable kernel version will need it. > Hi Sam, Jens, Thanks very much, currently maintained upstream kernels are 6.10, 6.6, 6.1, 5.15, 5.10, 5.4, 4.19. I think only 6.6 and 6.1 need backport, I've sent a fix for these two, it's three checkpicks from the one 6.10 series so the conflict is minimal. The stable series can be applied without conflict for both.