From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40979C46CD2 for ; Tue, 30 Jan 2024 05:55:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 937C06B0075; Tue, 30 Jan 2024 00:55:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E7A06B007D; Tue, 30 Jan 2024 00:55:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7AF016B007E; Tue, 30 Jan 2024 00:55:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 679E16B0075 for ; Tue, 30 Jan 2024 00:55:40 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 3981B1A038F for ; Tue, 30 Jan 2024 05:55:40 +0000 (UTC) X-FDA: 81734915640.15.B1AE95B Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by imf29.hostedemail.com (Postfix) with ESMTP id 48C9D120026 for ; Tue, 30 Jan 2024 05:55:37 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fY8+sMOw; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf29.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.167.47 as permitted sender) smtp.mailfrom=ryncsn@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706594138; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iNSFIzC99NdyScbVziFYqKRK4spLwzlJEsIkJFIvX98=; b=krZjJEAb1hh+5Eg1eTeqGSgOmvZzvwBh6/Wyvm0IfDUFWzHJYDkMpJVSr8zxceaqZcIPRT vA7NRCG/6FFqEpYJwy8DXjCiPldhJVcPIceA0a71NeX+VzrnjYudWZCygxdyO+DMYcxxyG V3pfSgbpGWNq0emEmAMImN/GWj+K3/g= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fY8+sMOw; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf29.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.167.47 as permitted sender) smtp.mailfrom=ryncsn@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706594138; a=rsa-sha256; cv=none; b=iwqBAxQ8v2yTlH/ULQGeJTSqyI4cr+nXIhlbnsUvNyGSSsDIdno/5z6gVpN56SoIvVt1y5 vHwDEyZUtCHZpvah9KMP74oBLJin0rxBAniqeGy2InY8pRyJe5vPkvGirF2cEeFZt4fWQk Qa9+6HA1+lgeJnW7o8F64dCTuTGu2iQ= Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-510322d5275so3769709e87.1 for ; Mon, 29 Jan 2024 21:55:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706594136; x=1707198936; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=iNSFIzC99NdyScbVziFYqKRK4spLwzlJEsIkJFIvX98=; b=fY8+sMOwej8kQIeqoW67zA412hVwVMFBumqKsnSkUoI3xdTJogfDOeyRUkR2B3NKap ffSa4n+3JGxXgpTnWVqYES0f7KreMhP0jSKMSXP9SudjyyWQnHywexGg6EJOuXBVnCpx 5S7St8kmyEVmOvRWlIhwGZnXN7aPNNu7lYSmDp3hLoawllrbTXppCyuCLQYD7LSII1ju y0a9GcsjDIsA1a0fVBo+wC49YgAYtzu5LtcF3kd+7o7wUCxwgbX56lqh+0NxQOMYeOlK j5nIPcJnposyJfBQ7rtGcR8+F1JM+d5sg4OfD1oCYQsu+0mGnvdPbRhDyqe4kb0LBDFS Yv4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706594136; x=1707198936; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iNSFIzC99NdyScbVziFYqKRK4spLwzlJEsIkJFIvX98=; b=MJfOkYkTMn2M2TOcCGeNbNXyVF9SC40zxj8DAxraD8JsWzaEBPw/X7jN89kd1HBpSK R27plOPo5ZiYfayBiFtOheMNsfOAqTkjqr0tEFHaeQrn0Ciq+UCYp8Bk5JDr8PGNGPga pYbL0UV2bKIYfcW6VpEcikwNqgHZEsuXSZnrRKoppziPm8oaNF0057pJ81CENNs13feO ykdVPinu90h+c90zSGlFmezQHNrdPbxcQhrpjVelIa3irNaQKyB7oGf8xvqf4rUs5P69 t+qfB2Y8YFwji4rGI7M7cqhjTKukNVekYP4DDAfxuILfYtbhS+y96Uhp0EbU05D9ggGY DZZw== X-Gm-Message-State: AOJu0YxdTu2rtOzf5pmD/N/xtMsSKOjgkVw7W+XF3shuetRiDcRBV26j hH5muDmbvBDaI3OBB2tUOTc0yoWIV8Cp92rJXvkFbLLQ8Xzeqy051Luria30Tz18Wz484NRDMRZ 2iY/KfFdiXWNeWCshhxoibOGol5I= X-Google-Smtp-Source: AGHT+IGHlMEGhni9zMb1H1khXMv3ERnRcpgP/0GXIgGCkwDzndrvZgzna31q8ELC48RoCoaV220ZTuzLL9aoHrod0sM= X-Received: by 2002:a05:651c:2cc:b0:2cd:7039:e281 with SMTP id f12-20020a05651c02cc00b002cd7039e281mr209926ljo.8.1706594136011; Mon, 29 Jan 2024 21:55:36 -0800 (PST) MIME-Version: 1.0 References: <20240129175423.1987-1-ryncsn@gmail.com> <20240129175423.1987-3-ryncsn@gmail.com> <87wmrrgz40.fsf@yhuang6-desk2.ccr.corp.intel.com> In-Reply-To: <87wmrrgz40.fsf@yhuang6-desk2.ccr.corp.intel.com> From: Kairui Song Date: Tue, 30 Jan 2024 13:55:18 +0800 Message-ID: Subject: Re: [PATCH v3 2/7] mm/swap: move no readahead swapin code to a stand-alone helper To: "Huang, Ying" Cc: linux-mm@kvack.org, Andrew Morton , Chris Li , Hugh Dickins , Johannes Weiner , Matthew Wilcox , Michal Hocko , Yosry Ahmed , David Hildenbrand , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 48C9D120026 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: zm3qq7jdq896mwj534eb69tfpeskz9b7 X-HE-Tag: 1706594137-4833 X-HE-Meta: U2FsdGVkX1+aOOrWKXo/XL98luSbJyydCGjc6U5TDPQb6qJJAWYXvceqat5zQOxyih6UyESsX9pY6otsUWeUPYxwbUwOpPX0ZqWnd36plV2RuQXeMSz8dsd1zUQkI4mu3Hau8bdGwTtYlo98jzXZseFS+Q97wgXKUBT56kkFc+C2LGg6ZE/2BaWMfL/v2tNkvgx7EwUn1YZkOYnsLH+CMw4bZ+1uM8qCFQ3CBU1sHtL93Dfbe64/25tgs3HPGfDmrGSZ2Q9BnALnFBQ5ZKPIhy58xZf6UBA9Irv28d9g8AbN66wyZ4xgqddW5MqkZWJgLD82kbvMRIU8TfvnzM+/utL6l2TACAFU2UHo8vIDCENGQP9TkhivTR2XYh7TmOoHBBHw6iIrIlb+ZkgOBRUNew95zfyndz435ZK1rCwfFF8o59bGYFjtSbIV0cgSEsn75DYNVwjeXEuTWjzuQX3nygYOj0q9Fe1pubuUcjiCpGL8U0xCs2Hp82Ki5ZaAGZQPdagdgD+ZhCgOf9AiZiL8PAjyV9E5VsC6KyCLWkwmnTxxD7Q0U36ZL4WvkuOWGzpdkCPnH3MtAZPL7aSS3Av5hq+d8cpnBnqaSpc9ZgNITRE6h2TinAX21HkpjwkvmK/IY8n2SK1O9W2UWHYx8828mkmtVs/ywtXAa0T3YUxd2oFu1bZ2YyqS1lPp4IV23f2QKR9Y1liHOtXlMaDvXDIVOBtG8Vd+zfWyaSwDaFJmWApDNhrudPMzrRTLf2uRbQVPlVNVQ5H7IK57/ekAcshRGPCyD1FXfkiq6cy4gk7PGBezDTptoeePi5NkXV8PcP5w4V0tXakqlYvxc/YtTcHGTnviw4xAHdLYRodN1b8Bg/ih2u/RC2kKb8FrkMd3Bn1bL06S7JikYS87ZiPDuB5P5u5ZlUHqpwdvxJueQihQ9Fe06hj08agTh7iDKZCNgVpbneUG4ptEhfb3sNe6UNg e2B8PMJ+ +bpQeqTZTJWUOZhUBBgqXuJiDWRgcIghzkLSHBcM4LtJlX8HVGaSEcEDZXkapmQ4+NJgWa+U5QKHugwwnIayhrRdRCjWB3A/hqk9yhUfcOyvioPDiHZyQPbZiJxuQxLbm3VywiN5f2P+BqIuDJLyMgw5mmWtuQV0hTKRiq7hiE85pm3ODuS5SqthSq7AAXkA5uB8y4eLtCE7HVsZTkAZ+7THTy34nJboobO4vFuQaUrXqNyb1W8FXLkDTwhWAB3+96jSzJUeOzrdLMrMtVNQp4enc5BeSMfnPvv5NMme0bDbS1dN31hmV0CWXoHfw2dp4O6hFKOIrTOecd80B8iM3prxHS+j5/qucjwHeX24YBnJFoCNjulAieobSdYH5Vxjbv0hDa9TGE76r/LaH+jTn34Q79mY1GBL6FcsAM6uJd835BQflGaYavHoJGt8N76WNcvNH4gR2WQ8z4WBEZEzn/SgOX6VWbxPcymAM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 30, 2024 at 1:40=E2=80=AFPM Huang, Ying = wrote: > > Kairui Song writes: > > > From: Kairui Song > > > > No feature change, simply move the routine to a standalone function to > > be re-used later. The error path handling is copied from the "out_page" > > label, to make the code change minimized for easier reviewing. > > The error processing for mem_cgroup_swapin_charge_folio() failure is > changed a little. That looks OK for me. But you need to make it > explicit in change log. Especially, it's not "no feature change" > strictly. Yes, you are correct, I thought it was hardly observable for users, so ignored that, let me fix the commit message then. Thanks for the suggestion. > > -- > Best Regards, > Huang, Ying