From: Kairui Song <ryncsn@gmail.com>
To: SeongJae Park <sj@kernel.org>
Cc: damon@lists.linux.dev, Jonathan Corbet <corbet@lwn.net>,
linux-mm@kvack.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Docs/admin-guide/mm/damon/usage: fix the example code snip
Date: Tue, 23 Aug 2022 19:39:36 +0800 [thread overview]
Message-ID: <CAMgjq7D989Ki-zHN5=yY+MYj2tUqizmg++PSK=5J6epr4isF6w@mail.gmail.com> (raw)
In-Reply-To: <20220822170500.87712-1-sj@kernel.org>
SeongJae Park <sj@kernel.org> 于2022年8月23日周二 01:05写道：
>
> On Mon, 22 Aug 2022 16:56:46 +0000 SeongJae Park <sj@kernel.org> wrote:
>
> > Hi Kairui,
> >
> >
> > On Mon, 22 Aug 2022 18:56:17 +0800 Kairui Song <ryncsn@gmail.com> wrote:
> >
> > > From: Kairui Song <kasong@tencent.com>
> > >
> > > The workflow example code is not working since it got the file names
> > > wrong. So fix this.
> >
> > Nice finding, thank you for this patch!
> >
> > >
>
> Oh, I forgot saying that it would be good to have Fixes: here, like below:
>
> Fixes: b18402726bd1 ("Docs/admin-guide/mm/damon/usage: document DAMON sysfs interface")
Thanks for the review, Let me send a V2 adding the "Fixes:" tag and
your review by.
prev parent reply other threads:[~2022-08-23 11:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 10:56 Kairui Song
2022-08-22 16:56 ` SeongJae Park
2022-08-22 17:05 ` SeongJae Park
2022-08-23 11:39 ` Kairui Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMgjq7D989Ki-zHN5=yY+MYj2tUqizmg++PSK=5J6epr4isF6w@mail.gmail.com' \
--to=ryncsn@gmail.com \
--cc=corbet@lwn.net \
--cc=damon@lists.linux.dev \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox