From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D82BC4345F for ; Mon, 29 Apr 2024 19:22:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 07A816B00A3; Mon, 29 Apr 2024 15:22:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 003B86B00A5; Mon, 29 Apr 2024 15:22:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DBF986B00A6; Mon, 29 Apr 2024 15:22:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B9AA66B00A3 for ; Mon, 29 Apr 2024 15:22:31 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 60528140415 for ; Mon, 29 Apr 2024 19:22:31 +0000 (UTC) X-FDA: 82063540902.07.63FA141 Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) by imf23.hostedemail.com (Postfix) with ESMTP id 8850214001C for ; Mon, 29 Apr 2024 19:22:29 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="Y4XFJq/Y"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.176 as permitted sender) smtp.mailfrom=ryncsn@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714418549; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Cpd1WYildkuoLom26860P+BikCx3lu1sKsq7QDlDPG8=; b=grswUorV/st33jt0jxeRWF2rkLDBJDZLymjd0v3Xk8sow5CNoNICNzKDh+mO+Djp5mebjG 4laOLe24xX+dQEB9UraljNuohl+eosXnCUCTy+nB0iURMApOTJdBI+sfGprzqMggM3rQ7w mMPKTEWG9YIZDT50NHga02V8QUveGKw= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="Y4XFJq/Y"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.176 as permitted sender) smtp.mailfrom=ryncsn@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714418549; a=rsa-sha256; cv=none; b=zdKoUI8f4qY5VlGaY662bMrRM5YSIlbwG+r1AFn909QniuIzceUloLHROHt2Nnt22XwwJt MKlDQnSKHG8B9HXx1sWs+b0VKW/+GPyKcxJdSkOT9LzBb6W6CodEgF+BWp7uhJH25MxKUG qwQi142rjOHBL0gmFcOltbHRYDbTF9w= Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-2dd64d6fe94so55372451fa.0 for ; Mon, 29 Apr 2024 12:22:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714418548; x=1715023348; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Cpd1WYildkuoLom26860P+BikCx3lu1sKsq7QDlDPG8=; b=Y4XFJq/YpeVdvMcLm6vVWRpaImn8DXsye8DG8sY6K82iD7De3Qbsh7sy9DRUted9IA S//JjtLIfupb3ne3P2ubSZDJ0FSGz9sp4UWss9RcEHL92tj0+zgRQDn8yhoAxcw0MGII tS2DJA4vJfeYoAPIMmhCigALy1NXtRGkXAIfNiNprDSaOKKaw8BbTWouHlWy5ntFYLjo dK6b/pE2JXgIjYspRJR99ptgbhVKVsiM1bcZmjKitaC2P332bwqVbCnhT8hQElpqYFoi 5jht9V2xuA/0enHf8+5V5c6/p85QjbNFIHHlx2qMQQsWHJAfrRTwB17YIL2JOSA26+kM WlKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714418548; x=1715023348; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Cpd1WYildkuoLom26860P+BikCx3lu1sKsq7QDlDPG8=; b=gYSo/Tuy+EgQay/EfnDbNGm19nanvuFiY4UmxP50lFza0zuLj6Zfx4+SOFCGyO7odS 62X4WspFvqxMH0FYTSv49D+rkxZyp1mY5HDHxlfQMpn7+Og0y2u0vTZxZFjzsU8ysZC3 42pxYiv2kXqrR9G5RT/RmI7r5DuUgAHwQOF+SRF2JNVQgEgt/7rXkgZvg4RVg1SEm0qq h4FOgxjYiOSH2lREz9oaavwi25FiiKFSm5s56RL++khF7IcgzwBoju7zmMUBwfKVQJxg Fys2ITL6tk10lKR+JQcJ6qyI6iAuyPGznaWeTi2/kLt7oiVAmlGcLaAWfKlMU8Cfq52B BScg== X-Gm-Message-State: AOJu0YwtPZ07WSNFDYP8bJ4cZWQKItRCkGjEcy+Wjhj8vcGmIrFt3dyI nbHe4twngj77e0vp2rTlVVHurl7q56Aj1hNz2YdcUPF1FdKUIL591tPtst5dNBPDg7e0H1NuFm3 NnWQfbL3g1BqXhWXM7jaTMMypPKI= X-Google-Smtp-Source: AGHT+IGSowF/+xWsJ96Y/dHBc0kV+WSElRsdFJhZmSTk9Dz1YbSkQSIgU2LDwJkdHchcBZki+qVTxZok5w4qnCfrVlQ= X-Received: by 2002:a2e:b6d1:0:b0:2d6:e2aa:6801 with SMTP id m17-20020a2eb6d1000000b002d6e2aa6801mr6798806ljo.46.1714418547561; Mon, 29 Apr 2024 12:22:27 -0700 (PDT) MIME-Version: 1.0 References: <20240429190500.30979-1-ryncsn@gmail.com> <20240429190500.30979-3-ryncsn@gmail.com> In-Reply-To: From: Kairui Song Date: Tue, 30 Apr 2024 03:22:10 +0800 Message-ID: Subject: Re: [PATCH v3 02/12] nilfs2: drop usage of page_index To: Matthew Wilcox Cc: linux-mm@kvack.org, Andrew Morton , "Huang, Ying" , Chris Li , Barry Song , Ryan Roberts , Neil Brown , Minchan Kim , Hugh Dickins , David Hildenbrand , Yosry Ahmed , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Ryusuke Konishi , linux-nilfs@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 8850214001C X-Stat-Signature: i17tmq6xatpr7hasf8wfgt57i7y84nd9 X-HE-Tag: 1714418549-221828 X-HE-Meta: U2FsdGVkX1/VfPslbI0MReio3GaideZg4f1TZBa6pB6tZUL6r5eWPEk1UsyVGOAft7RanfsAm30Y1rZba/U/C6s7YW+jinaREDidcHE/69HKnFYwDXd745oXBVndvSUwoQvqRnKRJ41PXtNNM6+lQigN3/vs8VwHLxyNy2By1q8/HnNKiMDkcOYSt+hfIFphMXnF1vu0ng/4tkwJraTQKNlzv1Vhs1pXYO+T1dQWXfOr7o7+zuEjEMV4QIVmQf8slOF4dOAunb4yIqybsN5j4RvfRvcEb9KijzGrqRSLzrgYFUJjE21EIeeSLCYKDyL/zqI9pZ5hF+nc0BjGiBNofv7Lb/hlcdfOxgtcNBshdVp5V8vTRIa1ttBZhavySV+vbPc6Lt72Afa+TC4h5UhPxbfmbievfClptP6aazrYLxcAyt7t5lOrw8HH3mPC64vcjso3wPGURdscBl5Mj0TPOwrnpdBesBtz3jFxu8uo8rR+Pz6t/dhmMQ4dGPZhkiNAfCQvD9614THHJcx/u2e1LIKEL21R8qZfi/XGuSP8D5nH4fQDAp3mgcFAwPAREGdT6x2ZZetKQ+1rWK+0NdBQDN2q8X+s8VCAVCpnQs52ThZkJTF3I3IevH5joUIVbrlyVMMMX4n4/bW9o81/SW93fzYYEO/TSz477oGBx41w2q5jLRCsSUEaU7CpX4lKNDH+DJSSUYQ2uuOmbB4sO8dSMJgu6ki9Z3nOazW/uPTXOlQmya/rcVoMRyul0AWnhy4yzBxZUIzbOhnhCP6L9opBiEf9lbac4IQbSbaymyNd7RzPDv1pmxzqXC186SRgTbBLq2CQ+binGFNdWIMq1qtF0CDY8qMyAR40rW2ud8R4o0a5j9TmtFxQH9QAFcR5COBtIqNCJsrU6A+xpft/iJp0XmV7399zMn2HNSjlm51kGRxQdpjPytbyL8Zi9/wU+vQpa8HrHaGHHxC96FtlvpX 8hKAkAKN aGdZPVqyMBD3biWePfNI4aYuycZFWmK6NyhPdsU/K0i0lNxPUasSr0SHTTbimzc1r6DQt1GGCe35DGjICLGv35e4Kag+6dSsnuTUMw/UFYTM/jopFo+S32pvExHMaiYdg1gStpb20eGVOeeDxh8rhXJRVMfWS5zwRX9nQE0S4YR7yoiy6H+UzMfBGWY3wG1Hlp8iHgQtPJT9QTDSu+nn8/EeKSQGVvhws9Db0wstNiPRTsSrHmgyKYPKwo1ca/uIvv9WPRbfYJqn9NR3hK5pDosXKbyAYLCqbPGxX46KNjJOVwqU0TERDm7Qf6BLoXYe25v5EIqwDWe+DmKb/WntaZyEZXsFcWh7j/RpSa+TujP8MNT2tUUHkk8xTmEY6mSao6tJhXQapDcBahpn+a7VzxZp/zAXHZDTjoYzF+KmiOoery69XnvDBMtBop8BsBkfbqjaxIDVue+kBotzUImzEcwa6WRRjiZdG4YdOetIThbWGbG/JOYduAwMyffki2RoPVIzC63jbnX4LKeMNkQnVW/0mSQfYqcr4+12N0Ml04JzGpUcFdLymks6UPHsJxTn/auOUPv2xn12Wv4lxcmyUg3JgV8McN0UGVF8utDbH7xrQf8vx+IYECw0nT2+GNNMucq0rbd/TjgiVZaT0Nw6NmL+KD71TuAY3/8VlnNbZ8fgNujk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 30, 2024 at 3:14=E2=80=AFAM Matthew Wilcox wrote: > > On Tue, Apr 30, 2024 at 03:04:50AM +0800, Kairui Song wrote: > > From: Kairui Song > > > > page_index is only for mixed usage of page cache and swap cache, for > > pure page cache usage, the caller can just use page->index instead. > > > > It can't be a swap cache page here (being part of buffer head), > > so just drop it, also convert it to use folio. > > > > Signed-off-by: Kairui Song > > Cc: Ryusuke Konishi > > Cc: linux-nilfs@vger.kernel.org > > --- > > fs/nilfs2/bmap.c | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/fs/nilfs2/bmap.c b/fs/nilfs2/bmap.c > > index 383f0afa2cea..f4e5df0cd720 100644 > > --- a/fs/nilfs2/bmap.c > > +++ b/fs/nilfs2/bmap.c > > @@ -453,9 +453,8 @@ __u64 nilfs_bmap_data_get_key(const struct nilfs_bm= ap *bmap, > > struct buffer_head *pbh; > > __u64 key; > > > > - key =3D page_index(bh->b_page) << (PAGE_SHIFT - > > - bmap->b_inode->i_blkbits); > > - for (pbh =3D page_buffers(bh->b_page); pbh !=3D bh; pbh =3D pbh->= b_this_page) > > + key =3D bh->b_folio->index << (PAGE_SHIFT - bmap->b_inode->i_blkb= its); > > + for (pbh =3D folio_buffers(bh->b_folio); pbh !=3D bh; pbh =3D pbh= ->b_this_page) > > key++; > > > > return key; > > Why isn't this entire function simply: > > return bh->b_blocknr; > Nice idea, I didn't plan for extra clean up and test for fs code, but this might be OK to have, will check it.