From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 743C7C3ABDA for ; Tue, 20 May 2025 03:50:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D03CF6B0083; Mon, 19 May 2025 23:50:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CB4F26B0085; Mon, 19 May 2025 23:50:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA3706B0088; Mon, 19 May 2025 23:50:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 966286B0083 for ; Mon, 19 May 2025 23:50:52 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 37CD5121BE1 for ; Tue, 20 May 2025 03:50:52 +0000 (UTC) X-FDA: 83461909944.22.65C8A6E Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) by imf18.hostedemail.com (Postfix) with ESMTP id 3E1D71C0002 for ; Tue, 20 May 2025 03:50:49 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CeNuIkcU; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.171 as permitted sender) smtp.mailfrom=ryncsn@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747713050; a=rsa-sha256; cv=none; b=trMuVA+897gfCAQuSIMoS8aeYaxkhhIVq3WeQVWrq0eYvCgix4Dqkv+qo35SjV2d/1009f mUyUO5GuhPZdztyyG7ck8T7i2gHpLirCjdxCjBKnl0Oi9v6cyBNGv1+1OvexlMFRXyCPLa qik5CUuoJPVF6cLXGvhq1xk0tRpMuDg= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CeNuIkcU; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.171 as permitted sender) smtp.mailfrom=ryncsn@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747713050; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HYdj+bJIsJtgt3154G/5pOH4AVBqxBVjujHHkLYPMcY=; b=moUh6MiKG1Sm74zGMaWyvv1XnS4ZpDS9SDLez5ErxcjSysP9UmXbbFqwVDYdI4S4vtUS8s NTuXGBP3kf8yNXRGx7tpbl0OQZQUBLk8yebQQb5j0pKhMTgIQyajIQzh8J96GPelc3CysF U8VtzM+yhN4BEx5KvM9fPpRJGVI1IaI= Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-32909637624so28120761fa.1 for ; Mon, 19 May 2025 20:50:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747713048; x=1748317848; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HYdj+bJIsJtgt3154G/5pOH4AVBqxBVjujHHkLYPMcY=; b=CeNuIkcUj5bzZ91JDD9FWGm0zCYkLK2/Pb90MEfIZKb8oywcF6epRqSkwnM0xOAX8e Peh58Aevyhts6Nw0a06qO5AzRdm+f5KmLwcKoL0NFYxAZ6yxf70JtUZ8/uZUxAeSFRr/ xQcdDRHR6n1h471Bkqnc85zThsdwz7NtSFc0LAglzhKgkBWC7bb20Y0TZXWZCljVuuUk 419jL0QNYuzJzEga+xYf/ygZMRk6tFObuHqwrnG/OI3IET33bpnzD887NlaXxqu4h73M 6m687AVhIhcArAGLFnQULvFnpZjzupi3zOoZOQs6fjCI1uj1IuszEr+ASXqFaJjRDXv+ Uobg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747713048; x=1748317848; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HYdj+bJIsJtgt3154G/5pOH4AVBqxBVjujHHkLYPMcY=; b=vRvYEy3oCZuRVPYM5mLM4mO4Br21j1qKTrkug/pP5NnBZ9R3nkPvkLZ5jUX/xUi+nB Vdg8dSFZVTtjkyxc+FmL5W+3r8QqnRYST/H4ZlOVottv2JYF0SRBkBG14AovuvvSZVQy CJSEuzLTXebUNwgGfvWnQB8cKkGsy0J/UHzrEckG+e0ZtssGf+Q4iOpo8o19C+OGXI04 Lb1UFJE7aJGBiVSKwif/aLEIsS0EOPOERWgswSApVFgZz4fIFalfOiUYKxsEqmjl7RXm TFyPKOt/q1lfsMpV426+FNpcqgHLytOxj1HBAhs1hkVa2Xse1QET2iWL4W+ntRYWVjrS Lc7g== X-Forwarded-Encrypted: i=1; AJvYcCUOe52DnCxsU84CQu4x9/Jk17iVNhNswbtUFUnJM/IMRSP+Q7blbcRywC4APyK2qncnbTzRqCo1BA==@kvack.org X-Gm-Message-State: AOJu0YwSnFRFjJ4vpBjlLAOrM0ej1QQO8HIWeADS9MiE5GdRPnyjLPFw JZiX8wn+qGUmZOnsFyGzOm9nC2ZLXL3cMEwOLTMTUC2aEP2BDXrStmGpv3FTdeVd5XNhCtcaCtI 68Vn77mltePqgkJMYRNn0lR2cumXDWx4= X-Gm-Gg: ASbGncsHTbsIevGvxZyGTUm27weDFiCMurU4EKZm26O8pclXI1p4cUw04ghNPrOBxhD h0OkLlFUDUnGEVIctsmjMg/55E2VePYhZsnzmXmfKd5Ml2oj0BBNgva1RY8O5nbllSzxtBnXVNd jfDzeoBNT9AdWY+c/IZH86zNx7QodLLX/h X-Google-Smtp-Source: AGHT+IET2DGq452q9rAbrOwwqsOYJk4lcDjWkGmidydLLMrzoyKoG2CX94AhT8gHlMfg1hd9STj1tLek/ZqIODkZJfc= X-Received: by 2002:a05:651c:2214:b0:30c:518e:452 with SMTP id 38308e7fff4ca-3280771e0c9mr50872371fa.13.1747713048270; Mon, 19 May 2025 20:50:48 -0700 (PDT) MIME-Version: 1.0 References: <20250514201729.48420-7-ryncsn@gmail.com> <20250519062605.2357-1-21cnbao@gmail.com> In-Reply-To: <20250519062605.2357-1-21cnbao@gmail.com> From: Kairui Song Date: Tue, 20 May 2025 11:50:30 +0800 X-Gm-Features: AX0GCFujiyVXBw1NCKW1NJElWjLorE0Qzqy_JyDu_-XDxeORjA1QdwnggC6Lk9g Message-ID: Subject: Re: [PATCH 06/28] mm, swap: rearrange swap cluster definition and helpers To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, baohua@kernel.org, baolin.wang@linux.alibaba.com, bhe@redhat.com, chrisl@kernel.org, david@redhat.com, hannes@cmpxchg.org, hughd@google.com, kaleshsingh@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, nphamcs@gmail.com, ryan.roberts@arm.com, shikemeng@huaweicloud.com, tim.c.chen@linux.intel.com, willy@infradead.org, ying.huang@linux.alibaba.com, yosryahmed@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 3E1D71C0002 X-Stat-Signature: wrot46mdchmgrusqwcnxnrcfdccguhjq X-HE-Tag: 1747713049-457481 X-HE-Meta: U2FsdGVkX1+qltijLNLNbNJllbm5CpG5WPu/5MZW4NQ9vTRKLcSHYEiTIxQiMVccM5IVYMkV9Z2loS+RbT6TJXHilrWvQXMFYCTsC+tG5twyxOYbWZAL0Ge2/J5QribjP80abkdkOpIFS7/bNu59rqp9O67ch8NX3wH7nGV5vutm4S10v3H9NwAXsokm6m3QaYPWpF7vS3FntanQb5N1MzW8hz1IfzWui6oXzAhej039kuUqM2H4E1+S3nj9bUmu2eUkJFGr/s8RQfFqWyHIqS+XBS0NMH7XNo8gZnhhc9gPYuo7lJRYfL2hLIb+P9oeM92yzbnxBT/JvyKmW1T93vlqZ+3LOFKpfNkSsimcy0MpNVsWOL2rbKaex0j32e04zruZmdHCjzuKRm+vzw4KX1VMdt3v0qpaq+qpwl9KC8sEEkABQptfpbAeaSYCdbpNo6fbVozsdrY+pj6Gv1UhOjJlK9cEcMf9ZjYbW6KAjaSnoww5/nu2ISxOYtBRq2jVVOdwls9rnOgpMfRZqa44X+nJLtkTmyxZqBQgvWTovRt9x8n3zyVkKp8K72pqzWm43PU9dzPTQY1kfWu2uxpH/vHiIWVHtvvLtAf2oV0nW1JlqjsfcNustvYWbmGd0CnSVBIQJqdg0XV+0z6VumVKSAGOWxwAQGOnOkgxdQQ+wKoVbqIK11RnY1ejt5mQc03zrIowBN25r0M2ubhPWG7HkEx6YxDDAXH4ClkVPpYe65vgtaPAkTpE1wjXo+1KoNQy6Q5BNWEF2jQYU75esR/xnT4UW+595tCKfNzGIkBkV71WOMnrDxNbhyQx4lS0NKkMXEl4nxM/N26evS4M3yOLuldzfTrwRzvsZ42PUVX+RXLIsnYsJjwhOgE8x99bkw9LWd6t+Kx4nF1+i7OfiLBPx1qZ5DzbHFqS+cF+4TTN3qt8D7710MqJrSPGcr9kSb5XIt92IU64dm433TMcqdp D1VyJsNM wLZSQbh5qJYPhGNo2E1bK2PN6ISKlNbDC5lyu8UD2fWaOr2xmNXcDTdS6ulwxFipyWmWGMY2dvBJNX5nIdzSTb/R+efAkUP4k7OqGjGqMhO+/es2DMz5Olf30ratdOFZ0XlgSbSoB1BGbjiNqyO9JkWJ12YV95QEBU9iDxWLFBWfXgbhVlWmpt8fRS7OVVaVcIM2YZE0pSZ9cy37twVNlp2P2TH/DvOR9nm86K6kL0mMqsPG7XThguLgManFnCxYzaJUpz3SoX2XaGLzq46L3+65v2miuRTUoHxMUO+Y/xMEg+LsbkR+6e+zg52kR/IRid7PCVfCHiIAyZD7WPpvu0+sBv2Ev9vZM3b26JBsu4wiCGcGVcvv2Xia21Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, May 19, 2025 at 2:26=E2=80=AFPM Barry Song <21cnbao@gmail.com> wrot= e: > > > From: Kairui Song > > > @@ -889,10 +849,8 @@ static unsigned long cluster_alloc_swap_entry(stru= ct swap_info_struct *si, int o > > /* Serialize HDD SWAP allocation for each device. */ > > spin_lock(&si->global_cluster_lock); > > offset =3D si->global_cluster->next[order]; > > - if (offset =3D=3D SWAP_ENTRY_INVALID) > > - goto new_cluster; > > We are implicitly dropping this. Does it mean the current code is wrong? > Do we need some clarification about this? Sorry, my bad, this change has nothing to do with this commit, I'll drop this change in the next version. > > > > > - ci =3D lock_cluster(si, offset); > > + ci =3D swap_lock_cluster(si, offset); > > /* Cluster could have been used by another order */ > > if (cluster_is_usable(ci, order)) { > > if (cluster_is_empty(ci)) > > Thanks > Barry