From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB63EC47077 for ; Thu, 11 Jan 2024 18:38:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 718056B00AD; Thu, 11 Jan 2024 13:38:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C7346B00AF; Thu, 11 Jan 2024 13:38:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 56A206B00B0; Thu, 11 Jan 2024 13:38:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3D37C6B00AF for ; Thu, 11 Jan 2024 13:38:16 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1CBE9140163 for ; Thu, 11 Jan 2024 18:38:16 +0000 (UTC) X-FDA: 81667890192.22.0F061B6 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by imf26.hostedemail.com (Postfix) with ESMTP id 2F8AC140025 for ; Thu, 11 Jan 2024 18:38:13 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=E2reQNXU; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.178 as permitted sender) smtp.mailfrom=ryncsn@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704998294; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BpRmx63Tx70yMmTO0ohECxAXID3B0DpOULNfXZ9JjIc=; b=pSnn9MY+hI27hSL9g6BpOL3gEV+JOcRHUFEKzq0DpgBwEMBuVHUleGbZ+V8R+Fjs1/Bb4d ZGda3rePqxpzQnRaD7YWOYCW+/8vdjovMKG0GtFu2rCOQ0VHMTZa+Is3K3/48DruyDabgv VdqcMXxzFrq+U81BcRGGlWDZbBbATIk= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=E2reQNXU; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.178 as permitted sender) smtp.mailfrom=ryncsn@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704998294; a=rsa-sha256; cv=none; b=jglou5aJyq+LlZsKwF/a9/RaFmbOd5HgFZZnPY1e72kVdN7xhoGYG/dPIzXn/CDBurlEX6 LVnZR/GGGZbkhzo8YS5NmLe3+bxaE7dYBnmgbMe+ys+FhvGKJbwFOZv9t3wmLkx3Zpuyy8 9zBAPm9TR+ubMpSSGZ2WAF6wrW+SyVU= Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-2cd7e348311so24064231fa.2 for ; Thu, 11 Jan 2024 10:38:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704998292; x=1705603092; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=BpRmx63Tx70yMmTO0ohECxAXID3B0DpOULNfXZ9JjIc=; b=E2reQNXUe0AnQ8z3A/PsjPIUNOXFYM/tLgPAk13qhRMaBQwdeqFFitvk0jAnPIsf/V pGId9yLtwU/RGpb9cAHxhbsQLVOYXQrwSd2MaMthqfCdT62MC0ek0LIsOYqwL4Gh1ttP zuRBGx1SCEPEQ23+uck7OnH+oSU8xGtWXIQG427AX/hwK7dZ6mCbK2UhL6+CqaO0ryYx bBcbAfExHXCN9zugoq2XjLYTv0F1RGkGgdwvF7T+Ua2xZ8m4DdCsOiuDTHclrJe5EXtS 2osB1yTrhJRiyc/pTxw36a3lGjHDSosGVpYVR7yxuBsA06BXAujLEy9nfBgdvnYxxxeZ 5sXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704998292; x=1705603092; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BpRmx63Tx70yMmTO0ohECxAXID3B0DpOULNfXZ9JjIc=; b=aTZkY0aDOLW8t8swIUp87twoRit6PjGhBBO9/Hs+pVhPqLQhtwzCdC/w2v2YkAMrM4 tbX8+jOwM/fW1br8RkoekkxtX8WyT1qvKe5e4ETaeX2GgmYeiBg1KzfCi2Jy9AA1vWT2 WyPyBh4KnORHhy4hIUZY+BayXXxPEQWAZdH58zWbjFCO2fqL2L05hA76NF9v5LSk8bPN CTNfNDbYkkDGWYvJD8hAd9RDxTJoOzDZaS96EUTSaeWR5z1HtzqRL7o/HWJ0TZ67WVE4 AbotEItU6MZG8cm7vHXFWEC5J+scvO4Jo0TFHoGEt6cfbPQ8HicMsA6OXN+gWuI2OScT Lg+w== X-Gm-Message-State: AOJu0YyvAuv5iY+3JRW35UXjFVaA+XVZMQv6li6wTtxKgPuAwEdrTUq2 yrfRN61ZMEZPxuaFVHoyy1N1kaRihNrsGBLBopxLlkd5/KG5Hq86 X-Google-Smtp-Source: AGHT+IHqUACxW29ZUmHzFGFxIwCBk1AqgQMU+RNqcJK2yt5N1JiDTuV3H///Je5ormr2cnbs+tUE641xuN/eqewIFco= X-Received: by 2002:a2e:7312:0:b0:2cc:8c52:df91 with SMTP id o18-20020a2e7312000000b002cc8c52df91mr89716ljc.85.1704998291614; Thu, 11 Jan 2024 10:38:11 -0800 (PST) MIME-Version: 1.0 References: <20240111183321.19984-1-ryncsn@gmail.com> <20240111183321.19984-2-ryncsn@gmail.com> In-Reply-To: <20240111183321.19984-2-ryncsn@gmail.com> From: Kairui Song Date: Fri, 12 Jan 2024 02:37:54 +0800 Message-ID: Subject: Re: [PATCH v2 1/3] mm, lru_gen: batch update counters on againg To: linux-mm@kvack.org Cc: Andrew Morton , Yu Zhao , Chris Li , Matthew Wilcox , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 2F8AC140025 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: m75aifxx6fkeh6ebuqw59rnemw8e9qtp X-HE-Tag: 1704998293-333741 X-HE-Meta: U2FsdGVkX188cm38/Gq87QjLi1sG/3DfGCMqSiF1SCefHEvlDQjBD4rbZLZ0dvLBXRaAW//LS0+ZgWpb8hk4Sk8rgwQrE3z0CmU6DIioSKpmuO6dOP0iNrlUpqXA7asAQyCdpWYeYf5xtRbE/wfZ4ZKvG3MhO9ymtfjAS3641L+WqDg4Wq6s2IvYpEkj13uFdHroxlujsO08d7hZvQqM3gpO78lxFOs4ycGhpN+hbndtgCQKoALWvwJuEMqeM9ogzvGHqkRQgwJtMXJ2qNC5UpRTlEZR/J2WTDno2OVihsirNASwf3voHl3tTTU8b+8iy6Q/pLSNYBNVQ/koUWNVTiFGJ2AfwMFwonNWpY6agyeDTV9B9Wa+s76RiRWPiPbEjOG4bJ4siQbT/MzAMrx9XhKhgHXZD7SDk2yGiSqS2uwNkL/vhTcY5Hc5MT9H8VzOXKTWJTvJUzROAEZXo9hHuDvRK2ffwC7pgW5SJ1UISwI14QbM49aV06vozN5hXuOMuuJh76vwIt5wJZoyxwRmnInDz5yviq4krUrkTNYSP0m0JYL/mhZp0KZYN1sm5eBOXZN4c09YaLnHf9hYoPuAbqZo+mJI3cka2BtrZsYBhfGtbWO17HKowYhcfxxGPFAfLinTvDH+lhm02mhySzXeR05LwOr5anFTm8Q36dro1kG/QfxfLAg3LbRaqTp0lpOomm9k+Z+JfyKBBh6XMsHw4ksbA5sre0iTWWfnErQ/Nhz6qW8p1LgqtgQFKCDlWDprcAyjnJQQ/feQt1vDOpYYmmxbCcogksIgIB7EDpjjnjeDvsDise+wMCAEiQq9UAfxA75t4kFAjLMvCmXgf8/5YJSPy1Q9ZGYlM4UJjhgpMUqQgJkYpkw+tmaChMqS6B7Ml35f5nw6qNinvPH3bflN/JJwozQvQZKHfli9OvkEI5a2eOjPnCaDWakN91GhYjRQpjYVuj/XcOgTAmRQ9vV xxwenxwQ aVV3dI8meEJOtDHJK9pGuqhIcRPQMuWtSz8t58M9UpJ+zjVFcT0pBmM+zkrJor0VPv338Zq71IkZ18VXkTJqi466KVMAPGea/WILqJN1kVvotDn6DN+DbN3pQ1PExRfHfFOA4puTYJ8S3F5wZovyXu3Ycj8hX+uS535HdbzsgSbs8sKqTjLOh3SkSOlsr+CFMsfiD/UpemTlzk1WWTehoGfMh2klwsTOwdMG0z4IIyIX4aZ9nIWjtGqLyC6oSFy2aR/29MDoOgcwwQYqNsDAAXLitY0OVITQJdP5rFFwi0FhqW9SPe/FMbXNm8FuUYMWSipPfgFQXlyRAkGpmqBO/cMrcEvJLSxKejBWeSA+DLTgUfot49XsfrbHx0RCo3h/ZTDZEj1/vHXTc1wQKVIa+KyGSsETFY57kv55CW/cvS3gdJT8PN6+MMMyZWj5Kx8FQFf9yXNgDSd1nSz62u6BixqTIznJh1CTkdEr+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.231249, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Kairui Song =E4=BA=8E2024=E5=B9=B41=E6=9C=8812=E6=97=A5= =E5=91=A8=E4=BA=94 02:33=E5=86=99=E9=81=93=EF=BC=9A > > From: Kairui Song > > When lru_gen is aging, it will update mm counters page by page, > which causes a higher overhead if age happens frequently or there > are a lot of pages in one generation getting moved. > Optimize this by doing the counter update in batch. > > Although most __mod_*_state has its own caches the overhead > is still observable. > > Tested in a 4G memcg on a EPYC 7K62 with: > > memcached -u nobody -m 16384 -s /tmp/memcached.socket \ > -a 0766 -t 16 -B binary & > > memtier_benchmark -S /tmp/memcached.socket \ > -P memcache_binary -n allkeys \ > --key-minimum=3D1 --key-maximum=3D16000000 -d 1024 \ > --ratio=3D1:0 --key-pattern=3DP:P -c 2 -t 16 --pipeline 8 -x 6 > > Average result of 18 test runs: > > Before: 44017.78 Ops/sec > After: 44687.08 Ops/sec (+1.5%) > > Signed-off-by: Kairui Song > --- > mm/vmscan.c | 64 +++++++++++++++++++++++++++++++++++++++++++++-------- > 1 file changed, 55 insertions(+), 9 deletions(-) > My apology for being careless again here... the title here should be: mm, lru_gen: batch update counters on aging