From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDEADC021A0 for ; Sat, 15 Feb 2025 06:40:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6C5D66B0085; Sat, 15 Feb 2025 01:40:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 675F16B0088; Sat, 15 Feb 2025 01:40:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 564446B0089; Sat, 15 Feb 2025 01:40:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3DF3D6B0085 for ; Sat, 15 Feb 2025 01:40:56 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id ACB6F4AA7A for ; Sat, 15 Feb 2025 06:40:55 +0000 (UTC) X-FDA: 83121231270.25.FD0DEC0 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) by imf04.hostedemail.com (Postfix) with ESMTP id 3517640003 for ; Sat, 15 Feb 2025 06:40:52 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=eb15D7YY; spf=pass (imf04.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=ryncsn@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739601653; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8gWBi6Up6x11HbmT+6x2x0ByauKGWbJI59pwdHZK+CQ=; b=zgOnkKiVoH0hfnSAzy7PcVSNFaYUgANhCXGZ5SFSiBhr+2w9Xyrhs1if+uaHEs4Mmebd+J mKBlvinF1l2UDiIyoru8WTCa2wa1XiwLGl3JcWKcHKZ73dlbcziSaUDQ98aROI00opDFhb l5CCwfbGCeupyAxdz+zUtHc4bEeZaqY= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=eb15D7YY; spf=pass (imf04.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=ryncsn@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739601653; a=rsa-sha256; cv=none; b=qop3kG0226Mzp1ANpgK5e4jBr44AlZ62a6eWjdHgzMOZGcoZN8tLoa0voHqruC8SP7GnN+ 97GNE0KCkWreYJlLPmdHYCmDwW8eh0FGkPVSgYFFeuuFMfXuVkxSH5XeiB/qi7bNYyndBW +iBq8h1tausPV8fbsAUlUGd3GvEn3Wc= Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-308f141518cso29481991fa.2 for ; Fri, 14 Feb 2025 22:40:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739601651; x=1740206451; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8gWBi6Up6x11HbmT+6x2x0ByauKGWbJI59pwdHZK+CQ=; b=eb15D7YYo/dU7+oWI8NFepa11MjECYGN5R2GCZl/bAYE6Orbab3yx/Bb+n44wjz+7c XKGqzw9a3UAeCNfhJPCzio5P4SsCsC6A+jBFMDDcq3Y+iMFPzj10rfz/cUEvc+u7XjVS 4PFdaUMdoO6UePYyGOgC/OWZsiZjuCbCDNUAzkug9k9LNCch2bw2yEOTYpVlgPfcQ9e7 SieEoJBPxcHgCPXjV2N68a3C76LhiYjCaK5sGYzL0osD7t4UMNeOHRsymsPtIVM01OOj pGPM5BSuQEZ1BQd13iDXZJd5+U1GAsG1kWtjzfB9mSbGXzHQx7doAArGHYUyxq1NqOcV a/AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739601651; x=1740206451; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8gWBi6Up6x11HbmT+6x2x0ByauKGWbJI59pwdHZK+CQ=; b=unCq8+HXRuzkUGZ6bbuN1as1UG+0v1YRoSSaoxi/Bvsl3b5lkDOjT/YWpnLW5yg5uM KQAgUiTDy5eYpbuQVvWL0rK8tGpUTXznZGbJWqRYlULT3lfjBP5PXutIToJVu984lv/d 6cAPeglzq+3Vny/VzB9By8HCol1llVb04z3RAvUIVEGv0rtGCODzKxK2rTNKUwfNcmge IZFoPHW5fFK6q8/bAUhYJjGdsRK85K88VEXRMeHwH+0wfv2Xk3za6fY+G9bR6/g/NRdL ycnTA4A86HAmkT/pcacl0dDrPGkBrjTZVUKCXMeN0J+DkXsrn3IAytfMXgUzOyPcpUIu GH6A== X-Gm-Message-State: AOJu0YwgRFi0AKT+qRtq/dJPdZU2x5IpfLvgOB9YWTORsGcdZTcE9ygp 8fxdvTBXsFYL9Pis42lEgNjmJv/BjW4yweooVuPjB4mKWMiFLAGWommooYxiwgU2aa0t2RSK+7f 7bOGdlNYuOvaFBJUEAymvXeHrQI0= X-Gm-Gg: ASbGncvfrtNaC132y/Y9cbSTCY0H7tmXJHBn8kUNqQI494z3BKMh2XH51Jk6n1kTg3r r6lssbC0Ab9FeT6OUgd31tmGDFsNrpmuOOMhMx5jpLKjpqOxs/8XgXDVDi06K8mi8LiZo+Q5r X-Google-Smtp-Source: AGHT+IFIh2TfvlG1XjoarCicPaxFsb1M8Rn7NNRcEkYSI4lbCLi77OuXLc7EnDahiUIR+Ky4xpF9gHMN0Ve7crgXE74= X-Received: by 2002:a2e:97d1:0:b0:308:f75f:459 with SMTP id 38308e7fff4ca-30927ad674bmr7409061fa.26.1739601651075; Fri, 14 Feb 2025 22:40:51 -0800 (PST) MIME-Version: 1.0 References: <20250214175709.76029-1-ryncsn@gmail.com> <20250214175709.76029-8-ryncsn@gmail.com> In-Reply-To: From: Kairui Song Date: Sat, 15 Feb 2025 14:40:34 +0800 X-Gm-Features: AWEUYZmOBJ3hBox8YCWZIuZ9QNORd9bHkz-xbOw959EXpHWu4CoYewgEBVyrWyg Message-ID: Subject: Re: [PATCH 7/7] mm, swap: simplify folio swap allocation To: Matthew Wilcox Cc: linux-mm@kvack.org, Andrew Morton , Chris Li , Barry Song , Hugh Dickins , Yosry Ahmed , "Huang, Ying" , Baoquan He , Nhat Pham , Johannes Weiner , Kalesh Singh , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 3517640003 X-Stat-Signature: 34oa7jibcj3pfp17prmrmznob7a4s9e6 X-HE-Tag: 1739601652-842997 X-HE-Meta: U2FsdGVkX188JnK4xVoRKkoMvq3MLyHhnzZgxR2lsPrX+T641icZSnFADBvbFfxWJJUCY8eLhxHvyBNwtDF8YgjImNdfY83nPLx29K+olH5TggWRmwmlC8LMn8DwDHVNXeSZu2W6lamU0AmKN0FyYbirmBn/hX90mLzf0WOlqauW2v0QQxlXVm2ia5lPWWtjtF5kiaa5Ka+JmryvEL2Vlb+W2UD8YK+37f/Yslpc0k9eH5Ff7/cuFYCf9gVm/tCs/HvesIjyAOd2R5Pw+KRiZssxxnR/rwwQt6Bz0/kvy6OpARjYpn4kWH+S1tHxIg5tZ0dimZL0IdIFEOP4sHbYyafYf2UFR97kUmCO7vbZ5kFd0BwSP0U7qT64hNkFesuRAdb1RE36e0BlUi4bTG6HDaky83YOA+gPByXmcEtzwMbVZXbl6z5gpjD80F/7LGjByOs7XOOqIn7jaGs1ZBtl+HtTqLWY7tbY6S0qWr1pMWf3R6JpqROVIqbGmLdn7MdrPFEEICjGiR5OgZFGN2jUXLGaeFOLoKi0ThFP+blljchoAdfaONR7bShjgTmtfjd0m+Gi3wwmzV88FkhQgKT08+zHUfoRQ5NcQhuYGzU3x+VIFMiC+jqkk6PcvLstRM6YWFvDj/Ghgwm9uv28VrIZPjVrI3Jh1gcTGYCVaAOhfXOT6g+K+HtZw28SJSZuXiJBg5jrc8VUci2U8whjCR2cxfBYLbj3ZSCblIwUGQ8tzUgpzezHO8oy9FQcioa1nu8RfvBVj+4vRFiCiy6Gmawv5BPcnbMjG7/68L+aULtB0U2v0Ri9WEe65s0EmYTGOv/Sr+UEKYTEX91BVXPLthVaZqPBtY8WUNUf+qE7gm8r3bPuTqZT3iNv3N3EUlb8cpiuxRXt+X7sFgPWbf3w+g9xv+DYYEQHodu3s3aR1MtmiZSVF/aInioh3YuoceQTU7TzjFff9UTypqQ+9XKyAsv fK9Kwq9a mWVLECXNRMMxBJwozJGsl+cv3qNWeRfbHIcvaYMe7jMRURW8hJ6OWbj3RodhCdNAyUYqEP6LyCgQAmMT2oUr12apHcYALQzqbpDc8f7TFlJ71QssStxm2wNnpecmXLnpVoSJ3NN1LU8apRc90q1G4z4bYgeEVgk+rH0uU4m2Or89/VtU2RS4p6jbxp44YXpZyPYuWa9rlgEulBUIiq4TGaEr2mB44OK73a2E5IML/5V9Ej24IMVz/mj05MdWWig+6BN3aoZP/FiGk5P/hJZDyEW8q2I4QwLvfqAgQWsobj44Z+INJS9/C5uxHFQ+mjfoVkhJ57WBt58eCmyl2hUO1GEHedsNrpijlDPejN6/E4ALZVIPi/l8Se2nG/LDeGvYBXNG0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Feb 15, 2025 at 4:13=E2=80=AFAM Matthew Wilcox wrote: > > On Sat, Feb 15, 2025 at 01:57:09AM +0800, Kairui Song wrote: > > @@ -1648,20 +1639,20 @@ static int shmem_writepage(struct page *page, s= truct writeback_control *wbc) > > if (list_empty(&info->swaplist)) > > list_add(&info->swaplist, &shmem_swaplist); > > > > - if (add_to_swap_cache(folio, swap, > > - __GFP_HIGH | __GFP_NOMEMALLOC | __GFP_NOWARN, > > - NULL) =3D=3D 0) { > > + if (folio_alloc_swap(folio, __GFP_HIGH | __GFP_NOMEMALLOC | __GFP= _NOWARN)) { > > add_to_swap_cache() returns 0 on success or -errno. > > folio_alloc_swap returns true on success. > > That would seem to indicate you should change the polarity of this test? I think I already did? It was (add_to_swap_cache(...) =3D=3D 0), now it's (folio_alloc_swap(...)) > > Or should folio_alloc_swap() return an errno? Is there value in > distinguishing why we couldn't alloc swap (ENOMEM vs ENOSPC, perhaps?) > Good idea, return an error value might be more helpful in the future, will update this part.