From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02487C4345F for ; Thu, 2 May 2024 09:38:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 79C6F6B009E; Thu, 2 May 2024 05:38:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 74C8B6B00A3; Thu, 2 May 2024 05:38:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 613F86B00A5; Thu, 2 May 2024 05:38:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 47E336B00A3 for ; Thu, 2 May 2024 05:38:25 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id AB5181A0A67 for ; Thu, 2 May 2024 09:38:24 +0000 (UTC) X-FDA: 82072955328.29.009C78F Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by imf06.hostedemail.com (Postfix) with ESMTP id 0E5A418001A for ; Thu, 2 May 2024 09:38:22 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=e4keftBI; spf=pass (imf06.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.178 as permitted sender) smtp.mailfrom=ryncsn@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714642703; a=rsa-sha256; cv=none; b=gg4PF4GvmZ1QXMyv1azzQBj8R94lEufvegneXxuHZG6mWLYaGPbcvsljaF8DvfgS5TgGET E3l+KJlPqTJxGng7jFuVaZjxG9jbx+Ywf28QaQNyTGnhKAPHyuEX8YD/bexapJ6znYLEef sz81fQIjvRDXkXwlpMXBr/0X0G1zM2c= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=e4keftBI; spf=pass (imf06.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.178 as permitted sender) smtp.mailfrom=ryncsn@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714642703; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RT+IUJGXBO9C/LDd+jhtRqq7bxM9alVUycQ/IhZBCEE=; b=zLfRYNEn+oA79AodVAtX8HdmgCDM8wDECEQYc39ivufmkIvWhhv8MnysM5cZRuiINMLaU8 tOI77BYYrKRQzEAzKiz7SFO4B+fuGy2RPfA1oStHPRnxPF6CPl8eBQxHiBvelKjgdXyp/c W82Qf7oefoC5ooGDjQJL/dbgV4JG6xo= Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-2db101c11beso91464201fa.0 for ; Thu, 02 May 2024 02:38:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714642701; x=1715247501; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=RT+IUJGXBO9C/LDd+jhtRqq7bxM9alVUycQ/IhZBCEE=; b=e4keftBIrLLADE5ZMv6qRqCvdWNcs+C9PdrtLl9cBZnJ8i/UOE/tX9uOD9HjCMSAuC gVRzhHjjChfVJvYPsC6L4DtzJC9oeHpc4SQPr+HvHGBfigStr1lKaH+7GiksXKwHbqC/ N6mlHSuKzS4DZ5Wp2X2d5DxhJ/j5GQCcnokb/OG62x4ufn5+40jrDERAw2cZzgZx/zQ/ 6neBIkuH/NdYE9j3S6BtuNziDBNt6RQ/oeHaLjQNhpij/30RgAN9Nu/SxdrMCq+TW4Z6 EGajVRawm8O3jevy3QMO3LBU7dxHBsPvtxmdnS72/ML8wEtSZ+j76CC5hVU8R8/WwbI4 E6AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714642701; x=1715247501; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RT+IUJGXBO9C/LDd+jhtRqq7bxM9alVUycQ/IhZBCEE=; b=nOV/0embCJ2FLoSFtU4f2JLj/1XcK2T3B6+vvZncsLYbSpiRITf0v9baljwnr9E6YR DuUcGFJjq4RTBbUi/JEfND6bBSGL5UFUXYEbK2k3g5LfGEQMhxsAsCBIP5ABmT13HOWx SwpW8kq9w/Sfbt7IT+p5/6o/EBBK+gfmnAZU6JLulaeteB7k/gMhK9WYvB6RFT9STWDW kBfFpTV5NtMso9EtFYYG8+8X4QkSpb6U+5WltvpNLUfGHVPqKK5l5g9s8rA6CHIqYzVM 3RfeGPj78sIFYNwSMffRI/j/QpRlQi6H0x204THsdVy6zI4pDqVEcAA2Ma5oF1Xmm+au 4L1w== X-Gm-Message-State: AOJu0YxtzQOZZOub52CJvFWb4PJgJkff8ph9riQss0cYQdWtpqX8aZi7 6ACW2J2F0JHHdSL+7lrjLX0LBX4B7uD5SygQRKjUt+qEKQS9p+0vOl80qFd/JPkP8LlQ3M46Bv3 a9m4VMrxqZJ6IQdAg6RkDlE8e3WM= X-Google-Smtp-Source: AGHT+IG98lXtQ9cRetkzaEILNd/49VPwW0+KR5BV0I6pMw5yI7zsCaudKNFMJLInG5As2tNliEGpHB1I4xCkwHl9u7k= X-Received: by 2002:a05:651c:235:b0:2d8:59cb:89ef with SMTP id z21-20020a05651c023500b002d859cb89efmr2738989ljn.24.1714642701090; Thu, 02 May 2024 02:38:21 -0700 (PDT) MIME-Version: 1.0 References: <20240502084609.28376-1-ryncsn@gmail.com> <20240502084939.30250-4-ryncsn@gmail.com> <7636ada9-fdf0-4796-ab83-9ac60a213465@redhat.com> In-Reply-To: From: Kairui Song Date: Thu, 2 May 2024 17:38:04 +0800 Message-ID: Subject: Re: [PATCH v4 11/12] mm: drop page_index and convert folio_index to use folio To: David Hildenbrand Cc: linux-mm@kvack.org, Andrew Morton , "Huang, Ying" , Matthew Wilcox , Chris Li , Barry Song , Ryan Roberts , Neil Brown , Minchan Kim , Hugh Dickins , Yosry Ahmed , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: fgjyap5qy3tpkgbk4rsrsnnt7ugzaygc X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 0E5A418001A X-HE-Tag: 1714642702-494311 X-HE-Meta: U2FsdGVkX180rx84BdBlTQ5rWJ2HCbfvYOzONkd3qthuAes7luUeZEm8cZdw3eMORllWFFFQ20QekooovkmNxqdIM0qFRaCoMMkzTCq7R4MRRkMBmHsl/zSnE80KXGu4IBxa2dFabi21MkR5GrY2KCBEcFF4TMjo3zxdMcCABFpF1T+5n0wl193q/6JH6qGTtRGg/NZpjBn+4aslYgU5f65/5erLs8Kz3E0QVmpBsB5g27ph9atwFkspaiKLIz8gyi3VbtIDAbKB59ZOY/bmPnIDvXVuyMEV9IVXhwHl3mRub6m3YER/+IO5w7DTBQgBHVedLL68N2PQIciOZHTTFKiLxcNhUQcRaiurZoIMSyvG3BwsdJtEANrqQfuBDJGuIos+9/2/6ihVCBEvhdG1JdObiBZxtTzNf1PY1XufvFF7Bcv5XKd6IUgqvTgC+ApN70NfE8zCWbukSJ2jv7mhhqPeSKvueg5RksOtm6AxWhyzamAE7SlozVYUmhJUoFmHc2Oj9VRGScQW/Xz4OMQooXg6PbVC0YMjYkbtnXi5wWg2Q9A7/uctoBegl8BFOLg1Zd0guQ5GQC5CpTLvT+hVyRz3keApslhZK2LfmsUukuPCXNs0mNF+S5A1Hx+1AkhuXkG7cbRTu1x7ZPg4NmbyCJZYzaEbFSKFA6g2UXPIi8qTDgatRNRV/8N2ZspvIjNOEGqEXiss3ua+hzJcQJVDagKGyZOA0lCPxUBzZfQRzhKUeLyDe28fXOvDkhNks1ZRkxcwC/Qa+QAOAAXK1AfvH1DjHS9cKAXgCBjJjHDyfdd1uyuYU6cKbLhQyOKMp+cgU3Ye0p5lsWJYG3JWrGY4zl0HW+gVDIhL5MZHTpkiHgLD1NEvyDWdZtj9sdqQk6cj1dRRuCL7NhTUiI0FUUFYBapQLdmcT3UrhQJ/L7dA69DYKXaTaFu33dHPTcCr3CnIxKLv8Kljsw473xZZcTq pUmF6ZrJ nDLUbA86STOyt2UZlwyuIcd5wY8xjszEQICDpPi4YDeNTrr5vsp9e+oEPyrl0R8bY4TfCgPEnUan/7A+kspriRP5BGg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 2, 2024 at 5:32=E2=80=AFPM Kairui Song wrote= : > > On Thu, May 2, 2024 at 5:12=E2=80=AFPM David Hildenbrand wrote: > > > > On 02.05.24 10:49, Kairui Song wrote: > > > From: Kairui Song > > > > > > There are two helpers for retrieving the index within address space > > > for mixed usage of swap cache and page cache: > > > > > > - page_index > > > - folio_index (wrapper of page_index) > > > > > > This commit drops page_index, as we have eliminated all users, and > > > converts folio_index to use folio internally. > > > > The latter does not make sense. folio_index() already is using a folio > > internally. Maybe a leftover from reshuffling/reworking patches? > > Hi, David, > > folio_index calls swapcache_index, and swapcache_index is defined as: > > #define swapcache_index(folio) __page_file_index(&(folio)->page) > > Where it casts the folio to page first, then call __page_file_index, > __page_file_index is a function and works on pages. > > After this commit __page_file_index is converted to > __folio_swap_cache_index. This change is a bit of trivial but we get > rid of the internal page conversion. > > I can simplify the commit message, just say drop page_index to make > the code cleaner, if this is confusing. Ah, you are right folio_index is not a simple wrapper of page_index indeed, that sentence in the commit message doesn't make sense, so it should be deleted, my bad for this leftover.