From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3BDFCFA45D for ; Wed, 23 Oct 2024 17:57:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 22B626B0089; Wed, 23 Oct 2024 13:57:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B4DF6B008A; Wed, 23 Oct 2024 13:57:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 054E76B008C; Wed, 23 Oct 2024 13:57:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D75076B0089 for ; Wed, 23 Oct 2024 13:57:03 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D6C8540DD6 for ; Wed, 23 Oct 2024 17:56:53 +0000 (UTC) X-FDA: 82705622748.16.5BA03D1 Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) by imf28.hostedemail.com (Postfix) with ESMTP id 2B8E8C0010 for ; Wed, 23 Oct 2024 17:56:43 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=RrTuRog8; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.173 as permitted sender) smtp.mailfrom=ryncsn@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729706170; a=rsa-sha256; cv=none; b=AFMEhNvxhs7HP70y69GPsF/CUiw09a1pHUnNdgAwkIwk2PRAACt1sBNpTUSOUyDU+s1zQ/ imRicPVGaJ+9H7chwP/AIE/wnGwT75sfE2JlIjURTPmZUdDvGDaj26oYQ2jHWzPE+AjCJk 1fRkYsxmcwWrNbOfJ3T6bS5EEdpKNss= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=RrTuRog8; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.173 as permitted sender) smtp.mailfrom=ryncsn@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729706170; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hvB5xKaiaZK0YemghYyGAcxFhcYXko09rPH6v+w5h1s=; b=NC3HDmyK8kqetUm4Li+N9jM5F63vXslWfKMo7SqmpWzItVyTKwmpD/2cg0ST5UCVPB97Rq 1lubLJNIt8KbvzJOJUzFYcVJ4SUz/9TgoTRqjDgHkWaQ5ISDmlxHAY5CWpEf/j3Frc8svg phN6AtaRIxCRli9Oo/4VJBYeWBa8RbI= Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-2fb49510250so335071fa.0 for ; Wed, 23 Oct 2024 10:57:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729706220; x=1730311020; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hvB5xKaiaZK0YemghYyGAcxFhcYXko09rPH6v+w5h1s=; b=RrTuRog8P+Avnp2Ia77PAHOvqI9kBqzgpNnj4v0dmZ9F4bKYDMMvlUBHaLYy5fIOlr wRI4akfJEOEbfDdScd/afdNXDDqWDQytqft3TeAYJi6qzI6zYrlGGDJYqDi2Lz2Muzat J46py39s2Y6BIsIJ94a5B+x7mZsuHLvg7K0RQuDeELr542YxUx1VbKI+7D/szdBKGrPk aewmPbNuQvyPHUcwKbxt6T302/RrsFJv5n9vgIy9pz5ygB9is/QtWuV91ZW8QxXHKw0D oeUStJS+Kva/tHJfeQw91r/KsEuyZXjLMTxaEHRQuxadCnJl81Z2eJyVF43aB/54eW4h +ZUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729706220; x=1730311020; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hvB5xKaiaZK0YemghYyGAcxFhcYXko09rPH6v+w5h1s=; b=rxH8CzD7lGRdBnw72ti47lxgR+ENSjb3jnBD6y2V17Crkup37rMxzjmhfVf4VcBJ2j e9dt96f6i4178EHsigiUbOV3CFXMCXkOF1D9jBldVdn1TxqvJQGTGjHwCmahBMYIxyEo iw3oVKDeKAKp+2YzplgvxtzwoP3T3MBgqptFrANh+TX27mQEp4ZbkW2fx3Z00A1pCF+P AV5jKxq2onUva9iWz1EBOxlrZ/+HLzRzDTEFFdXO/fUEHuBefQiMwIcPjpjvZgMc+XwY KCAIi/Tzyx89ucjt0dlTC0NyiaTUBBUZFS/fj7Dr7VrRvYPRRbbvepXAyMpCnMwmyXXC YSUw== X-Gm-Message-State: AOJu0Yy/THvlVkqGI3TfFIve98IYGeoVWxy5jDbT9tGXv0uMNvXWKsSx eQiFbA8b/MSo1KcTswbVe1oLs87apSWUDVtQ5GLOVflPr4u88NLHyciBuRSda+QvNFXz330NDKr yFQIAXogayaZUoSnq9roY+STboIg= X-Google-Smtp-Source: AGHT+IEPIQrS+O8DzEln/5FzOgknpG2IVQ+T0FgY4EWyYaDTb7RwkuQQyvMOpcl3Gd3x0//o3WDcADUY3sx5M/NYENg= X-Received: by 2002:a2e:5119:0:b0:2fb:5014:f093 with SMTP id 38308e7fff4ca-2fc9d5f8580mr16440661fa.44.1729706219460; Wed, 23 Oct 2024 10:56:59 -0700 (PDT) MIME-Version: 1.0 References: <20241022192451.38138-1-ryncsn@gmail.com> <20241023032744.84a6a9f6f5f1e3aa1fe5f0d9@linux-foundation.org> In-Reply-To: <20241023032744.84a6a9f6f5f1e3aa1fe5f0d9@linux-foundation.org> From: Kairui Song Date: Thu, 24 Oct 2024 01:56:43 +0800 Message-ID: Subject: Re: [PATCH 00/13] mm, swap: rework of swap allocator locks To: Andrew Morton Cc: linux-mm@kvack.org, Chris Li , Barry Song , Ryan Roberts , Hugh Dickins , Yosry Ahmed , "Huang, Ying" , Tim Chen , Nhat Pham , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 2B8E8C0010 X-Rspamd-Server: rspam01 X-Stat-Signature: adcdq57dgycx59pwa4inmbhretqgehkf X-HE-Tag: 1729706203-130544 X-HE-Meta: U2FsdGVkX1/RNp4HMz3OMZ5U2RDLzGRYqGEnstN9b6pT/H1mex75DmVVrYyWgK3K7GUN4CKrfi6axysvdN7ZzFX1MN+aiahT+e5w9+I2/vK+O8Uuj/zO6LizMlT6VF6UST6gysBxHptR38WLAFiinwgbyUq2hGnbJC49IUQLqGCSsUwdgLtH64t2kM3we1vRX0amR9JofNbunsuF3X2623bL/pUS6QGk+3/RGVt/wpdgafcFWT5V1KhU3l4LAqPxuYhhOVC9uX9pagNzhptxHaZ/MfJDW1KJ4DGka8Icwk12h7EB7Q/RUshHC5Ygr+u8jHn0JgxZZXV86sRcgZa99cCL3syWHogpk+//AjYAq80fAz41HCHhroy0zj0wZl0HDFoV5PZLk+Lxs+GZbIdoiw1QTY55GgOHOWTfhpx4XF7ne6Q70AlkZMl5x+Dd/bnRXWzlF1OlwKa2JHzcTd0TYtJloEIKbkktDB14t/hIp7ig3VVRsk4dX5XzgkMErRh79ZQecbZWlTZU3rUnqI8Vg4mQjV1TB8rHpFWpVEvMCjhJbMr2doH7UKl8rdWMyhyT/t9Ol5DFZahrHpbCEE4GtS+DVbsrFwmFzQdo3FDWnJzfrVmcGHd5NGOqB9KKpKDioe5gbRudGlRWd4asKPblVmgHRE7/AF7BFElNIw4Y6DjmxWP/aXu2V/ciB0/OdmpckqdWt8EP+S/zDRMUixdlsbqH1I1JOeVNmvwf0xb59IvSnLtXKTov79kthxP9VL0lvtPBYxA/SVrVfP25Hva858F/1jOMZR7KZqbA1KFq6x0gJGDZew0+swTXWgBWjgk4RsjYAkwunbenHET4u1w5s7LEN3pkBxefiCvXVDXHxYURXJQwukAX76+2jqrrCDkxQWfnLTS78O7bfYII9F3rhrx0hgbcKQ4M5T8W0zD6uZyW02SUKr5sa6DaNuukPO7tySIzTn/CExlfcEcXa+l Bj4AZC/k gYlNCT20wcbCW/aAHBN808GkUseyMw0IKzp4b4gTEypTrRaHxO8D8hUxej0/xs55OLzYTqUK66LswpO5SIRHvp6BO8iuKPMjxYPkF19u14DobnJkxpbI63vMtSBdmumBNZpJeGOCDnstXyxWDSPMER7hgMNjWtSx9WHrQNskhL9HgTMufd4Cd0OhahZtMZgKdP33FFpiRAYjQU22NM7vDqWHALJr0UexbN6BcQiU/+TmcSqD06SonKCqOsp8xPXPpi9Ni0pMqE2CCeqEQwrhkMtQN1rj/sPNcTAYGzO6GVSqGsDnF/pkc5k8EtaRedbzDHdCB76BywUGTQiN92BuqqRKMgZMAMthPEEBDtrIBiexmRwA2AFCNWSNy8AteoFViI+0U5bdNWHy4uD17vExN+cq85A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000066, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 23, 2024 at 6:27=E2=80=AFPM Andrew Morton wrote: > > On Wed, 23 Oct 2024 03:24:38 +0800 Kairui Song wrote: > > > After this series, lock contention on si->lock is nearly unobservable > > with `perf lock` with the same test above : > > > > contended total wait max wait avg wait type calle= r > > ... snip ... > > 91 204.62 us 4.51 us 2.25 us spinlock clust= er_move+0x2e > > ... snip ... > > 47 125.62 us 4.47 us 2.67 us spinlock clust= er_move+0x2e > > ... snip ... > > 23 63.15 us 3.95 us 2.74 us spinlock clust= er_move+0x2e > > ... snip ... > > 17 41.26 us 4.58 us 2.43 us spinlock clust= er_isolate_lock+0x1d > > ... snip ... > > Were any overall runtime benefits observed? Yes, see the "Tests" results in the cover letter (summary: up to 50% build time saved for build linux kernel test when under pressure, with either mTHP or 4K pages): time make -j96 / 768M memcg, 4K pages, 10G ZRAM, on Intel 8255C * 2 in VM: (avg of 4 test run) Before: Sys time: 73578.30, Real time: 864.05 After: (-54.7% sys time, -49.3% real time) Sys time: 33314.76, Real time: 437.67 time make -j96 / 1152M memcg, 64K mTHP, 10G ZRAM, on Intel 8255C * 2 in VM: (avg of 4 test run) Before: Sys time: 74044.85, Real time: 846.51 After: (-51.4% sys time, -47.7% real time, -63.2% mTHP failure) Sys time: 35958.87, Real time: 442.69 Tests on the host bare metal showed similar results. There are some other test results I didn't include in the cover letter for V1 yet and I'm still testing more scenarios, eg. mysql test in 1G memcg and with 96 workers and ZRAM swap: before: transactions: 755630 (6292.11 per sec.) queries: 12090080 (100673.69 per sec.) after: transactions: 1077156 (8972.73 per sec.) queries: 17234496 (143563.65 per sec.) ~30% faster. Also the mTHP swap allocation success rate is higher, I can highlight these changes in V2.