From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 422A5C02196 for ; Thu, 6 Feb 2025 07:51:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B2730280002; Thu, 6 Feb 2025 02:51:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AD6C76B0089; Thu, 6 Feb 2025 02:51:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 99E32280002; Thu, 6 Feb 2025 02:51:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7BD6C6B0088 for ; Thu, 6 Feb 2025 02:51:08 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 361DAC015F for ; Thu, 6 Feb 2025 07:51:08 +0000 (UTC) X-FDA: 83088749016.13.CE84F4F Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) by imf12.hostedemail.com (Postfix) with ESMTP id 440FC40003 for ; Thu, 6 Feb 2025 07:51:06 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=K0lvxD64; spf=pass (imf12.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.179 as permitted sender) smtp.mailfrom=ryncsn@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738828266; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UbmCZKRSiLI6l3P9JfBcjTwvUE/+hcNOQv63Wg9I3aI=; b=mScD7bCWuqyTeZmG/8VJnfEvy/Bu1CsNzYY0JANAzQqvg4E+Sxc57+xiKMXaN7i86cceY9 /hbBx0XohiMrNwsrFOTmgfFQlH8z8JfOJIZc/yQSD+XyxB+8MopoYrcfUj2aWIT+7hz6Ib 6HqgU7p+Em7Rwsif32zFX1zsq7f1L6g= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=K0lvxD64; spf=pass (imf12.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.179 as permitted sender) smtp.mailfrom=ryncsn@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738828266; a=rsa-sha256; cv=none; b=nGdWbcDSEak8FgOLukOsSunWT9gmyiAXqRecfpMd7FJW3Ru7WfVFwoKfSp5CPa0++leM40 oVLZl/GejRb+J0m0368MCdpoaG1CBwKqNN2MPzYlxewZIbGeTEfJr8/HXc4DCKcU5UVEtr 8tvIjmOrNHFeFnkDtMnx/MG8WMSPi/w= Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-30229d5b229so5300201fa.0 for ; Wed, 05 Feb 2025 23:51:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738828264; x=1739433064; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UbmCZKRSiLI6l3P9JfBcjTwvUE/+hcNOQv63Wg9I3aI=; b=K0lvxD642Nef3FRwmFYpEXD0fOfjS8OMBblV9ulP4XeOfk7j/kfamtiE2WUFTv00Q7 hOBGSUaziRoIgv4uAn4OqXgo0DyoOrZoKgDeu2v9AE+zh0xkGqHGGv1SxS3uKkbTbc8S 1pQ4363g98gZmlsGOuujaBW+KNw+UZf8WluDDk/NCUCo4QbY5pIYtwpbJ751jkNKTy5p ycYvACM+BEuV6KgMrIruG1xFcnwfXwe9js/+abKwKfNAdXXCjYPT/Ut68rDkL9uCPW3y flExM0wmVbRWDi9ydpwq/M63krZ+1thbtjx+F04XGMFhb7haUH3zWJ2KZ6dgdsF2MKqi o5rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738828264; x=1739433064; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UbmCZKRSiLI6l3P9JfBcjTwvUE/+hcNOQv63Wg9I3aI=; b=ao5Hxq+m0tx6bbclNj4p7CJGOGHL1+OfWpA+20653fFhMGSjQPYIG8E6pi5BzAqDPQ LA6TiVrUK4KqzqI3VK/oh7etgzbMl7M/rqyIUrQpcs0+7OcDZocPnx1AvQWjjZCALzU+ usXrT4Tz6rc0dGE+aTiOE+nGFFftiGY8mUbPD132bW9OQllwh6V6ALK3df6NHH8mjJMn yh1zhmpm+670gNnCzU2PEGdvO341hsI+jDt0JvSVS7/3K4T6B1Zp/murZIDXeNvLfMZp 2Y9mu8Z3cXFTjesxxUnaRsZH1eA58Ddm3jWsg0oR8d12enUHc3eFxjcfZ8uRUmxs7NO/ iZ+g== X-Forwarded-Encrypted: i=1; AJvYcCXCOwj8OUtewjK4iH88zKmnKJtvd2l1IrZrSL2H/S/4OWCQg6IIz3u3RFOWlGf+JJXCN0fvU3Tdzg==@kvack.org X-Gm-Message-State: AOJu0YzUQM8A2d56O8xTqfxMOelc4Tt8jKyPw5FCGy6jncT0Xx1YzRGg /PY6nfivYAGdFu+OEH22bf7X4PKfmciu+CbuC4/bWJVxvJZepHBECrKEAdSGbKAy/P4ptN3JtaF y34dDb9K3djN0gOIU8tnEnGeBFf43HWYelvs= X-Gm-Gg: ASbGncuMceEJf0mvzFdf5XcoDQ4avj95McY9BHi+pQyD/nhSRa+5vafnMvoHpYiLsI7 14kTClayj4qVHgQWdlRIuWKvV7pQnADSWc8cvuaDBjdztRnENBL0xssRAAVfoW5Ju5LyUeIHX X-Google-Smtp-Source: AGHT+IEpvYaRte2GJP3+ZanGdx5RE8IQ00usPn05fL5mq8ThV2pN+0Ia++3o5CLsNRsdFex3UY9rF+RMm5ny1I+nRo4= X-Received: by 2002:a2e:be25:0:b0:300:3a15:8f2a with SMTP id 38308e7fff4ca-307cf2ec982mr19791091fa.2.1738828264169; Wed, 05 Feb 2025 23:51:04 -0800 (PST) MIME-Version: 1.0 References: <20250205092721.9395-1-bhe@redhat.com> <20250205092721.9395-7-bhe@redhat.com> In-Reply-To: <20250205092721.9395-7-bhe@redhat.com> From: Kairui Song Date: Thu, 6 Feb 2025 15:50:47 +0800 X-Gm-Features: AWEUYZm9KbHQR4N8gOZV3zd4F_QyXlog4Jje4nmt8HJtC5d4hFTL0ROjsVAp7Rw Message-ID: Subject: Re: [PATCH 06/12] mm/swapfile.c: update the code comment above swap_count_continued() To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, chrisl@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 440FC40003 X-Stat-Signature: 5m6cg3an1695bt9k3z3gh5a5zrbxqb89 X-HE-Tag: 1738828266-787674 X-HE-Meta: U2FsdGVkX18rU63iGGbHf04BoJMzfCNI8kHAnLs0FEPNHQkHI1om2Zm5FevFVWFVyJuIDu9G5zC5PvKHxANYf7ZCb0P026Ym+sjfiWl8y2xRbn6ytFduCdWXtp+7QSK9XufpovNP4Pr8srAPHrDQj2sbU8ryRPzUokURW7s8xVbjYeWTyy8hspKC8CpLsWr7DUyy7I16NpQzEK5NRWbve0yrJhg/XCFX6gqQWcSewUIXmDfjUUJNYk4g0s+309Q7W3bszzgqYWZXOfVejDvXmAjLs5ihE96UMxPuTiMh2hoMZ9kGyxza1DREnkTsqX6SxMrrQSXNPB4p7CkoVTtShbEk47YMXJe2BDfbUgfVWz+eRjm6csU1UvJeen9MRfjhbBVeVgtjXr86AtK/aQqR7JFqVvSjiwkTy0esrTxnMICOFM8GS82aZ8j1W9fob2zMgjSQbeNjbe3k7T4w16T6rYxF+72+UzsKMbF5JAOSW0ojfU732f5EzX7ZCXwnI8l6v+k0WEBywRo7OpgJF1zvdAF8RAW7GI3wg725r2+30VCNbLkVohLvqr8eTWBlJNqSky7judJJWTNPT1d/u4mizo3z+7yOhXhqhbeAZB+UT3oGALH0Cxh+uyOQcinVanTlF0g5bQKvyOsReQPAudNYI3UZOA8Vz3MEHBHSmF9IE4Yb8zC9symxY2FJHBRER67TUR1n29BDsbRvlodRW7iNpSa98whv5o8RjZBYvxCZTWQrpDI1gAgXfDoO/wGBEuX2FTDksTmb0Kxtn9Uoi5bSWjDXYdrp4yZY0Pl7HEPylOyTPXkIZKOF04G7ysAL9kuxXH0wHh1kSqJKzx/d6PI/leENSt5y3XbgwiGo1O5Z+M75MR0MonItP+iJ0RE8RWIVSRGXill8miu4AYGRrIz/0grKpAh9bN4VChgLJxdXggP5u5YmQLKOPgUpVQJ142GnhtkSFld0HUzHBVqGk4a dqlSe0nC V1CXxOVU9LOr6LedJPpbtRRIvxf3fFuIrJcb7vxmqMn3PnYk8S6UVhogxIb9C2Rh5Q0vWjrZveMmjk8YriThkJPUxi+wQxJrw864o2u2zHwtpH8lrWCVEiGQQIgQjwE6jtAvdrTIFBMevF036hT1MiWibSKPczHXNlkRqFnQ6MlKDPAPIxzwlEcoiM3T7gJuIE3IO99CjMo2wivm8VOpj2lnUglrZxzjQzv/TtBEWX318HmXvBnPAl28M9aKOklmw6JGD3PnwDbsscMCoI/ZXxwISTvAseWmrIBcOx6qJTNDvPtizwfOdhfwEJU1wIp4N8pujRGh/smNLNHLVD2XorHENQBxu0LrRT6C5fP90nxiTMG+m04bL/HuhPsq1UgelQrIc X-Bogosity: Ham, tests=bogofilter, spamicity=0.018457, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 5, 2025 at 5:28=E2=80=AFPM Baoquan He wrote: > > Now, swap_count_continued() has two callers, __swap_duplicate() and > __swap_entry_free_locked(), the relevant code comment is stale. > Update it to reflect the current situation. > > Signed-off-by: Baoquan He > --- > mm/swapfile.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/swapfile.c b/mm/swapfile.c > index bf284ba16198..9ee2238042a5 100644 > --- a/mm/swapfile.c > +++ b/mm/swapfile.c > @@ -3789,8 +3789,8 @@ int add_swap_count_continuation(swp_entry_t entry, = gfp_t gfp_mask) > * into, carry if so, or else fail until a new continuation page is allo= cated; > * when the original swap_map count is decremented from 0 with continuat= ion, > * borrow from the continuation and report whether it still holds more. > - * Called while __swap_duplicate() or swap_entry_free() holds swap or cl= uster > - * lock. > + * Called while __swap_duplicate() or caller of __swap_entry_free_locked= () > + * holds swap or cluster lock. It should be only "cluster lock" not "swap or cluster lock" now? > */ > static bool swap_count_continued(struct swap_info_struct *si, > pgoff_t offset, unsigned char count) > -- > 2.41.0 >