From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 981D2C369D1 for ; Mon, 28 Apr 2025 02:14:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C62E66B0005; Sun, 27 Apr 2025 22:14:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C11CC6B0006; Sun, 27 Apr 2025 22:14:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B00056B0007; Sun, 27 Apr 2025 22:14:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9304E6B0005 for ; Sun, 27 Apr 2025 22:14:24 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 04D1680D18 for ; Mon, 28 Apr 2025 02:14:24 +0000 (UTC) X-FDA: 83381833290.26.B0EC76A Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) by imf25.hostedemail.com (Postfix) with ESMTP id 1DA51A0004 for ; Mon, 28 Apr 2025 02:14:22 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="FEYc9IN/"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.173 as permitted sender) smtp.mailfrom=ryncsn@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745806463; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6L7mReCEPPU3SVcDk4HNDfLPe55YhTxKj7HSojarmXE=; b=c8dB9wkGt0QYj4LA7F13ZVSWZScBvQJEezFvSzfTvWIr0w2lPpTsEqBQ8cmnqn7HmaDg4a NRR7sVffPw+dymtOLrOopgSQr4+ifSFLLWaHHjwQ90r+DirJEwJmZtrUVjnCm6Lx1nR9Ny BS/JH8M9FsxkGo6LdmnZFEhFC90mniY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745806463; a=rsa-sha256; cv=none; b=3ukVMBfbvevZTfDp5nwL7KTJIhppSVP1VwLR9YP7l1dLl9XhDJ9L+iRgUwLDXYXUpJrmp5 0O41EK8QjCfm9mZK0G1TD+pMq4P6A6xP67lyhFe2/1RooK0kq4kXxVqzGWNGjs1GgF6a1O qnGwXrc+kriCnoUSr7Ts8YFTaNWYuec= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="FEYc9IN/"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.173 as permitted sender) smtp.mailfrom=ryncsn@gmail.com Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-3104ddb8051so48711881fa.1 for ; Sun, 27 Apr 2025 19:14:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745806461; x=1746411261; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=6L7mReCEPPU3SVcDk4HNDfLPe55YhTxKj7HSojarmXE=; b=FEYc9IN/BowNYp9RBRcZe0mnbocewpETEEEKxB593qQz7Q1PSSqJUqot9zMN+wZHx4 vjp0V18lGvR73gNsyGPzb9kvO3SSReWUwUs+94hSGNm1GHAOLjk2/6yKSzo6TjWpB6AW 6Lz1YU/WgNiFpUs0TP+Wg1z+/bilUZpRXhHjDoaoXsWg8MLfw/5j2ojzzUIUIoargQEv iyfCgHQg4jHXYxB2BY361k31U+F6T3+4Lg9+cic4sVe7xGdHWfELdwYQ5Yfh1xD6G4C9 0mZxjUW/AexdA6PkStddUAglXSSub0xEPHraFGrRGYIEaqPhVUZ3ppFBVXS+icGCdnyR QSkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745806461; x=1746411261; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6L7mReCEPPU3SVcDk4HNDfLPe55YhTxKj7HSojarmXE=; b=TAZzq7Z1gBz8rBGJAMkKpXH3ZUYXbRCrn2gHF40duKNLgUtLMrBzVbZvt87YZU9iRI RDcnTEMkpYb21qzND2crBjXxHhJSOGcBVYN3RRU3LnPAlhaoGYvCOg6lXVS9anq911OV VQQ/JOGhEY39tSfKbPztne0gPe6QgvDjzYA43b83lqu5i3Hl7oYxC9oK9SCJY0m4vdOr lxIEE9b+nP0R42kC5qo4QHdUTGevIcbpnjER/wprJLYVyCSnXNWTsmD/dETLMGqV/Hre /WVF6hkVKwaMZzlOioo/riN8KZ3JZmllF6i2qrhheos5vteB+b4WpCkv6B+1sliht6Bz LFQg== X-Gm-Message-State: AOJu0YwgnX05VF7LI5tR9YJarwLvX0juv6t+EA802mpop4qHi5Y3SGRL 7o4dwU6VGwwHHu0UeMEIsEJQZqN83a+TNTCcnrHkCLlNm3fE5ex42tOEsiutjbHbkJm+d21XWH5 t1k4sAYV7cIv64mkn5EJ+uwUQneM= X-Gm-Gg: ASbGnct6V2ImopyMfibNB7981dk+MhxWoqVJFWzRalKM3fa8vrL9TYc1Im05UWte20P ruSFy5Bwb/MgdNFvKfVU832yWbeSzPmvZBNIuNjWFQ5xqxV6H/9Tuf/7HNNPrCyRNBRpJ7g5Xo8 sXhvGXb8gw3eDdAuFzFLKXaw== X-Google-Smtp-Source: AGHT+IFqG9IvL4DdVin/erLTT+mbKNl7H+n8o92o8qsmXMKCS3wOobNfOjdFUutakNI3AHxLZMz1lW/P8kipZLZf9Qg= X-Received: by 2002:a05:651c:1465:b0:30b:d05a:c103 with SMTP id 38308e7fff4ca-31907be7ee1mr36751781fa.29.1745806460856; Sun, 27 Apr 2025 19:14:20 -0700 (PDT) MIME-Version: 1.0 References: <20250427185908.90450-1-ryncsn@gmail.com> <20250427185908.90450-3-ryncsn@gmail.com> <30968c68-7ec2-4185-9b48-f8335dc2e0b0@gmx.com> In-Reply-To: <30968c68-7ec2-4185-9b48-f8335dc2e0b0@gmx.com> From: Kairui Song Date: Mon, 28 Apr 2025 10:14:03 +0800 X-Gm-Features: ATxdqUE43AwjPoI39IyPOxqKFyZI2qqvwM-fZ2nBNpIE4zuv8EfJ6_f8pPBi_4M Message-ID: Subject: Re: [PATCH 2/6] btrfs: drop usage of folio_index To: Qu Wenruo Cc: linux-mm@kvack.org, Andrew Morton , Matthew Wilcox , David Hildenbrand , Hugh Dickins , Chris Li , Yosry Ahmed , "Huang, Ying" , Nhat Pham , Johannes Weiner , linux-kernel@vger.kernel.org, Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 1DA51A0004 X-Rspam-User: X-Stat-Signature: bxjp9ggju3oca3rwakmhork8xgf48mn8 X-HE-Tag: 1745806462-67076 X-HE-Meta: U2FsdGVkX19ohTwFCKYz8ClZj2OzVGTTc63X0Qe8NUoj1xN+Y2WIUopVn0Y/r7feoFeorWaa6wJpJNq2RcsOr4pvYPMGDkZ+DLpbDZd9YIykIHmRxZ8WPib8lYrGFX5Yzome38sz4QEqXSeQpyFjMjZ0IZYkykccy2M8uhuik+oHOPDiWjvZayyLyXh6MddePuDzsEJh5rvNrF3BtMx+Iw1zqchEnkM6WKuHkvq2tQElc8XsTlQ6c54Ita0iVgfrD5GSjpKY/t81eEKHNlra6WyeAq4hryerzu88jTyhJjd192x6XOjidicleOEv4dePe6p5MUS21SlFHB5LxjHj2J9FfGfZ2m1DHI1bSOEJogaj48vsDv7ww5nPyzEeRoiH6ndymCcUnxY4by3RQf71CAzVle836XeCHCnUTnAi939ASf4uSNMD0EdezLdM/4DmCOvarrgRJ1GrGfq5OTyhchexVPszfK27Tky2PxR2tJ7ew3GeZR02jm2sTl36E7smdB9OsuqmQ/d60bQTnCGzXUOgj2zw2QIDRECQy1xEr4B5yPCBuo9Fw7yACI6O053pZxPDTMXrbmYsQSS8UfnbYqkGbwuOTqZV03gG0jteZQ/D6HZ5Whm6SUF7g1WP0l2bESv59VVoYUL+4Q9NkXh+cMUrQWImpWCTqGtwb5uF/Ire/d05zDFMA2WghY+1Iy76Jzk/u9jbtQBvQoM9qAoOYFMrDPgWKKMuOzIhPugmxMMnOvxSLI8xnWUD1oeDeJeqL4zO2QWpo/zOFQzVIAhfpDjig6dA01G/CDgyqH9eNhMGd8fIriDDbjgYWMiURR0f2s/3p1DiuNqUkH5ACLtMTBJGz0co9SpKaNSfxWfvgrKJyv9BD2tT5L24nNGWoSvaSe530j5zWDY3bKkRSFzqslUg9RT+S9c69iARikU68cM0/iiKJg/JaQm8T7qSFOJGs8s+bCqdGb1R29Nx8PT Sn0joPoO N76a18g+nPXllbPVOLErYUVU4PlCK4p24vE+nIRMxYHmZaPTNv7p0Jaj+fBVfiKmAM+ck/NxsjC+Of+VI4ywF8r0hxRzLN3bJpjKM1S3MqBvVFR2uXbLPVbcWui/xfEUTQPiIK4ARcMd9Q0XXIwZicx2tAe2/7HIwPlbDfJLE60xLsLmdQ53AfdJt+jwNMKYa16t6muJscx1v54aRPDe1JXgkGHGIAWJHOIHLxi5tUT411nuF0qsPsU4IbvU98OV1tdSTLUArAfN2rHvQnbFSXxkmkGn1PeaQ/ebRmscsnLCbZcHqf6cECssZweQw1sbnCt11UUIbfWApvdwHH0Ah2JhrHnBbjCLEB6cExqfmLlB5BmLO3otYMc49v4qk00NnxagIE6uQbHaHnW/3zNdkdIpfX5Wz7Jxuse4zwXMHssnI16gJoMmR2PRDy9Y+QiwNWiiL1hTG7sLPMfCc6UXPODDFhdderWAi28Lyvv2FWbyjTesg9x4BJ3rg0FslHKX1E/BsUZmkUfGxo0jluOb7rz9ggQQU0wGw/XrztrF5Sn56huFyd4ww9yssAtfq8Y/zOLcvn1nWlT1vNjlh4PgkhqPWN0GBGqwpy3GEphaZ4HdIrPg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 28, 2025 at 8:55=E2=80=AFAM Qu Wenruo = wrote: > > > > =E5=9C=A8 2025/4/28 04:29, Kairui Song =E5=86=99=E9=81=93: > > From: Kairui Song > > > > folio_index is only needed for mixed usage of page cache and swap > > cache, for pure page cache usage, the caller can just use > > folio->index instead. > > The patch looks good to me, but I'm afraid the next commit message is > not accurate. > > > > > It can't be a swap cache folio here. Swap mapping may only call into f= s > > through `swap_rw` and that is not supported for btrfs. So just drop it > > and use folio->index instead. > Thanks for the review. > Btrfs supports swap file, it's just not through the swap_rw() callback. Right, I just meant btrfs is not using `swap_rw`. Of course it supports swap files. Let me update the commit message a bit to clarify that. > > In this particular case, the folio belongs to the metadata (btree) > inode, thus it will never be swap cache folio. > > With that changed, it looks good to me. > > Reviewed-by: Qu Wenruo > > Thanks, > Qu > > > > > Signed-off-by: Kairui Song > > Cc: Chris Mason (maintainer:BTRFS FILE SYSTEM) > > Cc: Josef Bacik (maintainer:BTRFS FILE SYSTEM) > > Cc: David Sterba (maintainer:BTRFS FILE SYSTEM) > > Cc: linux-btrfs@vger.kernel.org (open list:BTRFS FILE SYSTEM) > > Signed-off-by: Kairui Song > > --- > > fs/btrfs/extent_io.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c > > index 197f5e51c474..e08b50504d13 100644 > > --- a/fs/btrfs/extent_io.c > > +++ b/fs/btrfs/extent_io.c > > @@ -3509,7 +3509,7 @@ static void btree_clear_folio_dirty_tag(struct fo= lio *folio) > > xa_lock_irq(&folio->mapping->i_pages); > > if (!folio_test_dirty(folio)) > > __xa_clear_mark(&folio->mapping->i_pages, > > - folio_index(folio), PAGECACHE_TAG_DIRTY); > > + folio->index, PAGECACHE_TAG_DIRTY); > > xa_unlock_irq(&folio->mapping->i_pages); > > } > > > >