From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F17AEC3DA6E for ; Mon, 25 Dec 2023 07:02:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 846C26B0083; Mon, 25 Dec 2023 02:02:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 800FC6B0085; Mon, 25 Dec 2023 02:02:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 696586B0087; Mon, 25 Dec 2023 02:02:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5272B6B0083 for ; Mon, 25 Dec 2023 02:02:19 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1CAE112014B for ; Mon, 25 Dec 2023 07:02:19 +0000 (UTC) X-FDA: 81604446798.26.167FDD9 Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) by imf21.hostedemail.com (Postfix) with ESMTP id 707161C0009 for ; Mon, 25 Dec 2023 07:02:17 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=OaJus6xU; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.170 as permitted sender) smtp.mailfrom=ryncsn@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703487737; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DZUnhHuaOo0JGLLaQ+h3vJJc1TC7Ws8y4G2gxGHbkKc=; b=kyTyWjgEw5zMwHx6l/pOsn6R8CqAmRd4Ra0tTxdXiE5XUAd2aBmiSNUyPh406DSwoD1Tdw Y7NeeVKq4iLEe1tQo/bixGF/eRF2a3LFgvtCt3wRUPDZU+Y3WNW6wtNaQ18TH/hNozSUnR X1ViyzNAqGZHXWhxWtgF4eoiqEgFLKY= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=OaJus6xU; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.170 as permitted sender) smtp.mailfrom=ryncsn@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703487737; a=rsa-sha256; cv=none; b=GpknZYO4wBVxbc0QtsNxaE+aYjvXn11APh8vWPjqkC6GPVReNHtQ5HMYkmpr7k34Hb/RKS ydujdv8YdeWvdiEN5ytVw0U9LcGAQmUPh0b6wAJtlwZHXZ/m36h3BvprMWC2J2aJc6u8RK rvODx+SjHRn7RQ0Hn6J3BtDrySVamco= Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-2ccaf5955aeso18062421fa.0 for ; Sun, 24 Dec 2023 23:02:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703487735; x=1704092535; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=DZUnhHuaOo0JGLLaQ+h3vJJc1TC7Ws8y4G2gxGHbkKc=; b=OaJus6xUEGEYpZgry028mfvHAlIfmuA4sdM9Luf4QZ9AL6NacJIWQJOj3TMVM0EIcq 1Tr1e4zVgScUJ6skqpJBEoGMbWdXbAJKIo8xakuLvMptqGEK7kykmrXktt2bbfu4PMLg QIF+zlTBKM9IO1NAO71odMgJMLMTDg/KLivvAjG66gcNI4JC5WjEWPH6Ug4TplwcbGio zDG4D8QFvqQdf6ocTOGf6E7vzSKYvRzvRIkN3UP8hs63ogZEfXu3qjpc++7fuPlXp36u RfkIbkJz83aqpfyneDdKa3/IAx/iqBqgBLhucp3Msoi30liI1LGKzujp97MiKaouFtgP 8kEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703487735; x=1704092535; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DZUnhHuaOo0JGLLaQ+h3vJJc1TC7Ws8y4G2gxGHbkKc=; b=m993NpcEp2F2y+Ic9RElWCnaFOUMUXRtGNoilDfukDQwili3FrOY3xpkFpeCQcqZri iuyqABYJQQN1SUxl0htaeugLr+jucdKr2VxXtiEii1xPKGHK7Cr9otagQ/etgd4AILoi 0JZpnxm5nER0BIP3aBKzK0TUDrWBUPtJfSRJrsxwqe0uWwioQsrgBmrCrzDU8An62oFN jOIlWfCYXXKA5hbs/4Vk1InXLpvQpsItbrd4ijRKEjJcFspQ01dtMKu1i8Qc/C5cbIui lhlh07Iv1Qa34GAzFs8uG4k7wo6kL4Kvi4I64L4qHf1cwAxzaBt4TRsc3KdnHHPB61rF uBEA== X-Gm-Message-State: AOJu0YzrYWNATCtOjNFn6K+Ihl6QWFvIT49dLa8Qg8hWNwnoL6+IObOQ E8jhaDrlCfT+xe370eRyfAthmKShhwKs9GxsAUk= X-Google-Smtp-Source: AGHT+IG0YTzceKLqiZZo43S76ZhfHngJL8Qyc+pA0ueaBmTIw3Si5AGxlQq+s/168KI8FIkvgEXAiWCAYwoG+zEOOdI= X-Received: by 2002:a2e:9d16:0:b0:2cc:9817:6388 with SMTP id t22-20020a2e9d16000000b002cc98176388mr1732880lji.64.1703487735136; Sun, 24 Dec 2023 23:02:15 -0800 (PST) MIME-Version: 1.0 References: <20231222102255.56993-1-ryncsn@gmail.com> <20231222102255.56993-3-ryncsn@gmail.com> In-Reply-To: From: Kairui Song Date: Mon, 25 Dec 2023 15:01:57 +0800 Message-ID: Subject: Re: [PATCH 2/3] mm, lru_gen: move pages in bulk when aging To: Yu Zhao Cc: linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: 17ryasz63ghf8rg3sg4ow1z74u713yj7 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 707161C0009 X-HE-Tag: 1703487737-935659 X-HE-Meta: U2FsdGVkX1+IMpz/mcOKiY1kZngKTAwb5M8xHP2dtverSkHfC/eaLGRpCTE1W0UxqyhTv+YEb9P0HwklG2JndksPs0WM8T+yVk0E68+7eQwtfCeTt6c+ByZhYF2Ji5DeL+ei2q6b8PBAURLf2JeZYXP996uI46Yy9r0AdcTTGgb6e5cfMhh0N+d5oBYEV+tyVvjVXXV7b70jxDamUxzyky2VahU3zU9iXZ7T9SgGncY5uR+W6Iis/zhF4A3+QT7B8T2OxH582RDQ+7o4o6420Q9Sn47hgUrv11DlB2JSiKtyCyLAgv0pllDyf+V92hrbypQ5ZE7ah2pLcVKkxSfgtI4wr4PK/8S4MOQt/MuSQSR1G8m0mUI4WbCjHmqUNGHtoqy4cEwND3EwT2PG1+cU7OMZ/bwaSK1K6WH4+3upnElS+nN76Kq4k80Gy5BgiGbBggf20BlPDNh66oo6K9ZzMCU/QAfIddDclFUtjYBA8ZruObElLXtATGHsec1IFf/5z1+qKYxrGepMjCVDyy7PaMVUAjOfouLReUZxc/3ciPzuX1bkaXj2vor7sWNv2GWu9Xj3oZh4aIO45NhMt+I4FOlhmQ5VJHy1C/3JTDIud6ssGYLo5+tidwhhb9E1vPUatLq9BzEV1gOGyhHDD/VC28UAVcMWycaiL1sY2hOPxN84/ECsmoRaRA0ap3xkzIzxEgSi7fX29gBvUYly1404IoKUD7O0+iWKRrpknVfcF/nDKt7Kq9FbIXjDXJe1O62Jqrmgu7TD/jGUDu4RRNN6VEwOaT74JeaGdwOnoEuzleOM7gqvrgvYI7Jl9BxtCNX9uuBgdYjdyI9tuqpD9gzYly5c5EpM2O/V3BSq5f6IfUU0jquJa6q1RSlnLutYj71gG7/+upEoD3Obbp2X8uk8EVPdfIMmnMEP86WxNdSvJ88QY+qbAo3yvpepcLw/bu6D+WzY9UTwcy8EFxB4o1O BIc3PAdD WBcOHFau66xQxp7+sbYXCv5iSeyJNgOJUL3zx8sg2QuoirleDcqI0txyXdibGPFn8f1fbpsAeti4L9sg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.302825, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Yu Zhao =E4=BA=8E2023=E5=B9=B412=E6=9C=8825=E6=97=A5=E5= =91=A8=E4=B8=80 14:58=E5=86=99=E9=81=93=EF=BC=9A > > On Fri, Dec 22, 2023 at 3:24=E2=80=AFAM Kairui Song wr= ote: > > > > From: Kairui Song > > > > Another overhead of aging is page moving. Actually, in most cases, > > pages are being moved to the same gen after folio_inc_gen is called, > > especially the protected pages. So it's better to move them in bulk. > > > > This also has a good effect on LRU ordering. Currently when MGLRU > > ages, it walks the LRU backward, and the protected pages are moved to > > the tail of newer gen one by one, which reverses the order of pages in > > LRU. Moving them in batches can help keep their order, only in a small > > scope though due to the scan limit of MAX_LRU_BATCH pages. > > > > After this commit, we can see a performance gain: > > > > Tested in a 4G memcg on a EPYC 7K62 with: > > > > memcached -u nobody -m 16384 -s /tmp/memcached.socket \ > > -a 0766 -t 16 -B binary & > > > > memtier_benchmark -S /tmp/memcached.socket \ > > -P memcache_binary -n allkeys \ > > --key-minimum=3D1 --key-maximum=3D16000000 -d 1024 \ > > --ratio=3D1:0 --key-pattern=3DP:P -c 2 -t 16 --pipeline 8 -x 6 > > > > Average result of 18 test runs: > > > > Before: 44017.78 Ops/sec > > After patch 1-2: 44810.01 Ops/sec (+1.8%) > > Was it tested with CONFIG_DEBUG_LIST=3Dy? > Hi, CONFIG_DEBUG_LIST is disabled here. > Also, the (44810.01-44687.08)/44687.08=3D0.0027 improvement also sounded > like a noise to me. >