From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8782C4345F for ; Thu, 2 May 2024 09:32:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4B09C6B00A8; Thu, 2 May 2024 05:32:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4601D6B00A9; Thu, 2 May 2024 05:32:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 34F9D6B00AA; Thu, 2 May 2024 05:32:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 104146B00A8 for ; Thu, 2 May 2024 05:32:28 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9F2C3801CA for ; Thu, 2 May 2024 09:32:27 +0000 (UTC) X-FDA: 82072940334.21.6686DE7 Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) by imf17.hostedemail.com (Postfix) with ESMTP id EE14E40011 for ; Thu, 2 May 2024 09:32:25 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=JdBFgoN+; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.180 as permitted sender) smtp.mailfrom=ryncsn@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714642346; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Z3lZtPpMKSUcjo/JnGTaHgDn+jnpLLkH19fhzoM/SDs=; b=DK3R9PWbYG7TVwcxrTDk3AHO8W/DVltfI8/O9U3MXPIDineKe2x6wRR0t6V78SPW3UMVrE 9HLCBYCX2Ng/i4aJDgwm6EqQdfSV7QFCHMu7M2uDFIr7YXGMeQUTAcZV+9AayNpjz+qwFy qvpgSdhCXGN/E6C7mXMiM6OQzDM0Pd4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714642346; a=rsa-sha256; cv=none; b=bi1OmOnBgFF8TIfG03LqoYSk3W6n160ETUqPziuNeIWq7UVy4PtjNbbMFrLQVSUuF5rB/h rJrekkEpQd9eNgly5xApb4Hy2ANl2ILBB9C58h1m8+fT4oT/U6ncziyfkUwUU3+oPYpzV2 0Mb4xL1G1Wrv1mJN2RLh7h50o4/mE1c= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=JdBFgoN+; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.180 as permitted sender) smtp.mailfrom=ryncsn@gmail.com Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-2e0b2ddc5d1so44970791fa.3 for ; Thu, 02 May 2024 02:32:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714642344; x=1715247144; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Z3lZtPpMKSUcjo/JnGTaHgDn+jnpLLkH19fhzoM/SDs=; b=JdBFgoN+BQAfeonE4Y3b0bs3TqWySsjJTkqgFw0YC3g+xYIIwAbiGZK8S/QsYm+BYT WWvVnCcJNb39POdjE2DShEEDXeQdGsu2O9m2qmLV1MzPmMkp4QNszKINSxsnfivg8UCO nFQ2hBsIoKMr6CTBMGYUD8HnpYjKmSoe3MLMFfJ800AG8pfCbF/HgTKs8f/YBTRsh+MR xPKlURl1d8TZgAPyRdTwKE+QZA0kYSm89r/BNF5Dc7U1sZWDGf7Q/cxuRjPSdvNFnLcY kZnv3zLkRBgPk1EH4QzdmXSzmSX29KDaOS7KgMuyW3JW+RiX+4HhN4fllZdVxJnKjWjS pCTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714642344; x=1715247144; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Z3lZtPpMKSUcjo/JnGTaHgDn+jnpLLkH19fhzoM/SDs=; b=jJqHL/0jK1ywKPIX6w++7V46ch7mwi7aVVXsvl6Uid+GexcBru2hT9l8aEXphBtI8f 5YMbb7Ju/FM/nq5XlgGYwMUMm7M76RjEj7iy6j9cT8961BTxaJHA/3P8Xkl9+TNGIwVz 4/DqzfFELTANpoJqL/7nDy+D783Os8Nx53Fmh+JhQofh+D7YiK+ZaCGOgiyqYsyBv/IV pTXHFUFEMnHkI/M6ZVX1es1Qw9VMw+9yshadN9sY+8h233OCndXKoNrbDmeot5VNKHaH Ig3OF2XayVImh/eMMNBNlb8X9z33j6zL9CpRRC6CzE/MlqrtVACdsWFZ1X3TrDoY6ohB Xngw== X-Gm-Message-State: AOJu0YxV/AhYcyI/jNeQHCrMGdtNKdNyMvevqtmKbeslxEM+G4aLmnLT THtR55codDjPRsuPJ70+Y8AwWmM8FzaxEnTIRLi5wkl0UXfhHtaxudRnyAcxIs4xGU/u+y0T0XD rKWtnyCSHdMhatSy8yK6lCHfg/Yw= X-Google-Smtp-Source: AGHT+IGCzOhkTfJRi4C5pjOm7iTIkpXmJVWJcWAimRSBIoNi/DSth1zP+hvlFVbxsvIwktZfamO0hBQVH3TYe+RbVkk= X-Received: by 2002:a2e:950e:0:b0:2d8:57a4:968d with SMTP id f14-20020a2e950e000000b002d857a4968dmr2959202ljh.12.1714642343841; Thu, 02 May 2024 02:32:23 -0700 (PDT) MIME-Version: 1.0 References: <20240502084609.28376-1-ryncsn@gmail.com> <20240502084939.30250-4-ryncsn@gmail.com> <7636ada9-fdf0-4796-ab83-9ac60a213465@redhat.com> In-Reply-To: <7636ada9-fdf0-4796-ab83-9ac60a213465@redhat.com> From: Kairui Song Date: Thu, 2 May 2024 17:32:07 +0800 Message-ID: Subject: Re: [PATCH v4 11/12] mm: drop page_index and convert folio_index to use folio To: David Hildenbrand Cc: linux-mm@kvack.org, Andrew Morton , "Huang, Ying" , Matthew Wilcox , Chris Li , Barry Song , Ryan Roberts , Neil Brown , Minchan Kim , Hugh Dickins , Yosry Ahmed , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: EE14E40011 X-Stat-Signature: r815gdkbdxqntmmo9wyxcg49usindd7h X-Rspam-User: X-HE-Tag: 1714642345-996169 X-HE-Meta: U2FsdGVkX19Nvm8l2eIHNwgRKVyoWisdt+hSZjvfhR5VhgXM+FQDtVK9Lsnn43m6jNkIwqB+hKEJJPIZZySFUXz/7x8RTDSEpVwwT+4JPuGs9qmCWJDUjy+zC5YvP8scJLIn0r1wXMwASHQ5isAbubwBmVhAwOAS9v7MpfJWvlyaUVaq9bIbh2k2dxiHgTB7D8r+7IZ13n6PB1SRM5s8SviBtTwBYQimgWzQbha1vEqGUYUZgNd0xjdzA6fy6f3S3+L4sWa9of2jcuAQEC4vhonYOdH4IuAlLMHoluRFnLVlp32SPp/9Lv9nc/MRS20pEzFYkSCQ4z98wUyepYxYO1keGOKezxPoSN/2q5WecMBVqwt7mzDN1QL5ADIPqN8+sUHU3859U325hqr3MgH6nhU5ywV6HsFKRwXVS6254m5OWhXBH/KsMvc6Rxq7DRnfs8LurkoiGO5C3Q3GZW1QUTvOlEZUZnPtmSCODCPucITmYMDn9SZktio3SemaZUgJaF1z9e4a90xKz3w2opc2PN99nTg9L8vmedmlHWxrMtrYclwbJpWKDIO020QlsbVEpnGAsRhbBgRqeaOIciLf4keurNQlI8JG/rvOs7ByWNsKO15f/HIEFyRFQv85LUGDHB8FbmlUlHdB6qZ94ogj07z0UyyLpDQrpMLaSgKh8oRyy2JFTBM7EtTy3El6CkVxj3K+A7DYVIH6kZTXgVIV02Y9/rhmDiV54GqZfKVJa/o+qHpAv413vZ7u+IeUKNTFLx/dh7EH3/WoSjmeMRWraRLKU++nbA5SfAfqn5vVBypC36oDxzbk8U1hcNjUOdafGOpsXw3a37hpgp2dW353PhFm/7g6qi1NIgQ853gVa2W+Re1vypjl3fdpVkHYZLvj5ZIpAnoFL026DR8/WRTF4H/bZzf2I1+QpR3iNdAh7drbyfnr8aYY2zP8Ac+NgiatPkinVfsKgs5Q1d65Fv8 IpGpZRgo PpKtB2bEQyXymulWCec2Ebk6B2v17crrhjxFJWx+j6Nj9JHzXj0HyYnV8oi4EntOOFegK6lHZ7frtihw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 2, 2024 at 5:12=E2=80=AFPM David Hildenbrand = wrote: > > On 02.05.24 10:49, Kairui Song wrote: > > From: Kairui Song > > > > There are two helpers for retrieving the index within address space > > for mixed usage of swap cache and page cache: > > > > - page_index > > - folio_index (wrapper of page_index) > > > > This commit drops page_index, as we have eliminated all users, and > > converts folio_index to use folio internally. > > The latter does not make sense. folio_index() already is using a folio > internally. Maybe a leftover from reshuffling/reworking patches? Hi, David, folio_index calls swapcache_index, and swapcache_index is defined as: #define swapcache_index(folio) __page_file_index(&(folio)->page) Where it casts the folio to page first, then call __page_file_index, __page_file_index is a function and works on pages. After this commit __page_file_index is converted to __folio_swap_cache_index. This change is a bit of trivial but we get rid of the internal page conversion. I can simplify the commit message, just say drop page_index to make the code cleaner, if this is confusing.