linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Kairui Song <ryncsn@gmail.com>
To: carstengrohmann@gmx.de, Andrew Morton <akpm@linux-foundation.org>
Cc: bugzilla-daemon@kernel.org, Baoquan He <bhe@redhat.com>,
	 Nhat Pham <nphamcs@gmail.com>,
	Yosry Ahmed <yosryahmed@google.com>,
	linux-mm@kvack.org
Subject: Re: [Bug 221055] New: Hibernate image write 10x slower since commit 0ff67f990bd4 ("mm, swap: remove swap slot cache")
Date: Fri, 13 Feb 2026 03:01:10 +0800	[thread overview]
Message-ID: <CAMgjq7By=prRMh2T=i-T2cV3fZX+oE+YM0H4zHMXwSscnhbZmg@mail.gmail.com> (raw)
In-Reply-To: <aYt4RwxqH1W_zHez@KASONG-MC4>

[-- Attachment #1: Type: text/plain, Size: 2201 bytes --]

On Wed, Feb 11, 2026 at 2:39 AM Kairui Song <ryncsn@gmail.com> wrote:
>
> On Fri, Feb 06, 2026 at 12:11:51PM +0800, Andrew Morton wrote:
> > On Fri, 06 Feb 2026 19:51:38 +0000 bugzilla-daemon@kernel.org wrote:
> >
> > > https://bugzilla.kernel.org/show_bug.cgi?id=221055
> >
> > > === Summary ===
> > >
> > > Hibernate image write 10x slower since commit 0ff67f990bd4 ("mm,
> > > swap: remove swap slot cache")
> >
> > Thanks for all the work you put into this.
>
> > > === Bisect Result ===
> > >
> > > A full git bisect on the vanilla kernel repository
> > > (git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git)
> > > between v6.14 (good) and v6.15 (bad) with 14 iterations
> > > consistently identified this commit:
> > >
> > >   # first bad commit: [0ff67f990bd45726e0d9e91111d998e7a3595b32]
> > >   #   mm, swap: remove swap slot cache
>
> Both are not too hard to fix. Is that's SSD only issue? And
> should we fix this in every LTS or just mainline? It could
> be a bit trouble some if every LTS needs a fix.

Hi All,

After many attempts, I haven't (fully) reproduced it yet. But I do
have a patch, see attachment.

After this patch:
PM: hibernation: Wrote 1559088 kbytes in 0.55 seconds (2834.70 MB/s) - NVME
PM: hibernation: Wrote 2038748 kbytes in 4.04 seconds (504.64 MB/s) - SATA

After 0ff67f990bd4 (the regression commit):
PM: hibernation: Wrote 2224184 kbytes in 0.90 seconds (2471.31 MB/s) - NVME
PM: hibernation: Wrote 2215472 kbytes in 4.44 seconds (498.98 MB/s) - SATA

Before 0ff67f990bd4:
PM: hibernation: Wrote 2222772 kbytes in 0.84 seconds (2646.15 MB/s) - NVME
PM: hibernation: Wrote 2230700 kbytes in 4.47 seconds (499.03 MB/s) - SATA

It seems a bit faster / slower indeed, or maybe just noise. On my
machines 0ff67f990bd4 is not causing an major issue like the one
described in the bugzilla link. I'll try to see if there are more detailed
issues with the test setup.

And can anyone help verify this fix? I'll also try some other SSD later
maybe that's only reproducible with SSD that have very poor 4K performance.

HDD should not be affected because the allocator has a special
way to do HDD allocation.

[-- Attachment #2: hibernate-perf.patch --]
[-- Type: application/x-patch, Size: 5772 bytes --]

  reply	other threads:[~2026-02-12 19:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-221055-27@https.bugzilla.kernel.org/>
2026-02-06 20:11 ` Andrew Morton
2026-02-10 18:39   ` Kairui Song
2026-02-12 19:01     ` Kairui Song [this message]
2026-02-12 20:37       ` Carsten Grohmann
2026-02-13  2:21         ` Kairui Song
2026-02-15  8:56         ` Carsten Grohmann
2026-02-15  9:25           ` Kairui Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMgjq7By=prRMh2T=i-T2cV3fZX+oE+YM0H4zHMXwSscnhbZmg@mail.gmail.com' \
    --to=ryncsn@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=bhe@redhat.com \
    --cc=bugzilla-daemon@kernel.org \
    --cc=carstengrohmann@gmx.de \
    --cc=linux-mm@kvack.org \
    --cc=nphamcs@gmail.com \
    --cc=yosryahmed@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox