From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0460FC369DC for ; Thu, 1 May 2025 10:08:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1EE266B0088; Thu, 1 May 2025 06:08:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 19C846B0089; Thu, 1 May 2025 06:08:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 08C366B008A; Thu, 1 May 2025 06:08:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DDCD96B0088 for ; Thu, 1 May 2025 06:08:40 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A05DD1A03AF for ; Thu, 1 May 2025 10:08:41 +0000 (UTC) X-FDA: 83393914842.08.F6E137E Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) by imf20.hostedemail.com (Postfix) with ESMTP id C71DC1C0007 for ; Thu, 1 May 2025 10:08:39 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=m6iUfSha; spf=pass (imf20.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.176 as permitted sender) smtp.mailfrom=ryncsn@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746094119; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HgLvO+n0R7zxT3cGMmFndY151LKlyH3b08KaJoiQevA=; b=JFC825IJMbaCexcYjFYcDkFCMp6O/CGszdWDiXhwYpQs913OBNeO2cUCNer9vR2dlI6gnz lUxkX/bZ06q043H165BtT5lpxeHnBpPYFnp9IIXmFRPNzP6nqUaOLjVWj6VD2LLci5fb81 qgyr5wiJ8xZNVFNSbQQ4VUw8mAZOynA= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=m6iUfSha; spf=pass (imf20.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.176 as permitted sender) smtp.mailfrom=ryncsn@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746094119; a=rsa-sha256; cv=none; b=qEHicmfV4MLJaV+cdmzjKvDJg55/ErijmPVa8M2aKSSEkMZkObZn3Rr+SVuWhBTYWsq/xr 5vXJFQk5YSwBaEM6w9p1Unag4zsIAPxGFy9iA97u3Xpl8gQf/LZsCNbzlmWgaYs7rQILNA ZpzcKDCTVVoRLv5BcAi0SU/4Uj0aFps= Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-30bfc79ad97so20769111fa.1 for ; Thu, 01 May 2025 03:08:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746094118; x=1746698918; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HgLvO+n0R7zxT3cGMmFndY151LKlyH3b08KaJoiQevA=; b=m6iUfShafw37YT9xFIyNei46dbj9jm6nOsizZpWdUQhJOfnK1v9Yv/F/ZfrY1ss9LI LjDEGycLFFjnasM9nCha7uNV+KzFm9hjAvLLDnJtdJ77RG6yDziNRUQYlC2PVS6aUcUt UXNXaTuQjxUtUF01mYT+stD0b986ffzS1XIaZIXuDoDULV2W2mno+5vyFh/Tg9JbDZwn XtXsAiSuP+ElqWXhgOHg9KHTMo62cu5t4uMgI98y/UXtdiSf7y3A2+pp28FTY56pR/26 HP9y7AT7dvBrgqrETH208E1llJk4m8LqcmFcZRAIZW0fojMnVn1uaZ0dJslu2BfoJ1gj 4U/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746094118; x=1746698918; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HgLvO+n0R7zxT3cGMmFndY151LKlyH3b08KaJoiQevA=; b=HKUEm5jDs+ZmVgB6il+YmXKbBVZmc0gEIMVqpi2ApXiwBzed5G8M+IOVQJd/+rPkLr M87eO0UiDKK09NoqFFdzu+MQJE+RfjtkF4vn76c35Aj7cw7Fd8cdXp9q2oPxidsREgyG 5kz4WGkLEYr2eZcblpFIQILFZ8fQMM2jXybNiRnUhLWTuLYdSVD0crDiCrXKv4jYZV1V yuYigsaxXHehMasrVsF/B63caBcv1anVABwCiC0Z8hUpNywyc8sToolITnMwf41R1HvM gCg3fWmoijgH0hxi/1ESgPbDmfqeQIC/Ue+CVhUGUEFjJFHNLqZgTL6QnI3on4hVllWi THsQ== X-Gm-Message-State: AOJu0YyICaaPywXE3UuPRcnKXBuZgck1TI1cu3KMa1I3oF7rhYUwlYwJ PGBzmZr73rw+XwuzqsPmB1WByj5b7XuLY7aTOSJmHEOZmrg1tHFYElu2ufyCnlGXORLRrU4NZ3h oLOXwHxhy/19ZtqtxvjHl2AbjGqo= X-Gm-Gg: ASbGncuHJAdX8z6oyYrmiFlLzE9lxdWl3fA1af5y8MuKIeaUKgdkuaYMwNDrN/xCTzY nO+oUmD89y+ncNM3C17hhISSPlwbesOrgRZ6Os/sdQiJUarjaPdMRuhulW6RI9dDhDwyFJaC8Wg MiSgY7GCzzp0faOqJs1firWw== X-Google-Smtp-Source: AGHT+IG1al/aKxdyoPYpVBZh9QPGrAguZJZDe79LmZGdPhoM6KIk17z7h13JBq9bkxvvPDQKjOMggWbxZpaefC37Pls= X-Received: by 2002:a2e:a906:0:b0:30b:f0dd:9096 with SMTP id 38308e7fff4ca-31fbc1849eamr4423881fa.12.1746094117691; Thu, 01 May 2025 03:08:37 -0700 (PDT) MIME-Version: 1.0 References: <20250430181052.55698-1-ryncsn@gmail.com> <20250430181052.55698-6-ryncsn@gmail.com> <19908a46-feaf-4bbb-b41c-ef5b7d72343a@redhat.com> In-Reply-To: <19908a46-feaf-4bbb-b41c-ef5b7d72343a@redhat.com> From: Kairui Song Date: Thu, 1 May 2025 18:08:19 +0800 X-Gm-Features: ATxdqUHS9sTsB5VG99FBddABZLncQkxd7c8acvTDcoWZo0Z6OVZk9LcS-Eea_38 Message-ID: Subject: Re: [PATCH v3 5/6] mm: move folio_index to mm/swap.h and remove no longer needed helper To: David Hildenbrand Cc: linux-mm@kvack.org, Andrew Morton , Matthew Wilcox , Hugh Dickins , Chris Li , Yosry Ahmed , "Huang, Ying" , Nhat Pham , Johannes Weiner , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: C71DC1C0007 X-Stat-Signature: ykywqzidtn56eukxzn8sr4fne5s48cdp X-HE-Tag: 1746094119-553227 X-HE-Meta: U2FsdGVkX1/BfNmcC7Mcj0x5naNdPkPI2kL+VP29L+MPiHfxlWoe1GbN4EeSxjcSr1h1wn11XzFVgu3n6+qnHG//XMO/sovQnTIhN98bM1hKgIyBtM4vorB3n5Zm5hpp+44X8/R9/VvE3EFkp0WAxm80WSlad3PfwhCFVJw70cgKeC4jU7RYQkla3gf5azuSvoGH2CrFqOGJpqDxlxE/eYN1JJot2ZSyPRmk0mMn7bQZBryBZC/eNTI0XyrHow1D8nYFqsDyzn4RlPGNNXTphUqN6zcHI/WtBUC+y5R3w7e+Xd1H6GS01EzreBB3ZLK20Egp7RGXOPWmq3AQWTBi/FD7fi8CiLEeAzDSBBtvCP82G6gIxEzac6oNkAC6b7mvPIRWNIm/jWI9Uu4qtXv1vO7RyBiIDUf+w42XpH+GXp3HGpbt2tRU+99svia+17eiT/7f5ZIxlxPzqlzraULwk3kV+Udy57XVn4TCCorL4ijSUj23MZlJJPjpO7M93MafuU4VaJ/YKpYjeoGJKeV3b7NkeWgNFTC3xWnCNjHdmJEQBtiagNfVSfEW+jDNhp6SQiAkLyBnTB+8M5S8Y4MACt64CCHSHVV+eO6f2myUffDi9G8SmprHeu9+9F5yMHXl2fGSe98q3dtToNayzaAcnbOs7JUBiHZvethVLX+xEB4R2nkxSaOaXaOoNUT/TEL2hDdPSbpBgw0j1WN6XB9vCBccQalW49NPj7eANTumpLU+zGgw3hcPqVvm5eWKduUkbdAhHeVngTZxsZJe/fDf0/c5pLJuih79omy7oi6DsGzD+tdE/s66+lvG08zotPFe1WtAIsILoP+t1lWaoGUtIua++PoA861YwcmGvgrTMOWhehg/bnqy2HMfF/tI/NELlVsV1GF/Tx/HFB4jqXpREa3DfpnNfEpcZZlF/9eSy+dTxl3V3gxxUw9pRhErc5KlBkt7LHiLfJdN11qfNk9 hXrso+ns nUadjlvv5Cs13Ykwj7GF2Djb1dxSyYaGjTQBla73Pnn+ByttP/1Uw4uQ4nns1JZhu/S+89TmPL4knxPzV773aGJrfA1K7SM05qK82bXn7eXymT13WoJ9MV1AZUHfjgQy6ppjRNf7HyBxwTJWpFS1xHLxdbiP2wIlvBKM5WsszaxiNye1XhbIDd08ADFcv7oZT17e2VkixMY9ZcBgp8ID0Fw66/wN0McPJEAmj+GiFT3RZ5eyXo8E9zb23V5VwPYzGwYE9yOcoihTeYCkbsqNvPPCS2EhAxDQTDf+qBCkrcJidW3gBjcuPJAIuzQRsjbRHZVaC9ulMGV00f14kvaIF+3WsIFa0hN5CL4flOQcqdqY4a7MD/QtQeqV6g2Ik/qTrizzN+CINFZoQGQwhVbgfarnFLbrhNHzitDQL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 1, 2025 at 5:11=E2=80=AFAM David Hildenbrand = wrote: > > On 30.04.25 20:10, Kairui Song wrote: > > From: Kairui Song > > > > There are no remaining users of folio_index() outside the mm subsystem. > > Move it to mm/swap.h to co-locate it with swap_cache_index(), eliminati= ng > > a forward declaration, and a function call overhead. > > > > Also remove the helper that was used to fix circular header dependency > > issue. > > > > Signed-off-by: Kairui Song > > --- > > include/linux/pagemap.h | 20 -------------------- > > mm/gup.c | 1 + > > mm/memfd.c | 1 + > > mm/migrate.c | 1 + > > mm/page-writeback.c | 1 + > > mm/swap.h | 18 ++++++++++++++++++ > > mm/swapfile.c | 6 ------ > > 7 files changed, 22 insertions(+), 26 deletions(-) > > [...] > > > bool isolate_movable_page(struct page *page, isolate_mode_t mode) > > { > > diff --git a/mm/page-writeback.c b/mm/page-writeback.c > > index 20e1d76f1eba..9ff44b64d3d6 100644 > > --- a/mm/page-writeback.c > > +++ b/mm/page-writeback.c > > @@ -41,6 +41,7 @@ > > #include > > > > #include "internal.h" > > +#include "swap.h" > > I wonder if we should just have it in mm/internal.h instead? That will require internal.h to depend on swap.h. In follow up patches I'd like to remove the folio_index usage in all places except migrate and swap files, this will make the code cleaner and swap cache will be less exposed. > > In any case > > Acked-by: David Hildenbrand Thanks! > > -- > Cheers, > > David / dhildenb > >