From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 081FCC3DA4A for ; Fri, 16 Aug 2024 16:56:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8B4016B030D; Fri, 16 Aug 2024 12:56:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8130A6B030E; Fri, 16 Aug 2024 12:56:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 68C836B030F; Fri, 16 Aug 2024 12:56:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4166B6B030D for ; Fri, 16 Aug 2024 12:56:04 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id DB937120130 for ; Fri, 16 Aug 2024 16:56:03 +0000 (UTC) X-FDA: 82458711006.26.4263AE2 Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) by imf07.hostedemail.com (Postfix) with ESMTP id F16484001B for ; Fri, 16 Aug 2024 16:56:01 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=aa7A+nNs; spf=pass (imf07.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.180 as permitted sender) smtp.mailfrom=ryncsn@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723827263; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dNTYAuLguEm/KVzhzDONt+kKrDKZHthfsPB3DnaxLOE=; b=FoQOZwjnvu4+a4WeCjvIQtUtzEG8eqZTcZPSR2/UMo+LrCHcb7PCAawDwAw9YTjKMhD1HE bDuXhvnu6wd5IEyX8LWK/rRz+o39jPZ3/gj8hfQFOzg2304JRAsqyMiCG+eLrw9l2DyY2B W0nm+es+o0BVe8tuDxogDXxPABkjkHY= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=aa7A+nNs; spf=pass (imf07.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.180 as permitted sender) smtp.mailfrom=ryncsn@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723827263; a=rsa-sha256; cv=none; b=O8RrMaGXkZfhnTywA6/FAwpZZCuCFlU7vLv6b7nT4aM1SUhrsbTAJ1oC7EFUctFIxIyhKT BNMwjJOi2vx03LVx4NrQeH1X1nyMl6oEMyPUN/MaH7HhLPUu4dIxK8vMpAJl9P1aInYwzC hYqK/p5C9THcCBnQnxKGg/jLd5VwlmE= Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-2f029e9c9cfso32860391fa.2 for ; Fri, 16 Aug 2024 09:56:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723827360; x=1724432160; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=dNTYAuLguEm/KVzhzDONt+kKrDKZHthfsPB3DnaxLOE=; b=aa7A+nNsbjBpTAYajDSUuaSyM3LL80a2IUKWKNEY5mbXnZq/hjJ7dY+un/bC4RRty0 keB1HhzCZtKqZXKeAQ03Ge2D7wxfNXC9TmIRgcP5lUe2qK0mQYomur1/XLwH016vG9KS Yq+5ydTsQBohfXKSnR3Tuyas+uirKmPz+DEIkZm4ZrsXlQXjgYo1sdrkacNtu8iZsCSh 2H1ysmaIos7236+B+lpYT/4wYbinrg/JG/BBdWekiREiteufiRA7Cp+DkQjc+//UJl7l 4rgdXh+AGraNfg9TgZBs8WMD4UiWsXJlNI1lQWfXmtc6hUT325Xd4TkL/eauAtzmj8II RnPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723827360; x=1724432160; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dNTYAuLguEm/KVzhzDONt+kKrDKZHthfsPB3DnaxLOE=; b=aAY5ITpPgp5rLeis6+XcURt+/5kDVriLNinYrid86sQy5i+F0GPkmhIT6G415YlNzZ fHoPYokS61/Hq6ZU62fzBKU+KxCb6Crq6JY4oca2GIO8gZIUfxFOST70IPFKDU/ZJlSW s9yERvfSzzgGyzEgPdJBMm7twNVd+Y865u2Za3kb53IIKYAmWVnQbZsE6P85kagoX8gP Pg6IZh8H8T80GaLDFp2gPPwHg0ja7CdFGK1qUTYaMuPgHo/H5vMZS7YEOoiygmFL38iQ E3bF00XO5CU9foLk9+QuWkbys5qL5UKHWASqICOVp9oLLmxgIeq2m2a+bv+ntdsWruFy hmlA== X-Forwarded-Encrypted: i=1; AJvYcCWuHgMCguV57+jae38hOZnYlCP+TIH/0ADI3hggTYQtcOuPh6gpY6Q4mIPcYEOREf9KZkcqqk5N1mMVY1KrqIAG1m4= X-Gm-Message-State: AOJu0Yy5irmf8o92X3WCo/EhU1JXZTby7ksP+j1+mcvP9doI+o66pJp3 joGco7NGwYt0R+VDw10MEdjaFYsPWhAyjz4sXkhqxc/Yn7rTAkIb3uLaAzfkV8Cfri/UHFQ6WII ZD/cy0BeypW+BVNQs/iMwnpPKkLs= X-Google-Smtp-Source: AGHT+IHsk4aXpZLWNLR6slFmyVVdq4I/vtPxpETP6Cg81SVckhGjxhqzcz5+PKIg8r85RQMhWblRrLO94EwlWrc4YmM= X-Received: by 2002:a2e:b5db:0:b0:2f1:67de:b536 with SMTP id 38308e7fff4ca-2f3be5963fbmr29160261fa.24.1723827359824; Fri, 16 Aug 2024 09:55:59 -0700 (PDT) MIME-Version: 1.0 References: <20240813120328.1275952-1-usamaarif642@gmail.com> <20240813120328.1275952-2-usamaarif642@gmail.com> In-Reply-To: From: Kairui Song Date: Sat, 17 Aug 2024 00:55:43 +0800 Message-ID: Subject: Re: [PATCH v3 1/6] mm: free zapped tail pages when splitting isolated thp To: Usama Arif Cc: akpm@linux-foundation.org, linux-mm@kvack.org, hannes@cmpxchg.org, riel@surriel.com, shakeel.butt@linux.dev, roman.gushchin@linux.dev, yuzhao@google.com, david@redhat.com, baohua@kernel.org, ryan.roberts@arm.com, rppt@kernel.org, willy@infradead.org, cerasuolodomenico@gmail.com, corbet@lwn.net, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kernel-team@meta.com, Shuang Zhai Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: F16484001B X-Stat-Signature: gzcw9a9fxozfun5n7ikcje49j44kdztu X-Rspam-User: X-HE-Tag: 1723827361-108974 X-HE-Meta: U2FsdGVkX18HI9CFx35DzL+Wv3tswnaKmbAXx7bBIoE9Do+sBl7tqpqlo6/oyePj1xQeb1c4GUKzmUMw+mwWW2QmVkj0dNfRImZiw08yuIzNzvF9oMW44Ktlxz0sajoVxWRHYfAJ5CoxdXnt56UHUV0jmhx/XCQ1QsXNZm4tHqS5SQNCWzmdGMfx8Ui70mZvicPliLA3kJraqmTSHpWPcxpGi6QFdK5PLYxhPMLD5csZpprgrRJm20ukU2Lb+icgxT7ZPNEZWt/I+onDRUz+8E8PPFQVZ6Aa+XRQxLcMRWUxAzB8+rWdCv7O3V2vxnsC4n9TXiYZ+czWETdgQP1qftmScTaB207gNE71PRCRFF7h9PQV4EOECYMHXL5FvZIsV/Fp/bclnpZQIKiqo85QoYx0iZXjco2C7qWY6K92+zGLYQPXdJIaou3vIsiq/Iv3UaQ5RiPY7smV002LCT/bAe8HZbOzSbCVrovNywprmjca9wkOoXWIp1Y9Qf0gvDTimWCAdoYy35BzKjSF/7ND59Z6nhpEJysFMeGjz8gvPvMzDzXsI9SoSaAZ/YRo4K33Gg6Jv3lMPKrmSklIxSr2JZY74HjcE8b8jPZLInj2Yi9kynuAB9MAm2CFCM/ouAYQPCd5fHzByHcKRnfPZuPc1XzYXU2r7LeRdFMED4Apnruz+NXlHVSYLXgriRPoPLUsmiotuRpB182kcikWy6Iic9pF1TGtzhNm4jF9tvf698lNU1EJ4AygK6hsVYSm70xwDPxPsA+TUu3IUfAGAhcpmNF9GU4XMNFxbW3CL7kDQUWZM9DRpXWpIoMNFkAMgSLCKUcMEPyj+lGCeBBVKEa2fJupFsd6BJQY4j6CkCyhtV9g46vrEvoIHi0qyBbJq4yRwLHAeRXXBZekDXBSQBu/pNX51aPK2J3yXZUkQ+tgMmz0iHjiBgMt8gt9E9KCh2CaTtKgb8pjddYjTUHR6rc CEPRpfoC 2t43YM0f3pSeXsSLAFLWCa/7hKEQK0U3l9lVekvKgiRw+eQ41/lLW4qTpl1cFUk6luV7fQYvrOqusgLgpV8MT4L6FDgNk5ueb3GPV6EYWKxlPGhaukC7o0H2pv4yu7jcPCvanKnbFBJrVEqnJC2kJtacfoznMzlIM7/XCTwC7vy6Ayl/oiHwNczooTJgkSobfZCPc0sLdeweTbrW3pLmvbyjfPoiJjvPBCKQwCbZZnQIAveBMvGujjnV2XWHg7eJgDjl62jpMU8qTqthG/DsCCJNLFgt5PH1q1PLEB4VLU9j3RM4pEAjD4Xi7krq/4CI7Y88P7NAmMyKEJO1C9Ja/FVtuwOaHjMfGf+LxK91dyFofj3bTP9N1HqWkteUAun7gl6WoTpEyRLY78P5mJrGm4i6y8w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Aug 16, 2024 at 3:16=E2=80=AFAM Usama Arif = wrote: > On 15/08/2024 19:47, Kairui Song wrote: > > On Tue, Aug 13, 2024 at 8:03=E2=80=AFPM Usama Arif wrote: > >> > >> From: Yu Zhao > >> > >> If a tail page has only two references left, one inherited from the > >> isolation of its head and the other from lru_add_page_tail() which we > >> are about to drop, it means this tail page was concurrently zapped. > >> Then we can safely free it and save page reclaim or migration the > >> trouble of trying it. > >> > >> Signed-off-by: Yu Zhao > >> Tested-by: Shuang Zhai > >> Signed-off-by: Usama Arif > >> Acked-by: Johannes Weiner > >> --- > >> mm/huge_memory.c | 27 +++++++++++++++++++++++++++ > >> 1 file changed, 27 insertions(+) > > > > Hi, Usama, Yu > > > > This commit is causing the kernel to panic very quickly with build > > kernel test on top of tmpfs with all mTHP enabled, the panic comes > > after: > > > > Hi, > > Thanks for pointing this out. It is a very silly bug I have introduced go= ing from v1 page version to the folio version of the patch in v3. > > Doing below over this patch will fix it: > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 907813102430..a6ca454e1168 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -3183,7 +3183,7 @@ static void __split_huge_page(struct page *page, st= ruct list_head *list, > > folio_clear_active(new_folio); > folio_clear_unevictable(new_folio); > - if (!folio_batch_add(&free_folios, folio)) { > + if (!folio_batch_add(&free_folios, new_folio)) { > mem_cgroup_uncharge_folios(&free_folios); > free_unref_folios(&free_folios); > } > > > I will include it in the next revision. > Hi, After the fix, I'm still seeing below panic: [ 24.926629] list_del corruption. prev->next should be ffffea000491cf88, but was ffffea0006207708. (prev=3Dffffea000491cfc8) [ 24.930783] ------------[ cut here ]------------ [ 24.932519] kernel BUG at lib/list_debug.c:64! [ 24.934325] Oops: invalid opcode: 0000 [#1] PREEMPT SMP NOPTI [ 24.936339] CPU: 32 UID: 0 PID: 2112 Comm: gzip Not tainted 6.11.0-rc3.ptch+ #147 [ 24.938575] Hardware name: Red Hat KVM/RHEL-AV, BIOS 0.0.0 02/06/2015 [ 24.940680] RIP: 0010:__list_del_entry_valid_or_report+0xaa/0xc0 [ 24.942536] Code: 8c ff 0f 0b 48 89 fe 48 c7 c7 f8 9d 51 82 e8 9d 36 8c ff 0f 0b 48 89 d1 48 89 f2 48 89 fe 48 c7 c7 30 9e 51 82 e8 86 36 8c ff <0f> 0b 48 c7 c7 80 9e 51 82 e8 78 36 8c ff 0f 0b 66 0f 1f 44 00 00 [ 24.948418] RSP: 0018:ffffc90005c2b770 EFLAGS: 00010246 [ 24.949996] RAX: 000000000000006d RBX: ffffea000491cf88 RCX: 00000000000= 00000 [ 24.952293] RDX: 0000000000000000 RSI: ffff889ffee1c180 RDI: ffff889ffee= 1c180 [ 24.954616] RBP: ffffea000491cf80 R08: 0000000000000000 R09: c0000000fff= f7fff [ 24.956908] R10: 0000000000000001 R11: ffffc90005c2b5a8 R12: ffffc90005c= 2b954 [ 24.959253] R13: ffffc90005c2bbc0 R14: ffffc90005c2b7c0 R15: ffffc90005c= 2b940 [ 24.961410] FS: 00007fe5a235e740(0000) GS:ffff889ffee00000(0000) knlGS:0000000000000000 [ 24.963587] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 24.965112] CR2: 00007fe5a24ddcd0 CR3: 000000010cb40001 CR4: 00000000007= 70eb0 [ 24.967037] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 00000000000= 00000 [ 24.968933] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 00000000000= 00400 [ 24.970802] PKRU: 55555554 [ 24.971559] Call Trace: [ 24.972241] [ 24.972805] ? __die_body+0x1e/0x60 [ 24.973756] ? die+0x3c/0x60 [ 24.974450] ? do_trap+0xe8/0x110 [ 24.975235] ? __list_del_entry_valid_or_report+0xaa/0xc0 [ 24.976543] ? do_error_trap+0x65/0x80 [ 24.977542] ? __list_del_entry_valid_or_report+0xaa/0xc0 [ 24.978891] ? exc_invalid_op+0x50/0x70 [ 24.979870] ? __list_del_entry_valid_or_report+0xaa/0xc0 [ 24.981295] ? asm_exc_invalid_op+0x1a/0x20 [ 24.982389] ? __list_del_entry_valid_or_report+0xaa/0xc0 [ 24.983781] shrink_folio_list+0x39a/0x1200 [ 24.984898] shrink_inactive_list+0x1c0/0x420 [ 24.986082] shrink_lruvec+0x5db/0x780 [ 24.987078] shrink_node+0x243/0xb00 [ 24.988063] ? get_pfnblock_flags_mask.constprop.117+0x1d/0x50 [ 24.989622] do_try_to_free_pages+0xbd/0x4e0 [ 24.990732] try_to_free_mem_cgroup_pages+0x107/0x230 [ 24.992034] try_charge_memcg+0x184/0x5d0 [ 24.993145] obj_cgroup_charge_pages+0x38/0x110 [ 24.994326] __memcg_kmem_charge_page+0x8d/0xf0 [ 24.995531] __alloc_pages_noprof+0x278/0x360 [ 24.996712] alloc_pages_mpol_noprof+0xf0/0x230 [ 24.997896] pipe_write+0x2ad/0x5f0 [ 24.998837] ? __pfx_tick_nohz_handler+0x10/0x10 [ 25.000234] ? update_process_times+0x8c/0xa0 [ 25.001377] ? timerqueue_add+0x77/0x90 [ 25.002257] vfs_write+0x39b/0x420 [ 25.003083] ksys_write+0xbd/0xd0 [ 25.003950] do_syscall_64+0x47/0x110 [ 25.004917] entry_SYSCALL_64_after_hwframe+0x76/0x7e [ 25.006210] RIP: 0033:0x7fe5a246f784 [ 25.007149] Code: c7 00 16 00 00 00 b8 ff ff ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 f3 0f 1e fa 80 3d c5 08 0e 00 00 74 13 b8 01 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 54 c3 0f 1f 00 55 48 89 e5 48 83 ec 20 48 89 [ 25.011961] RSP: 002b:00007ffdb0057b38 EFLAGS: 00000202 ORIG_RAX: 0000000000000001 [ 25.013946] RAX: ffffffffffffffda RBX: 0000000000000001 RCX: 00007fe5a24= 6f784 [ 25.015817] RDX: 0000000000008000 RSI: 0000558c0d311420 RDI: 00000000000= 00001 [ 25.017717] RBP: 00007ffdb0057b60 R08: 0000558c0d258c40 R09: 0000558c0d3= 11420 [ 25.019618] R10: 00007ffdb0057600 R11: 0000000000000202 R12: 00000000000= 08000 [ 25.021519] R13: 0000558c0d311420 R14: 0000000000000029 R15: 00000000000= 01f8d [ 25.023412] [ 25.023998] Modules linked in: [ 25.024900] ---[ end trace 0000000000000000 ]--- [ 25.026329] RIP: 0010:__list_del_entry_valid_or_report+0xaa/0xc0 [ 25.027885] Code: 8c ff 0f 0b 48 89 fe 48 c7 c7 f8 9d 51 82 e8 9d 36 8c ff 0f 0b 48 89 d1 48 89 f2 48 89 fe 48 c7 c7 30 9e 51 82 e8 86 36 8c ff <0f> 0b 48 c7 c7 80 9e 51 82 e8 78 36 8c ff 0f 0b 66 0f 1f 44 00 00 [ 25.032525] RSP: 0018:ffffc90005c2b770 EFLAGS: 00010246 [ 25.033892] RAX: 000000000000006d RBX: ffffea000491cf88 RCX: 00000000000= 00000 [ 25.035758] RDX: 0000000000000000 RSI: ffff889ffee1c180 RDI: ffff889ffee= 1c180 [ 25.037661] RBP: ffffea000491cf80 R08: 0000000000000000 R09: c0000000fff= f7fff [ 25.039543] R10: 0000000000000001 R11: ffffc90005c2b5a8 R12: ffffc90005c= 2b954 [ 25.041426] R13: ffffc90005c2bbc0 R14: ffffc90005c2b7c0 R15: ffffc90005c= 2b940 [ 25.043323] FS: 00007fe5a235e740(0000) GS:ffff889ffee00000(0000) knlGS:0000000000000000 [ 25.045478] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 25.047013] CR2: 00007fe5a24ddcd0 CR3: 000000010cb40001 CR4: 00000000007= 70eb0 [ 25.048935] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 00000000000= 00000 [ 25.050858] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 00000000000= 00400 [ 25.052881] PKRU: 55555554 [ 25.053634] Kernel panic - not syncing: Fatal exception [ 25.056902] Kernel Offset: disabled [ 25.057827] ---[ end Kernel panic - not syncing: Fatal exception ]--- If I revert the fix and this patch, the panic is gone, let me know if I can help debug it.