From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC343C4345F for ; Tue, 16 Apr 2024 03:51:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2B50B6B0088; Mon, 15 Apr 2024 23:51:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2643A6B0089; Mon, 15 Apr 2024 23:51:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 12D1F6B008A; Mon, 15 Apr 2024 23:51:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id EB56D6B0088 for ; Mon, 15 Apr 2024 23:51:51 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id BAA30A0CCD for ; Tue, 16 Apr 2024 03:51:51 +0000 (UTC) X-FDA: 82014021222.04.5B2AFA9 Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) by imf29.hostedemail.com (Postfix) with ESMTP id 24D8A120009 for ; Tue, 16 Apr 2024 03:51:49 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=EEkJQLze; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf29.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.169 as permitted sender) smtp.mailfrom=ryncsn@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713239510; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Sm7ZcmqODEDdlMVCkcEwyHPG5PSzL84rGETrzop4fyA=; b=yP8U/12X2sKjYblikRGWMtDFHl4a/XOPRG08HURdKRIFGF86AGOxyF1/fqxzFrkj+zoW4Z 7t39bDvO4wZFQs/aU1Ksv2XVKbZs+40zKcm6jo8FvrIyC3D8qk62hoF6DAhjktlHdsNO1x 2I1mbHNph5OM0RWIYT6dv6BG26+cDmg= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=EEkJQLze; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf29.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.169 as permitted sender) smtp.mailfrom=ryncsn@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713239510; a=rsa-sha256; cv=none; b=p6xOe0iuIIBt2wuiCk1qdq2+Nw/u3Tf2cxWLLTagdcFgPvwcXGkwtz7u2ZgYFgUaRs7m4j wUScFIx6qNsKgQPPBwtwB9A+bcBX0jYDy+OKT7BaLVYjJ/Kap6GwgP54zUuxW/91RyPcCk 9sJQc9wYYZdorHJ4eD1z6jjW1DvztYI= Received: by mail-lj1-f169.google.com with SMTP id 38308e7fff4ca-2da01cb187cso70166111fa.0 for ; Mon, 15 Apr 2024 20:51:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713239508; x=1713844308; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Sm7ZcmqODEDdlMVCkcEwyHPG5PSzL84rGETrzop4fyA=; b=EEkJQLzehEtypO0LNf+3M21jcNJOXzWmu7LXq+DVrw0OqZ8NEpqOoFvhTcz68oJozj ZlzRadpW2aMwuzkCjxsDMmglWsKUZxqosfK3YdeXa1gOQbXuN5ilhhhGnQUauaY1At/h 5Fh07UlC9bwHPhdHGnUzOncY9K7nzGRRp9bie03Obl0R2fJf61a8pHQE3Og6YSrTW+K/ R2EQSV3KmINtW3QfECwwbzxnCshmFGWpVRRiDB3Re82RhWBGkG2rNi9jpn8Djz6xCWZG v9NxE/zm5jSa+S8GmIqnUHKgRODSUFzpjOG51ihW3OY50CAbp1daPHRb7QmaLeMy50N1 RhtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713239508; x=1713844308; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Sm7ZcmqODEDdlMVCkcEwyHPG5PSzL84rGETrzop4fyA=; b=DgbWN4+9GgoaJxaz2JF5fLQwHo8JA6uGSranqGYqaglhNtwuF4ziJioXkCE69RkO48 RehmFSIwytFCrLROhxoufHTE9qFh/dUkRIpQa1yzUntlQyh/Ggb9CORnK+/rKhmkyUk5 iVLFC40QVYnVu6eQP3igReL5EVOlDzxMFpBLT1KmTLZ1vDS35qPQ9ZRU0sAsNEVJ+dos dwaZRwsTuTHjbz2BtdBVSisIh2v6rg8HGF8fFUGhDvsiWIq86VvT42PTooGIjbDpJH0/ 7q7QfbBHWeznnOUphKfML1LdSuJ729IAAlU/KVtTclCq1H9EydftKFdm0bmQMUN66pFR Z5pg== X-Gm-Message-State: AOJu0YzcBrLzEPIhopc0Dl0xebADMYXmM9YG+sDRJhh/8aFL14dTmYan VQ3v6wfXo8Il6L6J4GDbThnA9ABAfUjLezCPjAh2Gz/dBKqNXTngH4J/ZyCh44CUT1cMrPxRnrC k1W0Q0A6Z0rl0kcAkRCuMiWjo1/M= X-Google-Smtp-Source: AGHT+IGrxY0SZpf+F3z5NMZMRCHcrZyRK9yVeUmI1wjwLiaa3T1CHXHwm8tCk5xg6bHIUZbpUltsqPjqiqLA2RgMf/8= X-Received: by 2002:a2e:98d8:0:b0:2d7:121f:6b7 with SMTP id s24-20020a2e98d8000000b002d7121f06b7mr10287446ljj.38.1713239508017; Mon, 15 Apr 2024 20:51:48 -0700 (PDT) MIME-Version: 1.0 References: <20240415171857.19244-1-ryncsn@gmail.com> <20240415171857.19244-4-ryncsn@gmail.com> In-Reply-To: From: Kairui Song Date: Tue, 16 Apr 2024 11:51:31 +0800 Message-ID: Subject: Re: [PATCH v3 3/4] lib/xarray: introduce a new helper xas_get_order To: Matthew Wilcox Cc: linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: ixpqnurrg8rbdemw8q83768q4y8p17q7 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 24D8A120009 X-HE-Tag: 1713239509-185843 X-HE-Meta: U2FsdGVkX1+9QxAb70YuPKZST20NJZ4Szmya3E3eCqJ4IsSpvSnbxyotX4m0mkr6JogwFlomWyPLDzsjAYjFc+tcMV/+a5ZjV51pakFllQvrO4AS73vhs/XeVN4jo84Os+FA2TWG2SayAzpiV/ETEXNFqlcKKDDooRomWIGRdqEg8jwmohsrl8NyBKxtrEGJ0lEcj0lgoZytD7NqqN4gA1VyZsI9ANKB2ojjBMj2p8wvL2vZlCzXkqDx6aYl0FXlWtDFAM0jvtvK8HxeJpJukcP7oycbPXtRY+PywRpobCv1e4kT53KVqEAr2JIggB/a2iUEpZCqy1Zgtz+PQ5DjyaJQ8/0nvGl60Paeh8hxrfzMAchxsoXIvdgtKLUg5FZPTuxME30OU9RdXuSXCILS5ozpWHXeQyfDUP2S5UE4egTEyKpTVvsoYDZDFBjR3C1bMOaHxhcGvm6mufEwct6sLo9UEOcNUgXc1tyOfpt7ppRSBEIH4GNGyF9RxmPDjRkCinbpdoc5Qj0004AHJPG81NLQ4Xs2F9cw9v/ZKlvglOC9DSq2PJfylSFK7BHWezYtB84NJ4adtV/INI4vOnwnHXxsyP8BWsWmKiF8z5dRR52LvCjITccyW5qu0mzE/97e3dCr2TH82nUJ+ZIEQmO2CrtIh5kDOuMwK7SA7DXYQf+E4I5GMedNE0r1ZApyYOlQ4X5klArL27zrDNCK/Lq/wr0gFUHHW882QhSEioD9f38ygYTh90qdgyd5EQ6keZM7lqCpPcnXR8NfZCGHKFx+T5nGdCd/XKEhSKQa3kNAg1uhgOog5ZQzMxN1jIJ0IeiZq8/RcZ4nw3SSgOILGeTn7PSj6qn5OscQt0NN4MWKtVQMw1Zu7/P7TAPnEeahU1OGfvh/0aawVIM8EqbxU7a9PifxTY53dK0LeTLV8jmY6QRWs1hTvZAj60oxwyWPrPp/jnEtz2KlUkCB/h3lcfo iJbT5j8i Ky1EwrersuqKOMkZ8wILRC8+WJh5TkRQ4ayGeYMSLVzVYjsxvpujYzGGe28jVaG1hL76dEPG/3iAUUU4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 16, 2024 at 3:06=E2=80=AFAM Matthew Wilcox wrote: > > On Tue, Apr 16, 2024 at 01:18:55AM +0800, Kairui Song wrote: > > /** > > - * xa_get_order() - Get the order of an entry. > > - * @xa: XArray. > > - * @index: Index of the entry. > > + * xas_get_order() - Get the order of an loaded entry after xas_load. > > I'd just leave that as "Get the order of an entry." as it doesn't have > to be after calling xas_load(), it could be from any other operation > that moves xas. Also this is the short description! Good suggestion! > > > if (slot >=3D XA_CHUNK_SIZE) > > break; > > - if (!xa_is_sibling(xas.xa_node->slots[slot])) > > + if (!xa_is_sibling(xas->xa_node->slots[slot])) > > Could you fold in this change I have locally? > > - if (!xa_is_sibling(xas->xa_node->slots[slot])) > + if (!xa_is_sibling(xa_entry(xas.xa, xas.xa_node, slot))) > > That fixes a sparse warning which existed before your modifications. > OK.