From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45C4DC54FB9 for ; Tue, 21 Nov 2023 07:03:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE7986B043E; Tue, 21 Nov 2023 02:03:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B978A6B0442; Tue, 21 Nov 2023 02:03:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A86466B0451; Tue, 21 Nov 2023 02:03:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9A5996B043E for ; Tue, 21 Nov 2023 02:03:57 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 78A58A0908 for ; Tue, 21 Nov 2023 07:03:57 +0000 (UTC) X-FDA: 81481071714.26.5381341 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by imf26.hostedemail.com (Postfix) with ESMTP id 99443140009 for ; Tue, 21 Nov 2023 07:03:55 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=coOFG0iJ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.175 as permitted sender) smtp.mailfrom=ryncsn@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700550235; a=rsa-sha256; cv=none; b=IXwhluW91Xc43FkCg0KYqf6gT+T3ynx20JvMqx/4poS29yPo+xC0+aC+JNFp+qr7CtBh+e N6J8+mBRSQ+CXU/QvfMKRuI/zxCiCgrPEqCVZZSjgyihwfTBC6oIg6mEQXGZzs7rIH2pSK LeXnruxyDlSj4IrVrO/FO7Th5g3k9ns= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=coOFG0iJ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.175 as permitted sender) smtp.mailfrom=ryncsn@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700550235; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VOp3reY2bag6A9E6TpTlNAlJv0Ad2NbW094QK59DdBw=; b=w8PhJ0XmJMcz5Ril1yooiQOsczmxoQ+04x0t6E1kL+Qzpqg/hcg0cW4xN21/bwTTbS9eqE IiRGvaApTlXMIwnhBkmZz6faMA+gMP3XnqPDEZIXPcx2npx+mE7X4UUbcPKyRmM4PcfxAO LQwTTzfe4V3nwZZMeJhxEQJY+8kp88M= Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2c50906f941so70485751fa.2 for ; Mon, 20 Nov 2023 23:03:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700550234; x=1701155034; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VOp3reY2bag6A9E6TpTlNAlJv0Ad2NbW094QK59DdBw=; b=coOFG0iJpEATeT5YzCtp+GdXr/++QtYckH48S5JVc4bpjcvi3TjDbktqqZHs3Cs12c Noerszgu4MmeGn1u7iDUSAiytLQUGVl2IKM9PhUxOBXG2uwkIhJs4hzfR50nlW2xTj4n 32MD0l1RuH/kDAqtuaqVpjWAkB03wzdcTCCjmy/oDX00HnVEExcAHWl66cropaD8BN7d wpyGz0auMDkVWp9Fv3kBFAOFAy7mTv8sHhru3zQHkLNA/p55EyAIIg/XwakEob1IbWE5 C0xZwuyrsLJkI5U3o59tQSZ7Dw41FxuF7n0zqLawMiBEMg+56cLFrxF045ACRuSRPfT2 cNew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700550234; x=1701155034; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VOp3reY2bag6A9E6TpTlNAlJv0Ad2NbW094QK59DdBw=; b=TmHtCtr17zuxHJQnxhzlmGlgmhlM2JkVXOfL48P1WaSd3YZu/yND10H0xs64orpBd3 HaUuFIoXzYtm6f9JDdaGu1k3a0LTpg4uo7NtqaZ74RP0Y1CgxylK1rC6vb1ukYUwMGFo C23GOU/9Er6pOETJ3WUL6feAlIiHLYHiYTl5+//JB8wSgdhjAWyjONOrLFlhP71IOubc TnZ+6M7/I+7KKIeyYyvRz+7DEoOje6e6V7YWR27LgHX7JObcZf/yRbmYiYi16r+U3fE1 8p86oO8QBbiy0bba7k7gbLEpwmTy1v3Nn3h2afzJxZY7y49gDCJk+3AF046vR1uUr6wL OZGw== X-Gm-Message-State: AOJu0Yx+gyYU8fPDDVQjoR7nko3NrZgSUf4CCfePgM/frBkpkQLsLD57 7aKMZ+w1VZa0iwXP96Va/Q0br3uOgK3DVDfXNNw= X-Google-Smtp-Source: AGHT+IFeCq5NRHAVzCqCZaxA+wFlgaRv8aKB2Cp8sklzT3oed/MSHwYLFt5htutSECDvAkeG76R6UVPu9dW2BS5NO18= X-Received: by 2002:a2e:7307:0:b0:2c8:721c:6912 with SMTP id o7-20020a2e7307000000b002c8721c6912mr5890785ljc.37.1700550233662; Mon, 20 Nov 2023 23:03:53 -0800 (PST) MIME-Version: 1.0 References: <20231119194740.94101-1-ryncsn@gmail.com> <20231119194740.94101-8-ryncsn@gmail.com> In-Reply-To: From: Kairui Song Date: Tue, 21 Nov 2023 15:03:36 +0800 Message-ID: Subject: Re: [PATCH 07/24] mm/swap: move swap_count to header to be shared To: Chris Li Cc: linux-mm@kvack.org, Andrew Morton , "Huang, Ying" , David Hildenbrand , Hugh Dickins , Johannes Weiner , Matthew Wilcox , Michal Hocko , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 99443140009 X-Stat-Signature: hrmmk9dkk4r3jszsxbd6cgizsgpmkoxh X-HE-Tag: 1700550235-25175 X-HE-Meta: U2FsdGVkX19lX76J8RxtXgP8o6q8KBbdLYmfxUqPuaNff7+gxB/q9x3l6HlBjtqKjIFb4uLiwxjISgAOQS2vEzsiX6vVpxd5RBovU5Jk0p0RAFK/2xkVXgnwapxdIFjUzCZRrpQvX3cjmDnKi47uhzPJ4/fQVzegxe50/BYWb/yk6lJjNkeyuJu9QH/WmZtXSPLxxZV9dTSOj911LjygqpjUsHv5eMGo8RM4ASgyA+ozONHFCfXsIkUNbNnBfBdJcT7iV6z6tl36VU/7w107iWE2Pur28ZRrsu/5iecmBaAWNmqTdTrrm+Zh/E1G+mreM1gqKMHJlsjPa+aYJjAv9U8yYrB2TBiC6N/mND8NtpTo5bGe4Coi5qKRqxA6A3BsA5H+CkTjKMXaYk1jyphI+HuTQ3XNaophYCEBPwoHgVIBCUw0Avi2YgfPFRc4oIMLERAXvDeb9NdmMz8Jnxesec4UxrJSXxak9VWnninR7thYJ/rgXYTsHvIgC6XBIusp32peBaSi/2rd2ndqlbMNejRFTdOhxzizMY+yQ5V3ogF0+preehSdpHkyo9k+GO0OmGOlikZ+EzlMV+IxzPXbdsVvWvLZ8bqcU3CthhnFinsX1XtTgG73JB5pl4yIT5HAj1GVI3RnND3FuGubkx4yFVuNRLvP30yc+RJ9yjeWu2Sjvp63HLwLodQM5uRnM51ESmo7YNsLAafHuK5mYN10Gv086gWyxuT4l4iKVLzGtq04omdbCHd1AWm4UV0sdF7XUrzAjeEJZNSWXRTqLuaKasbEYDCJJjW6albzgkis1glMG404U5cIa6z31ySn2gs3+KR2GNOXbfqdq4dr7Mk+fAVdETJcPBKS48SVnmriGH6AK/0xuTLcM98PqwjVi4g+AGGhgDqdTe6qMwq7W/ccp8BAe/8DmLYX7G1NmioWP9Hr/hLeUjmkAjTW1rsEWZ+cKex/cIWvVAcSoWU8ZP9 bzy3b9hv AgsyLFaS60ecXN4+3+YNYzJtbw8/cZHUG6omZqvce+57Z1ASIU16HsV1cfZx8g34+28NzySkLyZ7bxdhbs/9+gXDUIH88f4E72ZnZ+7fIcH3LdIHSrS+AJYMS2+KYefJjonBi0zfvO8bKQbvWwzd1VXfoHYWJ0GwU+5IX2ObNzX5ymUo8cMr5xNEuLKcCXYevI8bjZCopjE3Ef7ZOEhSf7zqCq+38KuznODQf1wwrBDsi7QJP5WkkjVGXbDv+713SiZpzxNoYhmBMog/S67Ixb/he00yz5JLiVYWcrAknSbhVjYWlN94dS8bTK4HSygfkNa0CInRCq37zTvs8t6gnSkpVh7AGs3Mb865YoRjFRk9hKf0ZMuHNBhQikuj2PrEzUmlqmv26gHG5sRCjHwQBU6sfA7Vi6wQLtCBnPpAqx9H2JHkxkT29MPLRRMTpHqQ8nu8UuGTcJPfo4tkAKPh3fYkp7Mmuhz5PzWoYLGVaVSnnW/4DZgjlXKZ1BIrfFFZ027OaPlS15abeDs5fTrEsb0ObsZTtDfQ+puHa X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Chris Li =E4=BA=8E2023=E5=B9=B411=E6=9C=8821=E6=97=A5= =E5=91=A8=E4=BA=8C 14:52=E5=86=99=E9=81=93=EF=BC=9A > > Hi Kairui, > > On Sun, Nov 19, 2023 at 11:48=E2=80=AFAM Kairui Song w= rote: > > > > From: Kairui Song > > > > No feature change, prepare for later commits. > > Again, I don't see the value of having this as a stand alone patch. > If one of the later patches needs to use this function as external > rather than static, move it with the patch that uses it. From the > reviewing point of view, it is unnecessary overhead to cross reference > different patches in order to figure out why it is moved. Good suggestion, I do this locally for easier rebase & conflict resolving, will get rid of these little parts next time. > > Chris > > > > > Signed-off-by: Kairui Song > > --- > > mm/swap.h | 5 +++++ > > mm/swapfile.c | 5 ----- > > 2 files changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/mm/swap.h b/mm/swap.h > > index f82d43d7b52a..a9a654af791e 100644 > > --- a/mm/swap.h > > +++ b/mm/swap.h > > @@ -61,6 +61,11 @@ static inline unsigned int folio_swap_flags(struct f= olio *folio) > > { > > return page_swap_info(&folio->page)->flags; > > } > > + > > +static inline unsigned char swap_count(unsigned char ent) > > +{ > > + return ent & ~SWAP_HAS_CACHE; /* may include COUNT_CONTINUED fl= ag */ > > +} > > #else /* CONFIG_SWAP */ > > struct swap_iocb; > > static inline void swap_readpage(struct page *page, bool do_poll, > > diff --git a/mm/swapfile.c b/mm/swapfile.c > > index 0142bfc71b81..a8ae472ed2b6 100644 > > --- a/mm/swapfile.c > > +++ b/mm/swapfile.c > > @@ -114,11 +114,6 @@ static struct swap_info_struct *swap_type_to_swap_= info(int type) > > return READ_ONCE(swap_info[type]); /* rcu_dereference() */ > > } > > > > -static inline unsigned char swap_count(unsigned char ent) > > -{ > > - return ent & ~SWAP_HAS_CACHE; /* may include COUNT_CONTINUED = flag */ > > -} > > - > > /* Reclaim the swap entry anyway if possible */ > > #define TTRS_ANYWAY 0x1 > > /* > > -- > > 2.42.0 > > > >