From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EFD6C3DA79 for ; Mon, 15 Jan 2024 17:11:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E67326B0075; Mon, 15 Jan 2024 12:11:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E16836B0078; Mon, 15 Jan 2024 12:11:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CDFC36B007B; Mon, 15 Jan 2024 12:11:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C038C6B0075 for ; Mon, 15 Jan 2024 12:11:41 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6E49040525 for ; Mon, 15 Jan 2024 17:11:41 +0000 (UTC) X-FDA: 81682187202.01.14B128C Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by imf25.hostedemail.com (Postfix) with ESMTP id 58FDAA0023 for ; Mon, 15 Jan 2024 17:11:39 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=gqFSQUOC; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.174 as permitted sender) smtp.mailfrom=ryncsn@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705338699; a=rsa-sha256; cv=none; b=xUcU6Fq7CP9cbDaLCQwQDv0PT712JOwANS+3YHhaqK10MpslEkc2CpWHYapxCfDrd5cP4K iwPng8QmDE5tTnTc2Mbrafxeb84+YMDl/buqrl5FgYh0IcncZNIWlu8bY/MPxgxhD6go8G Bpo6VOnUcUWhuf/I1wRlZPohg/c9+EE= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=gqFSQUOC; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.174 as permitted sender) smtp.mailfrom=ryncsn@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705338699; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IqN1HXQI0vB7XDw+H37JNuIh2GbV9Tph7FvOP9587hA=; b=Uf+ShY/VqbF79BXhwcs7V1nGt37zlYmI+v/UQ5+X+r4VI6QaOd4wL0GR1DbFEJpC+WB9YL bDC/g0nN+Aylmp+nQ84HETmbBUZtehoWLzmxeVsj7iB6b8aomvFC58tflnityNgA1Gw7xk 4RPmYAltq5+YxTud1xib4uDWlhZZNFU= Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-2cd0db24e03so102430441fa.3 for ; Mon, 15 Jan 2024 09:11:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705338698; x=1705943498; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=IqN1HXQI0vB7XDw+H37JNuIh2GbV9Tph7FvOP9587hA=; b=gqFSQUOCmWdRiLS+y+c4rUb3raPsegzp3vsiAnFOvU2A75nmk36bIYDhvlYpqOhfcE j5mI3eGJRy7O2FqTP3N18i2AXbYGhJjpfd6km+4EL7ht5iR/5ZhNu6FpP09wbjlxpYrk DMZ8y8y/ozUuFNDnbUNb+dMr8cWlMyUF31CCj9Q6EEBpa4fQivtxF5C+oqeTC0plZHmI MGnum4nvoF1WnZd52jNmfauQwtT/icMXgY+8b0SMLTkSfRvCJJzDC1CCAzHgy1SqclmF 3F7qI40LtWqmXgho9hlHZ5oCHcZ96GO3ERSwYw2mwvuV3PfUAiNUydmH8ImksJHldF9Q O0Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705338698; x=1705943498; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IqN1HXQI0vB7XDw+H37JNuIh2GbV9Tph7FvOP9587hA=; b=MNyZKF3KF7hs+L2eOb1pBziCS622B4uoV80OpFwb1LwbKLpmTkh5RKdklQGo228FZJ 4u3PihavGoDwT+C6xMhgVDHDuoV5AvRURAOU4L9m1bf9+2Ut/zJ82heGnv0GG0T1tyu+ 7gR3iIkOe7Sfw0J5fsvaUoazTghVmvNhjXmZnTOTFlsYtA2X2aMoBWyFgKTcSgYHy2+F cLsLrKDcM1I/lhi5kGNiPIyKQq6ErNqN55CWyBHUJlUlBpNCl8Gi2UpqXIjB0mEnhYzQ b/0JY1pVIM+PWewf/IOwF37lZhDe+mVtMB/9r9NgVou8ttbanUxdPrk7eQ7AXbNK8jNW rp4w== X-Gm-Message-State: AOJu0Yzhu2Rwp8qBj4Hz0EkQlB7l5bYmETfmlTPMLLivu7COSo8SwHV9 y5Es/Y+K0HMxznSHJivS7f1UKb1ls1rcGEZZSF8= X-Google-Smtp-Source: AGHT+IGlpmbMQuPBilgG6GN7fTDb4D57XTy6h2ucDyxAnRhFvZyEVIOSP/T/tlkXZXjnDy2lNOIc6ac0PIVq5yaMWjQ= X-Received: by 2002:a2e:9e97:0:b0:2cc:606b:fcfd with SMTP id f23-20020a2e9e97000000b002cc606bfcfdmr1229911ljk.167.1705338697681; Mon, 15 Jan 2024 09:11:37 -0800 (PST) MIME-Version: 1.0 References: <20240102175338.62012-1-ryncsn@gmail.com> <20240102175338.62012-7-ryncsn@gmail.com> <87a5pg9qno.fsf@yhuang6-desk2.ccr.corp.intel.com> <87wmsb1ia8.fsf@yhuang6-desk2.ccr.corp.intel.com> In-Reply-To: <87wmsb1ia8.fsf@yhuang6-desk2.ccr.corp.intel.com> From: Kairui Song Date: Tue, 16 Jan 2024 01:11:20 +0800 Message-ID: Subject: Re: [PATCH v2 6/9] mm/swap: handle swapcache lookup in swapin_entry To: "Huang, Ying" Cc: linux-mm@kvack.org, Andrew Morton , Chris Li , Hugh Dickins , Johannes Weiner , Matthew Wilcox , Michal Hocko , Yosry Ahmed , David Hildenbrand , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 58FDAA0023 X-Stat-Signature: wsgrqcd9tpz7gjj9aymghzrf495hxcjq X-HE-Tag: 1705338699-425677 X-HE-Meta: U2FsdGVkX1/PKjlJ3R0EGBHZIYMriHTru1yEtpB0qs0H/7TU1RwHzB7sxh+guqSe2kCdSrCiO+f5U6k6frRfigD3EuthrXS4n/ghwVfYzYJUtec35p3G3Rf5LSdpVZIeAopAMGi4L3G4rU+++30seD8p0MwnPyIRbJb/rgSxoj0aC88+x8rdMiri3hKeiEpLYjZVSH3458l+iu+7AJkgcihVCZW72lnHp86y4s3gnIAmG2Aqm3BJGpvucGd5PAQhQFsFSLBcbkMJia6sf+eAsqGqOguNJ4c7KxVHh8cSPPqZ4QXdZsUCz2OwUytCG8a+4+E1oSWkg0omlptaL0BIPKAYIIa+9vn+2EZfFWvyvHvxx0KkgZS3S9tZG1sX4mxGZC76nPiydzLxJJkM2TAHolYy7Xn+eTUWP8F1nXsQkn3r4wMDy2kmKH9udfgyW2nGlOF2hf06RVb8/HNOt0u00scIHqfYIpXKMqKN8MzQM1kAC5MS484k2U5624Sq/7jIaf+JMuq/Bll8zYy9zKW2mC7ig+QwMTYK8uFYM9atmKkiwgfwpCAy1NcbK4GslV9q2seMPXajdAz8mQlLymdNzMyLk65fH+KCn9CgxpSSx5ien6i8OEZ6L2/3qT2C5RC22pSSQbGpfF0JFMUedP90sdmPQWcZDW3gpjDx+hqwk+xsW2vSNJpAOIYa8yhCarWntyhfU9vGBCA6BPGycu9hUSel6TsNAdKAYEFV2KtpoiqEZVgrfTa6ybc6X4NNOxgLVj8j/Me4iosjAz1Mn7sC6YBO/U6u2QhTcVSoF/HoW74BJCHOH4BB7ABN0a0+32bFWqFVOSK7iXOvwawNyAybvQ6U8rII7hVHW0RrWpE6Z+xHDHdXg1kILHhjrUn6VBToBVFXBeJ6V1WoLFDRmva7QmaD4Pp6DLhAps/ysJdW1VEfPwXy6ZZUaIs75iAog5B0DvcQVvrJl7oTRDQYSbG hRlJNhmH Qd5nPb1zeoT8D8Aq3ZLk0YkN54Obc74L4kQbWxcMEF/UIXeauKl4GJRuUpd3nk6GhrVzPImBtNjptUs/0A+eu1VyFgtp3Upoy/4qs3t8Jlqfp1e4Kp1N33d+c352ewViUYX5E2dgi4wa5JPp8WiiLYwukdlWr5HQ/wkwFrvFK/lahGjGrG/z4V99kFqpoand9FbQ/rzib06MrWpuCDZx4I1PmZXIpoywB8osjC8ee4X8xdUaqZvzB6NLZsuwthkKGHnqZljbm2w/eFyE38KXqvDyMZrZDS7kKOMJ8rHYuW3+biG8I/H5nla3jb7LY7LIWn4A/JPe+/kxR7s2WM0Apm/GZlswgSKRTZEpGGluVfJANzKTpo0UiImRHaWx71rv5J0YATL1OAD7Kj9siOD00WXoB/PSntnSziZXNvI3EBU0kv79u8cwFq7U+UlsGqHdzvLS03MIG8uLKV+mzhUBfSs+V5cVPxawwE0z4IuZ9KV4JsYXTEbGAsqPxa2acu+70ICc7tc5jZauucV9nLpUUOkJPIxbm2jIAHRlg44t870i/h3KxoIKdFc70gA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Huang, Ying =E4=BA=8E2024=E5=B9=B41=E6=9C=8815=E6=97= =A5=E5=91=A8=E4=B8=80 09:47=E5=86=99=E9=81=93=EF=BC=9A > > Kairui Song writes: > > > Huang, Ying =E4=BA=8E2024=E5=B9=B41=E6=9C=888=E6= =97=A5=E5=91=A8=E4=B8=80 16:28=E5=86=99=E9=81=93=EF=BC=9A > >> > >> Kairui Song writes: > >> > >> > From: Kairui Song > >> > > >> > Since all callers of swapin_entry need to check the swap cache first= , we > >> > can merge this common routine into swapin_entry, so it can be shared= and > >> > optimized later. > >> > > >> > Also introduce a enum to better represent possible swap cache usage,= and > >> > add some comments about it, make the usage of swap cache easier to > >> > understand. > >> > >> I don't find any benefit to do this. The code line number isn't > >> reduced. The concept of swap cache isn't hided either. > > > > Hi Ying > > > > Thanks for the comments. > > > > Maybe I should squash this with the following commit? The following > > commit want to do cache lookup in swapin_entry to avoid a redundant > > shadow lookup, it can help to improve the performance by about 4% for > > swapin path. > > It's good to improve performance. But I don't think we must put > swap_cache_get_folio() in swapin_entry() to do that. We can just get > "shadow" from swap_cache_get_folio() and pass it to swapin_entry(). Good idea. My only concern is, if the argument list is getting too long (7 args if we added all mpol, ilx, shadow here), will that cause issue for readability or performance?