From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C288C54E76 for ; Mon, 20 Nov 2023 11:15:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 324A26B043B; Mon, 20 Nov 2023 06:15:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2ACAF6B043C; Mon, 20 Nov 2023 06:15:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 126626B043D; Mon, 20 Nov 2023 06:15:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id ED6916B043B for ; Mon, 20 Nov 2023 06:15:04 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id AC66B120888 for ; Mon, 20 Nov 2023 11:15:04 +0000 (UTC) X-FDA: 81478075728.21.EE3ED1E Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) by imf27.hostedemail.com (Postfix) with ESMTP id C577C40017 for ; Mon, 20 Nov 2023 11:15:02 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Ift7iP9D; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.176 as permitted sender) smtp.mailfrom=ryncsn@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700478902; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=K8vipKU/tRzejLbedW+j/59TWOsRAP5UuAA6FEDfq9U=; b=lmQ6gKgUjf0vVC0VOJ7VxMv9JcvT2QXXylQx4ikEeJ9uR8ejlQa5cgyW2PYocu1euF9ek/ X3Rc0RE/6Kvdez9Tvq8tuaMdI6Kzem0qXg9FZke2x7uV8MtEeIXtTK5gCLDJRbbsoOCxt8 7DdDG8rb4cAe12Rf0K2fQl73yI00Tpk= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Ift7iP9D; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.176 as permitted sender) smtp.mailfrom=ryncsn@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700478902; a=rsa-sha256; cv=none; b=xFGAZTPhRr910Dj4nuzORqtJNkpnffmEDWetXkZAy1G/TiFj4qzi7KomsBMtgkyHJOnRXt b2WrRemffu0p3fGN/U3HPSCp01Xn6XQpPOGjGkTPxy79LFTGS0NQRClkRl9yPzCmEhv5N3 ekvOKbuxvHtUVoWG8yRrw2xhEG1XsYk= Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-2c8880fbb33so305791fa.0 for ; Mon, 20 Nov 2023 03:15:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700478901; x=1701083701; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=K8vipKU/tRzejLbedW+j/59TWOsRAP5UuAA6FEDfq9U=; b=Ift7iP9Ddl6aYUDxpPeZXzlNixRw+g4cNoausS0+ayEKqScRhkHn7l/Yxfp8wJ9qYU WSXtIJYsINk+NirNUFayXA4JLKjn4wBFPX2uOF/wSsSieREj3O7wabUbO/nqk+MK4gef 7Am3r859BAbJANmo6AlpEwXWSLPwiFef9H+uRcwtVdFfD1l9Sjs5Tzvzd4Elm+ZRpfoO BDVpPj5Ms+/+vSpb/juETh8rElCkB/cFCc+aF++g74NN9r9O8PojhwZH/x0nav9lC3A/ bMWZ02Opf4eFPDpSW4bLFbN6gfvBvA8bF4WgYkJDpalLQqVJeDLBN5ZFpl1C6P8gGAN2 4FrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700478901; x=1701083701; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K8vipKU/tRzejLbedW+j/59TWOsRAP5UuAA6FEDfq9U=; b=hypCMowDAcJxbfYmUd3RIAftZRBr55NNh9MId7ws/XkAZb8j+kndPYJgfqvDksVSt7 Ie/LRWW61xc2TyG+RVdEH5dZqTmC+2LcJfGZ2zlLzVS5vEHCbdkd9IESD28+FcQ2+oNo +brZBC8JWKEa7wIuhX+j4WzOTGCta6eGQTathYziOdRfEC3NQpOQLjO/UVmdQ8Q2dJ/H is1gMAyigYSGq7NkcSXeaZ0ClTu5lRuxIgmxbq7s9FD1In+vzZLi2Q8X+3BGUQWjscck vKECSAPMEn0kbpgVtPmQ5A889cLmr0hJOSFnIi5ic9fq3WlsKTk9UDQbE1nLUGBPM0sA l8Tg== X-Gm-Message-State: AOJu0Yxp0faK78BlIH1WbYEeKi8kXAyJRUUqzcYAdOY5yxjDKLgHpf5c PVNWDw2SlJBxZCa3f2PxVDWoXubL7PmdjYdDa0c= X-Google-Smtp-Source: AGHT+IEjlD/Fc2y5vKhdps+4ygOi3gQc2izP3YexgPJBkpav4zKlgl5VJRx2mf4jas6iyYu4TMyMwi2fwQv+RMPPf7g= X-Received: by 2002:a2e:7307:0:b0:2c8:721c:6912 with SMTP id o7-20020a2e7307000000b002c8721c6912mr4184743ljc.37.1700478900861; Mon, 20 Nov 2023 03:15:00 -0800 (PST) MIME-Version: 1.0 References: <20231119194740.94101-1-ryncsn@gmail.com> <20231119194740.94101-17-ryncsn@gmail.com> In-Reply-To: From: Kairui Song Date: Mon, 20 Nov 2023 19:14:42 +0800 Message-ID: Subject: Re: [PATCH 16/24] mm/swap: reduce scope of get_swap_device in swapin path To: Matthew Wilcox Cc: linux-mm@kvack.org, Andrew Morton , "Huang, Ying" , David Hildenbrand , Hugh Dickins , Johannes Weiner , Michal Hocko , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: C577C40017 X-Stat-Signature: 6eaj5pq9q63qinsbkbxuyy7ehqxrjd4c X-Rspam-User: X-HE-Tag: 1700478902-438460 X-HE-Meta: U2FsdGVkX1++dlVjVy5N184vFs9GLHjw31mJ+FGJ6BmTx/2P2j1C//o7HNMIWRdelWpbXoaxfNGvlozg1/dI7ejYAOcnu3ED5aQ94JM/Z68cagUwjqrhbmrIRwKbJZYDkUCgP+6cdmKGfC/ISUaJqth5Up13FgUKu4e74byBpwB/dwsCEuimp4Fv1f+3KTKf6P6zTJAosqHz5pIbtYURhg+VKAtSAdT3VrA8WkjDm5HLwmJpSwqz8AeU1f2uf9seZmRcA1WRxqP8Qt5ZKO95ZE15LevnBywYpM5YbKJ1VPHOWSRCyAn9PH2kzGsrsfCNvtFYCm0nM77D+5415gGNYxi3Jr2gbjcdk75L8vYdhHmKlae4+64/8J7xeuxZI+LSoaHaWjJPI14ExKX2d+fW3c3Stjr3WqQL3QT7RhF4lWRjr19LSudm/ywLVwJXsr8NVet4h1KOQ2/S852IwOGpHQnaM3uJ7ZTzvGJRJs3UHn7lercvxwipam9mQoqytVCwhzz21l7ESc3JhNYJ5B3kURpfa8qEzPQ5K0E8V97MXDioG9CohsbhUVjv6Z01kfggr3jFHjgamXw+Yspy4+7z7pKue7217K3Jkm5+XUR0aFSFojzFmmeEFzYfYarvdc7xzt+FV2kVn6vQUIfh9X6DUMDW3NLlHoyf5FUKEvj1hGHY/wNBt59QnAc72qwQJPiwMreaXMOQ6fiJUl1pbculLcpdKKZ45HQ2MeyV5v2OpXXwQnWYG2CKUsNDZYLLBIQICCerqUws5vqKGmFe2rexiN3wbKEEN0EkeZttkB0Su2dF2FCZEnj0k67bN+EvZpD8LVXkMJNKg/r+F6/XKTjKxBaLRZFHOSqIRRLYW/gTmhpXBJXfEg4OlSeasOdKePu0M/XLYvGX2AqREq3AgMpniM1Q9pYBd1Z5FvQMdsWnBxRtKb6LZQFmp7lHxd9VS451q/7qNIPDAYPw0Cod+U7 PUxoTFWI IiBvj/FauHBjUIdL2/qUoV7SvptG6j+NbDsTznZqtuS+D0Vv1hgTceyTnpgCmmVRpZeMGGPHeA904W/JNY6X7HdjNe+ORV9tqPvZNWwY8AXyWYbUlHLO13TFUlLI+QoSTLrZYKAKxul0IIkFl6KKbJYpahaPtyUpQ5QE4sshreeNE//seGQ4zKLgFxek6eFCWftzt8/ADWQNsE5GYjKx4UDeQVG0EnWDxFHlFBVvSYGAkW6GL0M/dLAqNcYbKDHKU6qhtGl7nzq0r6pCQWEsIAlIn+CLmhP2PgVxfixEsEmSOPXbismHlVG96ROSrw1ZSKob/UIfDxoScqLn7HVGMUZZAzym/MCNM3le7Z/6QA8eC8m3IMyRflqX8YrxaXlQs2FVsTNALTh8e4fkVrmv0lyA5AdX5QRQ6NBLiggZE9kUvTDUqojWVphFbR/VroxfpIsVSwvtmYHJThkg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Matthew Wilcox =E4=BA=8E2023=E5=B9=B411=E6=9C=8820=E6= =97=A5=E5=91=A8=E4=B8=80 05:12=E5=86=99=E9=81=93=EF=BC=9A > > On Mon, Nov 20, 2023 at 03:47:32AM +0800, Kairui Song wrote: > > page =3D swapin_readahead(entry, GFP_HIGHUSER_MOVABLE, > > vmf, &cache_result); > > - if (page) { > > + if (PTR_ERR(page) =3D=3D -EBUSY) { > > if (page =3D=3D ERR_PTR(-EBUSY)) { > Thanks, I'll fix this.