From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62508C54E90 for ; Sun, 25 May 2025 17:05:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 54BC66B007B; Sun, 25 May 2025 13:05:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4FCB16B0083; Sun, 25 May 2025 13:05:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3EB916B0085; Sun, 25 May 2025 13:05:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2038A6B007B for ; Sun, 25 May 2025 13:05:32 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 7C1E01A05FF for ; Sun, 25 May 2025 17:05:31 +0000 (UTC) X-FDA: 83482056462.18.D19975A Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) by imf08.hostedemail.com (Postfix) with ESMTP id 89305160005 for ; Sun, 25 May 2025 17:05:29 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=gpNjvtNm; spf=pass (imf08.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.172 as permitted sender) smtp.mailfrom=ryncsn@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748192729; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=L+MfSMNrhNlLP1WSYirVqpAIv2MNb4VocAlZZ/In95A=; b=BlAK74Q/41rTXSt6gi3MkI6d/CNpWPTTlD7kJu3kE1kNAHWZsh+WXYtXpj7OuhkKt8XvxU C7fSZUsYhZ9rWVdf9s+cx9pPTPibDaDuNcOWphLqGa+a8CnXd22xKJTntOkvZFSJQssAHT WRm32eOrtX23PMQsY3XpVpEJceCJsjY= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=gpNjvtNm; spf=pass (imf08.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.172 as permitted sender) smtp.mailfrom=ryncsn@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748192729; a=rsa-sha256; cv=none; b=si+0aX6yCFRzzRW2KgJCHQGDVDct59GfGg4iuOhToqrmXYwcNvUduMu1qjjVREhfxWBq5a zztMhqAS55m8VMtIbjou07R+K2j8L2QbObKP2mBMdjtvCU/jEKCj6r9Or0h4CI7pz/hkgH ZN1WA/Trx1xyRJQCy2JMKeAv/aUXjes= Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-327ff195303so13263521fa.1 for ; Sun, 25 May 2025 10:05:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748192728; x=1748797528; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=L+MfSMNrhNlLP1WSYirVqpAIv2MNb4VocAlZZ/In95A=; b=gpNjvtNma6cZ4xDRO6u0lpjxEQbA3+Fl379nJAqlHGLSl93MCcQD2++muYoiReiGYM RBtvYz+hWRASWjMeH+pR70lQMaBNizzEaDyWRVLQ7YBCKw2wEirzLoWGlm8nuFXnfAex mZEn7eto67QrbRyfEsei4sKlaYmR/c5RFU8y3PcpiIkgFSHgsoKN/W8xhZaOdOaTMNVq I/wmfACPLBBj6KNfGxMWS54mdhS2RLla1Gih1EZ1f9gVjYzGSQTRtSmJq42Rk3Lv7Bfq 4YekOGYUZJ0BByRotZ8CXFO46h9XUkcQLrrHSPy+QL+rm057xP44aWj9UWkX17na41TP SBdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748192728; x=1748797528; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=L+MfSMNrhNlLP1WSYirVqpAIv2MNb4VocAlZZ/In95A=; b=RdR2om6L0rTc0yNbNw+Nq+3tWxgH7xU+CKJDy4Ot622y8QZ1lT+/A3sdzjOI9BD0Ji DfnQWppFEwpDzk4b2zSuNMImpmniLTXGsi/nKjiE6wZgdPosdH3dQ/BG516tzc9xBCoS nLcQnw9n15CoIWrF0A3+D/9B0NDxfqYRK/KvzBSZet/f+vvzP3s5jkdE4jcpcUw6qYe5 sPn2jSWIXxYV3msE80g3huOghjshN0bxpfLS2O1DV6QRuMHVnRrvfmyX5etzr8F1AOh6 knmYxKcCUyP3qwusfESXID5o2x+khT1J6mQUZkRLHGjMSObtiCIGzLR2DFLwnRPWD4Ir J+Vw== X-Forwarded-Encrypted: i=1; AJvYcCUdiVdX3C/hj8EQDblAmWlUkpqZ2W+5sHjGcKyhH2nUD9lhnGwNCY5vAVkI1a1TRLmaxlw2iGuw1w==@kvack.org X-Gm-Message-State: AOJu0YyBiUTwH5D1N4LsESPV2lE9zXZ5YSi8OLe4YFYB84DAS7Lie3QN SR+vpRY6Tb8yZ0MpMhSsidcSH3zItYosSkG77JCyZHhIVfaxM2J9WFLfk0X3UVgtKPnVVcydz4O P4yI/VedQ17ofhl5ExozM8pH9lRHvjZo= X-Gm-Gg: ASbGncvqfEJKQZa20P7mG+ADYKSPuPuXgNe8tfygF8sqsTaf9X+sdnf9D5pX3oERh82 hy/VRzaPbp+bJh5/oRTJtQGuEUuZJ3iRyNlwbdFRP+IXLlw1612BcjObKKsx+EoYQgreNA3kWGd bN9LGZFRReYjq6tGTKZ4S4Tgd0dqFpgphW X-Google-Smtp-Source: AGHT+IH9QHwsiG/ZrFzq/XHsMtKha6acNdy3B0v+jXhvL1duuHwN6uPVX1AfjbhmBKx05HSISnLK/ASEylj8z5YHFe0= X-Received: by 2002:a05:651c:198d:b0:329:17b0:f45c with SMTP id 38308e7fff4ca-3295badab0cmr19062641fa.29.1748192727311; Sun, 25 May 2025 10:05:27 -0700 (PDT) MIME-Version: 1.0 References: <20250522122554.12209-1-shikemeng@huaweicloud.com> <20250522122554.12209-5-shikemeng@huaweicloud.com> In-Reply-To: <20250522122554.12209-5-shikemeng@huaweicloud.com> From: Kairui Song Date: Mon, 26 May 2025 01:05:07 +0800 X-Gm-Features: AX0GCFs-YwPHykSN0mFdg3ysDg1OoLUVF-2jMtGLhl8BnRxZ_1WtUCwIg3JU8b4 Message-ID: Subject: Re: [PATCH 4/4] mm: swap: remove stale comment stale comment in cluster_alloc_swap_entry() To: Kemeng Shi Cc: akpm@linux-foundation.org, bhe@redhat.com, hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: fouxi71g8ebe6wumopbxj4kar164ii9o X-Rspamd-Queue-Id: 89305160005 X-Rspamd-Server: rspam11 X-HE-Tag: 1748192729-573246 X-HE-Meta: U2FsdGVkX1+AVrPn63rfhMoBeC1hd75dQVB3wtD5K/1KmyejPrfUJm3wdgMpvrFvy1XG63Ic4TXCVwnoUb/kRPR49ogPiH5c0ZsMK7aVkLyLU9FJGFbJTGWOa0dFs0tKLdmOKVKk1g0Vf4POdZsBEUp5LqJNHDKA+JOddpjFTIcCw3K10NSugueUDNxfw9adz8Y5FJuqOsJdKtsl0Ed+yCPt2hz6g2TXf+RvTTkC92cJRnMhawIY3GpEuL7izl5cfKnEBJdN8m2HsNy2WG1UcnQIBxLhbbaXOIDJcf6Z54kEdIwM5skvSYEKJwncwWkLa65Nl3OlHO4P1LToHLFXpFBwnJKZFeu6a3i8fT/iopzcSE4u47aDGHKYjiftLrjfF3fMvo/u2+eKZgo0E+hKZSIHNvIfhF9J+uL9HHy0gfRSLiCw2kWDbtnr+tdqhwdk3R+hL35vP1Gjmk5gAMd4PlnSlP3tPJoEyBu4CSkkuFwEfDOSkN4GsCklybglbN9rVh6aPBTnhQ3AyWUsl7tO9TOfqaXQlXqOVJArdmw+ENp7itVKN1LrfFvYX4ve9A5pJmW2iTymEUlEdyl8ZRYWFS72hrglrxjmJNrKE/cEGi7Jn0m7WgYlABPTn2oj8X6l5knzonKw1Te61U6fMduwxvb5LiIa6xNavy8H+V/CZBvWi9Pt03ljTd8mE6LO/6v0mChSc7knoi9fw7VTunfZ6gy0PBjCbzmO27c3RmdLUKE48ecoKLrnmKIR98iOu3u5me7WdSdcmjVGoWTX6BwIntWxzoC1YWZxLDPub72OLDQ0mT+xfCQ9lmFHURb7/hHaTzgbYWTuFq+Ht+DtvdyKDqRdSIcsMvPHKyO6Uh7ixv7mJmCCUzryJel0vgVNE3DHqfqBGxw9IoMWCHrEe+rVgXxK+W8qEWoa4jQwlelrz/lojzoEbvCrtF3SO4hGx8sPjMUmCeZ/3L/y9VNCyHD 4RXS8Ou0 0pHfjBEP1bfkyDBX9hW2Ck2SOAr3W5WYJnyaTXPiCsxX64pCCApB0EBt9QHwEI2MnPfE9tEkYUcNPmYQoRyMzztc4hzw9bXFkvenVCJcrmMGr6sry6YqAdBSGCIg+ZSmxyN9yTPrbP4MlonWf7Pdz4OxxkDycPDsrdmU3iXgy77wqQ3j8oIks8M2xlzB3Jrpv31gX9EU+gEITFd9y4mzN3860ojfjMSpF1J9vRsXF6h43SbYz66h+fPVp5NZofTvKo0jh3nZeq/bPypi0kIe8+gJoKXNed4qg5kaPz/KBf7eUVWxMVLK9ZMnl1lZhmv/ZOdteP42/9c5+jsSARwZonccVAX/hmSy+UsG2CCtLCc5eZEbl08b/vF5t7MvNvw4uhYOADYHci9HVRd7UzJUd6+2ID0YGP916za5U X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 22, 2025 at 11:32=E2=80=AFAM Kemeng Shi wrote: > > As cluster_next_cpu was already dropped, the associated comment is stale > now. > > Signed-off-by: Kemeng Shi > --- > mm/swapfile.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/mm/swapfile.c b/mm/swapfile.c > index 63ab9f14b2c6..8525515fb06c 100644 > --- a/mm/swapfile.c > +++ b/mm/swapfile.c > @@ -956,9 +956,8 @@ static unsigned long cluster_alloc_swap_entry(struct = swap_info_struct *si, int o > } > > /* > - * We don't have free cluster but have some clusters in > - * discarding, do discard now and reclaim them, then > - * reread cluster_next_cpu since we dropped si->lock > + * We don't have free cluster but have some clusters in discardin= g, > + * do discard now and reclaim them. > */ > if ((si->flags & SWP_PAGE_DISCARD) && swap_do_scheduled_discard(s= i)) > goto new_cluster; > -- > 2.30.0 > Nice. Reviewed-by: Kairui Song