From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87A20E6C619 for ; Tue, 3 Dec 2024 08:26:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 263C36B0085; Tue, 3 Dec 2024 03:26:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1EC3F6B0088; Tue, 3 Dec 2024 03:26:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B4366B0089; Tue, 3 Dec 2024 03:26:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DE25E6B0085 for ; Tue, 3 Dec 2024 03:26:17 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4C7101607AC for ; Tue, 3 Dec 2024 08:26:17 +0000 (UTC) X-FDA: 82852964796.09.3C7296F Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) by imf20.hostedemail.com (Postfix) with ESMTP id 53C1A1C0002 for ; Tue, 3 Dec 2024 08:26:01 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Ic8W4Mdu; spf=pass (imf20.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.170 as permitted sender) smtp.mailfrom=ryncsn@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733214369; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jf5I3RuoC20RN0IsV/jbFVx4wBkXAmSkQkbAnkDREIg=; b=UoqQ2bh6A/qoqQApLbjmnuOeuz9/CQFzG5FD42B4gcRiVq7RximNq+uaZMkpgmpwoKhU3V 74FhMONfiPOt082eRoFCSxpK0xxkMiojLSNEgKcGorKX2N9Mylbr5GUYdVUxppl6jk0TSM fky2PiSjRnfjeg1DvhPc0plgC9XaLNk= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Ic8W4Mdu; spf=pass (imf20.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.170 as permitted sender) smtp.mailfrom=ryncsn@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733214369; a=rsa-sha256; cv=none; b=ZuLDE/gM2x3DrxTdJSDT/f8DzXCzZ0xLX+LiN2a9JU7EVs5cV1IQYjrZSDh7gqT8S/q+tM hsZ2MZhdqgWb5VAn4LAVeGT5yttL3yMqjnEt000iLmYtQpKopG2AQRFqFFlKsp+xadaLaP rZ9OWZvor2POtbhNSJWZoXW6ad8MPcI= Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-2ffb0bbe9c8so59955201fa.0 for ; Tue, 03 Dec 2024 00:26:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733214373; x=1733819173; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=jf5I3RuoC20RN0IsV/jbFVx4wBkXAmSkQkbAnkDREIg=; b=Ic8W4MduAZ3X+EgceLoSQdlLleFzQr2c6mqiPpt99JKEMZSuP1XwIYARbVZ/0uzUhb XAJIRfh3ayWqmDpUFJM58yB+aDLdxxFCiLSEOo00WJ8eI+GvOzrL6KbK2EjqztImXw7G 3ZtLcDtzO2mj2/BxRjJDsKbiFvOelH8jit1BaoO2WoW0MYWL3n06CPPTQ2hc8psj6zKf AGB2pAxZHedgrYOGR1+JCneX0CGosaT/1LV03quUFd/0QHKm8yFwd+yZBaAj+VDF8Irg o5pGo98BYvAdbVCd9pnGIsFz5Ec/ZviT1qPTMsnelkx0lIytAOnieRjDOoWWR7t5q86m y/Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733214373; x=1733819173; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jf5I3RuoC20RN0IsV/jbFVx4wBkXAmSkQkbAnkDREIg=; b=UbalENXWPZqnLH4Mhs5brDIWL/boNJxyaRRpvqAVn5VfOlkhyhHrQZX8DLh1PnY0py uH71Q7pcyqJCbdZjALUKOZD51HKFg5aP1Ue4u4BNL1rXR0xxfgQ0wHsPNmIbyd+oneHs GoZ9/WHxF2SD/EuwNT5P4WJVCBdGT2CqxnCMADtGz92oT1adnRXOzEZO7H37o0SsRaiZ Po23V3eSqKHO+XqiGXMkPOvf4QkN1c88mHbSSyrrfNqy9yuu5bSms05qPo7B+Y6pCpZp LBhS3FJeygtFuCb2Bs47/TM9e3Z1dwBHUihieuQFxZcWFWVaXX9iUtA3n92gvJH8fba8 Ssxg== X-Gm-Message-State: AOJu0Yx5o93EaE7BIyfRJ9ZKgsumwyUDB5BRjAabWyJUSN0Zoi4u0H64 L16sLORLmBe1ePMm/pFtBtXVpfF8MWSTRbv/1Hwf1AgUgFoxCeFSqFrtkK/aWMM2rlzWmAXv6T2 uBewhIzkpOua8LMTRwcyeP6zsJ1I= X-Gm-Gg: ASbGncvQMi3ZUfuBCPNN1twv5F75PMeb46ENTl5gZk2u7SlgPYKC+YGnzSnid5Z0SOZ 0xnKnJEJ8o989t9sDuWyAI2X/8Dns3A== X-Google-Smtp-Source: AGHT+IGfKFlAAQWGLPjwb8FCHA8+RmFCdqsvJQTdi78qnXBU0bxqK3oOGEt9JI24RUBM5MWP2/YI2cLbecsls+P9cCc= X-Received: by 2002:a2e:bd12:0:b0:2ff:a7c1:8c31 with SMTP id 38308e7fff4ca-30009c6e485mr11387831fa.26.1733214373311; Tue, 03 Dec 2024 00:26:13 -0800 (PST) MIME-Version: 1.0 References: <20241202184154.19321-1-ryncsn@gmail.com> <20241202184154.19321-2-ryncsn@gmail.com> In-Reply-To: From: Kairui Song Date: Tue, 3 Dec 2024 16:25:57 +0800 Message-ID: Subject: Re: [PATCH 1/4] mm, memcontrol: avoid duplicated memcg enable check To: Yosry Ahmed Cc: linux-mm@kvack.org, Andrew Morton , Chris Li , Hugh Dickins , "Huang, Ying" , Roman Gushchin , Shakeel Butt , Johannes Weiner , Barry Song , Michal Hocko , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 53C1A1C0002 X-Stat-Signature: eb3n8ate7rb7ojp7cks14ma367td8ign X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1733214361-647413 X-HE-Meta: U2FsdGVkX1+iEcKSB5kcySb5Oz/RiCOdRu843oDjKgBLWVyxMtN0VVHyH9MkA+uQTWej193i4Yhzl51H/LyCu6Cax8XZOd3KZcn2GITV2m+W2v4yZt3xSFWo+TgrbWa9o1Ug6UmOOc1GDCCSCpT9sRkVWL3W0uozPXmeOy7x9W5oyxN45pKrlUnamIpKbAOgMOT8kem7o0NejV3pdcc4xVi7xrjJtP2y3TSkAJwgo/dtxOotdws5iUzbO0PE27xO7aiXxdp0KdiQE0YwJr0DudeSMRRWdMNjZI9zjJfbsjrC9aZ/IC1KNVV9R1/23VQrIa1Jhi/dYSn4Gk8XWTmo1kjH1jB6K1H7tfgmhQrxnVLwRnciSNxBCv8SFB+eqj1ar+2+l85GS5cfO7lASAgd2sjTCm+YA5qwdBw4Xg9AEzbnim2CMTmI4/R7fBa7PbHmElkF5qrHK6pQX9o96y6EkcWwySEj3oYyGxM2o6Nt+8kcQfMCNGhXkAxhwTwvdcrl51Tpu0rmWlrgcHMj9mx/V3sr0Zog/QZgaCFwhGVjaH09fmdHmLaSxXIBfIIzdyCqNvq5Zdyo74tepyhJAFqRxRxPLgjsCSVabawANxUhju6WvbaOg5AqPDngtRU44EKt3ApS582q8rt4j3Z+ESuaNBgIa8yMgC2NJzE4AwM6oWh/mwBfpuYNyVC1x3QbCBkhMKlK36RtVODAg2m3DmqCulgoy9CAitROrUnPNaWXR9GqmGHgYtCZIP+FqPKDOwaCLRt16QC3wLwWOxyUMZmqarSbGHt3r0L2NQ382sPRTlyDQiPzKuv5D/CYpi+pLzONxsOk/vZU/U/ehdN3C0pMx+3690N0um3A7kFEUSML/x0qnp8FC3vNZuyoCvvDN8aEUUeSpbb+HgWZXZa/FK34RxHY6GZayNyrbibCAnvtkagO5Crawi8IQ+jZXyVPP5/Vau0DDp23xMtffB7/OyX vc6LGhLW W1dlGj5X4FAJZ+XM31sJxPrfl/kR8nHUoJsKbG4QTgKXoV84Wmgz/AIvDNlBvVPqWiHDP4bmCVhULzu7A2ecxKXu2s8hpZsZWhvjwKUA9TaAG6sKkr7H3IO6w3y00E6YfECL/UCvjaCliguTl4DVb9Hez0eFDaqDkZtedUVchiVc6+q9GePVS2PCc5kgQaEfcMUG1Jk51oMX5YkxEJF65XiY+j9S7mga4b6W2kKiDgfFGn3A0nw4Cg3Oi8zIml65rtaRZzZMFVw7UkvjGP/U3BWTblR57FgMq+/vg7RcDhxFn4TjgAx51gzts5v7oZYRUYHoKlvKRiJJXqoiFh4zZ/1/kGevOkutEzUxqyNkJ0b//VZNPI0Vn+/BsVKqLjzhOJRfysauFI6WObQY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 3, 2024 at 3:11=E2=80=AFAM Yosry Ahmed = wrote: > > On Mon, Dec 2, 2024 at 10:42=E2=80=AFAM Kairui Song wr= ote: > > > > From: Kairui Song > > > > mem_cgroup_uncharge_swap() implies a mem_cgroup_disabled() check, > > which is already checked by the caller here. Skip it by calling > > __mem_cgroup_uncharge_swap() directly. > > > > Signed-off-by: Kairui Song > > --- > > mm/memcontrol.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > > index 7b3503d12aaf..d3d1eb506eee 100644 > > --- a/mm/memcontrol.c > > +++ b/mm/memcontrol.c > > @@ -4615,7 +4615,7 @@ void mem_cgroup_swapin_uncharge_swap(swp_entry_t = entry, unsigned int nr_pages) > > * let's not wait for it. The page already received a > > * memory+swap charge, drop the swap entry duplicate. > > */ > > - mem_cgroup_uncharge_swap(entry, nr_pages); > > + __mem_cgroup_uncharge_swap(entry, nr_pages); > > Would it be better to instead remove the mem_cgroup_disabled() check > here and have a single check in this path? Good suggestion, and the kernel test bot just reported __mem_cgroup_uncharge_swap is undefined with !CONFIG_SWAP, so better to fix it by removing the check instead. > > Anyway, FWIW: > > Reviewed-by: Yosry Ahmed > > > } > > } > > > > -- > > 2.47.0 > > >