From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B185CC7115B for ; Mon, 23 Jun 2025 03:40:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 552EA6B00B8; Sun, 22 Jun 2025 23:40:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 502F36B00B9; Sun, 22 Jun 2025 23:40:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3CA406B00BA; Sun, 22 Jun 2025 23:40:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2CB3F6B00B8 for ; Sun, 22 Jun 2025 23:40:26 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E89B75FBBC for ; Mon, 23 Jun 2025 03:40:25 +0000 (UTC) X-FDA: 83585262810.18.E029D8E Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by imf03.hostedemail.com (Postfix) with ESMTP id 182A320005 for ; Mon, 23 Jun 2025 03:40:23 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fSrYF5he; spf=pass (imf03.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.175 as permitted sender) smtp.mailfrom=ryncsn@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750650024; a=rsa-sha256; cv=none; b=w642B/G4bqG/aKXLKbJtTYb+r6+WF2a2tTD3HlbWORFviywrOCDkDsZ7cck4EIbsNwZP/q 6l35t57uqxIOwL6ccg8tsIlvYOQ1drKP83lU7GJ0OzRl+d/YQzd31/w7GmsUZg0j1z85qv KtyPQdzvJOtd8ZDWP9K9K4LIA/F+s4w= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fSrYF5he; spf=pass (imf03.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.175 as permitted sender) smtp.mailfrom=ryncsn@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750650024; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yDoF03TxQWhSAvbPkAwLLDT/B+stLK/or3RHqbQBhRM=; b=Ecvc3ahR439P1o8f1FutKVlF0qrQjKGguyrNrBsYNiMUchJwRdygAfoIxCon6eLi95M8C8 wumg5lh0iCwJUOpflRLDz8cL4AAQRyjZeKQA3iKVUuwdW+itthuvlFymR5voyZema5iPZN 6C3JyTXFfmaoTVOuXDK7Rqw53NEP2O8= Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-32ade3723adso43525041fa.0 for ; Sun, 22 Jun 2025 20:40:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750650022; x=1751254822; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yDoF03TxQWhSAvbPkAwLLDT/B+stLK/or3RHqbQBhRM=; b=fSrYF5heJKvlRARonXyh5OMrb/4s9krVK8gLXBlm3euGakRY/Dw+Ix3Dcc6knhTe7I v5C8uhxTbkdHg4TKvaDTLYkLbTHszherS/pI/vnms4J7zxmr3V8+irabEzc+/GGdQ7H1 LVwhP2aEHW0U6NCO9JRlI8cBB2YmjMP9L57TQdA31Ux7KbB6QkcRKs6rddfrhLOm33cG uSr27QK40qm5NxlBXcn7GcvEYzWv2nYDygvsRlc5UOUYAwfI3gkCcTBxL7LKT8VXUFEp 090DSus6alTQiyIJmZWVa9MjqAayBc9o9dp/bKZ+YLVViiJAO7attzGvQ/ayYKqynA7J HBSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750650022; x=1751254822; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yDoF03TxQWhSAvbPkAwLLDT/B+stLK/or3RHqbQBhRM=; b=dh63b0sO4hx1CFsxtpQ0aRxY+N6Om6/jAGC3s93/KYcO7Kdb2wAwr3ug+gvbSDHw+1 M+b9luBzjmhiJcBunBKuztdArAHjbHr23yoxkOs1dGXcFOlYQ/q49dWJrcgknG4YoIUf xA6jBWqr8JwfPkrouUlw9DpEx0kQggbHj29X9nCpfqWwy7ubD4X+MJzcoM+p+ME5fJhZ j81yWK6gC01MB/eENKB+T/iEhyLpr2323197TwNW6yUiofGf2hQWYLyzOrtrNwW9cVtC iUfief2ldRPiJV1tMC9tN1Dn7RpxggxbxZ4fAidRhI+V/FdPDYjLCa7hunPoIhh8X5xy v8uA== X-Gm-Message-State: AOJu0YzHu9Q3vXek02WuESJ/j4QbE+4jO6cyNnHxhgnPWkdKAnElKUQj 71pvvIg1az+WL6JWFhDn5WGDYgINC1KfzgsZwHqjmNm0gFa9wYvHej6hXCcEjWd5HKDG9aPINyO oiPlE9gMCuqUacm7TEqbCOMLOf5HOkhQ= X-Gm-Gg: ASbGncsGpCiwarjsG+k23f7nFx2zxh1Z6CtTC5l0tPuvVTWiU7HogilfEu725aDxXZb 0oOdXHktv8q5K47TCk5qzRBzEd8h35OjZxKB0Ub8O1UpSy/BTFmsUJWsWRuUmSesnreVjV4Ee6i jx4bG7XSToQLFKdvfZngZLNe14XHAbx3rAFNBsAxY6jghq6CtpbXcPXw== X-Google-Smtp-Source: AGHT+IFzu9XeDSJkp18AF54E2jAv5YoPqCFuBJ9XhvTtkEz/nvJAl0XG32h0L6kafuyNKUPhrahczosykAa/BQw8BeA= X-Received: by 2002:a05:651c:514:b0:32b:72c8:9a6d with SMTP id 38308e7fff4ca-32b98e5d447mr19622141fa.7.1750650022129; Sun, 22 Jun 2025 20:40:22 -0700 (PDT) MIME-Version: 1.0 References: <20250619175538.15799-1-ryncsn@gmail.com> <20250619175538.15799-4-ryncsn@gmail.com> In-Reply-To: From: Kairui Song Date: Mon, 23 Jun 2025 11:39:44 +0800 X-Gm-Features: AX0GCFv3l5trMOnOMcrNf1BGLJQO46hGJCwwfEzTCxFRGb_QjfFdFC5DBQ-f3G8 Message-ID: Subject: Re: [PATCH v2 3/4] mm/shmem, swap: improve mthp swapin process To: Baolin Wang Cc: linux-mm@kvack.org, Andrew Morton , Hugh Dickins , Matthew Wilcox , Kemeng Shi , Chris Li , Nhat Pham , Baoquan He , Barry Song , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 182A320005 X-Stat-Signature: undr7drjq7dhtk6zxkijgfsh1u4nkw9i X-Rspam-User: X-HE-Tag: 1750650023-590839 X-HE-Meta: U2FsdGVkX18/eu6TNVRJHA0RuC9Kri4cCTg6+3m5nrDk9MHro7kaEI5mAg1aotUz/KDMvYNp05sXCjWT6/7cE7JPlRb832y8w1mVSqXr+/0N89Y2NDcDPp8Y7K3yUdxp9ewVAsoFogFjxEXOpytkmn8L/VO3mBB2GjhK4BflVKxSqvij28egywVywkvkC1wERyt/9STBvY4w8rqb/a1JGxOVrhYSzC3ZtkWcAzmqqR5F+oYfUk8f2T6i04o275wwjqrmYJhiCC+S7GXvJZY0oyJgqkMDC3ls5CHp0MXMW5Z8BusbxJRKHhlUpGgq1Nmjjsc8epOCnDDeJ5K0g0PPtlY0wd4PoH8OE9vANf1WB+U4YYBmApTUbwA1p1+yIqXTqLTd+Vw7KTcuikR9B1aK2i946hFTpZdBmZPOACBoJwi3nsFLAFujcAE0v3stvHvZrvXPRQpguQvsR6WCvOzBn5by6FY1dZnNAJ3w+8H9ZrJFfRyZpC9nDVpsgLqIaU6tnR7MBljVzSFrvwHTYwX0d91TxLraEfCz3XRxkjgzXuWRJLcxm0iz+3JqM/H/Y0FRMurwUw93QodwnZzDtWvjk/W51bNKy/GURqqhMSRhys/GJEzpJZAU6ImCUPWbgWZi1YB8vOunJMKAr+KAsiFV2zDJugqsEBSEDd44nqgCJfDsBvEf+I27NgLY4pGVNaoveOpiobesDkIyROT/ZzdRzkIuATFVCGAQGTjhouAmVMNdVuzTRntgRCwrXQSnfNGxwc4nhGct5HOZzETv8XOjahY6QSAjhzaoO9YiSXt+johXiUP197gcqWYL0IbsGYf+emBC/opAmTGQwssGazl/u9lZP9MXNsBw8fAqUjjSzU93yeGvm8CCGPJnwamPqKnT3k0KgiOFDadcbM2E3oOQGnxg1D8p6sQgyDAXzFEYOBMb3bjTpQJSj13n1OPSzIpj66aO6zHDF3fe857Rkxo WHel05u7 4APN3LSi5t+iVGrpwUms3LBYjMlDTqYS1q2AcMc+P3yDW2CrEDpoEcdlAKQNdU3Uzv/Ps+0YTuqMMTO31BpNTUrmJTxUL5PmFGA/VUtkpa1lQhvSTbNgp2YtyVjachhDMA2cpsDK0PHya01923QLtf4DPLozivcnucWhS/nIUYCI2yZd63ZsnLj+/w6Th81VTvnkIcznYJcp/UmrELP0XBVTFLuyG045NTK9vnsBIkZWAsxESIi949kFbINtmdVFWyL32M8f+OCVqc88AV0h9CDuu+0npri37Q8pz128E4JUvlk5rrmZniloS/w26uAcJrhOHgmfsXB5ADSHYm4Xsbugn2JMDtmw/Eoxsa7Bf+c6j6ZTiEIJu3B4ffw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 23, 2025 at 11:37=E2=80=AFAM Baolin Wang wrote: > > Hi Kairui, > > On 2025/6/20 01:55, Kairui Song wrote: > > From: Kairui Song > > > > Tidy up the mTHP swapin code, reduce duplicated codes and slightly > > tweak the workflow. > > > > For SWP_SYNCHRONOUS_IO devices, we should skip the readahead and swap > > cache even if the swapin falls back to order 0. Readahead is not helpfu= l > > for such devices. > > Yes, agree. > > > Also consolidates the mTHP related check to one place so they are now > > all wrapped by CONFIG_TRANSPARENT_HUGEPAGE, and will be trimmed off by > > compiler if not needed. > > I like your idea. But I found this patch hard to review, since you you > mixed too many changes into one patch. I think you could at least split > it into 3 patches to make it easier for the reviewer to review and test: > > 1. consolidate the mTHP related check to one place (cleanup) > 2. tidy up the mTHP swapin code (cleanup) > 3. skip swapcache for order 0 > Thanks for the suggestion, let me have a try, I will send a V3 later.