From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A092DC369AB for ; Thu, 24 Apr 2025 09:39:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C987D6B00AF; Thu, 24 Apr 2025 05:39:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C70D66B00B0; Thu, 24 Apr 2025 05:39:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AEB1F6B00B1; Thu, 24 Apr 2025 05:39:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8CFB56B00AF for ; Thu, 24 Apr 2025 05:39:01 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 487775F909 for ; Thu, 24 Apr 2025 09:39:02 +0000 (UTC) X-FDA: 83368438524.05.4356FD8 Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) by imf08.hostedemail.com (Postfix) with ESMTP id 84BFA160006 for ; Thu, 24 Apr 2025 09:39:00 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=laFwQLPC; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.180 as permitted sender) smtp.mailfrom=ryncsn@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745487540; a=rsa-sha256; cv=none; b=MWtsj4C5n2ujWTtn3EQrplP/FNsj7CL93fmWrWpnKhOgJGXK5WNGFOvKU1HNDCPMei309l 30OsyQYnKcRCt7yntIPo4NjWocNUGmCp76cTNWYHwGjxCKKdRwoAuO8R5pCzCDpUeNSih+ Q+uNI3DrG+7QeaGeKn23eOOeiRK/8UI= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=laFwQLPC; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.180 as permitted sender) smtp.mailfrom=ryncsn@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745487540; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NB2oNOCnxG85GWEANUQdzI220Wn03rrzKWljOGrWZgs=; b=nUWa+zpuercJBil2WZBqIO3QXZd2hvPnSKDdcnKYlsfoVryboDhFjiYkWiQn1OR8mM5RDu ZZNoJL/ecrxldnWsbPoNB3Tkxokzd9w8TcsMoE4V9KzKOPJWR8L5LIH6bFJ3GQcRJTiVwv OCbiHGEFzgYY4XIzghJzC24n8Vnbbuk= Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-30bf7d0c15eso8803101fa.0 for ; Thu, 24 Apr 2025 02:39:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745487539; x=1746092339; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=NB2oNOCnxG85GWEANUQdzI220Wn03rrzKWljOGrWZgs=; b=laFwQLPCm07ooxwUFdVzMu2M0dzk7ClrPpFziKCui0iCjGA5UKasZw1Cn4Q/AQFbYT nGG+kgxESJVUbgylYZQvfsMwTSaF949BfQ8TajgYTbVMlhiRbrWv7iaUGrukFV7l4CV1 f0nCLBoX2chUHtAL8abcwpCMrZMjftS4t55HTQar76S+JsRPTy3KYE+dHYBiZtayL1vW zRBnukprBNNgaKbnP8dgZeJ4dMIpe3gIkYsTkLOVKueGP8FfZJKxJSYDHVp/pj1siKea lrUI+wE5P2ZN+y4Fpizn0aUesHnmsIswjO0FqnLislRc0yPDqpgCafZ1kcQ3IYkD7AHL oyHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745487539; x=1746092339; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NB2oNOCnxG85GWEANUQdzI220Wn03rrzKWljOGrWZgs=; b=RryY2MWvKbAxe4LWLBm1Su1+ZojgH7/lmUxsGQo1TsyeDI5bYu2119+l2wWKCxk3I5 wctVX1l1nbDJX4jUSSkeA94BLH5SNfDm2k5aopL6aMlfyu5MVKppHTCNN1aucl5JsVJc 71wMNL7L3207WULuMyaoNxs8IoE6B/7lplQ+89vlIjyxJ1YoOEDWGqJyJuJpqnvBZWzr HMBnG4C/n5bPVO2n0aELWHoXd4ND2O+PCKjtu5aaHmvUWm6GXiyAELxC28oeyIf7un8O 2jmphpovVHC3hOlFZ295oqQyS93s8KNqu3HtmVqSKB4t9x0AZgkscdSo0+/q/0LGcW7A HECA== X-Forwarded-Encrypted: i=1; AJvYcCU7nrlyugoHCwiMka2phJ2BO8Nqpl1fYVB7iOqiR6weoAG9u1y93JHadEVzC5tW0AURzcvfi/Jj6A==@kvack.org X-Gm-Message-State: AOJu0YwoEpgHFixM6RKku3pynmzCqzlevGjML4Bes1emrb0P40GCDd05 8KTOk5VLHjZfEGajacvVHeDqH3Ydc5FnZev8YepV46PP+9ye0GogM8gyXMdZT3nJngfHNh6mknY s7fFFKK6ooqDtdWlFfk4pCrOsIU4= X-Gm-Gg: ASbGnculJFJkS4v3nOrfoeLdLputwf5KVdoxomPtME0viXil95g7w3MaIAB+orSffTC vFj7C30vbSnQeE2LkVcVV8Z82KY+0VTR9uSXoJYSGjd6+kbpZd9VA0cmpw7h9iPke+JAenNA4qZ puBbbq1GQoxW1XmsYplcIV3Q== X-Google-Smtp-Source: AGHT+IGxVjnHtPNegbr3C7Imfp6iB6vUgpa+DyLIQKc23y3BGS5YQua6rG4/E/4fQIRZ0NImjw5iKW4U3PoyKnwuILY= X-Received: by 2002:a05:651c:1614:b0:30d:62c1:3bdd with SMTP id 38308e7fff4ca-3179eaf48d1mr7393771fa.23.1745487538397; Thu, 24 Apr 2025 02:38:58 -0700 (PDT) MIME-Version: 1.0 References: <202504241621.f27743ec-lkp@intel.com> In-Reply-To: <202504241621.f27743ec-lkp@intel.com> From: Kairui Song Date: Thu, 24 Apr 2025 17:38:41 +0800 X-Gm-Features: ATxdqUEbFuGWETRbMvxzKfov8XBuQuSyhGaBkFQpEJHsk77t9tC6s3UekgRaWuw Message-ID: Subject: Re: [linus:master] [mm, swap] 7277433096: swapin.throughput 33.0% regression To: kernel test robot Cc: oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org, Andrew Morton , Chris Li , "Huang, Ying" , Baoquan He , Barry Song , Hugh Dickens , Johannes Weiner , Kalesh Singh , Nhat Pham , Ryan Roberts , Yosry Ahmed , linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 84BFA160006 X-Stat-Signature: bjoemgrn7yudj86awhoadhtfdomrkhmk X-Rspam-User: X-HE-Tag: 1745487540-886666 X-HE-Meta: U2FsdGVkX18WhGJGq//rr3SSJ+sNebFlIS4+U5AlIa7/mbN2inq0rC3SFbjrppUHrJec38qOo+/TExkl7IvyFzl2a29q1BVsddXmc3nQaRhcJK50Zz2yC2W2NAKd5/HT5/0RZOX1FZee//JSEfExGCxDfdfmxfIZOwqNHepHh9PsT3OiqejOgZ6wRA0tmPRSZgNVn4s9GJvElU0KRpOodaCIZ/4e50cuxwy5k8FzEoqta9n+98Ooog/FC/FpJYQM/hnB386B1PfXiblWjJkEZqEkj97IS83GZGZvYJxRxNT/nU0vDFlDvoqt/MPUOE0uEumzoq+jNSslLPQ2+XZ8V/tEtIc7WTcG+27vqy8KwveNd4o03gZGo0RTShaqGsgDBPj5Lu88IWF5mQ+CphfmS0CMoAy3Pc2d5RAVF/p4nEW8kvUDiOj7Uts7ONooggJTKVUP/7Iyby1cTIZW5w4K2n/x1qpCxXP8MOjNBftnbDm9KcUscCDy8PTUkMzvKwdaXN4qELJV7rRSGvgCCRfTX7uwxEoc9aFt2Cx8P2xUF4dsGjm4C5MxcW9AwZ/UrRd3LO/Sxugebo+fRzOKzynl/0WiybUhTUd0BCS6H5eabHIJ0OcjXnD/zje48+ubE46cqcoK5W3mb8pCMgWmnbDivRsZdGZznScl9jkvVWubgxsbnLeUW5sc2s2T1OcUlFeA5/Q7C4gjNufNEP4sPFgwZhvtrn/uebkzJ2AkDQ+wKCM+b7V3/Ndk+VcCDuez6Nt+DRf4DZSQYle3MNpeXjXfLdlVBYJ1NwdBXBJ+3lIw+zqg6/4d/jg901hVjQsSWnlRYr4PAwdT02x+OmBjC0ibyWvZGBE/2koaZtFW/RYLQmwrsnt7+tZS/GMTzuEmoK2bCjLvO3EK+pcvD5o8ILuEqjv11Msz/Ev6FuE6dUtsohxTZE+vTZcM8NmNF1gQiXWx5Hm/n1DHBo0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 24, 2025 at 4:40=E2=80=AFPM kernel test robot wrote: > > > > Hello, > > > note: > from commit message, this regression should be expected. we still make ou= t this > report FYI what's the possible impact of this change. > > below details just FYI. Hi, For most workloads with random swap io, there shouldn't be any regression. I checked the test and it's doing a sequential swapout with 8 workers (after a fresh swapon?). I was expecting bae8a4ef3efb56bb7e83bafd3c0856845aeaf605 ("mm, swap: use a global swap cluster for non-rotation devices") to optimize it. Seems that's not enough? I guess we might also need to disable the cluster shuffle in setup_clusters for HDD. The shuffle was meant to reduce lock contention on swap cache, the contention is clearly not an issue for HDD, the bottleneck for this test is IO, that might be making the IO more randomized. Or maybe clusters will better be sorted by offset for HDD. It seems this test can be easily reproduced with `$USEMEM -n $nr_task -W -d -p $TMP/pidfile $((size / nr_task))`, I think it's not a real problem in productions, but I'll try fix this if have time.