From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63362CD37AB for ; Tue, 3 Sep 2024 18:51:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BC1068D01CD; Tue, 3 Sep 2024 14:51:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B70D48D016E; Tue, 3 Sep 2024 14:51:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A38C38D01CD; Tue, 3 Sep 2024 14:51:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8061D8D016E for ; Tue, 3 Sep 2024 14:51:16 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 24DDC1608FC for ; Tue, 3 Sep 2024 18:51:16 +0000 (UTC) X-FDA: 82524319752.22.7C59EDF Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) by imf27.hostedemail.com (Postfix) with ESMTP id 501C24001C for ; Tue, 3 Sep 2024 18:51:14 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=A8tlKzQ2; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.173 as permitted sender) smtp.mailfrom=ryncsn@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725389368; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5HWBUov06ObmMzy01hCLFdm8w+seLfM6Kvtbr0Nq9fo=; b=sx/wvEJDDOSZMBrUDuSx4shgyXC26DBC2T999urqG6bpx48XDBRjvw8rx2aPPIEZv+lp7X BPTuUZZEax8CE+GEg+d77grloRnBPoC/5soadJmxst37xLZQLNCDC0qE0wpeIbGfa29jCj XiCW7vtheYK4zAyGVVv7fQs2/bAq1v8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725389368; a=rsa-sha256; cv=none; b=itBIW9OwMZfzLMfnx35FGBW8sEPsWmMhC5+B1a1xF+3Bdm2R8zg+oQcIkOcMVBMLln7qD9 TNbcH5WaQei1TbrS2W+p1Y1j5fWVc2mxeh0SY1cWFuXj5Xci0l7tIhLqExqZP2nohAGr8a j6mDcCAdCG8nkzgVch6/J802Xq6clmI= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=A8tlKzQ2; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.173 as permitted sender) smtp.mailfrom=ryncsn@gmail.com Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-2f409c87b07so72829791fa.0 for ; Tue, 03 Sep 2024 11:51:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725389472; x=1725994272; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5HWBUov06ObmMzy01hCLFdm8w+seLfM6Kvtbr0Nq9fo=; b=A8tlKzQ2ADJOWsQaBAAUFTznNWxy996XVliYmlhr6iSyeOk+oJ8osMLBGPHllGaDx9 RZQtkvFXMhGfCZaj5hlX5mrS52sW7c+VkI5F0YJTAFqabfASJfBh2hRDw+nUJ8wrf/eb upIAr6fCDjOzqQL68nAe3TpTJBhhqwFvf4bsyxXy3PUhC9nZXAN0sBBLSJ6w1BBZYVcm yxndbGxeeSej4toLJf+jS4trpDiDZ3mVPq7HS/g2CUYgTOgmsvQDqei3RqZA/+aoFZ0o b2QmxnHEygDwLVz6QLwinmejPr/SMytU0O7XDq+83UkhhKh7HVbcDQI7sT+eERpZDvoH b2VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725389472; x=1725994272; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5HWBUov06ObmMzy01hCLFdm8w+seLfM6Kvtbr0Nq9fo=; b=WCSBF3WK6zFpE0m/l4C/t72lPFdelPgqreOgkDr8XDh3So50siViLkI4nzD2+WgUIW tc6EJoGUo+aaM2rFA8cyDf7GlgafUYCRu1YtYQqWluJAIusk15plwFnbJRNnVy/wfFVN oCH6llnRPNVRugLvhK/NF6epLAxw8yg/v9f1bGhrXc4rWHg8qyayacdEZeHI0MctAMdY 3go5sH/PQaN4wNqXh8+OdKG7TGYpzi/8k8meTYD1pwVfr1MeheOztLkwNxh+8+1y9CcD qNjW6JLStSauD/r8kYc6P0vb7p4onWKLenisUNe+lotrOIzNyymQ69HvSf51tCK6JP+O R3Fw== X-Forwarded-Encrypted: i=1; AJvYcCXFJdWXMti+b1W9tOy17zyJ1isOCbX4QdEdZObh3E5irkDFGFRiN7PGIOm2qqtNPNDsdyk3DGTW5w==@kvack.org X-Gm-Message-State: AOJu0YwU7t2nFqN4EUREYGcQya+NVoel/O1d8pRH15hLgvOmiMiFL7oB +XzT2GQfLqd+4nR16Gv3r0PqxnpbIZM+/B9nKl+YGRztLe9SrfTpkYYrbZzWkxhnxCVZZvfx28N ac1eB+h3T3IbMXUygP9aR/nIF6Io= X-Google-Smtp-Source: AGHT+IHIYvnSqEsvBrn3eJeKpOQW9mnpJmyGbglDWb8nmEiSfSKQi9dy0Ikae6W7IQ6tCy7o2BWBJZD7PuX5i0kIfd0= X-Received: by 2002:a2e:be21:0:b0:2f3:af4b:224 with SMTP id 38308e7fff4ca-2f6265504cemr88310481fa.8.1725389472235; Tue, 03 Sep 2024 11:51:12 -0700 (PDT) MIME-Version: 1.0 References: <20240821054921.43468-1-21cnbao@gmail.com> In-Reply-To: From: Kairui Song Date: Wed, 4 Sep 2024 02:50:55 +0800 Message-ID: Subject: Re: [syzbot] [mm?] WARNING in zswap_swapoff To: Yosry Ahmed Cc: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, chengming.zhou@linux.dev, chrisl@kernel.org, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, nphamcs@gmail.com, ryan.roberts@arm.com, syzbot+ce6029250d7fd4d0476d@syzkaller.appspotmail.com, syzkaller-bugs@googlegroups.com, ying.huang@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 501C24001C X-Stat-Signature: ozzsoh8h4eyqchsfjhw3jf3cth9pgadf X-Rspam-User: X-HE-Tag: 1725389474-665025 X-HE-Meta: U2FsdGVkX18LrPLtFne5L4TiRdYHPHMjSdZGpVCU7H3af4oAAeU1lO2E8qZZgxkT4JWDVln3UvnYAOsX+S5NbfxjeuKHzncZUmt4uSUzV6v8f3EPuCVggQOApiMzhtqgZhlNXH1rKa+NnhiuHy/HRpMMcQboGkyPSRBnzf4BL5eToxAyRpjBtpMZ04pPHmgGw1+qRhBFv9ifdxGNIwiEF1spBHdt417rlAjg6sRpKgH2QPUGdIXBIxUt9ZI+Ykq4DUHJ5HkWZPJ5zYRdGHFHiQSPWp8An5r8QcQbbKpwNSCfI/HGGK3rT6nxGf6zZZ/IZN09yCfJG9KLwZ8LlwPX6JfxLUW1g2EvJuV4OcVg0eW3ltfvqaiz7y66md5DrlEmZZTw+zE9AlI6AWH5HjQ1ohk+ybBb31lOqq2fM8nS8TTpLtC/mUoEBErinMx2ZwEb5AiVhgVT/IVzxcsLYHuc0oYytFiJ9FkoUwh6N0ELbCw5yEOImAUcH5DubSxwX/evoxcxXfH3nfY1J2u/MOUIgX3+8VHnYeaHC3XxfMMIBZml5cKnoUff9qsLisR7ekkrbJ0z6/1hFw92w9ogcM0hG/TBoZF40ZtTQ7vkcvlZ99oHebTK6k3Kq+MOeqCwKL0vipnE6FlC4D6qAw78qN/9qxrEGnkfUg438xs0pBQFSQkCUDTHNZbNpc8aViaUsn8azimDtUh0TWCkrp5Rf/bHZ5frlwcJjisFy2CChbsu6qh/FlVc+jKGqMkVz+ilxU4q+/PKLEdTbnXZtMwxIC9Jp9yEYbZQ3OEFtDNGtkV8OUGyGtcwCQ6JS0s65i1+L7ax2W3d4fxYLkg70QERxCXGNVgysiJyVr5t1LUrP0DyEYirWzRHGLrhqeK5QrDyt3Pm5gftvCiJ0HGbG0Cplt7m8m+YyW+IO104AZ2qlE6VNCiDQ+LCIJsUG7AzqoW0fls9uK8SFfj2rGWCc8t9UTq 80k+uQsw qrB8vp1OuasIcF9LzXBsKe3Vpt8U9ifvKwSfsvnu04xugnVbr/zf2Uga7dD5J5+NUhNeEN9HPnxNI4zOLdZ9roz912odKJ5LF2c4xBU3O2/arbruA9sSCakmOUh4Qn9WeEpEzy4i8TzWx5QAc4RDHHOZPLRt4ZFzI5ExEyrd5m9ZZtl8ZniL54caIm7xsNZFjSHZfuqhFV/zY8whDi2Ux8ZPWr6IXEKu7HJZd+7eq5epooQ0HEZ8PQsVrofiiQO7faS3UjA0fnkiBtEMGRS/GawRNGRrSXQqg0iI3q1D7RHaIuuQ+25gsJGApdac3z3V+7faAPzXbT0yAOfPpx31XJXFoeST93R5/MFQ5gPNdGjdjLwiNFTlcEHgCzbTqgTtj9zfkisH5ntBX3lEBmAJ917OTTRlUAH+wl/CJrltFvq9LKnXF8i19yFCqnBCE5ErGlmD0d6MmbAsPvuEFsgPJv33YOLeEwv7Cosp+UHO+zkvB2jGh4zPXYPeTY/Oy5xLRbbOO3Bo6dWEdS7trOd+oD6NynA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Sep 4, 2024 at 2:22=E2=80=AFAM Yosry Ahmed = wrote: > Hi Yosry, > > > > diff --git a/mm/swapfile.c b/mm/swapfile.c > > > > index c1638a009113..8ff58be40544 100644 > > > > --- a/mm/swapfile.c > > > > +++ b/mm/swapfile.c > > > > @@ -1514,6 +1514,8 @@ static bool __swap_entries_free(struct swap_i= nfo_struct *si, > > > > unlock_cluster_or_swap_info(si, ci); > > > > > > > > if (!has_cache) { > > > > + for (i =3D 0; i < nr; i++) > > > > + zswap_invalidate(swp_entry(si->type, offset= + i)); > > > > spin_lock(&si->lock); > > > > swap_entry_range_free(si, entry, nr); > > > > spin_unlock(&si->lock); > > > > This fix from Barry have been applied for mm-unstable and it's looking good so far. > Kairui, Barry, any thoughts on this? Any preferences on how to make > sure zswap_invalidate() is being called in all possible swap freeing > paths? I have a set of patched that removed the si->lock around swap_entry_range_free, and the slot return cache is removed too. So we can move zswap_invalidate into it as locking or caching is no longer an issue, I will post it ASAP.