From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86F42C4345F for ; Thu, 18 Apr 2024 02:43:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 091596B0089; Wed, 17 Apr 2024 22:43:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 041AD6B0092; Wed, 17 Apr 2024 22:43:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E4C906B0093; Wed, 17 Apr 2024 22:43:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C82796B0089 for ; Wed, 17 Apr 2024 22:43:04 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 807F0A061A for ; Thu, 18 Apr 2024 02:43:04 +0000 (UTC) X-FDA: 82021105488.06.E489E19 Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by imf01.hostedemail.com (Postfix) with ESMTP id B4F5040004 for ; Thu, 18 Apr 2024 02:43:02 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=iFlEUc+1; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.174 as permitted sender) smtp.mailfrom=ryncsn@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713408182; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lHdJ1IEQUe90imoIzR17oc110KfFYytLZPC+x7YJWuU=; b=VlwwZr5lqQTAbPu6JJiUYcMSS0W+Tnw5hpJZVMk8KGbchhW4n0ESYqGfkwSjlKrSZvjDGP ZdOHsdOzxqsa+JKVpiNEf2835zVaUPJsX4OW66Ge0Nax9vQCOwoJO3OsmilV96UOK5LdVI gBVp7/RRAzez7vPrU+/ACWOTXA9mJ9I= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=iFlEUc+1; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.174 as permitted sender) smtp.mailfrom=ryncsn@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713408182; a=rsa-sha256; cv=none; b=gklTn4ePKn+rDi+SySSNLo5i3E91lkHwVgMANOaXky2oG4cz5MdZk+3jQ2+doctennKaVK 5vvo1O94pg6CkAcQBSqlYZfOY/tQU6rprkJ1ZuJnAA3tul5KFK3u53l3CPLT8CcsvuBYEL 3UqzHqrCzjmFF+m8fbc0Fa649ckuGOM= Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-2d8743ecebdso3554621fa.1 for ; Wed, 17 Apr 2024 19:43:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713408181; x=1714012981; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=lHdJ1IEQUe90imoIzR17oc110KfFYytLZPC+x7YJWuU=; b=iFlEUc+15axs2vKuskbUtMaHlMLT4M8u97ZwRFs9TYB95YglYnahTjqEwFceiAWwge w7lYuHhxmYn5nBltGzmOMIZa0XzdCgmaLj9dY71tMcQ1M7YgaaYlf6UtxIO+lXuJM/hu wLWSLD4/+jBulP3v4mUXBKBNERh7bpQicfIjiKVAbsmYl8G6PfwcjWFR1rkVUpSDxVpx pv/94pBZxNn/NpE6Sq+ywbNqiErX5ocLY4OkbkN+CzDRxhK+hTbNOt0OAhna1ED3yAd4 ROWLEcCoqsQTVLyU/HFmnbZRvsT4CwjebjzrTtk1c0D+tIfGZtE4MLh1r0s3ABrtRz1i pWwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713408181; x=1714012981; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lHdJ1IEQUe90imoIzR17oc110KfFYytLZPC+x7YJWuU=; b=Uajy9xHUtHn7fQlWechwMBG6Fp3FjxCPgVjgRZxwUSNrUqGW94x576T79N9/jClANh A7Q4Z/VIseFnBCKMBVZ8C1fRQhD1R+vIFZVo+/YwflbzWywp+uZYWbSVSz8IG7VbxsDY z0mf2ioMIc/9cHXUWLmH5wJL0MlgowWWEAdoilP9QydXCLJMP8ZtTwECoj6ANyPNUzhC WL7j/ryFMzt1Vm5h+Vu0gDwitzCHnfbA1MCKobs+cDXG/jH7R3ZAE6BVQ2cQS2Tcca18 UR/NCVveGoexGsKnaAFfUeGt/1Ic8awXSIxHrFMdB8ZC8Z2PxfFIdx/nWM1Q/u7uOeVg zZpg== X-Gm-Message-State: AOJu0Yxzs7AUxGIrVNHkR+tUZcWlCubB/SrVBKGNIXyCtN0ihZrxMU4Y xiMGIBR8Amf9TA65oJgpyBFo80GXcNkAxkzsIcTzywoKcKE30pOI3FruIRpc8ME1vIQt/9oVXHI 4pAis0gjNX68n8W5nS4wWBStAwHk= X-Google-Smtp-Source: AGHT+IFTCKTPAyg4nwsmNHIvepg/We0wTvwYE5mzO9dl8NADN2aVUyszysFamFq45vti2d+xPYdRpaL2zC0wX27sKm4= X-Received: by 2002:a2e:a986:0:b0:2d8:55f0:476b with SMTP id x6-20020a2ea986000000b002d855f0476bmr713852ljq.23.1713408180752; Wed, 17 Apr 2024 19:43:00 -0700 (PDT) MIME-Version: 1.0 References: <20240417160842.76665-1-ryncsn@gmail.com> <20240417160842.76665-3-ryncsn@gmail.com> In-Reply-To: From: Kairui Song Date: Thu, 18 Apr 2024 10:42:43 +0800 Message-ID: Subject: Re: [PATCH 2/8] nilfs2: drop usage of page_index To: Matthew Wilcox Cc: linux-mm@kvack.org, Andrew Morton , "Huang, Ying" , Chris Li , Barry Song , Ryan Roberts , Neil Brown , Minchan Kim , Hugh Dickins , David Hildenbrand , Yosry Ahmed , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Ryusuke Konishi , linux-nilfs@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: B4F5040004 X-Stat-Signature: eu57c3r1t4yu358ezuya9dfqrrd9higi X-HE-Tag: 1713408182-238148 X-HE-Meta: U2FsdGVkX1+GI7+YZT/p/OjYXrTsDw271KZ6MylPUPFUOb91NEtPzhWdAzZb2K5SjS2QmOuNRzzllLTgyCjbbUozvAWVYHWHVbwkuRPm78eLYm8DkNsDrddJEqro0zZAq6/TxF8UBebCPICp7oMjb7TsOZkrvIv6znoBIk5G34TX3BQzbYYRqz1j1zorAbfiuuOosRXFoS5ToXcJkmIpStcL6eP69My7zzZD4PyBxVU3DGBC/+RqBXhvnJrlMB0kaTIDGIAuffPKmSyRbkLbNfQtAXFk86bJhXJhJhjC5ecTFK363dksGrFD3vp0ak6IozK2b/wwE4CfI33MT4kMK4l2kRxQNGrufe86zI5PjajhpSbVOymk6otF6UquSnT/x+byJp8sTMXoOEAQmoXjtroYgmLsyxjfNBGaI7TAEwX+PfLjGMbspwYS+AmrerwXA3Bzj2Doly8SEsxkWklVeJs7JH/5N7wboN4RR4RWGmxUk+TfX4HEUk9qDHEXws6stvaXabLmPQktKJGOsKiQZ2FqKUH3yaDFE3zs4Dxxwda3mmNNsGyvr5IWd++poj+GvZZy6oBTfnel4cHsffkB9dP5p4iVrw/LBKyX79MSPKnhxvcr2N77j3WtpfMpvWbO6tZNfsM8ykA/I4lfAhRhlJJwlWn5CSeYGJEMQebvuWl68gLTyZfj6519zqa4aUn5j4bBFuFiS/Je7HaWp7iThgE4yYqT+f/85x0YRPtiYyMRPNZuWqxn/kWNT61ZD5cFdak5VpOuSDobmhJhz31jMXn57pgfdPDbTXQT5qXmmt3QxwdiWUbq92Qe4rqqcunJ676eZTaJzdcJWnB1uFmUA/6JRUhtpMPdoSdVAslowZ4j1cpSElM5BKN1I5vyCNQ8pzjrI4pD8GTkJMwwFIVg2q43QzkH0P6Hv/4wAaV6ydojSRqAbaoXADFmGh2vhmkQbGLiQ17LfqwPd3MxYK7 DMyvDwQa 7R0oSI9gr8TcF5zA4e9AkM8LzFSKhR3vaDY4ZMvu2+qwPT5cEHtUxP56TehBeFka51uOHgM1+ce4qPGwX8AnCu8SMxfe3xECz8T11L2lEUjxt3oXu8/HGOH8EQbVdNbD3YlgP82kpuOEAdur6khyIDBsj62NLjhg4QeRosG+pe6sJWJEqhDBI0brX0XDZJzunpKOxVrE/FYvGhn2J7CHanYnfZXRIs3u5AKIBml9gD57+1ap3gbWJEu8Ih3SjDTOG4lViAmIh81IiJkInrekkIBclUlKSprSSjl61KYUu2QegbHOfOkTT7vANesh+zG2k0Jtr1iJtzJSljfMX1MCHIg3T2Yr+FcxiNouv7Jg+go+Q8Dc0bJ7Lpsmn12R563pi10Rrp/wC5gBiwLetQ29n8cAwuSRBoR1jaNZIuZoLqElgP6bcs1JlQqMYHVeMjikBihIlmVps8m0nIPxUlvHbp1YdC72LwDhiqyhL6GT41lef/4N2kbtyTjdeUobbaIZkfldxQgPpWcNsBODMkhI4ft0f2Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 18, 2024 at 12:14=E2=80=AFAM Matthew Wilcox wrote: > > On Thu, Apr 18, 2024 at 12:08:36AM +0800, Kairui Song wrote: > > +++ b/fs/nilfs2/bmap.c > > @@ -453,8 +453,7 @@ __u64 nilfs_bmap_data_get_key(const struct nilfs_bm= ap *bmap, > > struct buffer_head *pbh; > > __u64 key; > > > > - key =3D page_index(bh->b_page) << (PAGE_SHIFT - > > - bmap->b_inode->i_blkbits); > > + key =3D bh->b_page->index << (PAGE_SHIFT - bmap->b_inode->i_blkbi= ts); > > I'd prefer this were > > key =3D bh->b_folio->index << (PAGE_SHIFT - bmap->b_inode->i_blkb= its); > > (pages only have a ->index field for historical reasons; I'm trying to > get rid of it) > Good suggestion! For easier review I just copied the original logic from page_index, I will update with folio conventions in V2.