From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4BF2C369D1 for ; Mon, 28 Apr 2025 03:14:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 793F86B0005; Sun, 27 Apr 2025 23:14:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 743606B0006; Sun, 27 Apr 2025 23:14:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 60AA86B0007; Sun, 27 Apr 2025 23:14:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 415986B0005 for ; Sun, 27 Apr 2025 23:14:34 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5FB11C5B78 for ; Mon, 28 Apr 2025 03:14:35 +0000 (UTC) X-FDA: 83381984910.01.69B25C3 Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) by imf19.hostedemail.com (Postfix) with ESMTP id A6A2F1A0008 for ; Mon, 28 Apr 2025 03:14:33 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mNmvaJtB; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.171 as permitted sender) smtp.mailfrom=ryncsn@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745810073; a=rsa-sha256; cv=none; b=MpFxME8KMXj63ksXYZ756uG58jKK9b+/Byv67jnBTCzGmIOGMmWQYBCqTEpfeTVHCAwrPl EUKN4Ztm0yWit/LIBuZXS/enlUyudefHZij8/CCWmFypipFWeTkIHYzqocevgd6cKJqtwS 5zovTKsjmzLyhWonVeggwSBNFWiZhVU= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mNmvaJtB; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.171 as permitted sender) smtp.mailfrom=ryncsn@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745810073; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=srTtWDqh3kQMLPOwQAdxuFWSFY3XFs9WRxLvh2UhnqA=; b=Dieg4aL7j23ricdpUOHIfqtH6tPOVQBSq/hPRuCg1omv+yMcgh4oe6moVXY4QBTyvkfwvX LP6l596tXdOpUtFqlomSKRfJUQ9dGTBGCua28YJgce67DcRzF/ZPjJ60PV+8e9UfsTB+tu Qd57DVZvwTuLTtGWMGbqvS9tOM7O78o= Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-30bfc79ad97so58170441fa.1 for ; Sun, 27 Apr 2025 20:14:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745810072; x=1746414872; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=srTtWDqh3kQMLPOwQAdxuFWSFY3XFs9WRxLvh2UhnqA=; b=mNmvaJtBH30Q9sGZUAPYjpEtJOvU/tMW4wcFnw488S3ovjmT/NuUiS6OWmPhLytmot GdIRarV8R7Q7GwnROA69kDFJo2X2PxjEXGq6ZhN7xr7mjj8bR1HK8e8GiYT2niCIEFYI NasVkF6JQ2FCV2Vad9eq4M5xf7aiYHycKSBfLkytoB3nLaeuVZHWtGuZCr8op8pXYUix Sf/o7YL+3a36IvYd/vF+l3cS9ccvAi4QnnoSTrSfGDOwIIx9/5WeriXWbAFoObpms6IM f8pMxvxCQ8iUygNqEDPS1cgztHMyE0/gAa7cQe1FSwhy+564aLafOl3PmVOsEgmXEPQn /r/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745810072; x=1746414872; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=srTtWDqh3kQMLPOwQAdxuFWSFY3XFs9WRxLvh2UhnqA=; b=uiGXRUGs2XBxXkHjgPcrKZhR8dgn9RP4Tpc6uDAdb6em8j8VqVw6tPmXry1Ujgghk+ tODJAAbE+MtIUU5YIuprd7mxEJtUXWUfMsxQZfgghSSmQF8AnSISQYC+1OCt8Q9/iV3i kZzATn55jCqzJ96e3wK2FnetJWFshDEb2kvIEQzRXGLEsb9xq/vr5qJlgLOnKaZnZG5r vRnTqhWmEWuPCl6WrXaKrbW55B9IrAYUdpCB8TVj3V6WKbpfwhHL5noO4mq19IRoALDM vPc7MpjsSEhGZyvKuCDXUEbJma08/aZ9CatUT8+/klO6uj6hEWbOSu0o0KZGJiDGdhvF gWww== X-Gm-Message-State: AOJu0YzPPbg2TmCYVzEOeenWOXiF7I283PWd0rxaDEw5MZgTTrq4SaDu VLqiCGEXp5IO5r1ZVbEMjIz03uvke4+ei+UUmFgJcd7hcCj9pTy7oV8RLuuZ1Z/5sNt+Hk7XzLJ ND8hk93PBhfv3Jdct4wN//Vyp+CU= X-Gm-Gg: ASbGncvrqELSndblnfI9+VcuUrlYxPEHlM6naQb51C+JyxKhuYkJH4fTSwknisPAGVN 75w42FQ9dmUUBMIw4mx7EHHsF00FI4qIN56+zzY4LVT+SzI+RW5nf4xP2xq8oaIaFso+lAm0Mv+ hOFXFs7MPnRDrbfYP/lI9AeA== X-Google-Smtp-Source: AGHT+IEn2HjgQ3MC/kCQOvqNKw6rj+pLRg6NeOktYXf6W95x5dyt4F/WVGM7D4lMAWpiUTq8RIO2muGQG3pluCH5GMs= X-Received: by 2002:a2e:b8ca:0:b0:30b:ef8f:cc94 with SMTP id 38308e7fff4ca-317cde057bcmr38431301fa.16.1745810071641; Sun, 27 Apr 2025 20:14:31 -0700 (PDT) MIME-Version: 1.0 References: <20250427185908.90450-1-ryncsn@gmail.com> <20250427185908.90450-6-ryncsn@gmail.com> In-Reply-To: From: Kairui Song Date: Mon, 28 Apr 2025 11:14:14 +0800 X-Gm-Features: ATxdqUF4tu_yJM4m3azkj-yEQyWmTm-bxfC_1US0-DDxYPavH7Z79hfpBJQBsQ4 Message-ID: Subject: Re: [PATCH 5/6] mm: move folio_index to mm/swap.h and remove no longer needed helper To: Matthew Wilcox Cc: linux-mm@kvack.org, Andrew Morton , David Hildenbrand , Hugh Dickins , Chris Li , Yosry Ahmed , "Huang, Ying" , Nhat Pham , Johannes Weiner , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: A6A2F1A0008 X-Stat-Signature: cpcam8r4ezme4dph95q6kxmnsf4cpina X-HE-Tag: 1745810073-895181 X-HE-Meta: U2FsdGVkX1806ZCpqsAUGBi4ydo5rcfISuBl6tJbDpq0Y3tJBMwT0ycY/+r4ljeZcvP77shNG+xAXaWHK5ie7XcAbobum5L1nWHJfocK4n+o1TaVWc9/KFQ83XTf/f69qH5ZgTyBdE4odR7PDwRv3eQpc1FTX89zpuUvJA0RtnUR33QbsZ2Kq/dWPLoS0eEYefhLKaiZu597ohqcJIhhyz1NOfNxKJs/Scf2JcGwS/Z08VJ9G0pEtlPKhW1jvDIy9byv1XLIgVMEv1XkXUN/lXvPBtswkUIENrfGxI9wxqQnghoDuVNGgf/W61Zp4FSGxuPIU1ie4oFV9OyMGQm88J28hF5GiZSQ8lW/ZUIzwqIlRFxX7oMj2CJk5JtsbRI86OrpG13khN5riwjIrJr31xkDfkWzORPG7B2AaKX8LG0Sg8XfLcCVNUbXu+jth2kFY+RDt75ly6SdDlnFDPXJ07CPfwU7IeY4tUZwmWokt58fxpD6AFAqm9hhirfGLV+ghsufvF3Nq2yDEtu1ij4e97HHRO7SbwJ7ZpMHRoaSqUCCV2Bij39ZkPKb0odA9nHcanHXYf0Q8001mjO3UI2xJcdFKjVrlCcgBMvx99a1dS/FP73wi5e7N3UYtGsntHJFw2UZWl7CVamzByo/M7BQNWvD0ZSzzc+BkrErc8JwO7GlZCqjbuHJ9t+VAqoCie9ZsTAAxWDTFoM1iDFTL1vrR7i8jhkE8YsHmgBnMF9FEXLu7B9+N01sZasSVI1bgqEl89NgT/Dk4XK8F3kwOiUictBGetoyZWEvXadKlK1Rg6sKlM1HnSQiUn3DN3438SZoVtCITSRebSwdaBh8N+YXnwG7bMden8y7QHf6Pd8UCu+8c37k2A/U6Mks+guN8wQBT6d06E7zC113uapJhlqQ34qFzBXDyoZpdZuHdYXfCWvIoSyJpD7t5ofTxpYAjviRERKMf3wzT7pkGp+p+bm N7zTqi1A yeOyu9HQo69ZwBLV+Lb9S1USLYw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 28, 2025 at 7:58=E2=80=AFAM Matthew Wilcox wrote: > > On Mon, Apr 28, 2025 at 02:59:07AM +0800, Kairui Song wrote: > > +++ b/mm/swap.h > > @@ -50,6 +50,24 @@ static inline pgoff_t swap_cache_index(swp_entry_t e= ntry) > > return swp_offset(entry) & SWAP_ADDRESS_SPACE_MASK; > > } > > > > +/** > > + * folio_index - File index of a folio. > > + * @folio: The folio. > > + * > > + * For a folio which is either in the page cache or the swap cache, > > + * return its index within the address_space it belongs to. If you kn= ow > > + * the page is definitely in the page cache, you can look at the folio= 's > > + * index directly. > > + * > > + * Return: The index (offset in units of pages) of a folio in its file= . > > + */ > > +static inline pgoff_t folio_index(struct folio *folio) > > +{ > > + if (unlikely(folio_test_swapcache(folio))) > > + return swap_cache_index(folio->swap); > > + return folio->index; > > +} > > I think the build warning can be cured by moving this outside > CONFIG_SWAP > Thanks, I will fix it in V2.