From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FA44C5AD4C for ; Thu, 23 Nov 2023 10:51:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 131796B0664; Thu, 23 Nov 2023 05:51:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E1326B0666; Thu, 23 Nov 2023 05:51:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EEA7D6B0668; Thu, 23 Nov 2023 05:51:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DC2736B0664 for ; Thu, 23 Nov 2023 05:51:34 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B5C211CC022 for ; Thu, 23 Nov 2023 10:51:34 +0000 (UTC) X-FDA: 81488902908.17.B4CF372 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) by imf18.hostedemail.com (Postfix) with ESMTP id E60861C001C for ; Thu, 23 Nov 2023 10:51:32 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=h0zwLzwH; spf=pass (imf18.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=ryncsn@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700736693; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YwmrQxHTU1CAY1ik/8lG526otmBtdlTxUGsXkGRD6CI=; b=x3tuSuFqM7hOxr3l+GLLCPSGNX4es6aG3KGgHFmHgE4NZQYrJ9ExiZ48zt3L4I2qBuR9mF x+h+Nqj0Pykpb5rWFNT9NbCaReulGrC9nV/J9UAdbbzulcKFozW1CK0htjGNMZSyrX/pBi HiCI8t9K7Qn5wFavFI+yihHJD5YOs+A= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700736693; a=rsa-sha256; cv=none; b=bHJnz0NrUZAo75tbBYw4+MX92MBE/Z9YEVa3NZIclXuKu81z8npZFrLeJYdjmBLMnBGkDU 8ALUMqDeiWsitOYKXgpU/VtNje+E7SCgIxgN29n2b4sdZV66ns0T0nhMq/6diYynp5+jOp wv3d3vWGxjweQVmVAW2NC2rNeHne+eQ= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=h0zwLzwH; spf=pass (imf18.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=ryncsn@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-2c87903d314so9296751fa.1 for ; Thu, 23 Nov 2023 02:51:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700736691; x=1701341491; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=YwmrQxHTU1CAY1ik/8lG526otmBtdlTxUGsXkGRD6CI=; b=h0zwLzwH3F2pcTMJq/hUCAqK2RC5Rt0JV6TdhE8vlBwU3tWhf6+LjxEMIQ3QfoY4NE 5xIEeoT4rEQk6lCS0Q7XH+l2cY4ClnN94rKoqqHH++yiACLGWFbMZaOQWG0zIIr6AbnZ wmwjOK2mPvru6zppFCkOh4xOuVVfmWj1AEAKBtGzs7M23b4Hxn8j270qyej8EtBusuEm VdC/23VoEtKA24fRPCaETweLNmYU5tRTMfOAwO2C1rRpnxNVBpyBxcCrgAdrwkGWVTVP KiTx26W3Q5wecDy87Ue/+W0/UfsKyYs4fpES1O+8FPYntieJoXhLVWpZy9knQ/w+kWJm w4Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700736691; x=1701341491; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YwmrQxHTU1CAY1ik/8lG526otmBtdlTxUGsXkGRD6CI=; b=BJitJ0zl1Z9FZz0TBA4honmD48UQm6MEf3sTdOvxFuzcoIZpx4HTVUXp01mGVyDdpE 8GTcTx78R6mbnTioa8JINMt3sg+om55HOKQkOcqXR3Ya93sUKXa9cWzO06In35o3KY60 liNSM/OTgbKOYy3yq7RpzXVtypybh4HuLZRHn3Tq9+0HXXTXLqvcZo0O+l9+DbKazU83 xuvbJH6qooM4L8knzv0UwW3zaHrF5Mj1Vcj3hQtwStQjI9MEeX25iaWSdLHkNzI11RuJ BKI0tz5H3mx65WOgeVONs3NbhA9g4OwFCORGZrHiZRD4T6ijnWMIkPSS12hPL0opBnZ3 ATrg== X-Gm-Message-State: AOJu0Yx4goEmL/WcRVaH1D9JBYcoKQUup7V9U34I0AB4KZDdmM0ZFPr0 uJ1UZwKkbF62OC6RfRzgxqSieaero7XHw6FSsXk= X-Google-Smtp-Source: AGHT+IG/bNRUZnDOK8JBHt6VPrcbVxdIHI6XPaKwYdXRcBEqiwDsjykl6EI0sBO9H1n+8AIlxzyLn24s3GHw/rvOVBg= X-Received: by 2002:a2e:a988:0:b0:2c6:c3ea:af7b with SMTP id x8-20020a2ea988000000b002c6c3eaaf7bmr3896551ljq.5.1700736690883; Thu, 23 Nov 2023 02:51:30 -0800 (PST) MIME-Version: 1.0 References: <20231119194740.94101-1-ryncsn@gmail.com> <20231119194740.94101-7-ryncsn@gmail.com> In-Reply-To: From: Kairui Song Date: Thu, 23 Nov 2023 18:51:13 +0800 Message-ID: Subject: Re: [PATCH 06/24] swap: rework swapin_no_readahead arguments To: Chris Li Cc: linux-mm@kvack.org, Andrew Morton , "Huang, Ying" , David Hildenbrand , Hugh Dickins , Johannes Weiner , Matthew Wilcox , Michal Hocko , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: E60861C001C X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: i6h56k5hfdf95yup7zr3guaqdjn4h3d5 X-HE-Tag: 1700736692-185722 X-HE-Meta: U2FsdGVkX18zzMgCh8MxClMc5GYU2N3s3ckFKq5iSsqkYOnDwskOxoHqsnbrok6eGte2D+85QKWF0ycXqsBuDPfxXnqonlvzGCxju8JAhxTnyZ4U2sGzZsJqAqsqrjeFr/famrWQjFqo/8qYn0tR+zl/yMHRM7YWkdMhPUkHzT/jp9rEN22aqoC340E4EPAH1+WptoCmJK6NXTkNbJtMpq8lcGR2RDb5HRkQjNM42atSfW+NCPwHQ0BNcsLvTtg4ADzYSWB3l48KQCtR7vF14r0JfHzxxa1GuT/maWBG4Nd0PCsvuCyRARst+m8iDDNULl8YkbduVrc4X2HsQJqY8HN5/inVRDirgbENYKil4lVbgLqOpE5LqnDE5Qm/CZbSldxurYIwvY/+KFFRILrUWCb0f0zl6DPhjEW61dOka2KhcRatWF6/JvG7L4a6p3hktMM8ScI4/WKxfApixBl0HTMyRcECesVsqD0ECblSbnlK5T+s7poH1un07xYcbq53k1nrbaximU+qL0Fgr/NV03Ur9/eWLi3Du2K5UFH3sWM/yOVwIEOocHH2MPWHicEf2BsshjBENLBxtCIYHF9AdT1M8aHlWN2YzE9zkjgT9GqclbIkTgC9KoOMgStko8Ees4dyXouRCO1PfN1Gqc9xFKNjBlY31kP7oHdtsgApqi0Opqt6gcS4UUprzKm1AXHtiFHwAAjaZ0g4KrTP2txv2MEXycqsqNkb4um6wlxSFyrg/GYVGoWE2D9Hi0rnYj4CvUIK/PvdX1/mqm0qaQs1ZZwioHOunqgsonDCPOzq1STr1sHypbVmZdHM9O/EGSnUlSbUBXD+8YY6kpy5rsq/6Vvuzq5W3nVrka3Aq4SSbNBA8ApNZWBzJWcGYfXKjGCVppSnrNZgAMmtN8KhGsdgQYCgr9obtd7R0dIKSEQK0/19WKnK0YLtKjeJAGm1q+p1cnKaBzWrr0cFLxOVGo7 wwHcdKTc KQXdeHv7vBHxMMEtEYxJe2kiZNeYeuLCK3lrkuR8s4upiqXuo+jk1gjg7xlMgEkJc29G9jLyEzdrJ68ZhObPfl0ABMWIn3yzAyrTcgjFtYU3eLdTJe+qnRrTtS3K/t8b0BPLLUbVMVIoNASR4s6HV7EZLx6fmjyIqr3M06ZdrZ2dsOTiusv1rOlex4y2DmK5leCv3G7Qh+0va37zd9nKozD2SU0Cbl7GvVAF93hN9W+nATx1ICgbr6QUFwV2x7jn5CUBGfowIKW+hIPKvZlk2UPK/3GSTuSgdjqlFAiVULLkLS92QHH5xfAOVz+3HtGikZLD5uQIatjPskHmKTsvP9zQ+Fsn+8Z9tMgGwuDpdVM5cYdb7U06cWUR6hGc2xuMXaagwxQzP1EtFExfYtERD/jC306Pn4zkUdspMfHA0+FwF+hmvEvdf1/k941OkDAcJ+gzeegbTgFY6wUWjsJF1JVzfPt38zO4FfjrfmGvNzJSOLwrUcVNtbR3du29w3d0mNBcntjRGE9/C/5jBgE8M/MaDJ+KzA5Bbbn0a X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Chris Li =E4=BA=8E2023=E5=B9=B411=E6=9C=8821=E6=97=A5= =E5=91=A8=E4=BA=8C 14:44=E5=86=99=E9=81=93=EF=BC=9A > > On Sun, Nov 19, 2023 at 11:48=E2=80=AFAM Kairui Song w= rote: > > > > From: Kairui Song > > > > Make it use alloc_pages_mpol instead of vma_alloc_folio, and accept > > mm_struct directly as an argument instead of taking a vmf as argument. > > Make its arguments similar to swap_{cluster,vma}_readahead, to > > make the code more aligned. > > It is unclear to me what is the value of making the > swap_{cluster,vma}_readahead more aligned here. > > > Also prepare for following commits which will skip vmf for certain > > swapin paths. > > The following patch 07/24 does not seem to use this patch. > Can it merge with the other patch that uses it? > > As it is, this patch does not serve a stand alone value to justify it. Yes, I'll rearrange this.