From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D41E5E77188 for ; Sun, 22 Dec 2024 14:52:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EEABE6B007B; Sun, 22 Dec 2024 09:52:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E9A866B0082; Sun, 22 Dec 2024 09:52:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D62196B0083; Sun, 22 Dec 2024 09:52:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B73136B007B for ; Sun, 22 Dec 2024 09:52:16 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 57272A0550 for ; Sun, 22 Dec 2024 14:52:16 +0000 (UTC) X-FDA: 82922885052.02.AFF33E9 Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by imf12.hostedemail.com (Postfix) with ESMTP id 68F7D40006 for ; Sun, 22 Dec 2024 14:51:58 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HjzoyvqC; spf=pass (imf12.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.174 as permitted sender) smtp.mailfrom=ryncsn@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734879117; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DB3sdebpXYYJOerevv73QbgckDNE+leDhLSWxTaMCUo=; b=m82f44UuN4izZyTbpmxy1EgRUCvWD1V0WimvQopUqH9hcchN2hNPOganYEuc2NCYTNt6mm GAnr424nK+lGUOZ4nbP38kq4TIRMWNOA6rzEWdEICzxTHc9eDdQGfLAog0iCqzWInHPO2w KANw1Bwf4l2aK0AAlxtapYaOGlRPfA4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734879117; a=rsa-sha256; cv=none; b=52+j2zBkZSCwL2STYJKaPN+wQ1WR9B1CzE/9KEMxvQoT0xUmdJQfgo5R72pN7Lf5p3E7SC OfhKMum9fb178C7oWZIKTkynXatiAwwww6xmmFPFmKT8qdnm+7YSmV1Ntq5EuFCYTP+/CE 1xTa9oB+6D2hcvQAzE8ya9kwZTbU/MA= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HjzoyvqC; spf=pass (imf12.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.174 as permitted sender) smtp.mailfrom=ryncsn@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-30229d5b21cso34127931fa.1 for ; Sun, 22 Dec 2024 06:52:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734879133; x=1735483933; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=DB3sdebpXYYJOerevv73QbgckDNE+leDhLSWxTaMCUo=; b=HjzoyvqCbdjAbFGvsihGr4pn/ver+gCUcU7xP0bhZ6MuRTSy0DY9nm1Q2ETMyFeMtg 1wZ+/l+kNfNNwenU3xOAvXtX6P6zddfyRlsHXfDMDOymVku/JFvIrl7T4e46eRcDDTO5 a5jYqTomAbBcwskiNvIJU+PfWf9S/UOpV10L3BY5T2PxxEkqjcvQew1sHRcGjKzguuJZ hStmALMPYPUkkCkocftds1jWEwYNArtLSV9o0IPlRtVSnuoVnXM7FHs7ykH9hvebwl31 yL0t5M+sJ+cphke1UjpgxvRJga6skoHpKRj1M59EJS4xwBIFysxvDl/y04/jz+ofbt6u 0iWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734879133; x=1735483933; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DB3sdebpXYYJOerevv73QbgckDNE+leDhLSWxTaMCUo=; b=DviU+CYJJ6xpRqBGg0ctBVdUxjYiyjYpPYwMGf2aH8FAlnHUUEIRV8OgaX/ux85cGL U837zs5KQXmUy2w1kTZdzgw0j5lqsBo87NORorAG9zJCELV3oLl9Jyf0WAu4XvqpbzZp aEvlHV1s3coszSRcYI67hpbS1+5lwWCJOEcz26kz3JiLGierpY/Vaj00zDuLEtHaKQgv e0WoDoZTLES9rF0GoyD3MVIBeTDQHApclZULb8/pG+OOGQBTwrmul7pngbVrPjaz4Y3p sTA510qpEK+CmsHn3uqjzH2upA5Y3z5LUVlkF12cNInfj0nD5QqzigAwCJJc5cHec6ch 92ZQ== X-Gm-Message-State: AOJu0YzO7xEj0K+N4/oaTIeBajcrVOnXgcza/crpHDw8H/gWu0ZCEXii +CbJsHlbC8HaizRk8f6GgosIR8Sc7Lg+qNa7CNhW6IQ7ekm/qgPoTRIq5WieM6v4d8KDRkqgqSN prTNjtNkWjGZFRRs35H32In5ezFo= X-Gm-Gg: ASbGncvxBqlg+r3Y3+uYTJS50jKB4Keh9SdQlyukX9D76VCfvk6vuv8CZv7yq09/b5r NN8aFBg3gm32Jm1G2Da/sNG7pdz7/OMNBADewUQ== X-Google-Smtp-Source: AGHT+IGviXzOUjNj5t7IbzuuAs8dMbziUWi5RP8HRrxG2M7AN1tJVeXvVX+oDycR1Xqrfq2x0dJu+8sdLBN9xoxqENQ= X-Received: by 2002:a05:651c:506:b0:300:324e:3504 with SMTP id 38308e7fff4ca-304685c0fe0mr27045571fa.27.1734879132338; Sun, 22 Dec 2024 06:52:12 -0800 (PST) MIME-Version: 1.0 References: <20241218114633.85196-1-ryncsn@gmail.com> <20241218114633.85196-2-ryncsn@gmail.com> <87ed1zj10t.fsf@DESKTOP-5N7EMDA> In-Reply-To: <87ed1zj10t.fsf@DESKTOP-5N7EMDA> From: Kairui Song Date: Sun, 22 Dec 2024 22:51:56 +0800 Message-ID: Subject: Re: [PATCH v3 1/4] mm, memcontrol: avoid duplicated memcg enable check To: "Huang, Ying" Cc: linux-mm@kvack.org, Andrew Morton , Chris Li , Hugh Dickins , Yosry Ahmed , Roman Gushchin , Shakeel Butt , Johannes Weiner , Barry Song , Michal Hocko , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 68F7D40006 X-Stat-Signature: uatyuty3cxihhz5jbpdqc9147nyziuop X-Rspam-User: X-HE-Tag: 1734879118-343180 X-HE-Meta: U2FsdGVkX1+kg/wmVfmmDBgo0c/MgxagcMfkHzxxDHtr1zCRFS3UUDNaTsgpVjxfASyLkUlCKBoCl+ZAjp8+v0FtsXu97JuaJA4x/VPj1ieyokQkyKm3+OAjOAe8nxZHBINI4+kfLUYXLcHc2nQueO1M68437sNX5dMvzzVD7zDxkNZoXvA4oNxtvWCQtt5CM6p5lhwXY5D/93sQVt/HHHq7fVmT3/XlmV3EJT1WC4KjSHkgU+KeJUHW5rstJmQReMvLOhO2AP+LiU5WNM3gjep6h0zaaBKAgCYYvr/fQD7wVT6vKv7p3agtLyhrVVd+IiLcHKTIZszvKGu6liK2/eFjc/2oHTaoME47N1mxC//btYBppM3rYm291sLlLkAF0fj2taxFDfdbrJKh/TUCsEF4aixmndCulzyRlNYbsuxx8RO5E+CKMeurmg5FRS95is3hZGpZEqtDuj5UVLKuLKfIm1fG0C6Ol8G+1X9yWv/R0uSrAj1zdYrmW/rE//Pw6mm7S+pWr2I3y180eO1VPSY+8lVK5algnomGSMJ5ivZQHg8EdLxjtM1CDDHm3ciIBOVuCqbXuHRNKAkMrJvAkMWQe/McMXjJ/N0sMC/Sl7SpluriiZYdcK9QbyNMRZ1k9s+XUhfw/ZLppIlZtT5bkJwjA5P/91ZisTJNgvJbgvkOHZONFTY7bDFs+BWwa/FgA8n1fz+ZmV5OtI9y5B//6c/uITWzbMMY9mE4xhvtH9xvnyfRlSB7iQoNUeRCGqNZ1Fi9Sp0Y9Tu4n+L3PebRSXGcdt8hyrmpFQaSOInYmZPJ+kvY9ksr0XCR5QspxAOM0JnbHgl+rc3HX1n1sp/i/594b9VS9uiW1JPIYWLOtHv55bzRe6T0yE5VKd/ugF9zYUwsKK7ERBgNhf6ysPtNUQ2Vwz5C1X76vvM3lBduP8NABJLtlCDU0qqGsQwfCcib46S4M0bj6zMnNBrYTGG xaRUlf8t 6JM1O7PFtlQ/JtroeB0hW+oU7yEHzReXzeiJMrmSDhuhili1vd8rxfhc1Fk+ZpE/27m+e3Y+kQm1RgFTWiC7U6/DpOO6E2PKwuGamwl/uvcqG5B9Ivb9BkrTUTr/Zwb0IprjfcqPwzT0siXaU5IAFEB5kGk4S+ItElkvSITlG/UEISpHJwwdmucR1R2pQ6hA9zlEwOktfekXFuXXWpA/8goawpcUv4XIDG6E1+y8cKXNdSlq1cdyWwcWvKVdyYsW1poksRqE4YjPwGJEp/D4BOYErSlgG4projyvGFRn7ZGOJ0VeND9HhjJUThn6azeCJ6rEZgiH1pB+8WhM5HvnC5036YYlK7lQndhVCKJhKBWoD2GySwB9oDZXb0a/c2cf4GwjcqvwUGF7BknLLusa6jWoyGtiXCN7bsTkkkiH8Ez/KQDtzWeZNdxOqTA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.004179, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Dec 22, 2024 at 9:33=E2=80=AFPM Huang, Ying wrote: > > Hi, Kairui, Hi Ying, > > Sorry for jumping in so late. > > Kairui Song writes: > > > From: Kairui Song > > > > mem_cgroup_uncharge_swap() includes a mem_cgroup_disabled() check, > > so the caller doesn't need to check that. > > > > Signed-off-by: Kairui Song > > Reviewed-by: Yosry Ahmed > > Reviewed-by: Roman Gushchin > > Acked-by: Shakeel Butt > > Acked-by: Chris Li > > --- > > mm/memcontrol.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > > index 7b3503d12aaf..79900a486ed1 100644 > > --- a/mm/memcontrol.c > > +++ b/mm/memcontrol.c > > @@ -4609,7 +4609,7 @@ void mem_cgroup_swapin_uncharge_swap(swp_entry_t = entry, unsigned int nr_pages) > > * correspond 1:1 to page and swap slot lifetimes: we charge the > > * page to memory here, and uncharge swap when the slot is freed. > > */ > > - if (!mem_cgroup_disabled() && do_memsw_account()) { > > + if (do_memsw_account()) { > > /* > > * The swap entry might not get freed for a long time, > > * let's not wait for it. The page already received a > > I take a look at memcontrol.c, it appears that almost all extern > functions check mem_cgroup_disabled() as the first step. Hmm, just checked memcontrol.c and I saw quite a few extern functions not doing that, so I think that's not a convention. > that this is a convention of memcontrol.c? And the benefit of the > change is minimal. In contrast, if someone makes more changes to > mem_cgroup_swapin_uncharge_swap() in the future, he may forget to add > this back. So, it may be unnecessary to make the change? This change is minimal indeed, it only helps to remove a few unneeded nop, still a gain though. I think mem_cgroup_swapin_uncharge_swap should fade away in the future, it's only for Cgroup V1, and it's a really simple function, just a wrapper for mem_cgroup_uncharge_swap, so I think this is not a problem? If you are concerned about this, this patch can be dropped from this series, rest of the patches still work the same. > > --- > Best Regards, > Huang, Ying