From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FAABC54E76 for ; Mon, 20 Nov 2023 11:15:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0B1D26B0434; Mon, 20 Nov 2023 06:15:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 03BA66B0438; Mon, 20 Nov 2023 06:15:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF6D56B043B; Mon, 20 Nov 2023 06:15:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C986A6B0434 for ; Mon, 20 Nov 2023 06:15:00 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 952E3A080D for ; Mon, 20 Nov 2023 11:15:00 +0000 (UTC) X-FDA: 81478075560.02.57F4963 Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) by imf05.hostedemail.com (Postfix) with ESMTP id A3C4410001C for ; Mon, 20 Nov 2023 11:14:58 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=OTeQW1fZ; spf=pass (imf05.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.172 as permitted sender) smtp.mailfrom=ryncsn@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700478898; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=haXSxEr8SHL2k7h4L7GLg+3o357Ly/kj2SV4CyscdCo=; b=rYCSR5d5OVrQH9k+WZDBKZALVYyIJOkv829Y+lDsgYCHwU1THqFd6/pzT3eUEfzKVIHM9M AFhtr+4vt+mQK/7mpLerUWF917jhEp+hyHY0Iwkyo3kFQCJcB66wRhXhOR4RNARUjHJGxS bUcDdpPLEfioWkmMZ3pxBMJm72lJb8c= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700478898; a=rsa-sha256; cv=none; b=l9SJtjRgretlpMx/G2IM0lykSYwQ8zltj30bBJxtfsLOr4a0aTa6UoTboLYdLbeha7iPS6 p09Ce9Bx5qDQ1ecyZutcAr2TNEXFAXyh53i8HrU2GLpkZKoJtzFFLLNYBmRXQqgZJPD/rR zfyaUlnC1rclTeqUZjnqblbFxzrVGqk= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=OTeQW1fZ; spf=pass (imf05.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.172 as permitted sender) smtp.mailfrom=ryncsn@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-2c87adce180so16864981fa.0 for ; Mon, 20 Nov 2023 03:14:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700478897; x=1701083697; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=haXSxEr8SHL2k7h4L7GLg+3o357Ly/kj2SV4CyscdCo=; b=OTeQW1fZ3vfndryBbNpVYR6MTWOW1lWd1v+p4oBJs22NLnNGJmc5bZ5pixNseCYFPJ RczVL+r57Ol06XvESDNZ0tag6B8I8C3nvI9xHKbmaWTJMjbfFYVAlzZGLjhL5LZvac7Z 0JYYPNOAuXkiJzRd3bbgeHdkBK9bWziESoC0xfxkEGLO1xetR5lXHMsouAHzZCjMNXrS TyDJnuJhtUZ74kNzkvJMIgMGE5jU1aA2sQUKAxGMhjKRe6+qKlBwUlkCXJWjbHAu9HgG rV6DqWUc0E+yseJVroG/+T9X8Riq8rWBuS/6tOczw2XyYo0d6fcBd76a9FljKslYeUi5 iY9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700478897; x=1701083697; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=haXSxEr8SHL2k7h4L7GLg+3o357Ly/kj2SV4CyscdCo=; b=FeVpBsaUYgycOtgWn2eeZhSC5Toxzw8t5aPDceXh1K2yWtpLjrgdJS0h6HhERC94Wu AihBCT0jk43yOOZuGSX4C+SEBFkqLGMf00dOKMwZgW6hNuIJ2FLVl8KWTA/JvryQysYl POdbcjy9BH2CnCXVdWB3uWPCJzEDjJjy6DtbW2QHsWhNH1vm01bM6D9gyN0v6dL6P9kL 08kcJMEfWQRUw/LrFif4qujPF/mStYkPw1fE8kFctwteCG5lJyArhWCNmQpVONFz8e5L l3P0U2S4wcHNqRixF7m1Dnir/qhj7qjZYa9Ga809hWloPLONMsmyUjlGAOQULbPjYQyF joeQ== X-Gm-Message-State: AOJu0Yxc2qP5yJhBLWHFro49fiBLx2Rv0MycOb7w3ce8fU6x0aPhXiY8 Q5eMYHGjlTjPVGhH+u2Vb4UbX2Uu6dXRJlsFkJvIfOtZ01jekg== X-Google-Smtp-Source: AGHT+IHda1+XicvS0ufYq5VLBr8oYzW6t2wOCQxIXHo6dpcVZVP27gJWMDfd2kc5E5X7Z/hjw0FCVrchMV8HjQgGjWM= X-Received: by 2002:a2e:2a83:0:b0:2c8:2e3a:e974 with SMTP id q125-20020a2e2a83000000b002c82e3ae974mr4676611ljq.44.1700478896638; Mon, 20 Nov 2023 03:14:56 -0800 (PST) MIME-Version: 1.0 References: <20231119194740.94101-1-ryncsn@gmail.com> <20231119194740.94101-4-ryncsn@gmail.com> In-Reply-To: From: Kairui Song Date: Mon, 20 Nov 2023 19:14:37 +0800 Message-ID: Subject: Re: [PATCH 03/24] mm/swap: move no readahead swapin code to a stand alone helper To: Matthew Wilcox Cc: linux-mm@kvack.org, Andrew Morton , "Huang, Ying" , David Hildenbrand , Hugh Dickins , Johannes Weiner , Michal Hocko , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: A3C4410001C X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: z7g19cx1emxguwsftirq6qxc3z9y9c5j X-HE-Tag: 1700478898-352286 X-HE-Meta: U2FsdGVkX1+XGVTQDPH01Dh+Nl7Z22LO2+o8qpxTt6LZEbxOV7yMNI44QKxdEl11nrRYGGAG2VQ7Q2eEEoxTwzSNRNxaZRB8X80N+eryO/vzXmUDMqRq1GcEAYXOiNCOdGgLvlayux55AIPK2f8PNfko8eL2YS8YPH7rzR0aCmvKdEBx/KPoeDypEKqOxorR/CTdutrvp3ZLJdZcxF6i9/mnHLmX6lOXP6op6ap+VqyWcu+9f402L0I13FjeAzymCyFaY4TAkMYqhX2l71plLSMU8GXv2wTsdkymt4R7X8SnzGM1Kuk7khF9c/+1r/9UFgbobW5SpA4zUJFJV3RY83kepki4K9sHO7h+NyQqp+ngtlzS7Lhujq5ZQ3SMSCS3Zqm6rQtwmFGetyyppNOqEnPwmdUDZpqTB7smdWVEjl65hjOlREsv7PGTmtUI2NH/AOxBBncNvgBiScbBKh9l8TkdIIn/voyhRIc6gk6i7TLT4w3fHC5SuZyKPs09UFn9bI+bjqSG4LlySm9nSaEhSimDaeE5jvQqop8vHER7UtL3Wh+MA85kHquyWRiza0/1bia+UUPL9qdwBFfFALVbuOtncD5Fi1njXbAUbi9qPGKwEIDXi0lNkhj/QH7l4BXIXLCryTM6lwdtaRHOuhAh9vAS4YRAwuv+wi0SxYyjDtdunTIefAdhru9feZ01Ee074y6894TG4PJ+koATpos7rrN6/X9Yv6JWxnxpkOOw3FQ7ExasGrw97I362PfYuPGcN29clL1N/1NleCOe82VJZwYi453nmMfxqPVS55ZrUlLABPS2Hh+cgnbRfdMwn+2gGnIKn5KP9GEmt3vDEmhonhKXWOaLg90XDMyRe0o3280jNtTXn1q8geeXjdPkfOiMs9FpbedYqjwtPkSCySXLE2KJRUpDAzHadFjOdzwQAWmtZy52pOlqxjpj1AyTo2Tq7cn7/Hq4S6cxnUVG36a x5ww3Ls0 sGWiAnXxMg4dAFmSqbDSga64s2g6vQOhQLme73eRx9jDegYpM3xcUQ3Tj5CmNQSaSLPfvn/DFktzz3bIBJqWaNc2vMuHtUwEfdcw0JeIeDm15kjCf8IOGKo7eMipxzm/TbHG7j+FPZoREsze8xmJcnXqc1M2+r9a5jZg8BPuJrYFyv2yJZ3Haqo6nhhatdanN3P4WnhUyMQf1k+AsCRnyCX4Y4qeOE4RoLY25gKRwFr3oXKevvq4gA6oKwqys+3DXbDzIAOxL3cH9SclzuSvIolk7EXvByqmH17JNuN45bMjynoD9riFrh3QSqDunE9YFflxsGpGPvNExOC5wJftZ3i4S/f4QjkMpMVUEIlvkTCqqn9Djp8AuKcuCBNeR0MCBIfrmWVChsdpx2M2MlXMB5iPaPEggLU/GS3t8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000865, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Matthew Wilcox =E4=BA=8E2023=E5=B9=B411=E6=9C=8820=E6= =97=A5=E5=91=A8=E4=B8=80 05:00=E5=86=99=E9=81=93=EF=BC=9A > > On Mon, Nov 20, 2023 at 03:47:19AM +0800, Kairui Song wrote: > > + /* skip swapcache and readahead */ > > + page =3D swapin_no_readahead(entry, GFP_HIGHUSER_= MOVABLE, > > + vmf); > > + if (page) > > + folio =3D page_folio(page); > > I think this should rather be: > > folio =3D swapin_no_readahead(entry, > GFP_HIGHUSER_MOVABLE, vma); > page =3D &folio->page; > > and have swapin_no_readahead() work entirely in terms of folios. > Thanks for the review! Good suggestion, I was actually thinking about converting more swapin function to use folio in later series, since that involved more changes, and this series is getting a bit too long. I'll try to see if I can reorganize the series to cover that too in a sensible way.