From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69CCAC28CBC for ; Fri, 1 May 2020 02:33:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1E0DD2064A for ; Fri, 1 May 2020 02:33:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZJKCu/Cm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E0DD2064A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AF7E08E0005; Thu, 30 Apr 2020 22:33:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AA7868E0001; Thu, 30 Apr 2020 22:33:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BDA98E0005; Thu, 30 Apr 2020 22:33:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0229.hostedemail.com [216.40.44.229]) by kanga.kvack.org (Postfix) with ESMTP id 857258E0001 for ; Thu, 30 Apr 2020 22:33:45 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 2B7FE5848 for ; Fri, 1 May 2020 02:33:45 +0000 (UTC) X-FDA: 76766579610.15.frame71_3dd29ae638424 X-HE-Tag: frame71_3dd29ae638424 X-Filterd-Recvd-Size: 8817 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Fri, 1 May 2020 02:33:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588300424; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WoEKQ4lWoOTrBQAr9fSIywvhXH2CJ/MfFxWkNiilf98=; b=ZJKCu/CmsK/6FisRxgFiLPGjtyCgkcVd1sf1yF6ECXuNLS+9e33VvGVIszgYGBOyNgKbcS 1GeA6J8U09WvrJWPFn/X9IbL9oOshKcwYMfHEXfYX3Cg35RiLLxiUGzSSUYNFBrkpi5N4V f3KpKSXT9U5kpKT1QuXnJFp5ClySC6A= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-379-dt6R-0OGOiydRW9McnNyYQ-1; Thu, 30 Apr 2020 22:33:40 -0400 X-MC-Unique: dt6R-0OGOiydRW9McnNyYQ-1 Received: by mail-vs1-f71.google.com with SMTP id z15so1984663vsp.12 for ; Thu, 30 Apr 2020 19:33:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FmTXwQDIMo+IjpBIspuTIpC6trFCfV96jFy7feBDa3U=; b=X/Nr1MwKo9gzazmgIHU6BvlUtXQ/99jiGncipWgh35Zplpf7jSot59JfFOdZ7yGcEz 7iFLvcTpDzrUyDzVwcMR+MMAHMKlr/dUb/LX82gdx6M+tD5+2U+23V6/YzDzXs2XEYG+ xHbPXwacsjRdGPTbFGFOi67jgknyaVNBn0bCQNaYuvjaFTEslrMtA92v6y7eGP8xftmr 2kkLNIWb8TDoNoPmqJGlN8r9UJTZaWFRIB5KxV71/qQBdBTqa5sDrdzJd3WZhurtZHrH oPXDb8zujzdjndOpD/eIy/lFPBMdw8Nwaf8gNCy0R2jwvSZaceqXASqRlauhVMMPc1z7 OsUA== X-Gm-Message-State: AGi0PuYa5d1sWvIjgGWGgrSQ9NviDzHOow+3RCDAo6erFQ5oETTbMh9D eLK5DJIc0fM+dx9kIwDpn07Y+9idp2VsE1JN5YKYOSQ3nipJMmJrx3+DfKkw6FDNKpvRywZV84a S+wBVWin9Pxjgs4VgzeFrPnl2WrU= X-Received: by 2002:a1f:4106:: with SMTP id o6mr1255005vka.52.1588300419596; Thu, 30 Apr 2020 19:33:39 -0700 (PDT) X-Google-Smtp-Source: APiQypKzJZChxr1bIOT3BrCLUuQh+Ikon7C/tnK/FqweuMnIX4otnNYFiYRZlgH/GIaMCFHcKeYabPii/TDhlHZceM8= X-Received: by 2002:a1f:4106:: with SMTP id o6mr1254987vka.52.1588300419383; Thu, 30 Apr 2020 19:33:39 -0700 (PDT) MIME-Version: 1.0 References: <20200414131348.444715-1-hch@lst.de> <20200414131348.444715-22-hch@lst.de> <20200414151344.zgt2pnq7cjq2bgv6@debian> In-Reply-To: <20200414151344.zgt2pnq7cjq2bgv6@debian> From: John Dorminy Date: Thu, 30 Apr 2020 22:33:28 -0400 Message-ID: Subject: Re: [PATCH 21/29] mm: remove the pgprot argument to __vmalloc To: Wei Liu Cc: Christoph Hellwig , Andrew Morton , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , x86@kernel.org, David Airlie , Daniel Vetter , Laura Abbott , Sumit Semwal , Sakari Ailus , Minchan Kim , Nitin Gupta , Robin Murphy , Christophe Leroy , Peter Zijlstra , linuxppc-dev@lists.ozlabs.org, linux-hyperv@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, bpf@vger.kernel.org, Linux Kernel Mailing List , Michael Kelley , Gao Xiang X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="0000000000004b5c5705a48d02f1" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --0000000000004b5c5705a48d02f1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Greetings; I recently noticed this change via the linux-next tree. It may not be possible to edit at this late date, but the change description refers to PROT_KERNEL, which is a symbol which does not appear to exist; perhaps PAGE_KERNEL was meant? The mismatch caused me and a couple other folks some confusion briefly until we decided it was supposed to be PAGE_KERNEL; if it's not too late, editing the description to clarify so would be nice. Many thanks. John Dorminy On Tue, Apr 14, 2020 at 11:15 AM Wei Liu wrote: > On Tue, Apr 14, 2020 at 03:13:40PM +0200, Christoph Hellwig wrote: > > The pgprot argument to __vmalloc is always PROT_KERNEL now, so remove > > it. > > > > Signed-off-by: Christoph Hellwig > > Reviewed-by: Michael Kelley [hyperv] > > Acked-by: Gao Xiang [erofs] > > Acked-by: Peter Zijlstra (Intel) > > --- > > arch/x86/hyperv/hv_init.c | 3 +-- > [...] > > > > diff --git a/arch/x86/hyperv/hv_init.c b/arch/x86/hyperv/hv_init.c > > index 5a4b363ba67b..a3d689dfc745 100644 > > --- a/arch/x86/hyperv/hv_init.c > > +++ b/arch/x86/hyperv/hv_init.c > > @@ -95,8 +95,7 @@ static int hv_cpu_init(unsigned int cpu) > > * not be stopped in the case of CPU offlining and the VM will > hang. > > */ > > if (!*hvp) { > > - *hvp =3D __vmalloc(PAGE_SIZE, GFP_KERNEL | __GFP_ZERO, > > - PAGE_KERNEL); > > + *hvp =3D __vmalloc(PAGE_SIZE, GFP_KERNEL | __GFP_ZERO); > > } > > Acked-by: Wei Liu > > --0000000000004b5c5705a48d02f1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Greetings;

I recently noticed this = change via the linux-next tree.

It may not be poss= ible to edit at this late date, but the change description refers to PROT_K= ERNEL, which is a symbol which does not appear to exist; perhaps PAGE_KERNE= L was meant? The mismatch caused me and a couple other folks some confusion= briefly until we decided it was supposed to be PAGE_KERNEL; if it's no= t too late, editing the description to clarify so would be nice.

Many thanks.

John Dorminy


<= /div>

On Tue, Apr 14, 2020 at 11:15 AM Wei Liu <wei.liu@kernel.org> wrote:
On Tue, Apr 14, 2020 at 03:13:40PM +0200, = Christoph Hellwig wrote:
> The pgprot argument to __vmalloc is always PROT_KERNEL now, so remove<= br> > it.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Michael Kelley <mikelley@microsoft.com> [hyperv]
> Acked-by: Gao Xiang <xiang@kernel.org> [erofs]
> Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> ---
>=C2=A0 arch/x86/hyperv/hv_init.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 |=C2=A0 3 +--
[...]
>
> diff --git a/arch/x86/hyperv/hv_init.c b/arch/x86/hyperv/hv_init.c
> index 5a4b363ba67b..a3d689dfc745 100644
> --- a/arch/x86/hyperv/hv_init.c
> +++ b/arch/x86/hyperv/hv_init.c
> @@ -95,8 +95,7 @@ static int hv_cpu_init(unsigned int cpu)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 * not be stopped in the case of CPU offlini= ng and the VM will hang.
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 */
>=C2=A0 =C2=A0 =C2=A0 =C2=A0if (!*hvp) {
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0*hvp =3D __vmalloc(PA= GE_SIZE, GFP_KERNEL | __GFP_ZERO,
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 PAGE_KERNEL);
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0*hvp =3D __vmalloc(PA= GE_SIZE, GFP_KERNEL | __GFP_ZERO);
>=C2=A0 =C2=A0 =C2=A0 =C2=A0}

Acked-by: Wei Liu <wei.liu@kernel.org>

--0000000000004b5c5705a48d02f1--