From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5EE6C43214 for ; Thu, 26 Aug 2021 17:23:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 95D2F6101C for ; Thu, 26 Aug 2021 17:23:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 95D2F6101C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 1CDE88D0002; Thu, 26 Aug 2021 13:23:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 17E638D0001; Thu, 26 Aug 2021 13:23:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 06C548D0002; Thu, 26 Aug 2021 13:23:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0208.hostedemail.com [216.40.44.208]) by kanga.kvack.org (Postfix) with ESMTP id DE7798D0001 for ; Thu, 26 Aug 2021 13:23:06 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 6FA2B1848AB34 for ; Thu, 26 Aug 2021 17:23:06 +0000 (UTC) X-FDA: 78517902372.09.9B70994 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by imf28.hostedemail.com (Postfix) with ESMTP id 37BE690000B1 for ; Thu, 26 Aug 2021 17:23:06 +0000 (UTC) Received: by mail-pj1-f54.google.com with SMTP id z24-20020a17090acb1800b0018e87a24300so2910117pjt.0 for ; Thu, 26 Aug 2021 10:23:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wH3hjz5Y0Xv45SIfl4mx52bhrdxx31yKbdxzt4w/j8Q=; b=O8img967zJnwZjYSbKm2y9nE2f5NAiup6+YiKzlbxApebuTStRcqBF5n2aNgfUKRoW 5oBh29+jF1/+4A0JMGrT5lxW4UYXxdcKvHXe03zJ+prbWmjl1YWAYy1d/3uc/vgFavbi 25btJb3NiF3ewfDY6f4pUP+66eUnTaiS/At7ripDnE3wBzIIemsVCoE9z92uoREez6Mn pyvJuwPh4/VHcxv66Pi4pOc6A2s1u8SlcbG5TO61JS30jMW3KqLsLajiCXD8eqeOy5SR A/LxxA5omWZ72vQVFtV22PQ2w0r6ApA1FAdnAM1WYrIci0ugb+w8PnkQbUjvPdzeXieH IeIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wH3hjz5Y0Xv45SIfl4mx52bhrdxx31yKbdxzt4w/j8Q=; b=om27D3OdJYYxAWQOsDwrddSHVoM/e1DbvlaXvGl4MsQQILQbsEGOtGuC23qWv0av0o 0gV1N/se71SpoBJDqNUk40KaUD0i1txalbcEdJ7+dO9McUnSqkK2qzfpPYNvkL3jFp5z jTbPim5ZAPLRShOk8rE1lKWREkn2ByowN5kjxWpC0Wx6UuRqPMSvGF0YAF58obTUlRES PT+8isSTld24yZ79qAB0FbaHddn+28oq1r8kDe7H5FGOPNKqRpiLHZZo/WGDMSp5Rikl kjF10YWQgqTsWZm3jy/2UC+/ry0pJx7fNST+sS+870tb+YxMRasb5PXrwdWpuGGEhSCC RfSQ== X-Gm-Message-State: AOAM5338tMvDdtSxb7UZSdQyxKPQFuygjpW/CdTv+TVa3WhF5F4TuOau n994fdkcdt41tzNdNf9b+hEyHQD1H3XBcFK4R3k= X-Google-Smtp-Source: ABdhPJwJOWtbpTIuf1nV9PyAQQEEdDBk4aNy6OueVH9Kqnzqxo1RxNzQPIxgTc4FI2n/4NJ+QBmguIsoZ0wwsVopTTA= X-Received: by 2002:a17:90a:1917:: with SMTP id 23mr4407685pjg.136.1629998585112; Thu, 26 Aug 2021 10:23:05 -0700 (PDT) MIME-Version: 1.0 References: <20210820181201.31490-1-yu-cheng.yu@intel.com> <20210820181201.31490-26-yu-cheng.yu@intel.com> In-Reply-To: From: "H.J. Lu" Date: Thu, 26 Aug 2021 10:22:29 -0700 Message-ID: Subject: Re: [PATCH v29 25/32] x86/cet/shstk: Handle thread shadow stack To: Borislav Petkov Cc: Yu-cheng Yu , "the arch/x86 maintainers" , "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , LKML , "open list:DOCUMENTATION" , Linux-MM , linux-arch , Linux API , Arnd Bergmann , Andy Lutomirski , Balbir Singh , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Dave Martin , Weijiang Yang , Pengfei Xu , Haitao Huang , Rick P Edgecombe Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=O8img967; spf=pass (imf28.hostedemail.com: domain of hjltools@gmail.com designates 209.85.216.54 as permitted sender) smtp.mailfrom=hjltools@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 37BE690000B1 X-Stat-Signature: oqi69xu6nqt197abhazfp1wixr5r1wyc X-HE-Tag: 1629998586-14871 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 26, 2021 at 9:49 AM Borislav Petkov wrote: > > On Fri, Aug 20, 2021 at 11:11:54AM -0700, Yu-cheng Yu wrote: > > diff --git a/arch/x86/kernel/shstk.c b/arch/x86/kernel/shstk.c > > index 5993aa8db338..7c1ca2476a5e 100644 > > --- a/arch/x86/kernel/shstk.c > > +++ b/arch/x86/kernel/shstk.c > > @@ -75,6 +75,61 @@ int shstk_setup(void) > > return err; > > } > > > > +int shstk_alloc_thread_stack(struct task_struct *tsk, unsigned long clone_flags, > > + unsigned long stack_size) > > +{ > > + struct thread_shstk *shstk = &tsk->thread.shstk; > > + struct cet_user_state *state; > > + unsigned long addr; > > + > > + if (!shstk->size) > > + return 0; > > + > > + /* > > + * Earlier clone() does not pass stack_size. Use RLIMIT_STACK and > > What is "earlier clone()"? clone() doesn't have stack size info which was added to clone3(). > > + * cap to 4 GB. > > + */ > > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette -- H.J.