From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx138.postini.com [74.125.245.138]) by kanga.kvack.org (Postfix) with SMTP id 122486B0031 for ; Wed, 24 Jul 2013 16:05:10 -0400 (EDT) Received: by mail-ob0-f181.google.com with SMTP id 16so14235180obc.12 for ; Wed, 24 Jul 2013 13:05:10 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20130724094035.GA28894@hal> References: <1372901537-31033-1-git-send-email-ccross@android.com> <20130704202232.GA19287@redhat.com> <20130724094035.GA28894@hal> Date: Wed, 24 Jul 2013 13:05:09 -0700 Message-ID: Subject: Re: [PATCH] mm: add sys_madvise2 and MADV_NAME to name vmas From: Colin Cross Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Jan Glauber Cc: Oleg Nesterov , lkml , Kyungmin Park , Christoph Hellwig , John Stultz , Rob Landley , Arnd Bergmann , Andrew Morton , Cyrill Gorcunov , David Rientjes , Davidlohr Bueso , Kees Cook , Al Viro , Hugh Dickins , Mel Gorman , Michel Lespinasse , Rik van Riel , Konstantin Khlebnikov , Peter Zijlstra , Rusty Russell , "Eric W. Biederman" , Srikar Dronamraju , KAMEZAWA Hiroyuki , Michal Hocko , Anton Vorontsov , Pekka Enberg , Shaohua Li , Sasha Levin , KOSAKI Motohiro , Johannes Weiner , Ingo Molnar , "open list:DOCUMENTATION" , "open list:MEMORY MANAGEMENT" , "open list:GENERIC INCLUDE/A..." On Wed, Jul 24, 2013 at 2:40 AM, Jan Glauber wrote: > On Fri, Jul 05, 2013 at 12:40:50PM -0700, Colin Cross wrote: >> On Thu, Jul 4, 2013 at 1:22 PM, Oleg Nesterov wrote: >> > On 07/03, Colin Cross wrote: >> >> >> >> The names of named anonymous vmas are shown in /proc/pid/maps >> >> as [anon:]. The name of all named vmas are shown in >> >> /proc/pid/smaps in a new "Name" field that is only present >> >> for named vmas. >> > >> > And this is the only purpose, yes? >> > > The heuristics used for the thread stack annotation is not working always: > > https://lkml.org/lkml/2013/6/26/256 > > Maybe we can get rid of the heuristic if there is an explicit interface to > mark vma's? > > OTOH, a new flag bit instead of a string would be enough to mark the thread > stacks correctly. I noticed this possibility when looking at the stack naming code, but I didn't have any evidence that it actually happens. As my patch is written (as well as the new version, see http://permalink.gmane.org/gmane.linux.kernel.mm/103228) it will ignore any vma that found a name any other way, but it could be changed to override the automatic stack naming. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org