From: Muchun Song <songmuchun@bytedance.com>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: Jonathan Corbet <corbet@lwn.net>,
Mike Kravetz <mike.kravetz@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
Iurii Zaikin <yzaikin@google.com>,
Linux Doc Mailing List <linux-doc@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>,
Xiongchun duan <duanxiongchun@bytedance.com>
Subject: Re: [PATCH 3/3] mm: hugetlb: add hugetlb_free_vmemmap sysctl
Date: Mon, 28 Feb 2022 23:14:27 +0800 [thread overview]
Message-ID: <CAMZfGtXvLj+DQj=YoN6CcVfHZA-ceB24t8waMZs7KEbOoh0jUA@mail.gmail.com> (raw)
In-Reply-To: <YhzfN574YUta3qay@bombadil.infradead.org>
On Mon, Feb 28, 2022 at 10:42 PM Luis Chamberlain <mcgrof@kernel.org> wrote:
>
> On Mon, Feb 28, 2022 at 03:10:22PM +0800, Muchun Song wrote:
> > We must add "hugetlb_free_vmemmap=on" to boot cmdline and reboot the
> > server to enable the feature of freeing vmemmap pages of HugeTLB
> > pages. Rebooting usually taske a long time. Add a sysctl to enable
> > the feature at runtime and do not need to reboot.
> >
> > Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> > ---
> > Documentation/admin-guide/sysctl/vm.rst | 13 +++++++++++++
> > include/linux/hugetlb.h | 5 +++++
> > include/linux/memory_hotplug.h | 1 +
> > kernel/sysctl.c | 11 +++++++++++
>
> kernel/sysctl.c is a hot mess with tons of knobs from all over the
> place. And so we've been moving these to their own place. For instance
> all the filesystem knobs are now properly in fs/. So Adding new ones
> to the file is undesirable. If this is going to be added, please add
> it somewhere in mm / hugetlb code.
>
I also have realized this when reading another patch [1]. I will
move this into its hugetlb related code. Anyway, thanks for
your suggestion.
[1] https://lore.kernel.org/linux-fsdevel/20220220060626.15885-1-tangmeng@uniontech.com/
next prev parent reply other threads:[~2022-02-28 15:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 7:10 [PATCH 0/3] " Muchun Song
2022-02-28 7:10 ` [PATCH 1/3] mm: hugetlb: disable freeing vmemmap pages when struct page crosses page boundaries Muchun Song
2022-02-28 7:10 ` [PATCH 2/3] sysctl: allow to set extra1 to SYSCTL_ONE Muchun Song
2022-02-28 7:10 ` [PATCH 3/3] mm: hugetlb: add hugetlb_free_vmemmap sysctl Muchun Song
2022-02-28 14:41 ` Luis Chamberlain
2022-02-28 15:14 ` Muchun Song [this message]
2022-02-28 17:35 ` kernel test robot
2022-02-28 17:37 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMZfGtXvLj+DQj=YoN6CcVfHZA-ceB24t8waMZs7KEbOoh0jUA@mail.gmail.com' \
--to=songmuchun@bytedance.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=duanxiongchun@bytedance.com \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox