From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2010C433F5 for ; Tue, 30 Nov 2021 02:37:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3AAE26B0071; Mon, 29 Nov 2021 21:36:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 332E76B0072; Mon, 29 Nov 2021 21:36:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D43F6B0073; Mon, 29 Nov 2021 21:36:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0218.hostedemail.com [216.40.44.218]) by kanga.kvack.org (Postfix) with ESMTP id 0704B6B0071 for ; Mon, 29 Nov 2021 21:36:55 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id C495989B3D for ; Tue, 30 Nov 2021 02:36:44 +0000 (UTC) X-FDA: 78864033486.17.085B17C Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com [209.85.219.171]) by imf10.hostedemail.com (Postfix) with ESMTP id 4F4A0600198E for ; Tue, 30 Nov 2021 02:36:38 +0000 (UTC) Received: by mail-yb1-f171.google.com with SMTP id f186so48038901ybg.2 for ; Mon, 29 Nov 2021 18:36:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rgI/AaQZFO092ur38zyTNNcK9cTmIjNH5zoKttaDw+s=; b=kYkEpq6LFfs3NoxTELSmxCDx47pYFaIovpRQGk2quPgVmdWUClF+vOD/rZsiomySAK X/zimWA0oKUSpvxdallx8oTsNjVTID4LekkUuE/tLkqT+GQ1HYUie6ZhKNFbOtfVyLrg Ol6Ov926pxHkMA3keHjhtZeyKd40GR/QHKJXOriNYWJvDwZi+y5GANYYSFLL7EwFqLls SWOM6of0sDfztlYzipJoSoyG0n7huKNlRqpRkgc+Flg82cBAIaqmbxv4poSaIfXHcBVP 68vLxzZrlSTYmwhvu7R6HepJZm6xQ31Nn9db81qJeAbnEl09V7n0zPl1oE840Yz/jQlU SWIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rgI/AaQZFO092ur38zyTNNcK9cTmIjNH5zoKttaDw+s=; b=BR+IfQo1wCzsHjrcQe6LjHg1r4eSe9BxKUpsZCrPZHoHuoGWY8fwsXIIT+UQMPmSfM ioiGn++2jd/q2RXh9ZmvpbGgdlP5BM9yYg04NIA+N82EEk0z0XtpMzKRg5Wk8ObhnceS UXQ/K4WSCWCtTHLxFd4e23FSS8NtmIi2rQOVp21fxCYnov2LDmxKuw0F3/bgT/XprSB3 DIygdBv/ySpdmIkYeNfo6BJ/aduKySVDJ9Frh7jmd5FXm9q2ryGBChKIHm/3vjhM6P8H CKV2Vw8COsJeeUgmthFOu3rFTjiFtxQJIWWD7CCV/yvGn+Ww1xofjrs8IJfklQd3ow8d 5i/g== X-Gm-Message-State: AOAM531jdY22U2aDXjOAKo9cAS7pVjNF2gk1ioMJMDyK5vTYMeUUCH8W XgRJc55iZYFppzA8wM+CZdlQNWO84MBOIYntzK/h0g== X-Google-Smtp-Source: ABdhPJyFf6WTkt1uX5KpYxUT5GJwtE8x2E0e3vEVMXMsXaGqkI+umr2ym/BiLOmJvqyb8y9kR3sw1Ymo4ANuwF0vanc= X-Received: by 2002:a25:ba0e:: with SMTP id t14mr9675193ybg.49.1638239803470; Mon, 29 Nov 2021 18:36:43 -0800 (PST) MIME-Version: 1.0 References: <20211129161140.306488-1-longman@redhat.com> In-Reply-To: <20211129161140.306488-1-longman@redhat.com> From: Muchun Song Date: Tue, 30 Nov 2021 10:36:07 +0800 Message-ID: Subject: Re: [PATCH] mm/memcg: Relocate mod_objcg_mlstate(), get_obj_stock() and put_obj_stock() To: Waiman Long Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , LKML , Cgroups , Linux Memory Management List , Shakeel Butt , Roman Gushchin , kernel test robot Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 4F4A0600198E X-Stat-Signature: 7kwgk8oot1esxwdx7yp1kbqia6ogd1r7 Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=kYkEpq6L; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf10.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.219.171 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-HE-Tag: 1638239798-936544 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 30, 2021 at 12:14 AM Waiman Long wrote: > > All the calls to mod_objcg_mlstate(), get_obj_stock() and put_obj_stock() > are done by functions defined within the same "#ifdef CONFIG_MEMCG_KMEM" > compilation block. When CONFIG_MEMCG_KMEM isn't defined, the following > compilation warnings will be issued [1] and [2]. > > mm/memcontrol.c:785:20: warning: unused function 'mod_objcg_mlstate' > mm/memcontrol.c:2113:33: warning: unused function 'get_obj_stock' > > Fix these warning by moving those functions to under the same > CONFIG_MEMCG_KMEM compilation block. There is no functional change. > > [1] https://lore.kernel.org/lkml/202111272014.WOYNLUV6-lkp@intel.com/ > [2] https://lore.kernel.org/lkml/202111280551.LXsWYt1T-lkp@intel.com/ > > Fixes: 559271146efc ("mm/memcg: optimize user context object stock access") > Fixes: 68ac5b3c8db2 ("mm/memcg: cache vmstat data in percpu memcg_stock_pcp") > Reported-by: kernel test robot > Signed-off-by: Waiman Long Reviewed-by: Muchun Song Thanks.