* [PATCH] mm: kmemleak: slob: respect SLAB_NOLEAKTRACE flag
@ 2021-11-15 2:08 Rustam Kovhaev
2021-11-15 23:00 ` Vlastimil Babka
2021-11-16 2:54 ` Muchun Song
0 siblings, 2 replies; 3+ messages in thread
From: Rustam Kovhaev @ 2021-11-15 2:08 UTC (permalink / raw)
To: vbabka, cl, penberg, rientjes, iamjoonsoo.kim, akpm, catalin.marinas
Cc: linux-kernel, linux-mm, gregkh, Rustam Kovhaev
When kmemleak is enabled for SLOB, system does not boot and does not
print anything to the console. At the very early stage in the boot
process we hit infinite recursion from kmemleak_init() and eventually
kernel crashes.
kmemleak_init() specifies SLAB_NOLEAKTRACE for KMEM_CACHE(), but
kmem_cache_create_usercopy() removes it because CACHE_CREATE_MASK is not
valid for SLOB.
Let's fix CACHE_CREATE_MASK and make kmemleak work with SLOB
Fixes: d8843922fba4 ("slab: Ignore internal flags in cache creation")
Signed-off-by: Rustam Kovhaev <rkovhaev@gmail.com>
---
mm/slab.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/slab.h b/mm/slab.h
index 58c01a34e5b8..56ad7eea3ddf 100644
--- a/mm/slab.h
+++ b/mm/slab.h
@@ -147,7 +147,7 @@ static inline slab_flags_t kmem_cache_flags(unsigned int object_size,
#define SLAB_CACHE_FLAGS (SLAB_NOLEAKTRACE | SLAB_RECLAIM_ACCOUNT | \
SLAB_TEMPORARY | SLAB_ACCOUNT)
#else
-#define SLAB_CACHE_FLAGS (0)
+#define SLAB_CACHE_FLAGS (SLAB_NOLEAKTRACE)
#endif
/* Common flags available with current configuration */
--
2.30.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mm: kmemleak: slob: respect SLAB_NOLEAKTRACE flag
2021-11-15 2:08 [PATCH] mm: kmemleak: slob: respect SLAB_NOLEAKTRACE flag Rustam Kovhaev
@ 2021-11-15 23:00 ` Vlastimil Babka
2021-11-16 2:54 ` Muchun Song
1 sibling, 0 replies; 3+ messages in thread
From: Vlastimil Babka @ 2021-11-15 23:00 UTC (permalink / raw)
To: Rustam Kovhaev, cl, penberg, rientjes, iamjoonsoo.kim, akpm,
catalin.marinas
Cc: linux-kernel, linux-mm, gregkh
On 11/15/21 03:08, Rustam Kovhaev wrote:
> When kmemleak is enabled for SLOB, system does not boot and does not
> print anything to the console. At the very early stage in the boot
> process we hit infinite recursion from kmemleak_init() and eventually
> kernel crashes.
> kmemleak_init() specifies SLAB_NOLEAKTRACE for KMEM_CACHE(), but
> kmem_cache_create_usercopy() removes it because CACHE_CREATE_MASK is not
> valid for SLOB.
> Let's fix CACHE_CREATE_MASK and make kmemleak work with SLOB
>
> Fixes: d8843922fba4 ("slab: Ignore internal flags in cache creation")
> Signed-off-by: Rustam Kovhaev <rkovhaev@gmail.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
> ---
> mm/slab.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/slab.h b/mm/slab.h
> index 58c01a34e5b8..56ad7eea3ddf 100644
> --- a/mm/slab.h
> +++ b/mm/slab.h
> @@ -147,7 +147,7 @@ static inline slab_flags_t kmem_cache_flags(unsigned int object_size,
> #define SLAB_CACHE_FLAGS (SLAB_NOLEAKTRACE | SLAB_RECLAIM_ACCOUNT | \
> SLAB_TEMPORARY | SLAB_ACCOUNT)
> #else
> -#define SLAB_CACHE_FLAGS (0)
> +#define SLAB_CACHE_FLAGS (SLAB_NOLEAKTRACE)
> #endif
>
> /* Common flags available with current configuration */
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mm: kmemleak: slob: respect SLAB_NOLEAKTRACE flag
2021-11-15 2:08 [PATCH] mm: kmemleak: slob: respect SLAB_NOLEAKTRACE flag Rustam Kovhaev
2021-11-15 23:00 ` Vlastimil Babka
@ 2021-11-16 2:54 ` Muchun Song
1 sibling, 0 replies; 3+ messages in thread
From: Muchun Song @ 2021-11-16 2:54 UTC (permalink / raw)
To: Rustam Kovhaev
Cc: Vlastimil Babka, Christoph Lameter, Pekka Enberg, David Rientjes,
Joonsoo Kim, Andrew Morton, Catalin Marinas, LKML,
Linux Memory Management List, Greg KH
On Mon, Nov 15, 2021 at 10:09 AM Rustam Kovhaev <rkovhaev@gmail.com> wrote:
>
> When kmemleak is enabled for SLOB, system does not boot and does not
> print anything to the console. At the very early stage in the boot
> process we hit infinite recursion from kmemleak_init() and eventually
> kernel crashes.
> kmemleak_init() specifies SLAB_NOLEAKTRACE for KMEM_CACHE(), but
> kmem_cache_create_usercopy() removes it because CACHE_CREATE_MASK is not
> valid for SLOB.
> Let's fix CACHE_CREATE_MASK and make kmemleak work with SLOB
>
> Fixes: d8843922fba4 ("slab: Ignore internal flags in cache creation")
> Signed-off-by: Rustam Kovhaev <rkovhaev@gmail.com>
Reviewed-by: Muchun Song <songmuchun@bytedance.com>
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-16 2:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-15 2:08 [PATCH] mm: kmemleak: slob: respect SLAB_NOLEAKTRACE flag Rustam Kovhaev
2021-11-15 23:00 ` Vlastimil Babka
2021-11-16 2:54 ` Muchun Song
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox