From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2F9CC433F5 for ; Tue, 16 Nov 2021 02:55:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7D697630EF for ; Tue, 16 Nov 2021 02:55:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7D697630EF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 0F1746B00AC; Mon, 15 Nov 2021 21:55:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A16A6B00AD; Mon, 15 Nov 2021 21:55:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EF9BE6B00AE; Mon, 15 Nov 2021 21:55:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0082.hostedemail.com [216.40.44.82]) by kanga.kvack.org (Postfix) with ESMTP id E271A6B00AC for ; Mon, 15 Nov 2021 21:55:35 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id A3E708249980 for ; Tue, 16 Nov 2021 02:55:35 +0000 (UTC) X-FDA: 78813277830.08.E6954DC Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com [209.85.219.182]) by imf28.hostedemail.com (Postfix) with ESMTP id 5B53C90000A1 for ; Tue, 16 Nov 2021 02:55:34 +0000 (UTC) Received: by mail-yb1-f182.google.com with SMTP id y3so53065629ybf.2 for ; Mon, 15 Nov 2021 18:55:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rpqDaIvxd8atjdNJzYkyVRAJyAC7aztRzEj4r3gO0pg=; b=oSeIDCVNGsGEVXFab6uHOW5y/tU6dCosRJNm8cBd6SB2tIa+QdWw8Bho0kGLw4muyN eZH8Kop1RkUJ2T9Ndf26h1x7X9674XMPtZUhUxo04UqFnOScyeZSXqNCuKicvOitGlcs uafaqgkcDVW4drNAjZJV8mZxXP4uSIR/+RyMW/Ksnr4p4Fae4+4B1yoeOfrZm30Xb+8f oVQNQCmL/R7/2Z0BBlvg5pcEv7E91LzdOx9tekxQ+WIDNVoS4daBXOcuyYljeeRaFSgj hafEXhqTpyw1WOUW0bz50gxhXy/1MsG7dUV+CXCazhIEEMp+F9j3rt/S07Q129V6beKZ nRxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rpqDaIvxd8atjdNJzYkyVRAJyAC7aztRzEj4r3gO0pg=; b=WZsC2SBwp6l8U8LZbrX/Q4fARIGfOzY3/UaGlLKZ1Z8J0086+GZziwTPZ6XRx4DRNk oX8X/RB6JnTHWiJB2THgU7POO2+DgxlWnoFU4Xd+X7OlV9xi5W7dF/W3waXQyFY0oGPM gGhlPa7U3t9PnEwhbJJWcsAUKhQExW0FaYaVi8a7t8SXWWaZLiIEcB/upJA5NMxaAbdl MtQ8xm+iRSh9pxabLS0LCEQYei0zRxvhzHfMeDZDbdGW6vFG/J+bXjMsLRfcdFCYzLW+ FK13Cpse82ncxKu4bSOXiR5IPmcjlFXYYqZL17/3PIMDsqF7Cp0RgqEZyTzsCKaDoXRo xBnw== X-Gm-Message-State: AOAM531k7i8LqSHHPO2S4J90ZsuSnNeqvRtbMGNJVhRBkP2muY7FQzht 0/P5JdyG3k4dwWx7mrNwOw3F/Wm0rQP57bbKj7yS/w== X-Google-Smtp-Source: ABdhPJxT40IF9I4AT6hA6vyiNjJ7uBJV0B7ydVaE8t/+5pTk6/UDSyL+eXhgQEEqlJQnZDNNzuYQz2kzumRuSLOpriE= X-Received: by 2002:a5b:648:: with SMTP id o8mr4668222ybq.208.1637031333423; Mon, 15 Nov 2021 18:55:33 -0800 (PST) MIME-Version: 1.0 References: <20211115020850.3154366-1-rkovhaev@gmail.com> In-Reply-To: <20211115020850.3154366-1-rkovhaev@gmail.com> From: Muchun Song Date: Tue, 16 Nov 2021 10:54:53 +0800 Message-ID: Subject: Re: [PATCH] mm: kmemleak: slob: respect SLAB_NOLEAKTRACE flag To: Rustam Kovhaev Cc: Vlastimil Babka , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Catalin Marinas , LKML , Linux Memory Management List , Greg KH Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 74xr6x865k8oftzo3cyhdc9momtad183 Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=oSeIDCVN; spf=pass (imf28.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.219.182 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 5B53C90000A1 X-HE-Tag: 1637031334-787433 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 15, 2021 at 10:09 AM Rustam Kovhaev wrote: > > When kmemleak is enabled for SLOB, system does not boot and does not > print anything to the console. At the very early stage in the boot > process we hit infinite recursion from kmemleak_init() and eventually > kernel crashes. > kmemleak_init() specifies SLAB_NOLEAKTRACE for KMEM_CACHE(), but > kmem_cache_create_usercopy() removes it because CACHE_CREATE_MASK is not > valid for SLOB. > Let's fix CACHE_CREATE_MASK and make kmemleak work with SLOB > > Fixes: d8843922fba4 ("slab: Ignore internal flags in cache creation") > Signed-off-by: Rustam Kovhaev Reviewed-by: Muchun Song Thanks.