From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35D8DC433E2 for ; Mon, 14 Sep 2020 16:55:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8FE022067C for ; Mon, 14 Sep 2020 16:55:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bytedance-com.20150623.gappssmtp.com header.i=@bytedance-com.20150623.gappssmtp.com header.b="RB+2IbSg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8FE022067C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1A1A4900008; Mon, 14 Sep 2020 12:55:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 12BF5900006; Mon, 14 Sep 2020 12:55:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F349F900008; Mon, 14 Sep 2020 12:55:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0202.hostedemail.com [216.40.44.202]) by kanga.kvack.org (Postfix) with ESMTP id D874C900006 for ; Mon, 14 Sep 2020 12:55:29 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 937778249980 for ; Mon, 14 Sep 2020 16:55:29 +0000 (UTC) X-FDA: 77262267978.13.story94_3610f7d2710a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id 8A63218140B70 for ; Mon, 14 Sep 2020 16:55:28 +0000 (UTC) X-HE-Tag: story94_3610f7d2710a X-Filterd-Recvd-Size: 7520 Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Mon, 14 Sep 2020 16:55:27 +0000 (UTC) Received: by mail-pf1-f195.google.com with SMTP id z19so26176pfn.8 for ; Mon, 14 Sep 2020 09:55:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nn8uGO9a9X0XwaIfMVFd2VgaWgHbpK8dvPYHd7Sq/nA=; b=RB+2IbSgUvQBoAdsF0OTSCz20nt98NJ5VHwnf9jRx7zYNTMQeX4LZz03zL76irCDsG 0mdg45wZp2YAKNVNcAwTPfapLTrblMQfnEi5juhLmTb8jSzbarIx3WRVlOGm1lwO0q4M JQXKYTnJSK2DV38j5skJQDiuqxCdrQ3kOy8gMmaXArc3C/XUvXxCidE0P/u3zhA62+yi xxn5pXMlfzPSghT6dqYreCTRbu1o6GiEEvmXJk4bl7fHVfWaL8keJwVa0PHKeirScjuK prJC8gaEvEx5yF4bvJyP9nUjr2ef9WkOsxRj3i4EAEkOXmG5T4VYP6A9imu3h5LqM1Nm 5WRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nn8uGO9a9X0XwaIfMVFd2VgaWgHbpK8dvPYHd7Sq/nA=; b=o2SWWFLOGcoaBiAyvR6rn6stWdAGWuTCOW2yXQlRAmv5eHbArz+f4r8w6gsmozqMSg 52xnVQpzYq/qFT8+om/KkduNES07uu0SsT1sZA0Rq9S0SgZBJxQDzy/e4T+2lc8bqgxn EskTgOHnk2ffL1vigdjrlZaqFxKotdbo0VqgKMdjwP46frxU8ppfbmIUAggrSvkyVYgo hS8RAtumx/xZYlh1nFwAp4hqC3JsPxyL/jQYxXvO8Gt7PzQQAT2K8y2IwpJI3GSFdFUm DugW9UMzzZKxfYWW5lxFbsQP6dlUQ5Ca+EdRN9huQ3ztIwShjfgZYcUmX5CXCxNtMfxv 112g== X-Gm-Message-State: AOAM533d+X05i/lnqGqslo56NvtAHPqs4SCUs9TGRawoZ7DUBvsR0rdw +Bm5wt6HX0PKyif/C9bYBCc3K/6WvKXe1gFo205Vdg== X-Google-Smtp-Source: ABdhPJxzhrEWtHfAz9YebgAYjnUP/OKSRvXH7hybqZE4UdLRz9e4pHdbh/Rl/limT4J8drQRD3Oae84qwNQP5k5X5fM= X-Received: by 2002:a62:8f4c:: with SMTP id n73mr13928326pfd.65.1600102526730; Mon, 14 Sep 2020 09:55:26 -0700 (PDT) MIME-Version: 1.0 References: <20200913070010.44053-1-songmuchun@bytedance.com> In-Reply-To: From: Muchun Song Date: Tue, 15 Sep 2020 00:54:50 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v3] mm: memcontrol: Add the missing numa_stat interface for cgroup v2 To: Shakeel Butt Cc: Tejun Heo , Li Zefan , Johannes Weiner , Jonathan Corbet , Michal Hocko , Vladimir Davydov , Andrew Morton , Roman Gushchin , Cgroups , linux-doc@vger.kernel.org, LKML , Linux MM , kernel test robot Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 8A63218140B70 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 15, 2020 at 12:07 AM Shakeel Butt wrote: > > On Sun, Sep 13, 2020 at 12:01 AM Muchun Song wrote: > > > > In the cgroup v1, we have a numa_stat interface. This is useful for > > providing visibility into the numa locality information within an > > memcg since the pages are allowed to be allocated from any physical > > node. One of the use cases is evaluating application performance by > > combining this information with the application's CPU allocation. > > But the cgroup v2 does not. So this patch adds the missing information. > > > > Signed-off-by: Muchun Song > > Suggested-by: Shakeel Butt > > Reported-by: kernel test robot > > --- > [snip] > > + > > +static struct numa_stat numa_stats[] = { > > + { "anon", PAGE_SIZE, NR_ANON_MAPPED }, > > + { "file", PAGE_SIZE, NR_FILE_PAGES }, > > + { "kernel_stack", 1024, NR_KERNEL_STACK_KB }, > > + { "shmem", PAGE_SIZE, NR_SHMEM }, > > + { "file_mapped", PAGE_SIZE, NR_FILE_MAPPED }, > > + { "file_dirty", PAGE_SIZE, NR_FILE_DIRTY }, > > + { "file_writeback", PAGE_SIZE, NR_WRITEBACK }, > > +#ifdef CONFIG_TRANSPARENT_HUGEPAGE > > + /* > > + * The ratio will be initialized in numa_stats_init(). Because > > + * on some architectures, the macro of HPAGE_PMD_SIZE is not > > + * constant(e.g. powerpc). > > + */ > > + { "anon_thp", 0, NR_ANON_THPS }, > > +#endif > > + { "inactive_anon", PAGE_SIZE, NR_INACTIVE_ANON }, > > + { "active_anon", PAGE_SIZE, NR_ACTIVE_ANON }, > > + { "inactive_file", PAGE_SIZE, NR_INACTIVE_FILE }, > > + { "active_file", PAGE_SIZE, NR_ACTIVE_FILE }, > > + { "unevictable", PAGE_SIZE, NR_UNEVICTABLE }, > > + { "slab_reclaimable", 1, NR_SLAB_RECLAIMABLE_B }, > > + { "slab_unreclaimable", 1, NR_SLAB_UNRECLAIMABLE_B }, > > +}; > > + > > +static int __init numa_stats_init(void) > > +{ > > + int i; > > + > > + for (i = 0; i < ARRAY_SIZE(numa_stats); i++) { > > +#ifdef CONFIG_TRANSPARENT_HUGEPAGE > > + if (numa_stats[i].idx == NR_ANON_THPS) > > + numa_stats[i].ratio = HPAGE_PMD_SIZE; > > +#endif > > + } > > The for loop seems excessive but I don't really have a good alternative. Yeah, I also have no good alternative. The numa_stats is only initialized once. So there may be no problem :). > > > + > > + return 0; > > +} > > +pure_initcall(numa_stats_init); > > + > > +static unsigned long memcg_node_page_state(struct mem_cgroup *memcg, > > + unsigned int nid, > > + enum node_stat_item idx) > > +{ > > + VM_BUG_ON(nid >= nr_node_ids); > > + return lruvec_page_state(mem_cgroup_lruvec(memcg, NODE_DATA(nid)), idx); > > +} > > + > > +static const char *memory_numa_stat_format(struct mem_cgroup *memcg) > > +{ > > + int i; > > + struct seq_buf s; > > + > > + /* Reserve a byte for the trailing null */ > > + seq_buf_init(&s, kmalloc(PAGE_SIZE, GFP_KERNEL), PAGE_SIZE - 1); > > + if (!s.buffer) > > + return NULL; > > + > > + for (i = 0; i < ARRAY_SIZE(numa_stats); i++) { > > + int nid; > > + > > + seq_buf_printf(&s, "%s", numa_stats[i].name); > > + for_each_node_state(nid, N_MEMORY) { > > + u64 size; > > + > > + size = memcg_node_page_state(memcg, nid, > > + numa_stats[i].idx); > > + size *= numa_stats[i].ratio; > > + seq_buf_printf(&s, " N%d=%llu", nid, size); > > + } > > + seq_buf_putc(&s, '\n'); > > + } > > + > > + /* The above should easily fit into one page */ > > + if (WARN_ON_ONCE(seq_buf_putc(&s, '\0'))) > > + s.buffer[PAGE_SIZE - 1] = '\0'; > > I think you should follow Michal's recommendation at > http://lkml.kernel.org/r/20200914115724.GO16999@dhcp22.suse.cz Here is different, because the seq_buf_putc(&s, '\n') will not add \0 unless we use seq_buf_puts(&s, "\n"). -- Yours, Muchun