From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33FB2C4708A for ; Thu, 27 May 2021 02:44:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 99CC6613C9 for ; Thu, 27 May 2021 02:44:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 99CC6613C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 671E16B0036; Wed, 26 May 2021 22:44:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 602906B006E; Wed, 26 May 2021 22:44:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C00E6B0070; Wed, 26 May 2021 22:44:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0237.hostedemail.com [216.40.44.237]) by kanga.kvack.org (Postfix) with ESMTP id C68676B0036 for ; Wed, 26 May 2021 22:44:23 -0400 (EDT) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 562DB181AEF39 for ; Thu, 27 May 2021 02:44:23 +0000 (UTC) X-FDA: 78185467206.31.B4DBDD9 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) by imf23.hostedemail.com (Postfix) with ESMTP id DDA92A0001C0 for ; Thu, 27 May 2021 02:44:15 +0000 (UTC) Received: by mail-pg1-f170.google.com with SMTP id 27so2597566pgy.3 for ; Wed, 26 May 2021 19:44:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4OWnhIRtH41VW4/lCOTjupHX4TklN7EnBtE+milzxdg=; b=yob++nCZ0jBPDz2/M6DUDb2d8Mvwd6Ed95UY9DwG4PoRNTQzWrjv4CXanUrje/xzkf UxQNr2uSSbo8OhSCditOvGbwiWqcbB9qN9m6466EwmfkUQCT9HoakI5Ck/85h+GApPEe uxFZ71gKN41HhskGj4Rohl9fklmpF3EUCOmR0XNv5Cy2AhBjuu0Wlet0h3L0DAoKHtvQ 5DBThvCeEeMKqXSRE75bZdbrVaDj6dleKXCxbNSCl/FdF5Q6Z5M4mlQsdhF5+YGZpHYY R213dFkzbRR+RPOO+WU0WmZBoltgQrlZIfomRpywSEh8j1sXBUuifSA6IWR3aU9CH2zN NvPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4OWnhIRtH41VW4/lCOTjupHX4TklN7EnBtE+milzxdg=; b=gyUOcaEuOXVCVbTosjk6q4IsEblHHgsV0Yet/PrPNIwg0iOEKrQFbB9RttI/x3cnr2 30u8cBP9wDSfqxT4GS/t3S+0/3a06wcGUrpUO1MwBUuEtx5OtShXd87kKt0iBThLCsFq naSV2seSLONFgVpTNUV+ctQ6JPGADd8hnM7bnDKkyDrCUswV72UyCVIsiM++/BeJWmCF zZLHuPu7PHVx5R7zhXr789N2Fx5jz67G2L8hXGM+dcOOPTNQgnDN9hX3mEcrelm4RRrp GodigIgBvoVElA42MsZmyrt3ydEcPO3bJWfSBJrC9OQlM7GMQ/Mu+Lzkht2WMtveJqX8 VIAA== X-Gm-Message-State: AOAM533cpUDbzVpX0O30NdfOBHaRiATBM5Bs6D3I2Txe7yyplarmhFoJ pF38F3JuE3rPJ98WX3nuE+ibJNx1fji8N9IeFYNWuQ== X-Google-Smtp-Source: ABdhPJxwDUrGAubiCAOTx3bDKiXKskkBV2syNptAff9s59quefpdRyl+YKE1S1ZKVM0ylFbmM4m5YgcXjcb+W+2YUjw= X-Received: by 2002:a62:7b07:0:b029:2e3:b540:707f with SMTP id w7-20020a627b070000b02902e3b540707fmr1505473pfc.59.1622083461024; Wed, 26 May 2021 19:44:21 -0700 (PDT) MIME-Version: 1.0 References: <20210526235257.2769473-1-nao.horiguchi@gmail.com> In-Reply-To: <20210526235257.2769473-1-nao.horiguchi@gmail.com> From: Muchun Song Date: Thu, 27 May 2021 10:43:44 +0800 Message-ID: Subject: Re: [External] [PATCH v1] hugetlb: pass head page to remove_hugetlb_page() To: Naoya Horiguchi Cc: Linux Memory Management List , Mike Kravetz , Michal Hocko , Oscar Salvador , Andrew Morton , David Hildenbrand , Naoya Horiguchi , LKML Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=bytedance-com.20150623.gappssmtp.com header.s=20150623 header.b=yob++nCZ; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf23.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.215.170 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-Stat-Signature: sc6jbc7p1i74rti8ipmx874ykozqirsg X-Rspamd-Queue-Id: DDA92A0001C0 X-Rspamd-Server: rspam02 X-HE-Tag: 1622083455-184929 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 27, 2021 at 7:53 AM Naoya Horiguchi wrote: > > From: Naoya Horiguchi > > When memory_failure() or soft_offline_page() is called on a tail page of > some hugetlb page, "BUG: unable to handle page fault" error can be > triggered. > > remove_hugetlb_page() dereferences page->lru, so it's assumed that the > page points to a head page, but one of the caller, > dissolve_free_huge_page(), provides remove_hugetlb_page() with 'page' > which could be a tail page. So pass 'head' to it, instead. > > Fixes: 6eb4e88a6d27 ("hugetlb: create remove_hugetlb_page() to separate functionality") > Signed-off-by: Naoya Horiguchi Thanks Naoya! Reviewed-by: Muchun Song