From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22328C433F5 for ; Thu, 24 Feb 2022 03:03:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 371B78D0002; Wed, 23 Feb 2022 22:03:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F96D8D0001; Wed, 23 Feb 2022 22:03:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 19AE48D0002; Wed, 23 Feb 2022 22:03:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0097.hostedemail.com [216.40.44.97]) by kanga.kvack.org (Postfix) with ESMTP id E13848D0001 for ; Wed, 23 Feb 2022 22:03:18 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 769EB9EB2F for ; Thu, 24 Feb 2022 03:03:18 +0000 (UTC) X-FDA: 79176177276.20.656AC0C Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) by imf28.hostedemail.com (Postfix) with ESMTP id 4CDD9C0004 for ; Thu, 24 Feb 2022 03:03:17 +0000 (UTC) Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-2d66f95f1d1so11426237b3.0 for ; Wed, 23 Feb 2022 19:03:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LBjw731gOZAZX11izjBDJpMfyEuV5GyF58y13CmjgQI=; b=WCSX7/V63Tb5YJ/PxU+KniB8C1Khw0+KR+ynZIbN1J62sE3rn9lOMkIK1u21L5m/Wu 7IGQyDtJmH0r9tZfIjBsJvXZVpGv9cThH1BPWzrdG/fRzT5CxWhUQUfSxfIJ+36FWv/T +fbdnl8jfw6XCmqU2C1Az2GRLN/9bwb8wqp6JCopXfQvVWRK+yBbVN5yhL/lw5D9NlU2 67UMFEVxKWVXXCBFmVXk3IGYMajUoqN85/eCbgQsMp9rD1PyjZ/7cD1w7VZtYXqup3mg SQFgHY041XA52HrXwHG3kfkM9VfoorWaT3r/9b9J9KXy1m9GFCBZ3kMh7WuhGH4qmzHb sNDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LBjw731gOZAZX11izjBDJpMfyEuV5GyF58y13CmjgQI=; b=IFb588o0cY/SLIfPuDWQSakIULsypEn+xZ+VFZ8KJWtlhNETFX1Tps5DoRwr2jLT6+ M8jnStRouTZn+zUJSdgzuB3KMZOSgVvj7wLaeiRIY1ZgVJ7NIMvs2m14SlhXxA2Yjai7 6XWQdefHUj5xBu3fCQEawbopmUK0xoyPtgFNf1jsGppWmIJJ4ZLTq0LZICl9aE4JWueQ eBGUYv0tykPxmiU0vMWVXz8SoubzrjZSXdgVxJnkQ5yTxJQdoZx3kzeNn7KExKsckzUL WnHD//ZVfzReefGZ6Z+8VAIc1t8UjSzdgvn9Tb1tAyxdqOOooep2CoRlrNKCwhUqiGF0 omGQ== X-Gm-Message-State: AOAM531A/9SJKivCtA0ZgD//jTDnIYVf0PCPbWVl3lNjV6H9Y82S7lOF 01HhszeHytmLWwh+ZuvdoVlRQO/m7FG4ujxTSeOazg== X-Google-Smtp-Source: ABdhPJz2AQ9wlEoioUOpPwIgSwQcN0ZkHflGDqUQfNbL2z/finOeSUCgBTkwVIhrEnBxK44ehL9YfcYLmYISvGb+fx8= X-Received: by 2002:a0d:e609:0:b0:2d6:b8b0:8608 with SMTP id p9-20020a0de609000000b002d6b8b08608mr551938ywe.31.1645671796086; Wed, 23 Feb 2022 19:03:16 -0800 (PST) MIME-Version: 1.0 References: <20220223194807.12070-1-joao.m.martins@oracle.com> <20220223194807.12070-2-joao.m.martins@oracle.com> In-Reply-To: <20220223194807.12070-2-joao.m.martins@oracle.com> From: Muchun Song Date: Thu, 24 Feb 2022 11:02:38 +0800 Message-ID: Subject: Re: [PATCH v6 1/5] mm/sparse-vmemmap: add a pgmap argument to section activation To: Joao Martins Cc: Linux Memory Management List , Dan Williams , Vishal Verma , Matthew Wilcox , Jason Gunthorpe , Jane Chu , Mike Kravetz , Andrew Morton , Jonathan Corbet , Christoph Hellwig , nvdimm@lists.linux.dev, Linux Doc Mailing List Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b="WCSX7/V6"; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf28.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.128.179 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 4CDD9C0004 X-Stat-Signature: 9cnuizcj1dnbqcpu86xu76x891wqcwmc X-HE-Tag: 1645671797-716098 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 24, 2022 at 3:48 AM Joao Martins wrote: > > In support of using compound pages for devmap mappings, plumb the pgmap > down to the vmemmap_populate implementation. Note that while altmap is > retrievable from pgmap the memory hotplug code passes altmap without > pgmap[*], so both need to be independently plumbed. > > So in addition to @altmap, pass @pgmap to sparse section populate > functions namely: > > sparse_add_section > section_activate > populate_section_memmap > __populate_section_memmap > > Passing @pgmap allows __populate_section_memmap() to both fetch the > vmemmap_shift in which memmap metadata is created for and also to let > sparse-vmemmap fetch pgmap ranges to co-relate to a given section and pick > whether to just reuse tail pages from past onlined sections. > > While at it, fix the kdoc for @altmap for sparse_add_section(). > > [*] https://lore.kernel.org/linux-mm/20210319092635.6214-1-osalvador@suse.de/ > > Signed-off-by: Joao Martins > Reviewed-by: Dan Williams Missed my Reviewed-by from previous version. Thanks.