From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B6DDC433EF for ; Mon, 28 Mar 2022 14:51:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F4A38D0002; Mon, 28 Mar 2022 10:51:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 97D908D0001; Mon, 28 Mar 2022 10:51:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F70C8D0002; Mon, 28 Mar 2022 10:51:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id 692C68D0001 for ; Mon, 28 Mar 2022 10:51:23 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2645E674 for ; Mon, 28 Mar 2022 14:51:23 +0000 (UTC) X-FDA: 79294083246.05.FFD042B Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) by imf12.hostedemail.com (Postfix) with ESMTP id 0F4CF40050 for ; Mon, 28 Mar 2022 14:51:21 +0000 (UTC) Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-2e64a6b20eeso151610117b3.3 for ; Mon, 28 Mar 2022 07:51:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Dh492AvAmd1IfP231Dj/fJ74UloGtVlkt9YVNW5vE7I=; b=rTK8HzanSVvHJeaRUqDoYN+cyp2drqzhCBdkBIia2K9UHYErmLeBK1OF/IhtkMKjMd 4+DvzSiFP3vAayYc5opVfj41MCgxmEQBqkQQRWWbIG0LAIcbrOs8KZdtMVelLS2er9dZ jaxB9J/SWWUrxSXh1SWupnN36l+s9gh7UnQCAiKuuQusGpvuHHsROcp8xmilrEEIYbK3 Aetv6B61+/xAPj5dfK/gSAJJKbvDVjsZZI7/EcFX/nzsileuM+QGjh/tkT4SafDIs5qm Drssu3limcmRrZ657CulEGvWJwC4sWBiDlSFDu3Z3q0wpQoorJ/UqttXZSqCWrnkNHX5 zOFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Dh492AvAmd1IfP231Dj/fJ74UloGtVlkt9YVNW5vE7I=; b=PylBYWHXX0HghDjCpgwyehuMGFwZsKuOBoulXJjjGPawhevFxtwVd7xXqP9Bcn1mnx CX2FjBLi2dVJ3Vf6NN86Mbnb04hnhQevRQhdMAR8N6VMxRlBWlx4CM+VwR244ucZ/0Zk zfhlA/y4yOI7L3mFe5OJx9yfH9ZPxmOEPuCemgT9FPP+NnHB7fZuAFj+jFgddjmDLruq 19s2A1ref1IQSUg9DplwJYcokyozCpWf++QbzhHZWhVBCsl2j1Db7tzenU7LDrznRtgL aqGXBurbWsYSGnXWUJjG+Hb+SorfVFFScV0mFq9kz3wf8E6sQihOJNwSTtkOvWudUMSb 5gNw== X-Gm-Message-State: AOAM533zX3d3VJnyFN9JkeQVUBmq4MHeLlq6zyNIG09kKB6CyTDRtO+0 1RsI/1T7kuBdLP5DCzJ9MGrdK8lYRdL+aq9YtGhElw== X-Google-Smtp-Source: ABdhPJwmyDAZlA/7hxHve0d0gyq6aqe1zkCsFLU02yLIaouW62yvoiJYimjxjmhfS2vJzYOHdSk9d4pF7QNrsYPzPxA= X-Received: by 2002:a81:1c4f:0:b0:2e5:9db3:7a8e with SMTP id c76-20020a811c4f000000b002e59db37a8emr24636467ywc.319.1648479081138; Mon, 28 Mar 2022 07:51:21 -0700 (PDT) MIME-Version: 1.0 References: <20220328112707.22217-1-linmiaohe@huawei.com> In-Reply-To: <20220328112707.22217-1-linmiaohe@huawei.com> From: Muchun Song Date: Mon, 28 Mar 2022 22:50:45 +0800 Message-ID: Subject: Re: [PATCH] mm: shmem: make shmem_init return void To: Miaohe Lin Cc: Andrew Morton , Hugh Dickins , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 0F4CF40050 X-Stat-Signature: xc1xxse19nyioxypuenejf6bcp5snfjb X-Rspam-User: Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=rTK8Hzan; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf12.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.128.173 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-HE-Tag: 1648479081-268344 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 28, 2022 at 7:44 PM Miaohe Lin wrote: > > The return value of shmem_init is never used. So we can make it > return void now. > > Signed-off-by: Miaohe Lin > --- > include/linux/shmem_fs.h | 2 +- > mm/shmem.c | 9 ++++----- > 2 files changed, 5 insertions(+), 6 deletions(-) > > diff --git a/include/linux/shmem_fs.h b/include/linux/shmem_fs.h > index ab51d3cd39bd..3e915cc550bc 100644 > --- a/include/linux/shmem_fs.h > +++ b/include/linux/shmem_fs.h > @@ -56,7 +56,7 @@ static inline struct shmem_inode_info *SHMEM_I(struct inode *inode) > * Functions in mm/shmem.c called directly from elsewhere: > */ > extern const struct fs_parameter_spec shmem_fs_parameters[]; > -extern int shmem_init(void); > +extern void shmem_init(void); > extern int shmem_init_fs_context(struct fs_context *fc); > extern struct file *shmem_file_setup(const char *name, > loff_t size, unsigned long flags); > diff --git a/mm/shmem.c b/mm/shmem.c > index 529c9ad3e926..26e09a022087 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -3879,7 +3879,7 @@ static struct file_system_type shmem_fs_type = { > .fs_flags = FS_USERNS_MOUNT, > }; > > -int __init shmem_init(void) > +void __init shmem_init(void) > { > int error; > > @@ -3904,14 +3904,13 @@ int __init shmem_init(void) > else > shmem_huge = SHMEM_HUGE_NEVER; /* just in case it was patched */ > #endif > - return 0; > + return; > > out1: > unregister_filesystem(&shmem_fs_type); > out2: > shmem_destroy_inodecache(); > shm_mnt = ERR_PTR(error); > - return error; > } > > #if defined(CONFIG_TRANSPARENT_HUGEPAGE) && defined(CONFIG_SYSFS) > @@ -3989,14 +3988,14 @@ static struct file_system_type shmem_fs_type = { > .fs_flags = FS_USERNS_MOUNT, > }; > > -int __init shmem_init(void) > +void __init shmem_init(void) > { > BUG_ON(register_filesystem(&shmem_fs_type) != 0); > > shm_mnt = kern_mount(&shmem_fs_type); > BUG_ON(IS_ERR(shm_mnt)); > > - return 0; > + return; Weird. Using return at the end of a void function.