From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E9B2C433F5 for ; Fri, 18 Mar 2022 08:26:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A86DA8D0002; Fri, 18 Mar 2022 04:26:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A37538D0001; Fri, 18 Mar 2022 04:26:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8FE788D0002; Fri, 18 Mar 2022 04:26:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 80A408D0001 for ; Fri, 18 Mar 2022 04:26:42 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 42FC788C for ; Fri, 18 Mar 2022 08:26:42 +0000 (UTC) X-FDA: 79256825844.13.17A9BF7 Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) by imf14.hostedemail.com (Postfix) with ESMTP id D87DB100003 for ; Fri, 18 Mar 2022 08:26:40 +0000 (UTC) Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-2e5a8a8c1cdso75203027b3.3 for ; Fri, 18 Mar 2022 01:26:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mBzdXH14sNTPS2biTeLVHAwNzH4AqH+YPPgAMnqAjy0=; b=gfoHkNQokHiSsL2oyZtVNFLI08STGD0lbZbe6YWRufgZZMTC/O+wtNbAuCmIbc/QmB 4DCWDvVb34zUpe28mt/yzyPAY6tGPL00CrkXdaeF0F7vSKOuvCxAm4XcqF/0+6qJ3pB+ csA78xcZh55zs9blxkIUT3fmIehVjaoclX3tragC0NPhCh50XtBHmaVyO/+H/a6+JORd f84wp6I/1SoFQ7Qn34WYPJa7XeXwBaXuNempw9xqyRol4dht95wwNzdJWOeOljlWfd0F GsVaV9UntWm2N/9FYNjiFSm9ASDGaCGh8uTKmPU6eEAi0fpAAUaVmOg6wjiYIav60elj qEfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mBzdXH14sNTPS2biTeLVHAwNzH4AqH+YPPgAMnqAjy0=; b=PzD+t6iNoR1b92ocL2S/tGfSDtPrlzYxjTR648oQnDfHC8NXHtZaOtK0mqGmC3kjWI O+m8XPy4wG1CjBV0F3fDlrGvvXGt3E9lOzZsuCViFXTR/eW5+J4Q2LQcL2NLDP8IkrDh hBAlDP8hnat7F53RtsXJywJP4tgJRZjhmNcTSuhS1RST2sta5xMFysxN6J1RIoLHS2Ib QcTljKAAMs3hRqYA3ZDupP651gRuBRsaVoEAm/BWmN4wRNOH2xkAj5gPW6LFhBqMWQdS vCIcgVc7qPCB8W98zxJ0SPqdfXPsL4B41Fw9skfCk4E9taIFmo2uXuJ15sB8JAPyZY/x Gcqw== X-Gm-Message-State: AOAM5308z1pG6uHKn0SH0W9YVeafA2TlSKXMkjWySTAwpnAYUiMcHOzi EI1plwTc1ClNBE33O9h4XN8RGfKI+1HcJpVO85Ux7w== X-Google-Smtp-Source: ABdhPJxvSDU15uyxATrFQe8YsZC7pCXOmIX++HPMNYnq1JUO+5+f89bnTizEEVAbwJihPB8SdjkVq7xvsNfpd1gzBZo= X-Received: by 2002:a81:1c4f:0:b0:2e5:9db3:7a8e with SMTP id c76-20020a811c4f000000b002e59db37a8emr9412053ywc.319.1647591999889; Fri, 18 Mar 2022 01:26:39 -0700 (PDT) MIME-Version: 1.0 References: <20220318111709.60311-1-linmiaohe@huawei.com> <20220318111709.60311-10-linmiaohe@huawei.com> In-Reply-To: <20220318111709.60311-10-linmiaohe@huawei.com> From: Muchun Song Date: Fri, 18 Mar 2022 16:24:48 +0800 Message-ID: Subject: Re: [PATCH v2 09/11] mm/migration: fix potential page refcounts leak in migrate_pages To: Miaohe Lin Cc: Andrew Morton , Zi Yan , baolin.wang@linux.alibaba.com, Huang Ying , Alistair Popple , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: xostj9t935n31rnbhxa5juyxf3if91je Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=gfoHkNQo; spf=pass (imf14.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.128.171 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: D87DB100003 X-HE-Tag: 1647592000-479304 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 17, 2022 at 10:41 PM Miaohe Lin wrote: > > In -ENOMEM case, there might be some subpages of fail-to-migrate THPs > left in thp_split_pages list. We should move them back to migration > list so that they could be put back to the right list by the caller > otherwise the page refcnt will be leaked here. Also adjust nr_failed > and nr_thp_failed accordingly to make vm events account more accurate. > > Fixes: b5bade978e9b ("mm: migrate: fix the return value of migrate_pages()") > Signed-off-by: Miaohe Lin > Reviewed-by: Zi Yan > Reviewed-by: "Huang, Ying" > Reviewed-by: Baolin Wang Reviewed-by: Muchun Song