From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00353C433EF for ; Wed, 10 Nov 2021 04:16:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6565F61181 for ; Wed, 10 Nov 2021 04:16:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6565F61181 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id B3BB16B0081; Tue, 9 Nov 2021 23:16:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AEAF46B0082; Tue, 9 Nov 2021 23:16:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9DA076B0083; Tue, 9 Nov 2021 23:16:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0231.hostedemail.com [216.40.44.231]) by kanga.kvack.org (Postfix) with ESMTP id 8E1E36B0081 for ; Tue, 9 Nov 2021 23:16:40 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 3A1A6184D83E6 for ; Wed, 10 Nov 2021 04:16:40 +0000 (UTC) X-FDA: 78791709360.06.E86B266 Received: from mail-yb1-f181.google.com (mail-yb1-f181.google.com [209.85.219.181]) by imf21.hostedemail.com (Postfix) with ESMTP id 0699AD03B994 for ; Wed, 10 Nov 2021 04:16:32 +0000 (UTC) Received: by mail-yb1-f181.google.com with SMTP id g17so2986002ybe.13 for ; Tue, 09 Nov 2021 20:16:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JCsAieRHfHn5cktrSz+nVZwZNS/wLjeQ3hgn+o0ozPc=; b=Mli8Tpm92EpuCHNFjuUQRfDwcAszIdAOHGuXXLHaS9oy6j2R/8KrD1Peoh1KTFzFPW xDtUgwfjZFY2+gdJYaKacLnAnpNfHJRPg9O5hzgzh1VhZNIty3c2xcylE7658khhy2XZ IEEgDi3ErDUgbp02CZkNpNB5IJy9SjurGKLg6RXgLWpBr0GjaeLjoBSy2N16YGwLxKco 7wYauAm4ammTVxANOWZH3kvyG1A42SgzIyDm3U673kGoIsIEb6ZryYHbkpaLjy4jq/0u RP0DeQHzy8PCdAWXe6M5NmooNYH20zgL0upm6Zw3n+aBTbah02nvZHUA7ojHt8yZwcAw d61A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JCsAieRHfHn5cktrSz+nVZwZNS/wLjeQ3hgn+o0ozPc=; b=aMnsy8WsoC1PSAKdyq9Dluls08u/vEEdjjxsg7u8YfDQ5puX2fj1gnDV8Du4u1stUW fUqkvGSf8jxj5VLn66qvDA04OFzkYr/ke86tXot/mUpwFwbpK1lx4OTipN0Gg/tO3Wl2 iDMauUkmQIBuIrt/7LrY0csyaXWOQxY4j41BLL1BZJ/fbcnjHVah1pjNFwhcip4fmUrf 5F3jjlq9L6xAc+a1aWSCfKw0cWFLfwdPMy5NDivVeZoYJQH0jY3QHvJO18YYUPvbm3KN sLpJ8obiLmSO813TRsVE7pL11JGolikjjIVmdZbgvggl9eF2BADvEvTsrS4o+zn6Wfzz 8emg== X-Gm-Message-State: AOAM532dN+hB8DDJOcn6jZphFCf3u6nm0R+iN7+NOrLMbhOWLmG5O2I5 wzpIHThGnSEpY4GL2+frDI/ZiImk48ZwZynIdoN9IQ== X-Google-Smtp-Source: ABdhPJwi6CPZJmcjD6FkgBTubgTI/S2YDDH+oxUbzJdD4c92D7cNRpEkEw/YAg0DMrIBSl1vYzUxavKDs60vRS4LGHk= X-Received: by 2002:a05:6902:72f:: with SMTP id l15mr15160277ybt.279.1636517797662; Tue, 09 Nov 2021 20:16:37 -0800 (PST) MIME-Version: 1.0 References: <20211110033221.22083-1-hanyihao@vivo.com> In-Reply-To: <20211110033221.22083-1-hanyihao@vivo.com> From: Muchun Song Date: Wed, 10 Nov 2021 12:15:57 +0800 Message-ID: Subject: Re: [PATCH] mm/damon/vaddr: use swap() to make code cleaner To: Yihao Han Cc: SeongJae Park , Andrew Morton , Linux Memory Management List , LKML , kernel@vivo.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 0699AD03B994 X-Stat-Signature: pg91ad8mzuaox7rtc1koph8ss9zypb67 Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=Mli8Tpm9; spf=pass (imf21.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.219.181 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-HE-Tag: 1636517792-390352 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000239, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 10, 2021 at 11:32 AM Yihao Han wrote: > > Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid > opencoding it. > > Signed-off-by: Yihao Han > --- > mm/damon/vaddr.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c > index 35fe49080ee9..414d9fb9c827 100644 > --- a/mm/damon/vaddr.c > +++ b/mm/damon/vaddr.c > @@ -100,11 +100,7 @@ static unsigned long sz_range(struct damon_addr_range *r) > static void swap_ranges(struct damon_addr_range *r1, > struct damon_addr_range *r2) > { > - struct damon_addr_range tmp; > - > - tmp = *r1; > - *r1 = *r2; > - *r2 = tmp; > + swap(*r1, *r2); IMHO, I suggest removing swap_ranges() completely since it's only a wrapper of swap() after your changes. The caller can invoke swap() directly. Thanks. > } > > /* > -- > 2.17.1 >