From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9177FC433DB for ; Thu, 11 Mar 2021 13:00:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CB2D064FC3 for ; Thu, 11 Mar 2021 13:00:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB2D064FC3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2266D8D02BA; Thu, 11 Mar 2021 08:00:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B2EF8D02B2; Thu, 11 Mar 2021 08:00:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 02C7E8D02BA; Thu, 11 Mar 2021 08:00:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0223.hostedemail.com [216.40.44.223]) by kanga.kvack.org (Postfix) with ESMTP id DA6028D02B2 for ; Thu, 11 Mar 2021 08:00:43 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 9126E181AF5CC for ; Thu, 11 Mar 2021 13:00:43 +0000 (UTC) X-FDA: 77907602766.16.34D4549 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by imf09.hostedemail.com (Postfix) with ESMTP id 7C145601D8EC for ; Thu, 11 Mar 2021 13:00:38 +0000 (UTC) Received: by mail-pg1-f176.google.com with SMTP id t37so2832616pga.11 for ; Thu, 11 Mar 2021 05:00:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ICClhXTxVfeDP5mVm1fYPC9myvROzb0Cj0NknzNNdKs=; b=FNWkqzAOnObAD9/0sUTGtXYMiNmrmS8FJP++ikoDpY2J5iqbCSDXmEDaZHkPYz3FXL /3sUWNHTxqVd5BmYP7/gMMHemNaYCOzzjhMY3Y3/cy5denRGwPb6GXyBN+mTXKpbPJ63 d1QZ9NojXcrEpGmXU+F8r9B90LJtBHRBqKqjYO+CBZjGNeUj0SZv6y2XGals1rh/QGpJ rRnhDR8bevFcuRXA8sM/7nxYwhMkjPWFiEHD6DDlo+DIMXqP5UYYyF7RvhuntNeX0uV7 +lbw12eHhpCMdlJ4OfITM2qsSCGj8Nia4SGTMhaUsWxOKnXitSkW05QekiAa/VwUb9zN zakQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ICClhXTxVfeDP5mVm1fYPC9myvROzb0Cj0NknzNNdKs=; b=l5n7qXU+EF+sdpJwPgsp2wqG0KHnWnNaiYurkfITUDegQhFOlmaR6Ji8JsaSQqaXzC 5Ui7w8MdLsPJb5j4k1LMs/G9es4VQ53VgbSfGIxcZh5mfiDP87S+9pFeyF/mR5VJvzD4 FjjJi3r3/tYPMpWFjTBKdjf1jyQCSclQHFyq8D0oi9AOnPJWopQHvEHB200h1YGGI7Kh fSOCO7JjD3YOvP6ATXjcKNK7mUroWN865ExM1Xjq4uhexUQevo0BPE4VYtn857gKbW5Z n3tgj9/U+p3Uc86Zep80IY/DoLsn4cIHI03uYQJQE9+gNHZ0Qpym/BRi4EmcaPrkM/sO rmWg== X-Gm-Message-State: AOAM5325ApyAMcTI1z+QEt2cd4DRH9Q5SsppMw4ZImFRUVzvpUm+mhq4 1XvxTZjQl3u5u/WwC7IXpCY3dHT/dPh0awRT0oNShw== X-Google-Smtp-Source: ABdhPJxyzvuPcaF1NhUhc4M3D6E0KoDRfcfVCFt8gZR+bL7CluOq6WyYxviIqRjhulE609IOhIf8Gf0BgyaPXq/cOKA= X-Received: by 2002:aa7:9e5b:0:b029:1f1:5ba4:57a2 with SMTP id z27-20020aa79e5b0000b02901f15ba457a2mr7614145pfq.59.1615467638784; Thu, 11 Mar 2021 05:00:38 -0800 (PST) MIME-Version: 1.0 References: <20210308102807.59745-1-songmuchun@bytedance.com> <20210308102807.59745-10-songmuchun@bytedance.com> In-Reply-To: From: Muchun Song Date: Thu, 11 Mar 2021 21:00:01 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v18 9/9] mm: hugetlb: optimize the code with the help of the compiler To: Michal Hocko Cc: Jonathan Corbet , Mike Kravetz , Thomas Gleixner , Ingo Molnar , bp@alien8.de, x86@kernel.org, hpa@zytor.com, dave.hansen@linux.intel.com, luto@kernel.org, Peter Zijlstra , Alexander Viro , Andrew Morton , paulmck@kernel.org, mchehab+huawei@kernel.org, pawan.kumar.gupta@linux.intel.com, Randy Dunlap , oneukum@suse.com, anshuman.khandual@arm.com, jroedel@suse.de, Mina Almasry , David Rientjes , Matthew Wilcox , Oscar Salvador , "Song Bao Hua (Barry Song)" , David Hildenbrand , =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= , Joao Martins , Xiongchun duan , linux-doc@vger.kernel.org, LKML , Linux Memory Management List , linux-fsdevel , Miaohe Lin , Chen Huang , Bodeddula Balasubramaniam Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: c8hxx79u5hfae83dm158okhgqkaxg5cz X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 7C145601D8EC Received-SPF: none (bytedance.com>: No applicable sender policy available) receiver=imf09; identity=mailfrom; envelope-from=""; helo=mail-pg1-f176.google.com; client-ip=209.85.215.176 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615467638-710634 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 11, 2021 at 8:16 PM Michal Hocko wrote: > > On Thu 11-03-21 18:00:09, Muchun Song wrote: > [...] > > Sorry. I am confused why you disagree with this change. > > It does not bring any disadvantages. > > Because it is adding a code which is not really necessary and which will > have to be maintained. Think of future changes which would need to grow > more of these. Hugetlb code paths shouldn't really think about size of > the struct page. Got it. I will drop this patch. > -- > Michal Hocko > SUSE Labs