From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 529FCC43461 for ; Mon, 14 Sep 2020 04:03:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7FC0A20771 for ; Mon, 14 Sep 2020 04:03:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bytedance-com.20150623.gappssmtp.com header.i=@bytedance-com.20150623.gappssmtp.com header.b="CqIfTLto" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7FC0A20771 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A001D6B0003; Mon, 14 Sep 2020 00:03:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B12D6B0037; Mon, 14 Sep 2020 00:03:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8EE906B0055; Mon, 14 Sep 2020 00:03:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0194.hostedemail.com [216.40.44.194]) by kanga.kvack.org (Postfix) with ESMTP id 77E6B6B0003 for ; Mon, 14 Sep 2020 00:03:11 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 33282181AEF1D for ; Mon, 14 Sep 2020 04:03:11 +0000 (UTC) X-FDA: 77260321782.08.star71_0f0464c27105 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin08.hostedemail.com (Postfix) with ESMTP id 0056F1819E798 for ; Mon, 14 Sep 2020 04:03:10 +0000 (UTC) X-HE-Tag: star71_0f0464c27105 X-Filterd-Recvd-Size: 3419 Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Mon, 14 Sep 2020 04:03:10 +0000 (UTC) Received: by mail-pf1-f196.google.com with SMTP id d6so11457413pfn.9 for ; Sun, 13 Sep 2020 21:03:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dWdl+yaQbYEtdR4On3P7CGGpC+OD3QLDLkmMq6+C9k0=; b=CqIfTLtozQ3xvA/KXFvjkKb1zYdS2iyiXoVFEvA0vmD2FVJ2slyMgvSYQ00c8x7ytj mx61VL523WNZigppR8w4h/OfvHx0V+eROTHrLyDK0xMG3Q16At3IMZVLEVrm6smf4LQj Hm2mKdquGXG4js/HGAiwxp+2xYuFK3YPdudZHFzhQszumUV3IJSRZXKjZiuVessize+V ceqaoE/OpxcPAb+ASWwOkBOjlZ2MFCpWp48AaphS6mTD39B20SZQ+OCgYZ6qytmaRPnu A2P4M7baDBpOgQzsToSWLad01UMxaRUgCxc8NUQeTxn+66zGl7EL2Ao3fNh+GKSwaLUX c4zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dWdl+yaQbYEtdR4On3P7CGGpC+OD3QLDLkmMq6+C9k0=; b=hrxkufp93TX/oyjbJRRrOesHNwF5Jth3WJ40LUTJOiHw5BgQYBy5lhkXtWXQ/eixH8 VXLWTb7KTouuD5mYnWVePqSZ2EIk7+5p6EE3YfHYWkDcr1Ivy+pRTsIC4cZLzBegK2dG OOaIOca0VWanfFPLOBewHVDyWWnLVuCQMlFNzFKO88NdEkg+SuOeKLahsGf0xDa5uBfZ 8TPX5mkCuUlht183hzljqFaeN+348yiX+zzq0j5E9xHrUJ1EMuArLJxGmCVm5qiRFgXc gL/8+qSctQOKh0RqU0zeV3nzGwS0weOWiAwSsetHk6QPPcsFc3Mz5cZTaDATogCPxKlI Wk+Q== X-Gm-Message-State: AOAM530KyAbOSST2AfI/YHX8t02HcInGJ+MfK3tZMDzC0ZFpjH357GWp S6vOl2DYbTHE3rO4APu+DLDZD04s2KXrH2HOQrxX4Q== X-Google-Smtp-Source: ABdhPJwJ5ImAc3zR+/ovbzQJqIFTBNyvaOQXjxE6WDS4XTm9eE+0WpjDQqQFxAhAREZOjstjQnmqTWIg/GfIct7L4vs= X-Received: by 2002:a17:902:a70e:b029:d1:9be4:b49c with SMTP id w14-20020a170902a70eb02900d19be4b49cmr13241634plq.20.1600056189287; Sun, 13 Sep 2020 21:03:09 -0700 (PDT) MIME-Version: 1.0 References: <20200912155100.25578-1-songmuchun@bytedance.com> <20200912174241.eeaa771755915f27babf9322@linux-foundation.org> In-Reply-To: <20200912174241.eeaa771755915f27babf9322@linux-foundation.org> From: Muchun Song Date: Mon, 14 Sep 2020 12:02:33 +0800 Message-ID: Subject: Re: [External] Re: [PATCH] mm: memcontrol: Fix out-of-bounds on the buf returned by memory_stat_format To: Andrew Morton Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Cgroups , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 0056F1819E798 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Sep 13, 2020 at 8:42 AM Andrew Morton wrote: > > On Sat, 12 Sep 2020 23:51:00 +0800 Muchun Song wrote: > > > The memory_stat_format() returns a format string, but the return buf > > may not including the trailing '\0'. So the users may read the buf > > out of bounds. > > That sounds serious. Is a cc:stable appropriate? > Yeah, I think we should cc:stable. -- Yours, Muchun