From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F419C433EF for ; Mon, 11 Apr 2022 03:50:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB2836B0072; Sun, 10 Apr 2022 23:50:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B60AE6B0073; Sun, 10 Apr 2022 23:50:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A29DC6B0074; Sun, 10 Apr 2022 23:50:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0111.hostedemail.com [216.40.44.111]) by kanga.kvack.org (Postfix) with ESMTP id 940406B0072 for ; Sun, 10 Apr 2022 23:50:54 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 466808249980 for ; Mon, 11 Apr 2022 03:50:54 +0000 (UTC) X-FDA: 79343222028.23.118B99C Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) by imf03.hostedemail.com (Postfix) with ESMTP id 8702520007 for ; Mon, 11 Apr 2022 03:50:52 +0000 (UTC) Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-2ec42eae76bso1672287b3.10 for ; Sun, 10 Apr 2022 20:50:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3zaQImLi0FzFBRmnFmLjG6HOawbZnSP9X2yOV3cxE4U=; b=p0wYNrWXbajDvZhjMlVAkw/+L8hLevOGmZtPSYERL7Iy5/5Rm6lIL5TzW2HVTTocg1 Ov2DlGOZ3EofzM1oTCaPip+4Fo92sPsVTrhKfjyDwWUw8SxtkbDJNudCpCiplMt/1yhF 2iHSVUiRIJJv+PO8Mzt173Nhyk7tQDGc8ByCpN0jEKdOcOBArU9HhbEM5iyApL5nmOel q3UrEU/5LTuWETFAwZteyJ8AY3j+XvMYrG9rBnUU2K0gO3otI5JYTxUTeAI2MED76wAe qoh0rkZEobOKqNlUEYVtTzxJvxdwcHU+D+nBL5/T+PdqV+Rhhn7e9q5/FZy8yHEnCJGr 8grQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3zaQImLi0FzFBRmnFmLjG6HOawbZnSP9X2yOV3cxE4U=; b=Ujr7xIq1t3bEnHqlErztfkAaAvVghLr2C9cO5SZVOSRqRMRNgKVFG0+Z+3IMxC+tP5 1y0jIvyZENmeU3dd9E+l6wnbpy0b4o6km8sxkztC6pjNJK6kHRWRImcnEa7x+cCOptam TKtVOTB2PXJd6MzR7Kg8SJ+qtI/pLpogyFK73ddVolAkOzpriG/5WyK80HpbAJQAcKX6 0yfvRGA5uAZskHDUgOP87c7CFaL/nJwdPObb2djKH+AJfQS0S1Lliz8cnqD6K/7siC1X vcNWgRWSPyHqx7+D933eakIKv5p3f/J6Oexdf2KU4rlrBhwmnxnTwp2Z/hOVViUCepNP iILg== X-Gm-Message-State: AOAM530nbV3YZbYKe+UX1lywKZ1yEefruCkiLTntbAbAWKhRxEsDqy2C kX+jAdB7tNMFJzs06qo5SlD0tjEWOEUuU4yUEfKg1w== X-Google-Smtp-Source: ABdhPJzhLxDy+AFwGDCZdKwANIGl4tMzfwmBe3gjOWrYkaQfibluIQLxEFevjriCH95pbr43GfpdL3R0UWbjNbuJs+s= X-Received: by 2002:a81:1c1:0:b0:2eb:7369:dd09 with SMTP id 184-20020a8101c1000000b002eb7369dd09mr25754598ywb.35.1649649051525; Sun, 10 Apr 2022 20:50:51 -0700 (PDT) MIME-Version: 1.0 References: <20220409144239.2649257-1-jsyoo5b@gmail.com> In-Reply-To: <20220409144239.2649257-1-jsyoo5b@gmail.com> From: Muchun Song Date: Mon, 11 Apr 2022 11:50:14 +0800 Message-ID: Subject: Re: [PATCH] mm/slub: remove meaningless node check in ___slab_alloc() To: JaeSang Yoo Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Ohhoon Kwon , Wonhyuk Yang , Jiyoup Kim , Donghyeok Kim , JaeSang Yoo , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: ug9yyzis8z1yturssjd61ssk6i43kmin Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=p0wYNrWX; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf03.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.128.182 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-Rspamd-Queue-Id: 8702520007 X-HE-Tag: 1649649052-355886 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Apr 9, 2022 at 10:43 PM JaeSang Yoo wrote: > > node_match() with node=NUMA_NO_NODE always returns 1. > Duplicate check by goto statement is meaningless. Remove it. > > Signed-off-by: JaeSang Yoo LGTM. Reviewed-by: Muchun Song